org.forgerock / org.forgerock.opendj

10 Jul, 2015

9 commits

  • 4d9dec6b   Fix checkstyle error ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12655 41b1ffd8-f28e-4786-ab96-9950f0a78031
    fabiop
     
  • f5f557f0   IndexBuffer.java: ... Browse Code » 
    Augmented javadoc with a comment from CR-7560

git-svn-id: https://svn.forgerock.org/opendj/trunk@12654 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 5698722a   Fix checkstyle error ... Browse Code » 
    
git-svn-id: https://svn.forgerock.org/opendj/trunk@12653 41b1ffd8-f28e-4786-ab96-9950f0a78031
    fabiop
     
  • e5c3737b   More code cleanup ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12652 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 77a85143   ID2entry.java: ... Browse Code » 
    Removed code duplication and dead code

git-svn-id: https://svn.forgerock.org/opendj/trunk@12651 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • cd059c04   Code cleanup ... Browse Code » 
    DirectoryServer.java:
Added getAttributeType(String lowerName, String upperName).

*.java:
Used the newly added DirectoryServer.getAttributeType(String lowerName, String upperName).
Used more DirectoryServer.getAttributeType(String, boolean).

git-svn-id: https://svn.forgerock.org/opendj/trunk@12650 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 65b74d3a   Upgrade PersistIt to 4.1.0-SNAPSHOT ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12649 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ylecaillez
     
  • f240df21   PDB: Reduce probability of transaction conflict (CR-7560) ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12648 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ylecaillez
     
  • 48e04737   Code cleanup ... Browse Code » 
    
AttributeBuilder.java:
Removed setInitialCapacity(), (no op)
Added addAllStrings() and made use of it.

Attributes.java:
Changed create(String attributeName, String firstValueString, String... otherValueStrings) to create(String attributeName, String... valueStrings) + made use of it.

*.java:
Removed javadocs duplicating javadocs from overridden methods.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12647 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

09 Jul, 2015

6 commits

  • 4d3bda98   OPENDJ-2171 CR-7414 import-ldif in append mode should not reset index state ... Browse Code » 
    Regardless of options specified to import-ldif, all indexes are systematically set as not trusted before importing and reset to trusted once it's finished. 
On the other hand if the suffix is simply appended to, indexes not up to date with the data should not be set to trusted, since they may end up with partial data. 

Before import we should set all trusted indexes as candidates for updates, but leave not trusted indexes alone.
In order to do that, use index lists from Suffix, building the list of indexes to update taking into account the append flag: if it is specified only consider trusted indexes. 
Import code should only get index information from the Suffix. 

Rebuild index should still be based on the EntryContainer though, since we are managing indexes directly.


git-svn-id: https://svn.forgerock.org/opendj/trunk@12646 41b1ffd8-f28e-4786-ab96-9950f0a78031
    fabiop
     
  • e6dd34ee   Apply code simplifications related to DN2ID and DN2URI from r12247, see CR-7414 ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12645 41b1ffd8-f28e-4786-ab96-9950f0a78031
    fabiop
     
  • 608ca70b   Code cleanup ... Browse Code » 
    
*.java:
Used CollectionUtils.newArrayList() as much as possible.
Made use of LDAPAttribute constructors which accepts Strings. This avoids String to ByteString conversion in client code since the constructors handle it.

AttributeBuilder.java:
Added toAttributeList() to avoid the need for client code to create a List itself.

Attributes.java:
Added several createAsList() to avoid the need for client code to create a List itself.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12642 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 37e0e591   OPENDJ-2187 Add missing server Javadoc to OpenDJ site ... Browse Code » 
    Revert r12639

git-svn-id: https://svn.forgerock.org/opendj/trunk@12640 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     
  • 4a9e79b6   OPENDJ-2187 Add missing server Javadoc to OpenDJ site ... Browse Code » 
    This patch aims to fix the connection to upload the site.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12639 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     
  • 21cd3fa5   AutoRefactor'ed Collections ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12637 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

08 Jul, 2015

6 commits

07 Jul, 2015

7 commits

  • 843441b6   Code cleanup ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12627 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • dc39d470   AutoRefactor'ed Use Diamond Operator ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12626 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 2b223bf4   AutoRefactor'ed file ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12625 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 75986512   Code cleanups ... Browse Code » 
    
ReplicationCliArgumentParser.java:
Extracted static class ServerArgs to separate fields named "*1" and "*2" + removed many methods.
Removed all fields named "*1" and "*2" and added fields server1 and server2 to replace them.
Extracted methods createServerArgs1() and createServerArgs2().

ReplicationCliMain.java:
In setConnectionDetails() and setReplicationDetails(), reduced number of parameters.
Extracted methods getReplicationPortArg() and newBooleanArgument().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12624 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • b89759bf   Code cleanups ... Browse Code » 
    
ServerDescriptor.java:
Used early exits.
Extracted methods getPort(), getPortProperty(), isAddReplica().
Removed areDnsEqual(), duplicate of Utils.areDnsEqual().
In getReplicationServer(), redirect to getServerRepresentation() to avoid duplicate code.

TopologyCache.java:
Extracted methods setAgeOfOldestMissingChange() and setMissingChanges().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12623 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • de88aab4   Code cleanups ... Browse Code » 
    
EnableReplicationUserData.java:
Extracted inner class EnableReplicationServerData.
Removed all fields named "*1" and "*2" and replaced them with new fields EnableReplicationServerData server1 and server2.

ReplicationCliMain.java:
Used EnableReplicationUserData.EnableReplicationServerData.
As a consequence, extracted methods setConnectionDetails(), setReplicationDetails(), checkReplicationServerAlreadyConfigured(), checkReplicationPort(), checkAdminAndReplicationPortsAreDifferent(), addToSets(), configureToReplicateBaseDN(), countReplicationServers(), checkCanMergeReplicationTopologies() to reduce code duplication.
Extracted methods findSameReplicationServer() and findReplicaInSuffix2() to increase readability.
Extracted configureServer() from configureServer1() and configureServer2() + removed these 2 methods.
Moved getValue(String v, String defaultValue) and getValue(int v, int defaultValue) to ReplicationCliArgumentParser.
Consequence of the changes to ReplicationCliArgumentParser.

ReplicationCliArgumentParser.java:
Reduced methods visibility + made a few methods static.
Renamed or inlined various methods.
Added getValueOrDefault(StringArgument) and getValueOrDefault(IntegerArgument).
Used ternary operator.
Extracted method getAdminUidArg()

PurgeHistoricalUserData.java:
Code cleanups.
Consequence of the changes to ReplicationCliArgumentParser.
Removed getValue(String v, String defaultValue) and getValue(int v, int defaultValue).

git-svn-id: https://svn.forgerock.org/opendj/trunk@12622 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • e8d6a0b6   CR-7462 OPENDJ-2150 Expand doc on use of entry caches ... Browse Code » 
    This patch fixes the existing documentation on entry cache settings,
and also includes tip in the section about static groups
to try to avoid large static groups by using dynamic groups if possible,
and if not to use an entry cache.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12621 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     

06 Jul, 2015

7 commits

  • 4c45fea5   Thank god we moved to Java 7. ... Browse Code » 
    There, the Selector, Socket and ServerSocket are correctly implementing Closeable.

StaticUtils.java:
Removed close() methods for Selector, Socket and ServerSocket.
Changed close(InitialLdapContext) to the more general close(InitialContext).

git-svn-id: https://svn.forgerock.org/opendj/trunk@12616 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 75d74692   Code cleanup ... Browse Code » 
    ReplicationCliMain.java:
In execute() and enableReplication(), used early exit.
In disableReplication(), reverted if statement + used early exit.
Extracted methods checksForNonInteractiveMode(), printSuccessfullyEnabled(), errPrintLn(), configureServer1() configureServer2(), isAnyReplicated().
In checkSuffixesForDisableReplication(), removed areSuffixRequired parameter, duplicate of displayErrors parameter.
In getMsg(), removed sProcessed and sUnprocessed which are string versions of processed and unprocessed longs.
Renamed getMessageForReplicationServerException() into errorConfiguringReplicationServer() and moved it.
Changed "col.size()>0" to "!col.isEmpty()"
Used diamond operator.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12615 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • f50e68e6   OPENDJ-2119 CR-7476 debugsearchindex incorrect output with AND search on only one attribute ... Browse Code » 
    Running a search while asking for debug information about filter processing should return for each AVA what happened. 
If we detect the search can be simplified as a bounded range, though, only partial information is printed, since we "forget" 
to update the debug information, normally updated by each evaluation.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12614 41b1ffd8-f28e-4786-ab96-9950f0a78031
    fabiop
     
  • 034adf58   AutoRefactor'ed Use Diamond Operator ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12613 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • f3719106   Fix ChangelogBackendTestCase randomness. Should be the last one!! ... Browse Code » 
    ChangelogBackendTestCase.java:
Fixed the failing searchInCookieModeOnTwoSuffixes() test by adding retry functionality to isOldestCSNForReplica().
In publishUpdateMessages(), added additional checks.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12610 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 5b0014ab   Additional fix for OPENDJ-2178 ... Browse Code » 
    This patch clarifies the wording as suggested by Ludo in the issue
and as pointed out by Jean-Noel.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12609 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     
  • af58757c   CR-7463 OPENDJ-2178 Document privilege removal ... Browse Code » 
    This patch adds a procedure on limiting privileges.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12607 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     

02 Jul, 2015

3 commits

  • 27f5f2cf   OPENDJ-2183 ECL: changes for new suffix are missing ... Browse Code » 
    OPENDJ-2184 ECL: wrong number of changes after adding a new replica

Code review: CR-7431



This problem is linked to OPENDJ-2141, where we introduced a "default" value for a CSN when starting from a changeNumberIndex record.

Explanation: when the server starts up, the newest record is read from the change number index db, so the change number indexer knows where to start.
From there, we must start all the cursors, and we are using the newest CSN as a starting point.
The triplet (LESS_THAN_OR_EQUAL_TO_KEY, ON_MATCHING_KEY, newestCsn) is then used to start all cursors, including the cursors for replica DBs created dynamically much after server startup.
When opening a cursor for any new replica, the provided default CSN cannot be found in the replica DB. Because of this condition and the provided triplet, the file-based changelog code creates an empty cursor.
Empty cursors cannot be recycled to iterate over the populated replica DB (And in that case, the replica DB already has the change csn3!!).

I think this is incorrect. This change fixes this.



LogTest.java, LogFileTest.java, BlockLogReaderWriterTest:
Changed the unit tests, so the returned values match what we need.

Log.java:
In getCursor(), changed the condition that creates a valid cursor to also include LESS_THAN_OR_EQUAL_TO_KEY.

BlockLogReader.java:
In positionToKeySequentially() and getMatchingRecord(), removed the code handling LESS_THAN_OR_EQUAL_TO_KEY and AFTER_MATCHING_KEY.
Renamed positionToKeySequentially() to positionToKey().


git-svn-id: https://svn.forgerock.org/opendj/trunk@12605 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • c47902af   OPENDJ-2189: Empty EntryIDSet are kept rather than deleted. ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12603 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ylecaillez
     
  • 363563d3   Fix ChangelogBackendTestCase randomness ... Browse Code » 
    ChangelogBackendTestCase.java:
Introduced assertLastCookieIsEqualTo() to do an equivalent to "wait until keyword suceeds"
In searchInCookieModeOnTwoSuffixesWithPrivateBackend(), do not forget to close the domain.
In isOldestCSNForReplica(), fixed error message.
Overrode getGenerationId() to have a fixed generationId. This ensures messages can always sent from ReplicationBroker to LDAPReplicationDomain and processed.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12600 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

01 Jul, 2015

2 commits