org.forgerock / org.forgerock.opendj

05 Nov, 2014

3 commits

04 Nov, 2014

3 commits

03 Nov, 2014

6 commits

  • ea1d257a   OPENDJ-1545 Remove Workflow, NetworkGroups and related attempts at building a proxy ... Browse Code » 
    WorkflowConfigManager.java, NetworkGroupConfigManager.java, WorkflowElementConfigManager.java, LocalBackendWorkflowElementConfiguration.xml, WorkflowConfiguration.xml, WorkflowElementConfiguration.xml: REMOVED

git-svn-id: https://svn.forgerock.org/opendj/trunk@11237 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • a20b0c89   Last batch of fixes from AutoRefactor (or me) for a while. ... Browse Code » 
    AutoRefactor successfully goes through the whole SDK now.

git-svn-id: https://svn.forgerock.org/opendj/trunk@11235 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 4329d28a   JPEGSyntaxImpl.java: ... Browse Code » 
    In isValidJfif() and isValidExif(), fixed a bug: original code was buggy.
In isValidJfif(), fixed the javadoc that I badly copied in r11231 :(

git-svn-id: https://svn.forgerock.org/opendj/trunk@11234 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 550a9b87   AutoRefactored: ... Browse Code » 
    - work with null checked expressions first
- revert conditions
- collapse if statements
- push negations down
- invert equals()

Manually used ternary operators

git-svn-id: https://svn.forgerock.org/opendj/trunk@11233 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 7585c8bb   Code cleanup ... Browse Code » 
    PasswordPolicyStateExtendedRequest.java:
Extraxcted methods setBooleanProperty(), setDateProperty(), setDateProperties(), toByteString() to simplify the code.

git-svn-id: https://svn.forgerock.org/opendj/trunk@11232 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 2bd07c13   JPEGSyntaxImpl.java: ... Browse Code » 
    Extracted methods isValidJfif() and isValidExif() for readability.

Code review: Matthew Swift

git-svn-id: https://svn.forgerock.org/opendj/trunk@11231 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

31 Oct, 2014

3 commits

30 Oct, 2014

5 commits

  • 0c2cbdc5   AutoRefactored code. ... Browse Code » 
    Collapsed else { if (...){...} }  into else if (...) {...}
Reversed boolean equals conditions using constants.

In tests, used the correct assert*() methods.

git-svn-id: https://svn.forgerock.org/opendj/trunk@11224 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • a83552c7   OPENDJ-1613 (CR-5064) NullPointerException while searching on ch=changelog ... Browse Code » 
    The problem happens when doing a search in the change number changelog.
It only appears when there are two replicas under the same domain.
When creating the domain cursor, it is initialized from the content of the change number index DB. A replica cursor is created for each replica. The first replica cursor is initialized from the CSN coming from the change number index DB while the second replica cursor is initialized from the null CSN.
Under this circumstance, the second replica cursor is immediately added to the exhausted cursors of the domain cursor, and never gets out of it despite its replica DB being not empty.
The reason is because next() is never called on the the underlying ReplServerDBCursor.


JEReplicaDBCursor.java:
In next(), test whether the cursor has already been initialized (rather than verifying if a previous record exists) in order to verify if this is the first time next() is called.
Removed currentChange field which duplicates the content of ReplServerDBCursor.currentRecord .
Better handled the cursor closed state in all the methods.

git-svn-id: https://svn.forgerock.org/opendj/trunk@11222 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 9f9f8464   Utils.java: ... Browse Code » 
    Reduced scope of variables.
Used early exits.

git-svn-id: https://svn.forgerock.org/opendj/trunk@11221 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • c4eaa999   Improvements to DN class. ... Browse Code » 
    Thanks Matt for the suggestion!


DN.java:
In toIrreversibleNormalizedByteString(), initializing the StringBuilder to the number of RDNs was incorrect, creating more garbage than necessary.
In normalizeAVA(), extracted local variable for attributeType + removed useless creation of an Iterator.

DNTestCase.java:
Added more tests to increase code coverage.

git-svn-id: https://svn.forgerock.org/opendj/trunk@11220 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 66f5e299   OPENDJ-1591 Modify UniqueMemberEqualityMatchingRuleImpl to normalized DN ... Browse Code » 
    in the same way than DistinguishedNameEqualityMatchingRuleImpl and add
 the optional uid if present


git-svn-id: https://svn.forgerock.org/opendj/trunk@11219 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     

29 Oct, 2014

3 commits

  • e54f5d39   Updated copyrights after r11216. ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@11218 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 09385456   OPENDJ-1571 Internal Error when doing REST operations on HTTP Connection Handler ... Browse Code » 
    
As pointed out by Ludo, problem is due to an API change in InternalClientConnection.processSearch() where LinkedHashSets parameters have been replaced with Set.
Reverted revision r9082 which introduced the problem.

Changed all client code to use LinkedHashSets instead of Sets.


CollectionUtils.java:
Added missing methods implemented in TestCaseUtils.

TestCaseUtils.java, LDAPReplicationDomain.java:
Removed generic methods creating collections.

git-svn-id: https://svn.forgerock.org/opendj/trunk@11216 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 0834565f   DN.java: ... Browse Code » 
    In toIrreversibleNormalizedByteString(), avoid uselessly creating a StringBuilder.

git-svn-id: https://svn.forgerock.org/opendj/trunk@11212 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

28 Oct, 2014

6 commits

23 Oct, 2014

1 commit

22 Oct, 2014

10 commits