org.forgerock / org.forgerock.opendj

25 Aug, 2015

12 commits

6a2e6899 Fix checkstyle ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12788 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
fabiop
2015-08-25 16:43:25 +0000

b473a235 SearchFilter.java: ... Browse Code »

Used Collection.contains().

LDAPURL.java:
Simplified equals().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12787 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-25 16:03:49 +0000

89f2c442 Use Collection.contains() ... Browse Code »

Used early exits
Removed duplicated code

git-svn-id: https://svn.forgerock.org/opendj/trunk@12786 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-25 16:02:28 +0000

297ff520 CommonSchemaElements.java: ... Browse Code »

Changed getNormalizedNames() to return a Set instead of Iterable.

*.java:
Consequence of the change to CommonSchemaElements.getNormalizedNames().
Used early exits.
Extracted method SchemaElementPanel.getAliases().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12785 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-25 15:59:10 +0000

caed5af9 VerifyIndex.java: ... Browse Code »

In mainVerifyIndex():
- use Collection.contains()
- release the shared lock in a finally clause

git-svn-id: https://svn.forgerock.org/opendj/trunk@12784 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-25 15:49:47 +0000

0c5d3200 Remove duplicated code ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12783 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-25 15:47:47 +0000
fb7c7ddb Fix build (Eclipse did not give me any errors :( ) ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12782 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-25 14:48:55 +0000
a00b8260 Use Collection.contains() ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12781 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-25 13:11:18 +0000
e1fafc6b Use Collection.contains() ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12780 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-25 13:00:27 +0000

80cfedf5 Code cleanup ... Browse Code »


Entry.java:
In applyModification(), extracted methods applyModificationToObjectclass() and applyModificationToNonObjectclass().
In hasUserAttribute() and hasOperationalAttribute(), extracted method hasAttribute()
Used Attribute.isReal() to explicit code + merged if statements.


Attribute.java:
Added isReal() -> !isVirtual().

AbstractAttribute.java:
Implemented isReal().
In equals() extracted method valuesEqual().
In hasAllOptions() and optionsEqual(), extracted method hasAllOptions0().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12779 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-25 12:51:06 +0000

75c5ce2f OPENDJ-1666 Code cleanup ... Browse Code »

* org.opends.server.protocols.http.HttpConnectionHandler
** Fix copyright section
** Make code more readable
*** Reformat
*** Inline some local variables

* org.opends.server.protocols.http.HTTPClientConnection
** Fix copyright section
** Reformat

* org.opends.server.protocols.http.CollectClientConnectionsFilter
** Fix copyright

* org.opends.server.protocols.http.CollectClientConnectionsFilterTest
** Reformat

git-svn-id: https://svn.forgerock.org/opendj/trunk@12778 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-25 08:12:30 +0000

1ff1552e AutoRefactor'ed Modification.java ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12777 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-25 07:52:56 +0000

24 Aug, 2015

5 commits

e2da75cb AssuredReplicationPluginTest.java: ... Browse Code »

Used ReplicationTestCase.waitForSpecificMsg*().
Code cleanup

ReplicationTestCase.java:
In waitForSpecificMsgs() and calling methods, let exceptions go up.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12776 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-24 10:53:01 +0000

4dd4823c EntryHistorical.java: ... Browse Code »

Use HistAttrModificationKey instead of raw string.
Code cleanup

git-svn-id: https://svn.forgerock.org/opendj/trunk@12775 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-24 09:13:47 +0000

dae45c1b Try to fix randomly failing test. ... Browse Code »

JmxTestCase.java:
In getJmxConnectionHandler(), increase maximum wait time from 6s to 10s.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12774 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-24 08:43:46 +0000

ec004dc7 JmxPrivilegeTestCase.java: ... Browse Code »

Extracted methods assertSuccess()
Code cleanup

git-svn-id: https://svn.forgerock.org/opendj/trunk@12773 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-24 08:42:10 +0000

52c76278 HistAttrModificationKey.java: ... Browse Code »

Renamed DELATTR to ATTRDEL to match string representation.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12772 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-24 07:59:10 +0000

21 Aug, 2015

7 commits

700e7baa Reverted part of r12768 ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12771 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-21 15:40:08 +0000

fc13fa8b Test code cleanup ... Browse Code »


NamingConflictTest.java
Extracted fields to simplify code in test methods.
Extracted methods setUpLocal(), tearDown(), addMsg(), modDnMsg(), replayMsg(), createAndAddEntry(), createParentEntry(), createChildEntry().

ModifyConflictTest.java:
Made the code a bit more readable.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12770 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-21 15:39:46 +0000

6a724f71 AttrHistoricalSingle.java: ... Browse Code »

Extracted methods replaceOrDelete(), add(), replace(), delete() and deleteWithoutDeleteTime() to increase code expressiveness.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12769 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-21 14:48:58 +0000

16054e1b AssuredReplicationPluginTest.java: ... Browse Code »

Used ReplicationTestCase.waitForSpecificMsg() and waitForSpecificMsgs() to ignore unrelated messages.

ReplicationTestCase.java:
Added methods:
- waitForSpecificMsgs(Session session, Class<?>... msgTypes)
- waitForSpecificMsgs(ReplicationBroker broker, Class<?>... msgTypes)
Changed
<T extends ReplicationMsg> T waitForSpecificMsg(Session session, ReplicationBroker broker, Class<T> msgType)
to
ReplicationMsg waitForSpecificMsgs(Session session, ReplicationBroker broker, Class<?>... msgTypes)

git-svn-id: https://svn.forgerock.org/opendj/trunk@12768 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-21 14:33:17 +0000

05b1b0e4 HistoricalAttributeValueTestCase.java: ... Browse Code »
```
Added test values.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12767 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-21 12:47:25 +0000
a1a9d57a AttrHistoricalMultiple.java, AttrValueHistorical.java: ... Browse Code »
```
Improved toString()

git-svn-id: https://svn.forgerock.org/opendj/trunk@12765 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-21 10:51:46 +0000

edd83f36 Fix random test failure. ... Browse Code »

Tests methods were not properly isolated. The sequence testUpdateDeletedIDs() followed by testUpdateAddedIDs() caused the following failure:
17:42:32                  T E S T   F A I L U R E ! ! !
17:42:32 
17:42:32 Failed Test:  org.opends.server.backends.pluggable.DefaultIndexTest#testUpdateAddedIDs
17:42:32 Failure Cause:  java.lang.AssertionError: 
17:42:32 Expecting:
17:42:32  <[]>
17:42:32 to contain:
17:42:32  <[1, 2, 3, 4]>
17:42:32 but could not find:
17:42:32  <[1, 2, 3, 4]>
17:42:32 
17:42:32     org.opends.server.backends.pluggable.Utils.assertIdsEquals(Utils.java:39)
17:42:32     org.opends.server.backends.pluggable.Utils.assertIdsEquals(Utils.java:51)
17:42:32     org.opends.server.backends.pluggable.DefaultIndexTest.testUpdateAddedIDs(DefaultIndexTest.java:76)



DefaultIndexTest.java:
In setUp(), use @BeforeMethod annotation (rather than @BeforeTest)


git-svn-id: https://svn.forgerock.org/opendj/trunk@12764 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-21 09:42:39 +0000

20 Aug, 2015

4 commits

cfa395e7 CR-8001 OPENDJ-2216 Add upgrade task which reruns dsjavaproperties ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12763 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2015-08-20 17:19:24 +0000

592f2972 RebuildIndexTask.java: ... Browse Code »

Removed indexExists, used Collection.contains() instead

git-svn-id: https://svn.forgerock.org/opendj/trunk@12761 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-20 10:14:55 +0000

bb64845d Add missing method in LdapPromiseWrapper ... Browse Code »

* opendj.ldap.spi.LdapPromiseWrapper
** The method was missing since the Promise API has been changed in fru-2.0.0-SNAPSHOT

git-svn-id: https://svn.forgerock.org/opendj/trunk@12760 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-20 08:49:47 +0000

377596cb Fix OPENDJ-2243: Missing ".bat" extension for bat/addrate script ... Browse Code »

Rename "opendj-ldap-toolkit/src/main/assembly/bat/addrate" to "opendj-ldap-toolkit/src/main/assembly/bat/addrate.bat"


git-svn-id: https://svn.forgerock.org/opendj/trunk@12759 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-20 07:37:59 +0000

19 Aug, 2015

3 commits

bdb8fa02 AttrHistoricalSingleTest.java: ... Browse Code »

Fixed a bug in replay_deleteMissingAttributeValue().
Renamed replayOperationSuccess() to replayOperation().
Renamed replayOperationFailure() to replayOperationSuppressMod().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12758 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-19 14:57:26 +0000

e407cbc4 OPENDJ-1192 Modify request replay failures ... Browse Code »

Added unit tests for AttrHistoricalSingleT and AttrHistoricalMultiple.
Renamed AttrInfoTest to AttrHistoricalMultipleTest.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12757 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-19 14:10:08 +0000

f6eafc85 CR-7872 OPENDJ-2238 Add support for FreeBSD to init script ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12756 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2015-08-19 09:43:33 +0000

18 Aug, 2015

3 commits

16d24293 AttrHistoricalSingle.java: ... Browse Code »

In processLocalOrNonConflictModification(), made the code more explicit + prevented double assignment

*.java:
Added toString().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12755 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-18 14:51:20 +0000

fbd5487a Changed AttrHistorical.getValuesHistorical() return type to match usage ... Browse Code »


AttrHistorical.java:
In getValuesHistorical(), changed return type from Map<AttrValueHistorical, AttrValueHistorical> to Set<AttrValueHistorical> - to match the usage.

AttrHistoricalMultiple.java:
Consequence of the change to AttrHistorical.getValuesHistorical().
In delete(Attribute, CSN), now call delete(ByteString, CSN).
In add(Attribute, CSN), now call add(ByteString, CSN).
Extracted method update(CSN, AttrValueHistorical).
In conflictAdd(), changed return type to void since it was never used.
Removed javadoc copied from supertype + useless @inheritDoc.
Reduced method's visibilities.

AttrHistoricalSingle.java
Consequence of the change to AttrHistorical.getValuesHistorical().
Removed javadoc copied from supertype + useless @inheritDoc.
Used static import for HistAttrModificationKey.*.
Extracted method getSingleValue().

EntryHistorical.java:
Consequence of the change to AttrHistorical.getValuesHistorical().
Extracted method toOptionsString().
In newInstanceFromEntry(), reduced scope of variables.

AttrInfoTest.java:
Consequence of the change to AttrHistorical.getValuesHistorical().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12754 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-18 12:56:09 +0000

3a418f54 Replaced uses of StringBuilder.append(Utils.joinAsString(String, Collection)) wi… ... Browse Code »
```
…th the more efficient Utils.joinAsString(StringBuilder, String, Collection).

git-svn-id: https://svn.forgerock.org/opendj/trunk@12753 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-18 09:39:52 +0000

17 Aug, 2015

6 commits

e52f59c4 DirectoryServer.java: ... Browse Code »

Removed fields duplicating the ones from CoreSchema + replaced them with the getters directly delegating to CoreSchema methods.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12752 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-17 15:01:57 +0000

e6a7de5a DatabaseEnvironmentMonitor.java: ... Browse Code »

Remove class which has been moved to org.opends.server.backends.jeb

git-svn-id: https://svn.forgerock.org/opendj/trunk@12751 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-17 14:35:58 +0000

2bfac168 ChangelogBackendTestCase.java: ... Browse Code »

In assertChangelogAttributesInRootDSE(), removed always true parameter "isECLEnabled".

ReplicationTestCase.java:
Code cleanup

git-svn-id: https://svn.forgerock.org/opendj/trunk@12750 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-17 11:55:34 +0000

b5491f8a CR-7933 OPENDJ-2240 Handle lack of spaces at end of attributeType values ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12747 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2015-08-17 10:13:35 +0000
0c9bc6fc opendj-server-legacy module: replace fest by assertj ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12746 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-17 09:39:56 +0000

7c871b0b Code cleanup ... Browse Code »

Fix a bug in RootDSEBackend.getRootDSE().

RootDSEBackend.java:
In getRootDSE(), fix a bug with supportedAuthPWSchemes which wrongly referred to supportedSASLMechanism attribute.
In addAttribute(), renamed publicNamingContextAttr parameter to attribute
Used interfaces for collections rather than concrete classes.
Removed useless @inheritDoc javadoc.

Task.java:
Extracted methods getTime(), compareTimes(), 
In execute(), simplified code.

LDAPReplicationDomain.java, ReplicationDomainMonitorData.java:
Code cleanups

git-svn-id: https://svn.forgerock.org/opendj/trunk@12745 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-17 08:56:29 +0000