org.forgerock / org.forgerock.openicf

10 Dec, 2009

1 commit

04 Dec, 2009

1 commit

01 Dec, 2009

1 commit

30 Nov, 2009

1 commit

27 Nov, 2009

1 commit

  • 94e857f8   IMPLEMENTATION of Update for Group (both native and NIS) ... Browse Dir » 
    * UpdateNativeGroupCommand.java + basic unit test.
* UpdateNISGroupCommand.java -- TODO needs some testing on special NIS resource.
 
REFACTORINGS:
- refactoring: OpCreateImpl, OpDeleteImpl - better naming of entry and account related variables.
- cleanup of NativeAttribute (unused methods / fields)
- refactoring UpdateNISUserCommand: sudoStart should be before the try/finally block. If something goes wrong in sudoStart, the program should stop immediately, and should not try to do sudoReset (that lies in the finally block).
- united calls of getOwner script across all the NIS operations (AbstractNISOp#initGetOwner() is the central hub for all).
- both Create/UpdateNISGroupCommand use the same logic for processing some output, so created a common method for them: AbstractNISOp#parseNisOutputForErrors(String outputFromCommand).
- better naming in UpdateNISUserCommand.java, OpDeleteImpl.java, OpCreateImpl.java
- erased unnecessary code from NativeAttribute.
- doc update on SolarisConnection (needs review from Andrei TBD)


git-svn-id: https://svn.forgerock.org/openicf/trunk@5509 05b3e5af-d696-470f-a577-fd7599f74d3c
    davidadam
     

25 Nov, 2009

1 commit

24 Nov, 2009

4 commits

16 Nov, 2009

1 commit

  • 225c0582   Search consolidation: ... Browse Dir » 
    - implement Group search
- align Group and Account search (for both Native and NIS use cases)
- implement and test GroupIterator

TODO:
add javadoc where needed + more unit tests (w.r.t. search for Group in OpSearchImpl --> We have to wait with this, until other group operations are ready too. (CRUD))


git-svn-id: https://svn.forgerock.org/openicf/trunk@5488 05b3e5af-d696-470f-a577-fd7599f74d3c
    davidadam
     

09 Nov, 2009

3 commits

05 Nov, 2009

1 commit

  • 69ec2da4   Fixed contract tests: ... Browse Dir » 
    -- org.identityconnectors.contract.test.SearchApiOpTests.testCaseInsensitiveSearch()
 * config.groovy

-- org.identityconnectors.contract.test.DeleteApiOpTests.testDeleteThrowUnknownUid()
 * OpDeleteImpl.java


git-svn-id: https://svn.forgerock.org/openicf/trunk@5466 05b3e5af-d696-470f-a577-fd7599f74d3c
    davidadam
     

04 Nov, 2009

1 commit

03 Nov, 2009

3 commits

30 Oct, 2009

2 commits

27 Oct, 2009

2 commits

20 Oct, 2009

2 commits

  • 3d3991c0   cleanup ... Browse Dir » 
    git-svn-id: https://svn.forgerock.org/openicf/trunk@5409 05b3e5af-d696-470f-a577-fd7599f74d3c
    davidadam
     
  • 8eb17aaa   Consolidated SolarisConnection ... Browse Dir » 
    - concept of accepts, rejects, and command.
  - changed all operations to use the new convention
  - eliminated direct call of expect4j, which can be dangerous (order of matchers matters!)
--
"That's one small step for a man, a giant leap for mankind" (Armstrong)


git-svn-id: https://svn.forgerock.org/openicf/trunk@5406 05b3e5af-d696-470f-a577-fd7599f74d3c
    davidadam
     

15 Oct, 2009

1 commit

12 Oct, 2009

1 commit

06 Oct, 2009

1 commit

02 Oct, 2009

1 commit

30 Sep, 2009

1 commit

25 Sep, 2009

1 commit

24 Sep, 2009

3 commits

23 Sep, 2009

1 commit

  • 286a2ace   - logging refactoring (_log instead of getLog() ... Browse Dir » 
    - simplified OpCreateImpl
   - added CommandSwitches map class which provides switches for Update, Create and Passwd Commands.
   - TODO decouple Create from getting the MutexAcquirescript from Update.
- added a few new attributes used by create in SolarisConfiguration

TODOS
- OpUpdateImpl: TODO refactor it according to OpCreateImpl to a new form, see FIXME note.
- CommandUtil: too little to be standalone, thing of some merge.


git-svn-id: https://svn.forgerock.org/openicf/trunk@5299 05b3e5af-d696-470f-a577-fd7599f74d3c
    davidadam
     

22 Sep, 2009

2 commits

  • 8a89959c   refactoring & cleanup ... Browse Dir » 
    git-svn-id: https://svn.forgerock.org/openicf/trunk@5273 05b3e5af-d696-470f-a577-fd7599f74d3c
    davidadam
     
  • 01b4d97c   BIG BANG commit: ... Browse Dir » 
    [A] changes to operation implementations:
A.1 OpAuthenticateImpl -- rewritten bottom-up based on adapter impl.
A.2 OpUpdateImpl -- changes mainly caused by erasure of legacy attribute name constants.
A.3 OpCreateImpl -- the same changes as A.1

  
[B] cleanup of files that are connected to legacy attribute name constants (in old 'constants' package)
B.1 PatternBuilder deleted
B.2 added package 'attr' which contains the new simplified attribute name constants.

[C] Other improvements
- SolarisConnection contains public reference to the configuration, so we don't need to pass them in methods separately. Triggered changes to: BlockAccountIterator, and many other classes.
- modified generation of schema based on new attribute names form new 'attrs' package.
- SolarisConnection now enables TELNET connection.
- SolarisConnection provides the current rootShellPrompt by its getRootShellPrompt() method. (It is always set to the correct one, and the configuration itself is not modified).

[D] TODOs:
>> Control the generation of the Schema (if it is the same as before transition to 'attr' package attribute names)
>> Resolve problem of NativeAttribute#getCmdSwitch() -- it should be a private property of the Update/CreateOperation itself, and should not leak into the constants.


git-svn-id: https://svn.forgerock.org/openicf/trunk@5271 05b3e5af-d696-470f-a577-fd7599f74d3c
    davidadam
     

17 Sep, 2009

2 commits

  • 32cda0af   *A* OpSearchImpl -- implementation for ACCOUNT search is FINISHED, though further testing is needed. ... Browse Dir » 
    . Search op unit tests are enabled.

*M* made SolarisEntries's methods static (no state involved)
*M* UniversalNode -- filter that accepts all entries
* OpSearchImpl now is completely initialized through constructor (evaluate() method has no args). Reason: it has to preserve the state throughout search; disputable.

*M* Account/GroupAttribute doesn't need a fromNative() method. It is never used. (erasing unit tests for this method too).


git-svn-id: https://svn.forgerock.org/openicf/trunk@5236 05b3e5af-d696-470f-a577-fd7599f74d3c
    davidadam
     
  • c03ff466   test for rev. 5233 ... Browse Dir » 
    git-svn-id: https://svn.forgerock.org/openicf/trunk@5234 05b3e5af-d696-470f-a577-fd7599f74d3c
    davidadam
     

16 Sep, 2009

1 commit