org / org.jsmpp

17 Feb, 2012

3 commits

0412e879 Less chatter about activity/enquireLink on session ... Browse Code »
```
A different commit has added logging of all PDUs at debug level so here we reduce the log messages about activity or inactivity.
```
Stefan Thorvardarson
2012-02-17 16:03:58 +0000
e94cf4d1 Debug logging of raw SMPP PDUs ... Browse Code »
```
All PDUs received and sent over SMPP connection are now logged at debug level
```
Stefan Thorvardarson
2012-02-17 16:03:19 +0000
eb4dec8a Add minor unit tests for HexUtil Browse Code »

Stefan Thorvardarson
2012-02-17 15:42:19 +0000

16 Feb, 2012

6 commits

eaec419d Preallocate correct size for StringBuffer in HexUtil Browse Code »

Stefan Thorvardarson
2012-02-16 17:41:49 +0000
022ca7dc Give PDUReaderWorker thread a name Browse Code »

Stefan Thorvardarson
2012-02-16 15:39:40 +0000
6e80cf75 PDUReaderWorker waits for termination of executor service Browse Code »

Stefan Thorvardarson
2012-02-16 15:26:29 +0000
3b5be566 Give EnquireLinkSender thread a name Browse Code »

Stefan Thorvardarson
2012-02-16 14:00:06 +0000

30167dd5 Wait for EnquireLink thread to exit when closing ... Browse Code »

After the smpp session has been closed with close() method, we shouldn't leave any threads running. Any extra threads should have exited before Session.close() exits, otherwise many webapp containers will complain during webapp shutdown or webapp restart

2012-02-16 13:55:47 +0000

75593bdd Refactored EnquireLinkTimer thread into AbstractSession ... Browse Code »
```
There was duplicate code in SMPPSession and SMPPServerSession that should live in AbstractSession.
```
Stefan Thorvardarson
2012-02-16 13:43:39 +0000

15 Feb, 2012

3 commits

c61adc48 Fix race condition when session is being bound ... Browse Code »

When an smpp session is bound and there are messages waiting on the
smsc side, it is legal for the smsc to send a DeliverSM PDU immediately
after it sends a bind response. Because of the PduProcessorDegree,
there is a race condition were both the BindResp and the DeliverSM can
simultaniously be processed but the DeliverSM will be processed like
the session is still in the open state instead of the bound state. This
patch changes the size of the executorService pool to remove the race
condition. It starts with size 1 in open state and when the session is
bound, the pool will be enlarged to the PduProcessorDegree.

2012-02-15 13:22:07 +0000

1255aee2 Retrieve state processor when task is run instead of when enqueued. ... Browse Code »

Change PDUProcessTask so that state processor is retrieved when task is actually executed, not when task is enqueued. This solves a race condition where the bind state changes while a task is enqueued

2012-02-15 13:11:01 +0000

0483393b the method onStateChange() in an SessionStateListener interface always receives … ... Browse Code »
```
…a session, so the passed object can be a Session instead of a generic Object
```
Stefan Thorvardarson
2012-02-15 11:56:52 +0000

14 Feb, 2012

4 commits

82960633 Use readFully() instead of read() for reading in DefaultPDUReader.readPDU(). Und… ... Browse Code »

…er some network conditions, it is possible for the code to receive a partial package over the socket and erronously throw an IOException for the socket. The specs for read() don't guarantee that the full requested length is read in one call. Using readFully() fixes that problem.

2012-02-14 23:34:06 +0000