org.forgerock / org.forgerock.opendj

14 Mar, 2013

1 commit

1b1d0a37 LDAPConnectionHandler.java: ... Browse Dir »

Extracted method checkAnyListenAddressInUse().
Fixed words spelling, renamed exceptions in catch clauses to better communicate their intent.
Added javadocs + @Override annotations.
Used foreach + StaticUtils.close().


git-svn-id: https://svn.forgerock.org/opendj/trunk@8600 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-14 10:57:19 +0000

13 Mar, 2013

2 commits

712c592a Fix minor code alignment style ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8595 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-03-13 09:22:54 +0000

3a627d23 Fix for OPENDJ-800 : Support escaping characters in make-ldif templates. ... Browse Dir »

The main set of changes have been provided by Elliot Kandall @ UCSF, but I've done additional cleanup of code and refactoring, added support for multiple constants per lines (this was required by the support for escaping [ and ].
Unit tests are provided and have been extended after the code review and suggestions by reviewers (CR-1401).

git-svn-id: https://svn.forgerock.org/opendj/trunk@8593 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-13 08:48:57 +0000

12 Mar, 2013

1 commit

1b316a4a OPENDJ-813 (CR-1404) SNMP connection handler does not start when allowed-manager… ... Browse Dir »

… prop is set and server is running with JDK1.7

The issue here is that the TreeSet implementation changed starting from Java 1.7.
When adding as a first element a non Comparable object, Java 1.7 will now throw a ClassCastException.

SNMPInetAddressAcl.java:
Changed hostsList instance member type from TreeSet to Set + HashSet.
In checkReadPermission() used Set.contains().
Used foreach.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8590 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-12 09:50:26 +0000

11 Mar, 2013

1 commit

64955e5e OPENDJ-799 - CR-1391 rebuild-index disables backend after trying to rebuild a nonexistent index. ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8586 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-03-11 13:39:17 +0000

08 Mar, 2013

2 commits

6e013d7b OPENDJ-802 rebuild-index online with "--clearDegradedState" should not disable the backend ... Browse Dir »
```
- Fixed : with degraded state option, the backend is no more disabled/activated.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8575 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-03-08 09:45:51 +0000

26f870df OPENDJ-803 (CR-1380) ldapsearch exits with wrong return code when server is down ... Browse Dir »

LDAPConnection.java:
In connectToHost(), protected LDAPConnectionException from the general catch(Exception) which made our error code disappear.

LDAPSearchTestCase.java:
In getInvalidArgumentLists(), removed very easily 100 lines of code.
Properly used assertEquals() instead of assertTrue().

LDAPSearchNoServerTestCase.java: ADDED

git-svn-id: https://svn.forgerock.org/opendj/trunk@8573 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-08 08:20:00 +0000

07 Mar, 2013

5 commits

d064ff77 Fix typo and code simplification ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8567 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-03-07 13:59:03 +0000
e0c6b182 Fix typos in comment, as well as refactor multi-line comments into blocks, and r… ... Browse Dir »
```
…emove unused param from method.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8566 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-03-07 13:18:34 +0000

d1af4e45 OPENDJ-655 Message about authentication failures should contain identification o… ... Browse Dir »

…f the user for easier analysis. 

Removed the bindDN from several error messages, covering simple bind and SASL bind.

core*.properties:
Updated relevant error messages + the places where they are used in the java code.

TextAccessLogPublisher.java:
In logBindResponse(), log the bindDN and SASL saslAuthUserDN if SASL is used.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8565 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-07 12:03:26 +0000

1ddbeef5 Minor fix about style and typos. ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8562 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-03-07 09:51:12 +0000

77d18595 OPENDJ-655 Message about authentication failures should contain identification o… ... Browse Dir »

…f the user for easier analysis.

Fixed other occurences of copy/pasted code.

LocalBackendBindOperation.java:
In processBind(), fixed the code.
Extracted methods generateAccountStatusNotificationForLockedBindAccount() and getIntegerUserAttribute() to remove duplicated code.



git-svn-id: https://svn.forgerock.org/opendj/trunk@8561 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-07 09:02:37 +0000

06 Mar, 2013

8 commits

14d5bb0e Do the one fix to get a green build. ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8560 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-06 16:55:44 +0000
16acfb22 Revert to revision 8555 of this file. ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8559 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-06 16:54:27 +0000
374cadec Fix OPENDJ-797 Custom Password policy did not survive upgrade to 2.5.0-Xpress1 ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8558 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2013-03-06 16:49:21 +0000

c711abfe OPENDJ-655 Message about authentication failures should contain identification o… ... Browse Dir »

…f the user for easier analysis.

Aargh so much code copy/pasted! Found and fixed other occurences.
Aargh I also broke the build again.

LocalBackendBindOperation.java:
In processBind(), fixed the code.
Extracted methods generateAccountStatusNotificationForLockedBindAccount() and getIntegerUserAttribute() to remove duplicated code.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8557 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-06 16:48:29 +0000

9bb6c8ff OPENDJ-770 Simplify the "rebuild-index --clearDegradedState" command output ... Browse Dir »
```
- Fixed message.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8556 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-03-06 15:58:01 +0000

f77e2588 OPENDJ-655 Message about authentication failures should contain identification o… ... Browse Dir »

…f the user for easier analysis.

What a convoluted code!! It is using a label and a block to implement a goto in Java. yuck!

LocalBackendBindOperation.java:
In processLocalBind(), extracted method processBind().
In the newly extracted method processBind(), converted the break stmts into return stmts + moved the switch stmt inside the try stmt (instead of the try/catch stmt in the switch stmt) + then removed useless if statements and break statements from the switch stmt.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8555 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-06 15:51:04 +0000

a39a6553 OPENDJ-66 (CR-1368) DS does not failover between replication servers in differen… ... Browse Dir »

…t groups when configured explicitly for one of the groups 

ReplicationBroker.java:
In connectAsDataServer(), removed following useless if statement (root cause for the bug):
// Really no other server with our group id ?
if ((tmpRsGroupId == groupId) || (!someServersWithSameGroupId))

Extracted method connectToReplicationServer() in connectAsDataServer().
Removed hasSomeServerWithSameGroupId().

git-svn-id: https://svn.forgerock.org/opendj/trunk@8554 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-06 13:03:44 +0000

9d883d41 OPENDJ-66 DS does not failover between replication servers in different groups w… ... Browse Dir »

…hen configured explicitly for one of the groups 

java.net.Socket implements java.io.Closeable starting from Java 7 only :(


git-svn-id: https://svn.forgerock.org/opendj/trunk@8549 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-06 08:57:56 +0000

05 Mar, 2013

8 commits

a345dbb7 OPENDJ-66 (CR-1365) DS does not failover between replication servers in differen… ... Browse Dir »

…t groups when configured explicitly for one of the groups 

Fixing checkstyle errors.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8548 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-05 17:06:37 +0000

53006813 OPENDJ-66 (CR-1365) DS does not failover between replication servers in differen… ... Browse Dir »

…t groups when configured explicitly for one of the groups 

Fixing checkstyle errors.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8547 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-05 17:01:02 +0000

3881ced1 OPENDJ-66 (CR-1365) DS does not failover between replication servers in differen… ... Browse Dir »

…t groups when configured explicitly for one of the groups 

Code cleanup.

ReplicationBroker.java
In computeBestReplicationServer(), fixed the screwed up for (ctr) switch (ctr){}; pattern + added keepBest() method.
In computeBestServerForWeight(), used BigDecimal.valueOf() instead of ctor.
In changeConfig(), fixed complicated condition.
Added javadocs, fixed variable naming, used foreach.

StaticUtils.java:
Added toIterable().

git-svn-id: https://svn.forgerock.org/opendj/trunk@8546 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-05 16:50:35 +0000

9574d5c1 Fix OPENDJ-765 Modify with replace attr=value and delete attr gets misrecorded in ds-sync-hist ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8542 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2013-03-05 13:13:07 +0000

e4c9e5a4 Code cleanup. ... Browse Dir »

If I see another if (c != null) try{ c.close(); }catch (Throwable t){}, I am going to bail out!!

git-svn-id: https://svn.forgerock.org/opendj/trunk@8541 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-05 12:04:09 +0000

352663cf OPENDJ-764 ldapsearch etc does not try all dns entries ... Browse Dir »

LDAPConnection.java:
Extracted methods createSocket(), createSSLSocket() and createSSLOrBasicSocket().
In createSocket() and createSSLSocket(),call InetAddress.getAllByName() to try all host name entries.

SSLConnectionFactory.java:
Added method createSocket(InetAddress host, int portNumber).

git-svn-id: https://svn.forgerock.org/opendj/trunk@8540 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-05 12:00:24 +0000

70390f94 Cleanup: use Java 5 foreach ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8539 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-05 11:34:10 +0000
a1d1a570 Minor code and typos cleanup. ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8537 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-03-05 10:27:55 +0000

04 Mar, 2013

2 commits

1f8f3624 OPENDJ-770 Simplify the "rebuild-index --clearDegradedState" command output ... Browse Dir »

- If in cleardegradedState mode, output just displays the following msg "Degraded state of index(es) [indexe(s) name] has been removed".

git-svn-id: https://svn.forgerock.org/opendj/trunk@8535 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-04 12:25:31 +0000

4b64fb63 OPENDJ-769 rebuild-index --clearDegradedState in online mode should not rebuild the index ... Browse Dir »
```
- added support for the clearDegradedState option in online mode.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8532 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-03-04 08:37:07 +0000

01 Mar, 2013

5 commits

c4ed891a Fix OPENDJ-750 SNMP: impossible to get the operation counters for a LDAP connection handler ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8529 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2013-03-01 16:21:49 +0000
38ca258c OPENDJ-796 Document new ldif-diff and ldapcompare arguments ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8528 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-01 15:57:23 +0000
0cd0271c OPENDJ-777 (CR-1343) ldapcompare should exit with different values w.r.t compari… ... Browse Dir »
```
…son is successful or not

Fixing the build.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8527 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-01 11:25:21 +0000

c208ef26 OPENDJ-777 (CR-1343) ldapcompare should exit with different values w.r.t compari… ... Browse Dir »

…son is successful or not

LDAPCompare.java:
In mainCompare(), added useCompareResultCode option and changed the code to return the aggregated resultCode when this option is used from command line, else return SUCCESS. Used LDAPResultCode everywhere possible.
In readAndExecute() and executeCompare(), changed result code to int.
Added aggregateResultCode() method.

LDAPCompareTestCase.java:
Replaced exit code 0 with LDAPResultCode.SUCCESS.
In many tests, added checks for --useCompareResultCode option.
Added testMultipleCompareAllTrue(), testMultipleCompareOneCompareIsFalse(), testMultipleCompareOneNoSuchObject(), addEntriesUpToParentDN(), getAggregateResultCodeParamsAndResults() and testAggregateResultCode().

git-svn-id: https://svn.forgerock.org/opendj/trunk@8526 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-01 10:41:48 +0000

47087a85 OPENDJ-778 ldif-diff should exit with different values w.r.t files are identical or not ... Browse Dir »

EncodePassword.java:
Fixed a little bug introduced in previous commit (missing one output message)


git-svn-id: https://svn.forgerock.org/opendj/trunk@8524 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-01 10:07:20 +0000

28 Feb, 2013

5 commits

7f76dcf4 OPENDJ-778 (CR-1341) ldif-diff should exit with different values w.r.t files are identical or not ... Browse Dir »

LDIFFDiff.java:
In mainDiff(), added new arguments "-r, --useCompareResultCode" to ldiff-diff + unified the return pathes for when differences might be found, removing some duplication.

LDIFDiffTestCase.java:
Added more asserts for the "--useCompareResultCode" case within the existing tests.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8516 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-02-28 16:20:30 +0000

af657c47 OPENDJ-778 ldif-diff should exit with different values w.r.t files are identical or not ... Browse Dir »

EncodePassword.java:
In encodePassword(), changed return statements to return actual LDAP result codes + fixed ugly duplication with the return statements for when we must useCompareResultCode.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8514 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-02-28 11:00:38 +0000

87e8830a OPENDJ-771 rebuild-index tool should fail when "--clearDegradedState" and "--reb… ... Browse Dir »
```
…uildDegraded" options are specified on the same command line

git-svn-id: https://svn.forgerock.org/opendj/trunk@8512 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-02-28 10:16:17 +0000

0803d126 OPENDJ-778 ldif-diff should exit with different values w.r.t files are identical or not ... Browse Dir »

LDIFDiff.java:
In mainModify(), changed return statements to return actual LDAP result codes.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8511 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-02-28 10:09:37 +0000

3c0fa9dd OPENDJ-776 ldapmodify with a non-existing file exits with wrong return code ... Browse Dir »

LDAPModify.java: Code cleanup:
- removed useless filename instance member, duplicated passing down the fileNameValue parameter to readAndExecute() method.
- transformed comments to javadocs
- in mainModify(), changed return statements to return actual LDAP result codes.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8510 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-02-28 09:41:12 +0000