org.forgerock / org.forgerock.opendj

28 Feb, 2014

6 commits

  • 283a360a   OPENDJ-1308 (CR-3121) Migrate schema support ... Browse Code » 
    Factorized duplicated code from org.forgerock.opendj.ldap.schema into SchemaUtils.java


git-svn-id: https://svn.forgerock.org/opendj/trunk@10449 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • ec43fc25   OPENDJ-1308 Migrate schema support ... Browse Code » 
    Preparation work for removing org.opends.server.api.MatchingRule.normalizeAssertionValue().
Updated copyright for r10447.

Assertion.java:
In matches(), renamed attributeValue parameter to normalizedAttributeValue.

MatchingRuleImpl.java:
In getAssertion(), renamed value parameter to assertionValue.
Fixed javadocs.

AbstractApproximateMatchingRuleImpl.java, AbstractEqualityMatchingRuleImpl.java: ADDED
Made the relevant approximate and equality matching rule classes subclass these new ones.

AbstractMatchingRuleImpl.java:
In getAssertion(), returned UNDEFINED_ASSERTION.
Extracted method trimConsecutiveSpaces() here from several places in the code.

WordEqualityMatchingRuleImpl.java: REMOVED
Implementation was the same as KeywordEqualityMatchingRuleImpl so reused that class instead + updated CoreSchemaImpl.

KeywordEqualityMatchingRuleImpl.java:
Extracted method isAcceptable().
Removed useless calls to String.intern() on String literals.

IntegerFirstComponentEqualityMatchingRuleImpl.java:
In getAssertion(), used DefaultEqualityAssertion instead of custom built Assertion.

EnumSyntaxTestCase.java:
Made the code more readable.

*.java:
Simplified code by using ConditionResult.valueOf().

git-svn-id: https://svn.forgerock.org/opendj/trunk@10448 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 32c881e5   OPENDJ-1308 Migrate schema support ... Browse Code » 
    Preparation work for removing org.opends.server.api.MatchingRule.normalizeAssertionValue().


Assertion.java:
In matches(), renamed attributeValue parameter to normalizedAttributeValue.

MatchingRuleImpl.java:
In getAssertion(), renamed value parameter to assertionValue.
Fixed javadocs.

AbstractApproximateMatchingRuleImpl.java, AbstractEqualityMatchingRuleImpl.java: ADDED
Made the relevant approximate and equality matching rule classes subclass these new ones.

AbstractMatchingRuleImpl.java:
In getAssertion(), returned UNDEFINED_ASSERTION.
Extracted method trimConsecutiveSpaces() here from several places in the code.

WordEqualityMatchingRuleImpl.java: REMOVED
Implementation was the same as KeywordEqualityMatchingRuleImpl so reused that class instead + updated CoreSchemaImpl.

KeywordEqualityMatchingRuleImpl.java:
Extracted method isAcceptable().
Removed useless calls to String.intern() on String literals.

IntegerFirstComponentEqualityMatchingRuleImpl.java:
In getAssertion(), used DefaultEqualityAssertion instead of custom built Assertion.

EnumSyntaxTestCase.java:
Made the code more readable.

*.java:
Simplified code by using ConditionResult.valueOf().

git-svn-id: https://svn.forgerock.org/opendj/trunk@10447 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 1bd3dd51   ConnectionFactoryTestCase.java: Added @AfterClass that calls TestCaseUtils.stopS… ... Browse Code » 
    …erver() to match @BeforeClass

git-svn-id: https://svn.forgerock.org/opendj/trunk@10446 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 215d487a   Fix path to manifest for AbstractManagedObjectDefinition : ... Browse Code » 
    add '/' to make the path absolute, to ensure manifest is found
 when using opendj-config as a jar dependency
 


git-svn-id: https://svn.forgerock.org/opendj/trunk@10445 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     
  • 4cc021ea   Additional fix for OPENDJ-1197: API is lacking functionality to specify TCP connect timeout ... Browse Code » 
    Fix build break: use older JDK6 socket option APIs.

git-svn-id: https://svn.forgerock.org/opendj/trunk@10444 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     

27 Feb, 2014

4 commits

26 Feb, 2014

1 commit

25 Feb, 2014

1 commit

24 Feb, 2014

4 commits

  • 52f6a04c   OPENDJ-1352 upgrade.log does not contain platform line breaks ... Browse Code » 
    - Replaced harcoded "\n" by ServerConstants.EOL.

git-svn-id: https://svn.forgerock.org/opendj/trunk@10425 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     
  • 95c30e49   Fix OPENDJ-1276: ModifyDNRequest javadoc should describe deleteOldRDN default value ... Browse Code » 
    Minor Javadoc improvements: document default values for deleteOldRDN and newSuperior for modify DN operations.

git-svn-id: https://svn.forgerock.org/opendj/trunk@10424 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • 063c2ca1   Fix OPENDJ-1348: Various connection pool implementations do not recover if the t… ... Browse Code » 
    …arget server is powered off and restarted

* HeartBeatConnectionFactory: check for heartbeat timeouts when there is a bind/startTLS in progress. Use the pending bind/startTLS as a proxy for the heartbeat request
* CachedConnectionPool: flush all pending connection futures if an attempt to establish a new pooled connection fails. Improve statistics in toString() representation to make problems easier to diagnose during debugging
* AbstractLoadBalancingAlgorithm: minor change - notify event listeners after closing the monitoring connection so that statistics are more accurate.

Reviewed by Jean-Noel.


git-svn-id: https://svn.forgerock.org/opendj/trunk@10423 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • bff68fe3   Checkpoint for OPENDJ-1303 "opendj-cli" ... Browse Code » 
    - Replaced some argument names by their long identifier.toLowerCase() (in CommonArguments ).
- Replaced "trustAll" -> CommonArguments.getTrustAll()
- Replaced "showUsage"/"help" -> CommonArguments.getShowUsage()
- Renamed sslBlindTrust by trustAll in LDAPPasswordModify.java
- Added OPTION_LONG_RESTART to ArgumentConstants. 
	- Replaced "restart" string in StopDS.java by OPTION_LONG_RESTART.
	- Replaced argument declaration by CommonArguments.getRestart().

git-svn-id: https://svn.forgerock.org/opendj/trunk@10422 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     

21 Feb, 2014

3 commits

  • 58dc83b8   Checkpoint for OPENDJ-1303 "opendj-cli" ... Browse Code » 
    - Fixed build in SetupCli. Added message + replaced importLDIF to getLDIFFile.

git-svn-id: https://svn.forgerock.org/opendj/trunk@10420 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     
  • 447aba21   Checkpoint for OPENDJ-1303 "opendj-cli" ... Browse Code » 
    - added javadoc for arguments which share the same short ID. (TBC...)
- added argument constants.

git-svn-id: https://svn.forgerock.org/opendj/trunk@10418 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     
  • 9ec826a1   Checkpoint for OPENDJ-1303 "opendj-cli" ... Browse Code » 
    - added javadoc for arguments which share the same short ID. (TBC...)
- removed from ArgumentConstants 'description' / 'memberName' (unused).
- Added to ArgumentConstants the OPTION_SHORT_CONTROL && OPTION_LONG_CONTROL.

git-svn-id: https://svn.forgerock.org/opendj/trunk@10416 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     

20 Feb, 2014

3 commits

19 Feb, 2014

3 commits

  • 6d1da379   OPENDJ-1271 (CR-3008) dsreplication pre-external-initialization task fails with STOPPED_BY_ERROR ... Browse Code » 
    
Improved design for Replication Topology


ReplicationBroker.java + *Test.java:
Extracted the Topology class to encapsulate the dsList and replicationServerInfos fields + atomically set it via an AtomicReference + moved setLocallyConfiguredFlag(), isSameReplicationServerUrl(), computeConnectedDSs() to Topology class.
Created methods computeNewTopology() and topologyChange() to compute and set the new topology.
Removed generationID instance variable duplicated with the one from ReplicationDomain + updated ctor and setGenerationID().
Improved debugging messages.
Renamed getDsList() to getReplicaInfos() + changed return type from List<DSInfo> to Map<Integer, DSInfo>.
Renamed getRsList() to getRsInfos().
Extracted method toRSInfos().

ReplicationBrokerTest.java: ADDED
Added to test new ReplicationBroker.Topology class.


DSInfo.java:
Changed equals(Set<String>, Set<String>) to equals(Object, Object).
In toString(), hid the assured fields if assured replication is off.

RSInfo.java:
Renamed fields id and serverUrl to rsServerId and rsServerURL.
In toString(), relied on the compiler to generate the String.


TopologyMsg.java:
Renamed fields dsList and rsList to replicaInfos and rsInfos.
Renamed getDsList() to getReplicaInfos() + changed return type from List<DSInfo> to Map<Integer, DSInfo>.
Renamed getRsList() to getRsInfos().
Extracted methods readStrings() and writeStrings().
Code cleanup
Used javadocs


ReplicationDomain.java, replication*.properties:
Extracted class ECLIncludes to replace eclIncludesLock, eclIncludesByServer, eclIncludesAllServers, eclIncludesForDeletesByServer, eclIncludesForDeletesAllServers + moved setEclIncludes() implementation to this class + removed synchronized blocks from all the getters.
Added baseDN to ERR_INIT_NO_SUCCESS_START_FROM_SERVERS.
Inlined initializeRemote().
Removed unused initializeFromRemote().
Reduced methods visibility.
Renamed getReplicaList() to getReplicaInfos() + changed return type from List<DSInfo> to Map<Integer, DSInfo>.
Renamed getRsList() to getRsInfos().
In initializeRemote(), waitForRemoteEndOfInit(), isRemoteDSConnected() and getProtocolVersion(), simplified code.

*.java:
Consequence of the changes above.
Simplified code in a number of places, particularly in the tests.

git-svn-id: https://svn.forgerock.org/opendj/trunk@10405 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • f2993090   Checkpoint for OPENDJ-1303 "opendj-cli" ... Browse Code » 
    - Added messages.
- Added common arguments.
- Added constants.
- Unit test : removed TODO.

git-svn-id: https://svn.forgerock.org/opendj/trunk@10404 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     
  • 8346f79b   Fix OPENDJ-1350: Access controls and timelimits are not enforced when searching cn=changelog ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@10402 41b1ffd8-f28e-4786-ab96-9950f0a78031
    cjr
     

18 Feb, 2014

6 commits

17 Feb, 2014

1 commit

  • acd8880e   ModificationType.java, ResultCode.java, SearchScope.java: ... Browse Code » 
    Added asEnum() + added an actual inner enum called Enum to match all the cases.
In valueOf(int), fixed a bug for ResultCode + implemented it the same as ResultCode for the other classes.

ModificationTypeTestCase.java, ResultCodeTestCase.java: ADDED

SearchScopeTestCase.java:
Added more tests.

DataProviderIterator.java: ADDED
Eases developing TestNG's DataProviders.

git-svn-id: https://svn.forgerock.org/opendj/trunk@10386 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

14 Feb, 2014

8 commits