org.forgerock / org.forgerock.opendj

16 Apr, 2015

1 commit

29c5304d Code cleanup ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12095 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-04-16 10:55:06 +0000

15 Apr, 2015

2 commits

45d08b74 Code cleanup ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12094 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-04-15 20:01:20 +0000
5800d7e9 Minor code cleanup: Use assertThat() in LDAPSyntaxTest ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12093 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ylecaillez
2015-04-15 13:04:53 +0000

14 Apr, 2015

7 commits

2d4f9edc OPENDJ-1929 Improve suggested dsconig cmd line ... Browse Code »

As suggested by Ludo, in general it's better to do delete before add.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12092 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-14 15:24:33 +0000

fb06d9a1 OPENDJ-1929 Minor code cleanup ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12091 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
gaetan
2015-04-14 15:24:29 +0000

7fbc94db OPENDJ-1929 Code cleanup ... Browse Code »

* src/main/java/org/opends/guitools/controlpanel/util/ConfigFromFile.java
** Apply r12079 refqctoring

git-svn-id: https://svn.forgerock.org/opendj/trunk@12090 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-14 10:29:09 +0000

d67b76d4 OPENDJ-1929 Code cleanup ... Browse Code »

* org.opends.guitools.controlpanel.ui.VLVIndexPanel.java
* org.opends.guitools.controlpanel.ui.AbstractVLVIndexPanel.java
* org.opends.guitools.controlpanel.ui.NewVLVIndexPanel.java
* org.opends.guitools.controlpanel.task.DeleteIndexTask.java
** Use List instead of ArrayList as declarative type
** Reformat
** Add final keyword
** Add @Override annotations
** Remove unecessary javadoc

* org.opends.guitools.controlpanel.task.Task.java
** In method getConfigCommandLineArguments():
*** Returns a List instead of ArrayList

git-svn-id: https://svn.forgerock.org/opendj/trunk@12089 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-14 10:29:05 +0000

c65bd791 OPENDJ-1929 Code cleanup ... Browse Code »

* VLVIndexDescriptor.java
** Add final keyword
** Reformat

git-svn-id: https://svn.forgerock.org/opendj/trunk@12088 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-14 10:28:59 +0000

04008912 OPENDJ-1929 Code cleanup ... Browse Code »

* indexDescriptor.java
** Add final keyword
** Add override annotations
** Extract local constants for database indexes
** Reformat and improve a bit javadoc

git-svn-id: https://svn.forgerock.org/opendj/trunk@12087 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-14 10:28:55 +0000

d64b85d7 OPENDJ-1929 Backport r11503 to server-legacy ... Browse Code »

This change is a backport to opendj-server-legacy of the bug fixing done in opendj-config at revision r11503.
* org.opends.server.client.spi.Driver
** Fix bug in config framework that prevented management of Persistit backend indexes using dsconfig.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12086 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-14 07:35:39 +0000

13 Apr, 2015

1 commit

1bba0ada OPENDJ-1943 Fix control panel new index ... Browse Code »

* NewIndexPanel.java
** Revert changes from revision 10554

git-svn-id: https://svn.forgerock.org/opendj/trunk@12085 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-13 07:51:15 +0000

10 Apr, 2015

14 commits

1e65424b OPENDJ-1878: remove unnecessary entry read locks. ... Browse Code »

Some code was using read-locks before calling Backend.getEntry(DN), but read-locks are no longer required.


git-svn-id: https://svn.forgerock.org/opendj/trunk@12084 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 16:18:30 +0000

58ea50f5 Code cleanup: remove unused import. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12083 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2015-04-10 16:13:06 +0000

d531861c OPENDJ-1878: minor code cleanup ... Browse Code »

* JE/Pluggable EntryContainer: defend against cases where caller does not hold any locks (very common)
* Backend/DirectoryServer: update getEntry() and entryExists() Javadoc to specify that no locks are required
* other miscellaneous code cleanup.


git-svn-id: https://svn.forgerock.org/opendj/trunk@12082 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 15:24:40 +0000

dde1c334 OPENDJ-1809 CR-6564 Disk Space Monitoring should be a server wide service ... Browse Code »

Disk space monitoring is now a global service, per DirectoryServer instance.
Backends can get the service through a serverContext and will be notified of any trigger of the configured thresholds.
Instead of using raw directories, if the JVM supports it, try to gather the mountpoints or global root folders and monitor those
instead. Still messages logged by the backends will reference only their own directories.
Each backend can also log its own messages in addition to what already logged by the general service.



git-svn-id: https://svn.forgerock.org/opendj/trunk@12081 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 14:55:54 +0000

3b86a194 OPENDJ-1929 Code cleanup ... Browse Code »

* BackendDescriptor.java
** Sort Type enum values

git-svn-id: https://svn.forgerock.org/opendj/trunk@12080 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 10:43:05 +0000

d7c916da OPENDJ-1929 Code cleanup ... Browse Code »

* ConfigFromDirContext.java
** readConfiguration(InitialLdapContext)
*** Reformat
*** Add final keyword
*** Rename local variables to make the code more readable
*** Extracted methods
**** readSchemaIfNeeded(InitialLdapContext, List)
**** readConfig(InitialLdapContext, Set<ConnectionHandlerDescriptor>, Set<BackendDescriptor>, Set<DN>, List<OpenDsException>)
**** readAdminConnector(RootCfgClient, List<OpenDsException>)
**** readConnectionHandlers(Set<ConnectionHandlerDescriptor>, RootCfgClient, List<OpenDsException>)
**** readBackendConfiguration(Set<BackendDescriptor>, RootCfgClient, List<OpenDsException>)
**** refreshLocalDBBackendConfig(Set<IndexDescriptor>, Set<VLVIndexDescriptor>, BackendCfgClient backend, List<OpenDsException>)
**** readIfReplicationIsSecure(RootCfgreadSyncProviderIfExists(final RootCfgClient root)Client, List<OpenDsException>)
**** readSyncProviderIfExists(RootCfgClient)
**** readReplicationConfig(Set<ConnectionHandlerDescriptor>, Set<BackendDescriptor>, ReplicationSynchronizationProviderCfgClient, boolean, List<OpenDsException>)
**** readAlternateBindDNs(Set<DN>, RootCfgClient, List<OpenDsException>)

git-svn-id: https://svn.forgerock.org/opendj/trunk@12079 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 10:43:02 +0000

acd443cf OPENDJ-1929 Code cleanup ... Browse Code »

* IndexPanel.java
** Reformat
** Add final keyword
** Use list as declarative type

git-svn-id: https://svn.forgerock.org/opendj/trunk@12078 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 10:42:58 +0000

5fff3286 OPENDJ-1932 Code cleanup ... Browse Code »

* NewBaseDNPanel.java
** validateAutomaticallyGenerated(final Set<LocalizableMessage> errors)
*** Extract local constants
*** Add final keyword

* StatusGenericPanel.java
** checkIntValue(Collection<LocalizableMessage> errors, String stringValue,int minValue, int maxValue, LocalizableMessage errMsg)
*** Now return a boolean to allow client code to use conditionnal code after call
*** Don't throw runtime exception anymore (Thanks Jean-Noël for refactoring advices!)

* ExportLDIFPanel.java
** okClicked()
** Consequences of checkIntValue changes

git-svn-id: https://svn.forgerock.org/opendj/trunk@12077 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 10:30:37 +0000

0c67de10 OPENDJ-1932 Code cleanup ... Browse Code »

* NewBaseDNPanel.java
** refactor okClicked()
*** Reformat
*** Add final keyword
*** Extract local NEW_BACKEND_TEXT constant
*** Extracted methods
**** resetLabelAsValid()
**** validateBackendName(final Set<BackendDescriptor> existingBackends, final Set<LocalizableMessage> errors)
**** validateBaseDN(final String backendName, final Set<BackendDescriptor> existingBackends, final Set<LocalizableMessage> errors)
**** validateImportLDIFFilePath(final Set<LocalizableMessage> errors)
**** validateAutomaticallyGenerated(final Set<LocalizableMessage> errors)

git-svn-id: https://svn.forgerock.org/opendj/trunk@12076 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 10:30:32 +0000

b7842b3b OPENDJ-1932 Code cleanup ... Browse Code »

* opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/NewBaseDNPanel.java
** Reformat
** Removes unecessary javadocs
** Use interface List declarative type instead of ArrayList

git-svn-id: https://svn.forgerock.org/opendj/trunk@12075 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 10:30:29 +0000

85a2312c OPENDJ-1932 Code cleanup ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12074 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
gaetan
2015-04-10 10:30:25 +0000
8b9d4ac7 OPENDJ-1605 CR-6610 update syntax for ds-base-dn-entry-count to reflect actual usage ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12073 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ian.packer
2015-04-10 09:39:31 +0000

251b3640 OPENDJ-1893 (CR-6600) Do not hardcode Importer threadCount to 1 ... Browse Code »

Problem was due to multiple threads sharing the same Persistit exchanges. Generally speaking DBs do not like mixing transactions and threads.
By using transactions for each DB access, the problem disappears.
Are we losing any performance by using full fledged transactions? Could we somehow do these operations in a thread safe manner without the need to use transactions?

Importer.java:
Use transactions for read/write operations on DN cache.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12072 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 09:07:55 +0000

e89c578c More code cleanup: ... Browse Code »

Added generics
Ignored javadocs warnings
etc.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12071 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 08:16:10 +0000

09 Apr, 2015

7 commits

c87ea6ca Minor code cleanup: reduce visibility and remove redundant method parameter. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12070 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2015-04-09 22:59:43 +0000

25114903 Minor code cleanup: ... Browse Code »

* removed listDatabases(), getConfiguration(), and substringKeys() in AttributeIndex
* added AttributeIndex.isIndexed() and modified BackendImpl.isIndexed() to delegate to AttributeIndex.


git-svn-id: https://svn.forgerock.org/opendj/trunk@12069 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-09 22:45:43 +0000

c8f1b0bf Minor code cleanup: use matching rule's index ID for verifying indexes. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12068 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2015-04-09 22:16:52 +0000
f21a4627 Minor code cleanup: use matching rule's index ID for identifying indexes. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12067 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2015-04-09 21:25:21 +0000

6fed2f34 IndexOutputBuffer.java: ... Browse Code »

Prevent too many allocations

git-svn-id: https://svn.forgerock.org/opendj/trunk@12066 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-09 16:57:19 +0000

ea6acd4a Introduced ImportRecord to get rid of IndexOutputBuffer.IndexComparator and its … ... Browse Code »

…myriad of compare() methods.
ImportRecord is composed of a key as a ByteSequence and an indexID being an int.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12065 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-09 16:34:24 +0000

fdd07f33 OPENDJ-1714 (CR-6595) UI setup backend type choice ... Browse Code »

* Installer.java
** Remove temparary OPENDJ-1927 fix

* DataOptionsPanel.java
** Add a combo box to allow user to select a backend type (default value is JE)

* Utils.java
** Update UI installation review and equivalent setup command

* FieldName.java
** Add the backend type field name

git-svn-id: https://svn.forgerock.org/opendj/trunk@12064 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-09 12:41:47 +0000

08 Apr, 2015

8 commits

f86728a6 DatabaseContainer.java: ... Browse Code »

Removed unnecessary declaration of toString() in an interface.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12063 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-08 16:18:32 +0000

cbe25d4d OPENDJ-1714 Code cleanup ... Browse Code »

* Installer.java
** Minor refactorings in method updateUserDataForNewSuffixOptionsPanel(QuickSetup)
*** Fix minor UI bug with invalid/valid fields
*** Reformat
*** Add final keyword
*** Replace hardcoded line separator by constant
*** Extracted methods:
**** checkProvidedBaseDn(QuickSetup, List<String>, List<LocalizableMessage>)
**** checkImportLDIFFile(QuickSetup, List, boolean, List)
**** checkImportGeneratedData(QuickSetup, List, boolean, List)
**** checkImportData(QuickSetup, List, boolean, List)

git-svn-id: https://svn.forgerock.org/opendj/trunk@12062 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-08 14:42:49 +0000

4ed4c538 AttributeIndex.java: ... Browse Code »

Protect against accidental changes.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12061 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-08 11:56:40 +0000

bea3b609 AttributeIndex.java: ... Browse Code »

Removed more duplicated code.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12060 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-08 11:55:25 +0000

b34fb23d Code cleanup ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12059 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-04-08 11:35:19 +0000

34e0c4cb (CR-6590) Remove code specific to extensible indexes in Importer and VerifyJob ... Browse Code »

AttributeIndex.java:
Removed extensibleIndexesMapping field + getter getExtensibleIndexes() + computeExtensibleIndexesMapping() and isDefaultIndex().
Removed getDefaultNameToIndexes(), superseded by getNameToIndexes()

Importer.java:
Removed extensibleIndexMap, superseded by indexMap.
Removed one fillIndexMap(), superseded by the other fillIndexMap()
Removed processExtensibleIndexes().

VerifyJob.java:
Consequence of removing AttributeIndex.getDefaultNameToIndexes().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12058 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-08 11:29:49 +0000

ff7abfb3 Minor code simplification and fix for incorrect trace logging. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12057 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2015-04-08 07:59:47 +0000

598b5221 CR-6580 OPENDJ-1796 Use static hostname in reference docs ... Browse Code »

This patch prevents generated man pages
from using the default host name of the build system.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12056 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-08 07:08:08 +0000