org.forgerock / org.forgerock.opendj

23 May, 2013

4 commits

2cf794b3 Fix for OPENDJ-939: Upgrade to forgerock-doc-maven-plugin 1.2.0 ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8898 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-05-23 14:15:27 +0000

300a50a8 OPENDJ-844 Patches don't affect ControlPanel.app ... Browse Code »

OPENDJ-842 On Windows, the setup command hangs when the length of the install path is too long


Code review and initial idea: violette


Now that the application starts with the single bootstrap jar, MacOS X can take advantage of this by referencing it statically in the plist files. In other words, it is no longer necessary to build the plist files dynamically.


Info.plist:
Hardcoded the path to bootstrap.jar

build.xml:
Removed the code that appended the jars to the **/Info.plist files for MacOS X.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8897 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-23 13:16:11 +0000

d2751614 changed add operation: now checks if column has not null defined before assigning a default value ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8896 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
glennvl
2013-05-23 09:17:01 +0000

9ec54a49 CR-1720 OPENDJ-835 Upgrade should add HTTP Connection Handler to config.ldif ... Browse Code »

OPENDJ-914 Upgrade should add Based HTTP Access Logger to config.ldif
- HTTP connection handler and the based HTTP access logger are now added to upgrade.
- The http-config.json is added to the config file during upgrade.
- Simplified UpgradeTasks.java
- Added new messages.
- Fixed javadoc for unit test.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8895 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-23 08:10:24 +0000

22 May, 2013

5 commits

5f405268 CR-1725 Fix for OPENDJ-893: Update admin guide section on server logs to mention HTTP ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8894 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-05-22 16:37:39 +0000

7b9df29e OPENDJ-902 Add connectionID to the HTTP access log + move to extended log format ... Browse Code »

OPENDJ-858 Add stats tracking to HTTP client connections


The value output by the "cs-uri-query" extended log format was incorrect, the URL parameters should have been separated by a question mark character '?' instead of a slash character '/'.


HTTPClientConnection.java:
Used a question mark character '?' to build the uri query.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8893 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-22 16:03:12 +0000

9bbd9fa2 OPENDJ-927 java.lang.ClassNotFoundException when running OpenDJ QuickSetup ... Browse Code »
```
Thanks Matt & Ludo :)

git-svn-id: https://svn.forgerock.org/opendj/trunk@8892 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-05-22 12:54:28 +0000

50f6c043 OPENDJ-918 (CR-1723) - HTTP Connection Handler - Server cannot start with horked http-config.json ... Browse Code »


Protected the HTTP Connection Handler against a failing initialization: after two consecutive startup failures, the HTTP connection handler will be disabled, errors will be logged and alerts will be output.


HTTPConnectionHandler.java:
Added instance member enabled to decouple the enable/disable state from the config.
Implemented getAlerts() method.
In startHttpServer(), moved the try / catch block and the call to notify() to the run() method.
In run(), handle failing initialization.
In stopHttpServer(), added a null check in case of failed intitialization.
Extracted method cleanUpHttpServer().

ServerConstants.java:
Added alerts for HTTP connection handler.

protocol*.properties:
Modified the name of the LDAP specific properties to be more generic.

LDAPConnectionHandler.java
Consequence of the change to protocol.properties.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8891 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-22 10:33:52 +0000

5371920b CR-1721 Windows: Fixed snmp/basic testcase and added known issue on tasks/restart_db testcase ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8890 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-05-22 10:02:57 +0000

21 May, 2013

9 commits

0d203288 Fixed bug in ConvertSearchFilter() when there was only 1 subfilter present. ... Browse Code »
```
Added documentation.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8889 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
glennvl
2013-05-21 22:58:38 +0000

c221f025 Fix OPENDJ-922: Replication window size is too small on high latency networks ... Browse Code »

* set the default window size to 100K
* indicate that the properties may be deprecated in future releases
* tag properties as advanced.

Reviewed manually by Ludo.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8888 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-21 17:15:15 +0000

cc9f9980 Added getPort() and getHostName() methods. ... Browse Code »
```
Added documentation.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8887 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
glennvl
2013-05-21 13:12:31 +0000
307d6f8f Added getPort() and getHostName() methods. ... Browse Code »
```
Added documentation.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8886 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
glennvl
2013-05-21 13:09:59 +0000

837c0e6a OPENDJ-902 (CR-1702) Add connectionID to the HTTP access log + move to extended log format ... Browse Code »

OPENDJ-858 (CR-1702) Add stats tracking to HTTP client connections



In HTTP access log, changed the name of the non standard "datetime" field to "x-datetime".
Added the "x-etime" field that outputs as a number.
Added validation for the log format that outputs error messages.


FileBasedHTTPAccessLogPublisherConfiguration.xml, FileBasedHTTPAccessLogPublisherConfiguration.properties:
Renamed the "datetime" field to "x-datetime" + added the "x-etime" field.
Improved the description of the ds-cfg-log-format.

TextHTTPAccessLogPublisher.java, config.properties:
Extracted constants for all supported field names.
Added ALL_SUPPORTED_FIELDS constant.
Changed logFormatFields instance member from String[] to List<String>.
Added validateLogFormat() which can output new error messages and called it from applyConfigurationChange() and initializeLogPublisher().
Added subtract().

HTTPClientConnection.java, HTTPRequestInfo.java:
Added instance member totalProcessingTime.
In sendResponse(), added to the totalProcessingTime + extracted method getProcessingTime().
Added getTotalProcessingTime().

git-svn-id: https://svn.forgerock.org/opendj/trunk@8885 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-21 12:47:35 +0000

bb9c7b83 Unbind requests originating from the HTTP Connection Handler always do not logge… ... Browse Code »

…d as internal operations.

SdkConnectionAdapter.java:
In close(), marked the UnbindOperationBasis as being an internal/inner operation.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8884 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-21 12:35:44 +0000

3ae1c0c5 Fixed typo ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8883 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-05-21 12:26:34 +0000

5eab5871 Fix OPENDJ-913: ConcurrentModificationException in TimeoutChecker ... Browse Code »

* use synchronized set for storing connections because request cancellation can cause a re-entrant update of the connection set if the connection is closed
* simplify notification and avoid locking when removing connections.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8882 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-21 11:06:20 +0000

93f7e6e9 OPENDJ-889 Regression: access logger not logging replayed synchronization operat… ... Browse Code »

…ions when it should be

Code review: matthew


AbstractTextAccessLogPublisher.java:
Fixed the bug by coming back a bit to what the old code was doing (it is not totally comparable).

AbstractTextAccessLogPublisherTest.java:
Updated the test.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8881 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-21 09:59:38 +0000

19 May, 2013

1 commit

13fad4bb OPENDJ-842 (CR-1699) On Windows, the setup command hangs when the length of the … ... Browse Code »

…install path is too long

resource/bin/_script-util.bat
Fixed the classpath on Windows (removed double quotes on bootstrap.jar).



git-svn-id: https://svn.forgerock.org/opendj/trunk@8880 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-19 17:01:58 +0000

17 May, 2013

4 commits

2bea0297 OPENDJ-842 (CR-1699) On Windows, the setup command hangs when the length of the … ... Browse Code »

…install path is too long

UpgradeUtils.java:
Fixed the code "fixed" by the plugin.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8879 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-17 15:44:39 +0000

31460397 OPENDJ-842 (CR-1699) On Windows, the setup command hangs when the length of the … ... Browse Code »

…install path is too long


In order to avoid getting errors like "The input line is too long" on windows, a common way to fix this is to provide a "bootstrap" empty jar which contains only a MANIFEST.MF file listing all the application's jars in the "Class-Path" attribute.
This URL describes well enough the problem: http://ant.apache.org/manual/Tasks/manifestclasspath.html


build.xml:
In "prepackage" target, build bootstrap.jar.

_script-util.bat, _script-util.sh:
Replaced appending all the jars under libs with just the bootstrap jar.

Utilities.java, Utils.java, UpgradeUtils.java:
In getInstallPathFromClasspath(), extracted getInstallPath() and simplified its code a lot.

Installation.java, Installation.java:
Changed OPEN_DS_JAR_RELATIVE_PATHS into OPEN_DJ_BOOTSTRAP_JAR_RELATIVE_PATH. 


git-svn-id: https://svn.forgerock.org/opendj/trunk@8878 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-17 13:58:41 +0000

3e5388c4 CR-1677 Fix issue OPENDJ-899: ModDN with the same value ignored by ACIs ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8877 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
manuelgaupp
2013-05-17 12:15:30 +0000
8540daee CR-1700 Fix for OPENDJ-865: Document new upgrade experience ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8876 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-05-17 09:01:33 +0000

16 May, 2013

2 commits

be6a2734 Review comment (thanks, Jamie) ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8875 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-05-16 16:32:32 +0000
eae1c498 OPENDJ-904 RPM/Deb packages should not restart server after package update. ... Browse Code »
```
- Modified RPM/Deb scripts
- Modify RPM build number.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8874 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-05-16 13:14:41 +0000

15 May, 2013

4 commits

f8264f07 Fix message typo. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8873 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-05-15 19:28:58 +0000

86e81646 OPENDJ-842 On Windows, the setup command hangs when the length of the install path is too long ... Browse Code »

Code review: csovant

Jars now appear only once in the classpath (they were appearing twice).
INSTALL_ROOT and INSTANCE_ROOT represented the same absolute paths despite having different relative paths, resulting in the jars appended twice to the classpath.
After this change, the paths are using the absolute paths instead of the relative paths.

_script-util.bat:
Fixed jars appearing twice in the classpath


git-svn-id: https://svn.forgerock.org/opendj/trunk@8872 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-15 14:08:15 +0000

da3229b8 Dump of my Eclipse configuration. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8871 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-05-15 10:14:11 +0000

eafdb0a8 OPENDJ-906 Upgrade: unexpected error for some tools when the server has not been upgraded ... Browse Code »

- make-ldif / encode-password / ldifsearch & ldifmodify are subject to version verification between unpack/upgrade.(They are disabled at this step).

git-svn-id: https://svn.forgerock.org/opendj/trunk@8870 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-15 07:11:21 +0000

14 May, 2013

8 commits

5f408a35 CR-1688 Fix OPENDJ-905 X-SCHEMA-FILE should not allow directory path separators ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8869 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2013-05-14 16:05:08 +0000

96bbb6e9 OPENDJ-808 (CR-1685) Implement a simple commons REST based HTTP connection handler ... Browse Code »



Added support for ds-cfg-num-request-handlers in the HTTPConnectionHandler configuration to bring it at par with the LDAPConnectionHandler configuration.



02-config.ldif, HTTPConnectionHandlerConfiguration.xml, HTTPConnectionHandlerCfgDefn.properties:
Added ds-cfg-num-request-handlers.

HTTPConnectionHandler.java:
Set the SelectorRunnersCount in grizzly based on the numRequestHandlers property.

LDAPConnectionHandler.java, ConnectionHandler.java:
Moved getNumRequestHandlers() from LDAPConnectionHandler to ConnectionHandler.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8868 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-14 15:37:18 +0000

c0c345c4 CR-1681 Fix for OPENDJ-896: Document patch support for REST ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8867 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-05-14 14:14:32 +0000

736bafdc Attempt to fix the random post-commit tests failure, making sure that the config… ... Browse Code »

…uration of the password policy is explicitly set as expected for the test.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8866 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-14 11:33:30 +0000

af43c048 Partial fix for OPENDJ-898: Rename OpenDJ SDK 3.0 to 2.6 in order to align versi… ... Browse Code »

…ons across the product

* change SDK dependencies from 3.0.0-SNAPSHOT to 2.5.0-SNAPSHOT.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8865 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-14 10:30:53 +0000

a9a0b9e0 Partial fix for OPENDJ-898: Rename OpenDJ SDK 3.0 to 2.6 in order to align versi… ... Browse Code »

…ons across the product

* update project version to 2.5.0-SNAPSHOT (development version leading to 2.6.0).

git-svn-id: https://svn.forgerock.org/opendj/trunk@8864 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-14 09:50:18 +0000

e442edd3 Fixed a bug in the modify operation where values were not added correctly. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8863 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
glennvl
2013-05-14 09:09:18 +0000

b7c2106a OPENDJ-858 (CR-1680) Add stats tracking to HTTP client connections ... Browse Code »



Now monitoring total etime for each supported HTTP method.
While implementing this, I noticed that HTTPRequestInfo was duplicating fields in HTTPClientConnection and adding little more. I moved the missing data in HTTPRequestInfo to HTTPClientConnection and transformed the HTTPRequestInfo class into an interface to keep zero coupling between logging and HTTPClientConnection.



HTTPRequestInfo.java:
Transformed this class into an interface.
Renamed getRemoteHost() to getClientHost() and getRemoteAddress() to getClientAddress().

HTTPClientConnection.java
Now implements HTTPRequestInfo.
Moved several fields from HTTPRequestInfo here + added missing getters and setters.
In sendResponse(), calling HTTPStatistics.updateRequestMonitoringData().
Added log().

TextHTTPAccessLogPublisher.java:
Consequence of the changes to HTTPRequestInfo.
Also added support for the "c-port", "s-ip", "s-computername", and "s-port" fields.

CollectClientConnectionsFilter.java, SdkConnectionAdapter.java:
Consequence of the changes to HTTPRequestInfo.

HTTPStatistics.java:
Renamed instance members nbRequests to requestMethodsTotalCount and nbRequestsTotalCount to requestsTotalCount.
Added requestMethodsTotalTime instance member.
Completed the constructor, clearStatistics(), getMonitorData().
Fixed clearStatistics().
Added addAll(), updateRequestMonitoringData().

02-config.ldif:
Added attributes for monitoring the total etime of HTTP requests.
Renumbered some previously added attributes to follow what is done for LDAP operations etime.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8862 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-14 07:13:05 +0000

13 May, 2013

3 commits

d88522a6 Fixed embedded test cases (buildinfo added) ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8861 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-05-13 15:42:28 +0000

6eae0cb5 AttrHistoricalSingle.java: ... Browse Code »

In getValuesHistorical(), simplified the code by removing useless generics.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8860 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-13 13:07:52 +0000

a191cd8c OPENDJ-858 (CR-1651) Add stats tracking to HTTP client connections ... Browse Code »

Added support for monitoring statistics of the HTTP connection handler:
It monitors: total number of requests, and number of delete, get, patch, post and put requests.
It also monitors the internal LDAP operations to display how the server is performing.


HTTPConnectionHandler.java, HTTPClientConnection.java, CollectClientConnectionsFilter.java, SdkConnectionAdapter.java:
Added support for statistics.

config.ldif, HTTPConnectionHandlerConfiguration.xml, HTTPConnectionHandlerCfgDefn.properties:
Added "keep-stats" property.

02-config.ldif:
Added attributes "ds-mon-http-*" for monitoring HTTP statistics.

LDAPStatistics.java:
Changed getMonitorData() return type to List.
Made createAttribute protected.

HTTPStatsProbe.java, HTTPStatistics.java: ADDED


git-svn-id: https://svn.forgerock.org/opendj/trunk@8859 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-05-13 12:35:26 +0000