org.forgerock / org.forgerock.opendj

26 Aug, 2013

3 commits

2d1082dd Trivial fix - closing streams with StaticUtils ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9456 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-08-26 12:09:43 +0000

10beaa4d OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Dir »

Introduced interfaces ChangelogDB and ChangelogDBIterator to remove direct dependencies to org.opends.server.replication.server.changelog.je .
The interfaces remain similar to the old classes DraftCNDbHandler and DraftCNDbIterator, but:
- I plan to introduce more changes to rework a bit these interfaces
- They reduce the number of accessible methods for client code


ChangelogDB.java: ADDED
Renamed getValue() to getPreviousCookie().

ChangelogDBIterator.java: ADDED
Renamed releaseCursor() to close().


*.java:
Consequence of the use of the new interfaces.
Renamed instance variables, local variables and method parameters to accommodate the new classes.
Also renamed variables and methods to better explicit their role.	
Also reworked javadocs and comments.


ReplicationServer.java:
Extracted method contains().
In getEligibleCN(), reworked the code to avoid computing debug information if debug is off.
Renamed local variables.
Removed useless comments.

DraftCNDB.java:
Removed unused instance member ReplicationServer.

DraftCNDbHandler.java:
Now implements ChangelogDB.
Consequence of change to DraftCNDB.
Extracted method debugException().
Removed releaseReadCursor() (Replaced by StaticUtils.close()).

DraftCNDbIterator.java:
Now implements ChangelogDBIterator.

TestCaseUtils.java:
In deleteDirectory(), added a null check and an exists check.

DbHandlerTest.java, DraftCNDbHandlerTest.java:
Extracted method createCleanDir().
Removed now useless checks before calling TestCaseUtils.deleteDirectory().
Called StaticUtils.close().
Extracted method assertIteratorReadsInOrder().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9455 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-26 08:41:18 +0000

046b7ab1 Fixed minor '%changelog not in descending chronological order' introduced with 9440. ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9454 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-08-26 07:41:58 +0000

23 Aug, 2013

5 commits

5cd8b6ce ReplicationServerTest.java: ... Browse Dir »

Removed test on number of entries returned:
Eclipse gives me 33, command line run gives me 34, while Jenkins run gives me 32!!!
What a deterministic test!

git-svn-id: https://svn.forgerock.org/opendj/trunk@9453 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-23 15:27:18 +0000

056bac99 ReplicationBackend.java: ... Browse Dir »

Fixed a bug introduced in r9449.

ReplicationServerTest.java:
Extracted several methods to simplify this test.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9452 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-23 14:54:04 +0000

0549775a Small cleanup of use of maps, lists. Forgot to commit these changes with the previous commit ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9451 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-08-23 14:13:10 +0000

14f46463 Small cleanup of use of maps, lists and also few typos in comments, and constants in the QuickSetup. ... Browse Dir »

Side effect of renaming a constant, the ReplicationCliMain was touched, and I run more cleanup on it.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9450 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-23 13:25:33 +0000

86f9e985 Fixed the duplicate attribute values returned by "dc=replicationchanges". ... Browse Dir »


ReplicationBackend.java:
Removed useless setBaseDNs().
In exportRootChanges(), used Collections.singletonList() + Rearranged the code to make it more explicit and reduce duplication.
Renamed processContainer() to writeChangesAfterChangeNumber() + changed signature.
Renamed processChange() to writeChange() + changed signature + removed calling Operation.setInternalOperation().
Extracted methods extractChangeNumber(), canContinue(),  addAttribute(), createBackupManager(),  getBackendDir().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9449 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-23 12:43:38 +0000

22 Aug, 2013

10 commits

0c8e47d2 Fixed checkstyle error. ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9448 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-08-22 14:34:43 +0000
fd37d423 OPENDJ-1114 Improve the debian package ... Browse Dir »
```
- Changelog added

git-svn-id: https://svn.forgerock.org/opendj/trunk@9447 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-08-22 14:27:57 +0000

1df2b43b ReplicationIterator.java: ... Browse Dir »

Renamed releaseCursor() to close().
Now extends Closeable.

*.java:
Consequence of the change to ReplicationIterator.

MessageHandler.java:
Removed releaseAllIterators() in favour of StaticUtils.close().

ReplicationBackend.java:
In getEntry(), used early exit.
Used StaticUtils.close().
Removed useless comments / code.
Used interfaces rather than concrete classes.
Extracted methods computeDN() and writeChangeRecord().

ReplicationServerDomain.java:
Removed sleep() replaced with StaticUtils.sleep().

StaticUtils.java:
Made close(Collection) more generic + now log exceptions happening when closing.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9446 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-22 14:13:20 +0000

b857c9ad Since jabx and xjc are now part of JDK (starting with 1.6), we no longer need th… ... Browse Dir »

…e jars nor the ant task.
Building directly with xjc is preferred and this also makes the war file lighter.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9445 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-22 12:08:26 +0000

43716721 Fixed checkstyle. ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9444 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-08-22 10:20:08 +0000

e59db0a3 ReplicationServerHandler.java: ... Browse Dir »

Fixed broken early exit.

ServerHandler.java:
Collapsed comments on one less lines.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9443 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-22 10:15:50 +0000

a0afa6a3 Code cleanup. ... Browse Dir »

Removed useless duplicated javadocs for getMonitorData.


ServerHandler.java:
Extracted method releaseDomainLock().
Replaced lockDomain(boolean) with lockDomainNoTimeout() and lockDomainWithTimeout().
Removed duplicate code from MessageHandler.
Moved shuttingDown() to ServerHandler.

DataServerHandler.java, ECLServerHandler.java:
Consequence of the change to ServerHandler.

MessageHandler.java:
Moved shuttingDown() here from ServerHandler.

ReplicationServerHandler.java
Consequence of the change to ServerHandler.
In checkGenerationId(), used early exit.
Extracted method clearRemoteLSHandlers().
In processTopoInfoFromRS(), inlined local variables.
In hasRemoteLDAPServers() and getConnectedDirectoryServerIds(), removed useless and misleading synchronized blocks.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9442 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-22 09:52:28 +0000

08d87d45 OPENDJ-1114 Improve the debian package ... Browse Dir »
```
Removed unused file

git-svn-id: https://svn.forgerock.org/opendj/trunk@9441 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-08-22 09:38:23 +0000

a692efb0 OPENDJ-1114 Improve the debian package ... Browse Dir »

- Original data are copied under build/deb/ folder as the process to build the deb package implies to modify the source.
 - Opendj init script has been modified. Indeed, under debian OS (and others) the /var/run/ folder is deleted at reboot, deleting by the same way our pid  file, making the service wobbly.
 - As linux distro use the same opendj file, a new folder was created under resource to store the shared file between them.
 - At last, modified post/prem/specFile as well as the fact to create a symlink on an existing one throws an error. (same when you try to remove one from no-existing)

git-svn-id: https://svn.forgerock.org/opendj/trunk@9440 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-22 09:38:01 +0000

922f6013 Increased code expressiveness. ... Browse Dir »

Code cleanup.


MonitoringPublisher.java:
Removed one call to a setter.

ReplicationDomainMonitor.java:
Renamed computeDomainMonitorData() to recomputeMonitorData().

ReplicationServerDomain.java:
Renamed replyWithMonitorMsg() to replyWithTopologyMonitorMsg().

ReplicationDomainTest.java:
Extracted methods createReplicationServer(), assertExpectedServerStatuses(), disable(), remove().
Replaced assertTrue() with assertEquals().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9439 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-22 08:13:06 +0000

21 Aug, 2013

6 commits

d7af31ca ReplicationServerDomain.java: ... Browse Dir »

Fixed test break introduced in r9436.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9438 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-21 16:42:41 +0000

7fd9b97e Renamed MonitorData.java to ReplicationDomainMonitorData.java ... Browse Dir »

Renamed fmd field to firstMissingDates.
Obeyed java naming conventions.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9437 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-21 14:12:26 +0000

3bf678b6 Extracted ReplicationDomainMonitor class out of ReplicationServerDomain to increase its cohesion. ... Browse Dir »


ReplicationDomainMonitor.java: ADDED
Extracted from ReplicationServerDomain.

ReplicationServerDomain.java:
Moved all the code managing the MonitorData to ReplicationDomainMonitor + added domainMonitor instance member.
In createGlobalTopologyMonitorMsg(), removed the MonitorData parameter.
Renamed mayResetGenerationId() to resetGenerationIdIfPossible().
Extracted methods setGenerationIdIfUnset() and getMessage().
In getConnectedDSs() and getConnectedRSs() returned unmodifiable maps.

MonitoringPublisher.java:
Renamed instance member replicationServerDomain to domain.
Consequences of the changes to ReplicationServerDomain.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9436 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-21 13:26:47 +0000

c8e3b95d OPENDJ-1099 control-panel can not connect to remote server unless a local OpenDJ… ... Browse Dir »
```
… instance is configured
- buildinfo is not verified if remote  is detected.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9435 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-08-21 12:36:18 +0000

70ea1efd Increased encapsulation in ReplicationServerDomain by: ... Browse Dir »

- Making private the start*() methods
- Moved some code to here from some other classes
- MAking private the buildAndSendTopoInfoTo*() methods.

ReplicationServerDomain.java:
Extracted method sendTopoInfoToAllExcept().
Renamed buildAndSendTopoInfoToDSs() to sendTopoInfoToAllDSsExcept() + made it private.
Renamed buildAndSendTopoInfoToRSs() to sendTopoInfoToAllRSs() + made it private.
Renamed changeStatusFromStatusAnalyzer() to changeStatus().
Made startStatusAnalyzer() and startMonitoringPublisher() private.
Directly used the fields connectedDSs and connectedRSs instead of through their getters.
Moved 2 register() methods here from DataServerHandler and ReplicationServerHandler.
Renamed all variables and parameters named "handler" to disambiguated names.

DataServerHandler.java:
Renamed changeStatusFromStatusAnalyzer() to changeStatus().
Moved registerIntoDomain() + some other code to ReplicationServerDomain.

ReplicationServerHandler.java:
Moved registerIntoDomain() + some other code to ReplicationServerDomain.

ReplicationServer.java
Renamed all variables and parameters named "handler" to disambiguated names.
Consequence of the change to ReplicationServerDomain.sendTopoInfoToAllExcept().

StatusAnalyzer.java:
Consequence of the change to ReplicationServerDomain.changeStatusFromStatusAnalyzer().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9434 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-21 08:33:59 +0000

65f89b4e Partial fix for OPENDJ-1114 Improve the DEB package ... Browse Dir »

- copyright added
- doc section added (to complete)


git-svn-id: https://svn.forgerock.org/opendj/trunk@9433 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-21 07:47:45 +0000

20 Aug, 2013

5 commits

c64558ad LDAPReplicationDomain.java: ... Browse Dir »

Fixed off-by-one error.

FractionalReplicationTest.java:
Removed try / catch / fail test anti pattern.
Removed useless comments.
Extracted method waitTillEntryHasSynchroAttribute().
Made attributes private.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9432 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-20 15:19:28 +0000

5f037f31 ReplicationMonitor.java: ... Browse Dir »

Used interfaces instead of concrete classes.
Removed useless comments.
Extracted method addMonitorData().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9431 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-20 13:41:49 +0000

4de1199a Entry.java: ... Browse Dir »

Extracted methods newMapIfNull(), getUserOrOperationalAttributes(), getAttributes(), putAttributes(), removeAttributes(), addAllIfNotNull(), onlyKeepAttributesWithAllOptions(), getAttribute(), onlyKeepAttributesWithAllOptions(), addObjectClass(), hasObjectClassOrAttribute(), hasObjectClass(), containsObjectClassByName(), hashCode(), equals(), appendAttributes(), newList().
Comments to javadoc.
Used interfaces instead of concrete classes.
Collapsed if statements.
Put code on one line where possible.

LDAPReplicationDomain.java:
Extracted methods isSolveConflict(), needReconnection(), findReplicationSearchResultEntry(), isMandatoryAttribute(), isFractionalProhibited(AttributeType), canRemoveAttribute(), contains(), runAsSynchronizedOperation().
Removed useless else.
Used interfaces instead of concrete classes.
Put code on one line where possible.
Removed useless comments.
Simplified code in several places.
Collapsed if statements.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9430 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-20 13:22:22 +0000

0c48cb0f Fix nightly tests failure within these tests. ... Browse Dir »

It was due to a side effect of the last commit as well as several locations where cleanup wasn't properly done after a test.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9429 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-20 13:05:53 +0000

faa9db49 Partial fix for OPENDJ-1031 (DEB part) ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9428 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-08-20 08:58:21 +0000

19 Aug, 2013

5 commits

b9bcd548 Simplify via refactoring the processing within LDAPReplicationDomain's synchroni… ... Browse Dir »
```
…ze(PostOperationOperation op) method. 
Reviewed by JN, CR-2193.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9427 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-08-19 16:02:07 +0000

821e6c72 Code cleanup. ... Browse Dir »

RSInfo.java, DSInfo.java:
Made them (almost) immutable classes.

LightweightServerHandler.java:
Replaced many instance members with just one DSInfo instance member.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9426 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-19 14:18:10 +0000

bdeecc59 - Fix STAX exception in replication/externalchangelog_consistency tests due to u… ... Browse Dir »

…nknown function paramter
- Added README to explain how to start the STAF daemon and run the tests



git-svn-id: https://svn.forgerock.org/opendj/trunk@9425 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-19 14:16:00 +0000

ccbdfce4 Avoided possible costly thread leaks in ReplicationServerDomain. ... Browse Dir »



ReplicationServerDomain.java:
Used AtomicReference for statusAnalyzer and monitoringPublisher.
As a consequence:
- Changed update*(), start*() and stop*() methods.
- Removed isRunning*() methods.

MonitoringPublisher.java:
Extracted getMessage() to make error messages more conherent.

ServerReader.java:
In run(), removed redundant code by checking whether the message is a RoutableMsg.
Extracted method logException().
In ServerReader.run(), moved some code to ServerHandler.put().
Code cleanups:
- inlined useless local variables
- removed useless use of "this" before method calls.

DataServerHandler.java, ECLServerHandler.java, ReplicationServerHandler.java:
Extracted method createReplServerStartMsg().

ServerHandler.java:
Renamed process(WindowProbeMsg) to replyToWindowProbe().
Made some instance members private.
Moved createReplServerStartMsg here.
In put(), moved decAndCheckWindow() call here from ServerReader.run().

WindowProbeMsg.java:
Fixed javadocs + simplified code.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9424 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-19 13:27:40 +0000

50d9c0b5 Enforced ReplicationServerDomain responsibilities by increasing encapsulation. ... Browse Dir »


ReplicationServer.java:
Added getConnectedRSUrls(), that aggregates code from ReplicationServerDomain.getChangelogs() and from runConnect().
In applyConfigurationChange(), moved code to ReplicationServerDomain for better encapsulation.

ReplicationServerDomain.java:
Renamed checkForDuplicateDS() into isAlreadyConnectedToDS().
Renamed checkForDuplicateRS() into isAlreadyConnectedToRS().
Moved getChangelogs() to ReplicationServer.
Made several methods private to reduce coupling and enforce class responsibilities.
Generalized the use of isRunningStatusAnalyzer() and isRunningMonitoringPublisher() to improved readability.
Inlined updateStatusAnalyzer() and updateMonitoringPublisher().
Moved code from ... to create updateDegradedStatusThreshold() and updateMonitoringPeriod().
In stopReplicationServers(), renamed parameter for increased readability.

DataServerHandler.java:
Inlined createStatusAnalyzer().

ServerHandler.java, ReplicationServerHandler.java:
Inlined createMonitoringPublisher().
In lockDomain(), removed useless else.
Code cleanup.

StatusAnalyzer.java:
Extracted isInterrupted().
Extracted getMessage() to make error messages more conherent.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9423 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-19 10:32:47 +0000

14 Aug, 2013

5 commits

6947eea3 ReplicationServerDomain.java ... Browse Dir »

Renamed directoryServers to connectedDSs.
Renamed replicationServers to connectedRSs.
Removed the useless getConnectedLDAPservers(), replaced with getConnectedDSs().
Renamed a few local variables.

DataServerHandler.java:
Consequence of removing to ReplicationServerDomain.getConnectedLDAPservers()
Extracted method changeStatus() from changeStatusFromStatusAnalyzer() and changeStatusForResetGenId().
Extracted method getStatusMachineEvent() from changeStatusForResetGenId().

InitOnLineTest.java
Consequence of removing to ReplicationServerDomain.getConnectedLDAPservers().
Removed useless try / catch / fail.
Extracted methods getCompletionTime(), assertAttributeValue().
Used Assertions.assertThat().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9418 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-14 14:22:52 +0000

ca7e1746 - Added known issue OPENDJ-1051 in replication/externalchangelog_consistency tests (Upgrade mode) ... Browse Dir »
```
- Updated i18n/datacomparison reference file
 


git-svn-id: https://svn.forgerock.org/opendj/trunk@9417 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-08-14 13:08:43 +0000

d53a5808 ChangeNumber.java: ... Browse Dir »

In the ctor, renamed parameters.
In other methods, used early exit.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9416 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-14 11:15:32 +0000

dc7c17c6 OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Dir »

Removed ReplicationServerDomain.getReplicationServer() to follow the Law of Demeter: "Only talk to your immediate friends." to promote loose coupling.
Changed approxFirstMissingDate from Long object to long primitive.


ReplicationServerDomain.java:
Removed getReplicationServer().
Added getLocalRSMonitorInstanceName() and getLocalRSServerId().

*.java:
Used the newly added ReplicationServerDomain.getLocalRSMonitorInstanceName() and ReplicationServerDomain.getLocalRSServerId().

LightweightServerHandler.java:
Removed getLocalRSMonitorInstanceName().


MonitorMsg.java, MonitorData.java:
Changed firstMissingDate from Long object to long primitive.
Used StringBuilder in toString().

SynchronizationMsgTest.java
Changed approxFirstMissingDate from Long object to long primitive.
Extracted methods newList(), newSet(), getEntryAttributes(), assertAttributesEqual().
Used assertEquals() instead of assertTrue().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9415 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-14 11:14:13 +0000

29ad2aa6 OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Dir »

Removed avoidable references to replicationServerDomain.getReplicationServer().
Code cleanups:
- collapsed if statements
- applied early exits
- Replaced useless use of StringBulders with string concatenations
- Removed useless parentheses


*ServerHandler.java:
Replaced calls to this.replicationServerDomain.getReplicationServer() with directly using this.replicationServer .

DataServerHandler.java:
Inlined local variables.
Removed useless catch.

ECLServerHandler.java:
Extracted method releaseIterator().

LightweightServerHandler.java:
Extracted method getLocalRSMonitorInstanceName().

ReplicationServerHandler.java
In isRemoteLDAPServer(), renamed parameter.


MessageHandler.java:
Extracted methods collectAllIteratorsWithChanges(), addIteratorIfNotEmpty(), releaseAllIterators().

ReplicationServerDomain.java
Renamed replicationServer to localReplicationServer.
In put(), renamed id to serverId + extracted method publishMessage().
In getChangelogIterator(), renamed parameter.
Extracted methods replyWithMonitorMsg(), replyWithUnroutableMsgType(), forwardMsgToAllServers(), replyWithUnreachablePeerMsg() from process().
Renamed stopDbHandlers() to shutdownDbHandlers().
Extracted isServerConnected() from getEligibleCN().



DbHandler.java, JEReplicationIterator.java:
Renamed parameter.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9414 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-14 09:30:53 +0000

13 Aug, 2013

1 commit

b1466a91 Fix checkstyle ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9413 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-08-13 16:28:31 +0000