org.forgerock / org.forgerock.opendj

21 Jun, 2013

1 commit

20 Jun, 2013

4 commits

19 Jun, 2013

1 commit

  • 5529b20a   Fix OPENDJ-986: Exception when reading messages from Replication server RS ... Browse Dir » 
    * make protocol versioning the responsibility of the ProtocolSession object. Previously, it was split between various classes making it very confusing and risk-prone. Now only one class (TLSSocketSession) "owns" the protocol version
* removed ReplicationMsg.getBytes() and require that all message impls implement ReplicationMsg.getBytes(short protocolVersion). Messages which have never evolved since the first protocol version can simply ignore the passed in protocol version parameter
* simplified the handshake process, ensuring that we always set the protocol version once the handshake has completed. Part of this change was to remove the protocol version from the start message constructors, since it is implied during encoding (this removes some ambiguity in these classes)
* many other minor code clean ups and bug fixes.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9009 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     

18 Jun, 2013

1 commit

17 Jun, 2013

1 commit

14 Jun, 2013

1 commit

  • 1416fbc5   OPENDJ-960 (CR-1844) HTTP Connection Handler - Validate http-config.json file ... Browse Dir » 
    Enhanced JsonValue by adding a record/verify mode for key accesses.
Client code must call recordKeyAccesses() to verifyAllKeysAccessed().
When yhere is an an unaccessed key, a JsonException will be thrown and all unaccessed keys will be reported (unaccessed keys located under other unaccessed keys are not reported to reduce noise).


HTTPConnectionHandler.java:
In createAndRegisterServlet(), enabled the record mode before accessing the keys, then verify all the keys have been accessed after we are done with the JSON config.

JsonValue.java:
Added recordKeyAccesses() and verifyAllKeysAccessed().

JsonValueKeyAccessChecker.java, JsonValueKeyAccessCheckerTest.java: ADDED


git-svn-id: https://svn.forgerock.org/opendj/trunk@8994 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

13 Jun, 2013

1 commit

12 Jun, 2013

1 commit

11 Jun, 2013

3 commits

10 Jun, 2013

2 commits

07 Jun, 2013

3 commits

  • 8dba2078   Fix for OPENDJ-925, OPENDJ-926, and overall schema management. Review CR-1806. ... Browse Dir » 
    Back a few years ago, when we did the SVR4 package, we split the schema into read-only (Install) and writable (Instance).
With the template model in 2.6, the whole schema is under config, and we should never edit/change the one in the template.
So, I've removed all code related to the 2 locations for schema, reverted some I10N messages to their previous versions, and tidy up code and tests.
All unit-tests are passing.
And it's also possible to change the instance.loc and run setup and have a fully functioning server :-)

git-svn-id: https://svn.forgerock.org/opendj/trunk@8978 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ludo
     
  • b28e242c   Partial fix for OPENDJ-951: Reduce size and frequency of replication MonitorMsg ... Browse Dir » 
    * use single TCP packet where possible for replication messages
* reduce frequency of socket reads.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8977 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • 446576f8   CR-1804 OPENDJ-931 OpenDJ QuickSetup should display the license ... Browse Dir » 
    The jnlp / webstart is now able to display the license if it is present and to validate it.

Additional fix : The font is now set to UIFactory.TEXTFIELD_FONT for the license panel. (fix windows OS trivial graphical bug)

git-svn-id: https://svn.forgerock.org/opendj/trunk@8975 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     

06 Jun, 2013

1 commit

05 Jun, 2013

4 commits

04 Jun, 2013

2 commits

  • 50f64155   Fix unit test regression introduced in previous fix for OPENDJ-866 (Local RS is named differently). ... Browse Dir » 
    This commit addresses the InternalSearchMonitorTestCase unit test regression introduced by my previous fix for OPENDJ-866. 

Monitor provider instance names are required to be stable so that deregistration attempts succeed. This is not the case for many of our replication monitors which include mutable components such as host addresses or connected RS identifiers (as a parent RDN). Before my fix for OPENDJ-866 these "mutating" monitors took care to re-register themselves whenever they detected that the name was about to change. Unfortunately my fix for OPENDJ-866 made the names of local replica monitors mutable as well by including the local address. The side effect was that the monitor providers would sometimes not be deregistered which was causing the org.opends.server.monitors.InternalSearchMonitorTestCase unit test to fail. 

This fix modifies the replication domain monitor provider so that it re-registers itself whenever it senses a potential name change (i.e. connection establishment). The change was not as simple as I hoped because many unit tests create replication brokers with null replication domains. 

I've refactored the code a little and pushed ownership of the monitor provider into the broker in order to make its lifecycle clearer.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8963 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • eb70c476   Initial work for re-opened OPENDJ-866: Local RS is named differently to remote RS under. ... Browse Dir » 
    Align signature of DirectoryServer.deregisterMonitorProvider with registerMonitorProvider and avoid lots of boilerplate name normalization.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8958 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     

03 Jun, 2013

3 commits

  • 8b650fac   Minor fix on Upgrade's log file. ... Browse Dir » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8955 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     
  • 8568ea8a   Fix OPENDJ-866 Local RS is named differently to remote RS under cn=replication,cn=monitor ... Browse Dir » 
    * add host:port information to each replication node monitoring entry
* make replication monitor entry naming more consistent
* bump the protocol version in order to support including the remote server URL in DSInfo/TopologyMsg.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8953 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • 55980394   CR-1777-OPENDJ - Upgrade code cleanup ... Browse Dir » 
    - The upgrade context is now set in the CLI.
- The upgrade context contains now the callback handler
which simplify all the function (removed all calls to callbackhandler, functions just need the context at this point).
- The context contains the CLI user selected options
which simplify the code, removed the CheckCLIUserOption, the task have just to check the context for those parameters.
- Removed the useless VerificationCallback.java
- Added a TaskType in UpgradeTask.java.
- Added function verifyTaskType in UpgradeTasks.java which verify user selected options are correct.
- Modified tools.properties message numbers

git-svn-id: https://svn.forgerock.org/opendj/trunk@8951 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     

31 May, 2013

2 commits

  • b640a1e8   Fix for OPENDJ-875: Use of hostnames in replication protocol causes failover problems ... Browse Dir » 
    * Set the RS URL by first checking the list of configured replication servers to see if any correspond to the local host / port. If a match is found then it is used, otherwise we fall back to the old mechanism which was to perform a name lookup of /etc/hostname.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8950 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • c68d69ef   Additional fix for OPENDJ-875: Use of hostnames in replication protocol causes failover problems ... Browse Dir » 
    * fix unit test regression introduced by previous commit. RS candidate filtering was too aggressive and assumed that there would only be one RS per JVM, which is not the case in the unit tests

* also use a thread safe set implementation for the local RS ports in order to avoid potential race conditions in unit tests (this may be the cause of occasional RS load balancing unit test failures).



git-svn-id: https://svn.forgerock.org/opendj/trunk@8948 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     

30 May, 2013

3 commits

  • 53979be5   Partial fix for OPENDJ-875: Use of hostnames in replication protocol causes failover problems ... Browse Dir » 
    This partial fix addresses the first two bugs described in the issue comments, specifically:

* the logic (ReplicationBroker#filterServersInSameVM) which chooses the best RS does not prefer RS which are on the same host, only those which are in the same VM. In addition, the logic in ReplicationServer#isLocalReplicationServerPort assumes that the local host name is the same address which the RS is listening on

* the method ReplicationBroker#isSameReplicationServerUrl contains a typo which causes the second url to be interpreted as the local host name if the first url is a local address. This triggers all kinds of strange side effects during RS fail-over.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8946 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • 5631cabd   OPENDJ-930 setup in non-interactive mode should not accept automatically the license ... Browse Dir » 
    - added --acceptLicense to the setup command line options.
- modified code for checking the license during the setup :
	- using the no-prompt option no longer bypass the license if presents.
	- displays now the license text, question and answer(yes) when used with the --acceptLicense.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8943 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     
  • 076e23b6   Fix logging typo ... Browse Dir » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8942 41b1ffd8-f28e-4786-ab96-9950f0a78031
    cjr
     

29 May, 2013

2 commits

28 May, 2013

1 commit

27 May, 2013

3 commits