13 Dec, 2013

1 commit

  • 
    Most of the replace was done by global search replace from Eclipse via regular expressions.
    Individual files had incorrect headers or badly formatted ones, so some of them have been done manually by replacing the content between CDDL HEADER START and CDDL HEADER END.
    Some headers were quoting "trunk/opends/resource/legal-notices/CDDLv1_0.txt" while it should have been "legal-notices/CDDLv1_0.txt".
    
    
    Removed:
    - resource/legal-notices/OpenDS.LICENSE
    
    The following required manual changes:
    - build.xml
    - ext/checkstyle/opendj.sourceheader
    - resource/admin/java-utilities.xsl
    - src/build-tools/org/opends/build/tools/ProcessFilesForPackages.java
    - src/build-tools/windows/*
    - src/pkg/opends-dsml-gateway_proto.py
    - src/pkg/opends_proto.py
    - src/server/org/opends/server/util/ServerConstants.java
    - tests/staf-tests/functional-tests/shared/data/aci/aci_targattrfilter/add_aci18.ldif
    - tests/staf-tests/build.bat
    
    An incorrect header mentionning "exclude" instead of "include" in the copyright header existed for: tests/staf-tests/functional-tests/testcases/backends/backup/**/*
    
    Some files have no copyright headers at all. I did not update them. Here is some of them (more exist):
    - tests/staf-tests/functional-tests/shared/data/core/psearch/**/*.ref
    - tests/staf-tests/functional-tests/shared/data/core/psearch/**/delete.ldif
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9984 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

18 Jun, 2013

1 commit


08 Apr, 2013

1 commit

  • Resolve race condition in Windows Services when stopping the server.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8705 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ludo
     

02 Nov, 2011

1 commit


20 Oct, 2011

1 commit


19 May, 2011

1 commit


30 Sep, 2010

1 commit


27 May, 2010

1 commit

  • The fix consists on waiting in the service code to the start-ds.bat call to finish (the re-entrant one). This avoids having a race condition problem locking the file (as can happen today).
    There is a new environment variable that can be configured (OPENDS_WINDOWS_SERVICE_STARTDS_WAIT). The default value is 300000 milliseconds (5 minutes). This is the maximum time in milliseconds the service code will wait for the server to start before checking directly its status.
    Also update setup.bat and uninstall.bat to return an error code when called in CLI mode.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@6408 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ludovicp
     

18 Jan, 2010

1 commit

  • Improve the code of windows service to poll the status of the server (whether is running or not).
    Improve some of the messages associated with the events that are sent to the windows service log.
    Improve the code that is in charge of starting the service (and the server) to help identify cases where the server startup is correctly launched but the startup itself fails (because for instance a port of the server is already in use).
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@6356 41b1ffd8-f28e-4786-ab96-9950f0a78031
    jvergara
     

16 Jan, 2009

1 commit


11 Nov, 2008

1 commit


07 Nov, 2008

1 commit

  • …ing it configurable).
    
    The fix increases the number of tries used to figure out if the server is started or not.  This is required in particular after reboot since the system can be really loaded.
    
    The user can modify the default tries value (100 tries with an interval of 5 seconds between tries) by setting the value of the OPENDS_WINDOWS_SERVICE_START_NTRIES  environment variable (it must be a SYSTEM environment variable in order to be taken into account).
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@4592 41b1ffd8-f28e-4786-ab96-9950f0a78031
    jvergara
     

05 Jul, 2008

1 commit


12 Feb, 2008

1 commit


18 Jul, 2007

1 commit

  • With the new user access control of Vista, even if we are administrators we are not allowed to do certain operations (such as writing in the service registry) in some circumstances.  For instance if we launch net start <service_name> from a normal command prompt this will fail systematically.  In order to be able to execute these "privileged" operations we have different alternatives:
    
    Execute the binary that will do the operations using the "Run as Administrator" option in Vista (or launching them from a command prompt that has been started using that same option).
    Add a manifest to the binary informing that the binary requires administrator privileges.
    
    The first alternative is one of the workarounds for the bug, however it does not apply to the case of the Java Web Start Installer.
    
    The second alternative is in what consists the bug fix.  A new binary has been created.  This binary has a manifest informing that it requires administrator privileges.  This binary will be used in Vista as a wrapper to call operations that require administrator privileges (modifying the registry in windows-services.bat command line and calling "net start" and "net stop").  
    
    If the user is running the setup, the status-panel using the "Run as Administrator" option or is using the command lines from a command prompt launched with that option the behavior in Vista does not change with the behavior in previous versions of Windows.
    
    If the UAC is enabled and the user is not using the "Run as Administrator" options, (s)he will be prompted for confirmation each time the registry is modified and the server is started or stopped as a service.  The wrapper is called on any of the individual operations.  An alternative would be to call the wrapper when we launch the setup or the status-panel but this generates some issues:
    1. This does not work (directly) with the Java Web Start installer.
    2. This would force users that are not administrators to provide administrator credentials even to install/run an OpenDS that does not require to do privileged operations (an OpenDS that does not run as a service).
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@2428 41b1ffd8-f28e-4786-ab96-9950f0a78031
    jvergara
     

08 May, 2007

1 commit


07 May, 2007

2 commits

  • -    debug("Deleting the service '%s'.");
    +    debug("Deleting the service '%s'.", serviceName);
    
    Which was causing the process to core on uninstall.  So I went through the other debug messages, and made a few more changes that most likely wouldn't have caused problems.  For instance,
    
    -      debug("doStartApplication: spawn failed.  Sent command:");
    -      debug(command);
    +      debug("doStartApplication: spawn failed.  Sent command: '%s'", command);
    
    Technically, command could include a format directive (e.g. %s) in which case we'd have the same problem as debug("Deleting the service '%s'."), but this is unlikely.  There are also a few other debug messages that I added to track down the real problem, and I've left them in.
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@1833 41b1ffd8-f28e-4786-ab96-9950f0a78031
    davidely
     
  • …h stopping the server on Windows, and also adds a lot of debug logging to the service code, so we can track problems down in the future
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@1827 41b1ffd8-f28e-4786-ab96-9950f0a78031
    davidely
     

04 May, 2007

1 commit

  • 1. A char array was set to NULL wrongly which caused a core in the windows services code.  This problem appeared almost systematically when the install path was long.
    2. The windows services code got into an infinite loop when the server could not be started.
    3. The windows services code was missing to unlock a file after testing if it could lock it.
    4. Create specific loggers for Setup, Uninstall and StatusPanel applications.  This avoids having duplicated and not very user friendly log lines on the output of these applications.
    5. When we cannot launch the graphical applications store the stack trace we get in the log file associated with the application and inform the user about the existence of this file in the same message where we tell that we are falling back to the CLI mode.
    6. Fix a refresh problem in the status panel.  Now when the number of entries of the database increase the contents of the panel are automatically updated.
    7. Modify the name of the Age of Oldest Missing Changes as mentioned by Brian.
    8. Redirect some logging/debugging lines of the windows services to a file called windows-service in the logs directory.
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@1821 41b1ffd8-f28e-4786-ab96-9950f0a78031
    jvergara
     

26 Apr, 2007

1 commit


24 Apr, 2007

1 commit

  • - Narrow down the set of packages that external developers will need to access
      in order to write a plugin or other type of extension.  Hopefully, for most
      things developers will only need to interact with the following packages (and
      their sub-packages):
      * org.opends.server.admin
      * org.opends.server.api
      * org.opends.server.config
      * org.opends.server.protocols.internal
      * org.opends.server.types
      * org.opends.server.util
    
    - As part of the attempted narrowing of packages that external developers need
      to access, I have moved the org.opends.server.core.Operation and
      org.opends.server.protocols.ldap.LDAPException classes to the
      org.opends.server.types package.  I have also created
      org.opends.server.types.RawAttribute to wrap the
      org.opends.server.protocols.ldap.LDAPAttribute class, and
      org.opends.server.types.RawModification to wrap the
      org.opends.server.protocols.ldap.LDAPModification class.
    
    - I have updated the internal operations API to add a few new convenience
      methods when performing internal operations.
    
    - I have updated all of our message strings so that none of them end in periods
      (except those that end with an ellipsis).  This will help us avoid the
      problem in which we see multiple periods due to embedding one message in
      another.
    
    - I have moved a message file from a synchronizaiton package to the messages
      package and resolved conflicts with existing message IDs.
    
    - I have updated a number of cases in which
      StaticUtils.stackTraceToSingleLineString() was used in client-facing code to
      replace those calls with StaticUtils.getExceptionMessage() instead.  This
      should provide a more user-friendly message that will hopefully not reduce
      our ability to debug problems that may arise.
    
    - I have cleaned up some of the code in the org.opends.server.api package so
      that all of the classes use consistent formatting, and to fix a couple of
      potential Javadoc problems.
    
    - I have moved the build-tools/src directory to src/build-tools to be more
      consistent with other components of the server.
    
    - I have updated the build script so that the xslt task will no longer dump
      lots of output to the terminal when generating code.  I have also gotten rid
      of warnings about run.classpath not being set properly.
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@1695 41b1ffd8-f28e-4786-ab96-9950f0a78031
    neil_a_wilson