org.forgerock / org.forgerock.opendj

25 Oct, 2013

3 commits

  • 482ed473   Fix OPENDJ-1191: Rare NPE in StaticUtils.isLocalAddress() ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9751 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • 62488b2d   Checkpoint commit for OPENDJ-175: Decouple OpenDJ LDAP SDK from Grizzly ... Browse Code » 
    Move all classes from org.forgerock.opendj.asn1 package to org.forgerock.opendj.io package in opendj-core


git-svn-id: https://svn.forgerock.org/opendj/trunk@9750 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     
  • 3e4febba   Checkpoint commit for OPENDJ-175: Decouple OpenDJ LDAP SDK from Grizzly ... Browse Code » 
    Move non-specific Grizzly code to opendj-core and refactor LDAPReader and LDAPWriter.

* Add new package org.forgerock.opendj.io in opendj-core for all IO related features
**  org.forgerock.opendj.asn1 classes to be moved in this io package in a future commit 

* Refactor LDAPReader class
** use an ASN1Reader as field instead of passing it as arg of each method
** rename methods to readXX
** add hasMessageAvailable method
** move to org.forgerock.opendj.io package in opendj-core

* Refactor LDAPWriter class
** use an ASN1Writer as field instead of passing it as arg of each method
** rename methods to writeXX
** remove implementation of LDAPMessageHandler
** move to org.forgerock.opendj.io package in opendj-core

* Adapt GrizzlyLDAPConnection, GrizzlyLDAPConnectionFactory, GrizzlyLDAPListener,
LDAPClientFilter and LDAPServerFilter classes to changes in LDAPReader and LDAPWriter
** caching of LDAPReader per connection
** caching of LDAPWriter per thread 
** new utility methods in GrizzlyUtils class to handle creation and recycling of LDAPReader and
LDAPWriter instances

* Refactor LDAPMessageHandler and AbstractLDAPMessageHandler classes
** remove user provided P parameter
** move to org.forgerock.opendj.ldap.spi package in opendj-core

* Move UnexpectedRequestException, UnexpectedResponseException and UnsupportedMessageexception classes
to org.forgerock.opendj.ldap.spi package in opendj-core

* Convert TimeoutChecker class to a generic timeout facility which is not tied to connections.
** new interface TimeoutEventListener to represent listeners on timeout event
** TimeoutChecker send callbacks to listeners instead of connections
** move to org.forgerock.opendj.ldap package in opendj-core

* Fix issues with TimeoutChecker and usage in GrizzlyLDAPConnection
** prevent negative delays
** wakeup of listeners only if timeout is > 0 

* Add test case support for LDAPReader/LDAPWriter in opendj-core and 
specific implementation of test case in opendj-grizzly


git-svn-id: https://svn.forgerock.org/opendj/trunk@9749 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     

23 Oct, 2013

2 commits

  • ebdc9786   OPENDJ-1144: Document recognized control names ... Browse Code » 
    Thanks to Chris Ridd for reviewing the patch I posted to the issue and letting me know by IM.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9747 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     
  • ac9a8c6f   LDAPReplicationDomain.java: ... Browse Code » 
    Replaced instance fields with directly storing and using the ReplicationDomainCfg object.

ReplicationBroker.java:
Replaced instance fields with directly storing and using the ReplicationDomainCfg object.
Removed start(Set<String>), setChangeTimeHeartbeatInterval() (now useless), and setGroupId() (never used).
Added getBaseDN(), getReplicationServerUrls(), getGroupId().
In several methods, used Map.entrySet() instead of Map.keySet() with Map.get(Object)  + renamed replicationServerInfo to rsInfo.

replication.properties:
Removed now unused message.


ReplicationDomain.java:
Replaced instance fields with directly storing and using the ReplicationDomainCfg object.
Code cleanups:
- Removed useless use of "this." for method calls.
- In processErrorMsg() and processUpdateDone(), collapsed if statements
- Increased vertical density
- Extracted method getGenId()
- In waitForAckIfAssuredEnabled(), used early exit.


DomainFakeCfg.java:
Comments => javadocs
baseDn => baseDN
Removed several unused methods.
Added setWindowSize() + instance member.

*Test*.java
Used the DomainFakeCfg everywhere + SortedSet instead of Set.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9746 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

21 Oct, 2013

1 commit

18 Oct, 2013

2 commits

  • a64b72d9   Fix OPENDJ-41: Expose LDAP Grizzly filter APIs ... Browse Code » 
    This a a part of OPENDJ-175 - Decouple OpenDJ LDAP SDK from Grizzly 
CR2491

* In GrizzlyLDAPListener and GrizzlyLDAPConnectionFactory classes :
 - Default filter chain used for processing is built from transport instead of building it from scratch.
 - Additional Grizzly filters can be provided by using transport argument passed to constructors (no change implied)
 - Additional Grizzly filters are added between Transport filter and LDAP filter
 
* Add a new utility class GrizzlyUtils that provides buildFilterChain and addFilterToConnection methods
   Use the utility class to factorize code to add a filter to the filter chain in LDAPServerFilter and GrizzlyLDAPConnection classes
  
* Add test case for the new GrizzlyUtils class

git-svn-id: https://svn.forgerock.org/opendj/trunk@9740 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     
  • 086fbb91   Fix OPENDJ-1180: "Connection Error" when trying to connect to a Tivoli Directory Server instance ... Browse Code » 
    * revert back to previous "(objectClass=*)" search filter to avoid interop issues.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9738 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     

17 Oct, 2013

7 commits

  • 135ae13b   OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code » 
    
ReplicationDbEnv.java, replication.properties:
In openDatabase(), fixed TODOs for i18n.
In newErrorMessage(), improved error logging by including the DB name.

JEChangelogDB.java:
Simplified the code by calling domainToReplicaDBs.remove() from inside shutdownReplicaDBs().
In shutdownReplicaDBs(), do not bother cleaning up the domainMap since it will be removed from domainToReplicaDBs.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9737 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 3c108d77   Fixed GenerationIdTest.generationIdTest(): test was failing precisely because th… ... Browse Code » 
    …e directory server's broker was not connected to a replication domain, hence it was impossible to add the changes to the changelogDB and then find them when querying the changelogDB.


GenerationIdTest.java:
Renamed assertConnectedToReplicationDomain() to waitConnectionToReplicationDomain().

LDAPReplicationDomain.java:
Removed uses of StringBuilder, relied on *Operation.toString() to do it for us.

ReplicationBroker.java:
Improved toString().

ReplicationTestCase.java:
Removed a wrong comment.
Used Assertions.assertThat().

ReplicationServerTest.java:
Removed a useless call to DirectoryServer.getSynchronizationProviders().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9736 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 17bdce54   GenerationIdTest.generationIdTest() test is not fixed, but I have now determined… ... Browse Code » 
    … that it is failing because the server is not connected to a replication domain, hence it is impossible to add the changes to the changelog.

GenerationIdTest.java:
Added assertConnectedToReplicationDomain() + called it.
Fixed a few logged strings.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9735 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 0c4a1089   Fix OPENDJ-701: Implement paged results support ... Browse Code » 
    * added support for paged results in rest2ldap.



git-svn-id: https://svn.forgerock.org/opendj/trunk@9734 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • 4bc0253a   Preliminary work for OPENDJ-701: Implement paged results support ... Browse Code » 
    * added support for page results in memory backend.
* unit test accidentally committed in previous commit.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9733 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • 1ea15fbf   Preliminary work for OPENDJ-701: Implement paged results support ... Browse Code » 
    * added ByteSequence.isEmpty().


git-svn-id: https://svn.forgerock.org/opendj/trunk@9732 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • 1f951778   ReplicationBroker.java: ... Browse Code » 
    In toString(), improved the returned String.
Changed rsServerId field from Integer to int.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9731 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

16 Oct, 2013

2 commits

15 Oct, 2013

4 commits

14 Oct, 2013

3 commits

12 Oct, 2013

1 commit

11 Oct, 2013

9 commits

  • 6759d9e2   Checkpoint commit for OPENDJ-175: Decouple OpenDJ LDAP SDK from Grizzly ... Browse Code » 
    * Adjust opendj-rest2ldap-servlet dependencies
  - Add dependency on opendj-grizzly jar in generated war 
  - No dependency on opendj-grizzly for use by another component

git-svn-id: https://svn.forgerock.org/opendj/trunk@9720 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     
  • a7b6a1d1   Trying to fix random failures for HistoricalTest.testRecurringPurgeIn1Run(). ... Browse Code » 
    
ReplicationTestCase.java:
In executeTask() and waitTaskState() added maxWaitTimeInMillis parameter.

HistoricalTest.java:
In testRecurringPurgeIn1Run(), added a sleep before configuring conflicts purge delay + waited purge for a maximum of 120 seconds (was approximatively 20 seconds before): as long as task max duration.

InitOnLineTest.java, ReplicationServerTest.java:
Consequence of the change to ReplicationTestCase.

GenerationIdTest.java:
Consequence of the change to ReplicationTestCase.
Extracted method createSetGenerationIdTask().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9719 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 5023f883   Checkpoint commit for OPENDJ-175: Decouple OpenDJ LDAP SDK from Grizzly ... Browse Code » 
    * Added dependency-reduced-pom.xml to svn:ignore property

git-svn-id: https://svn.forgerock.org/opendj/trunk@9715 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     
  • 75a27a1d   Checkpoint commit for OPENDJ-175: Decouple OpenDJ LDAP SDK from Grizzly ... Browse Code » 
    * Removed dependency-reduced-pom.xml as it is a file generated by the build

git-svn-id: https://svn.forgerock.org/opendj/trunk@9714 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     
  • fc0580d6   Checkpoint commit for OPENDJ-175: Decouple OpenDJ LDAP SDK from Grizzly ... Browse Code » 
    * Fix issue with dependencies when using opendj-ldap-sdk
   Now we ensure that :
   - maven-based clients don't get dependencies on opendj-core and opendj-grizzly  
   - non-maven-based clients can use jar with all dependencies included
 
 opendj-ldap-sdk module uses:
 - maven-shade-plugin to build a jar from opendj-core and opendj-grizzly, to hide opendj-core and opendj-grizzly and to provide a corresponding (reduced) pom
 - copy-maven-plugin to extract content of jar into target/classes directory (needed by bundle)
 - maven-bundle-plugin to generate a custom META-INF/MANIFEST file
 
* Remove duplicated javadoc/overview.html file

git-svn-id: https://svn.forgerock.org/opendj/trunk@9713 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     
  • 8fd0a15a   ReplicationBroker.java: ... Browse Code » 
    In computeInitialServerStatus(), used early exits.
In computeBestServerForWeight(), extracted methods computeBestServerWhenNotConnected() and computeBestServerWhenConnected().
Changed replicationServerUrls from Collection<String> to Set<String>.
Removed useless field initialization to null.
Renamed _publish() to publish() + reduced local variables scope.
In receive(), renamed local variable replicationServerID to previousRsServerID and used this one more rather than the field.
In changeConfig(), used Set.equals().
Changed getReplicationMonitor() to getReplicationMonitorInstanceName().

ReplicationDomain.java:
Consequence of the change to ReplicationBroker.getReplicationMonitor(), inlined getReplicationMonitorInstanceName().
Consequence of the change to ReplicationBroker.replicationServerUrls.

TestCaseUtils.java:
Moved newSet(), newSortedSet(), newList() here from test classes.

*Test.java:
Consequence of the changes to ReplicationBroker.replicationServerUrls.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9712 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 92040b25   Fix checkstyle: ... Browse Code » 
    package org.opends.server.types requires javadoc even for private methods.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9711 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 9746e6a8   Code cleanup in RDN, increased code vertical density + added comments ... Browse Code » 
    RDN.java:
In getDNValue(), changed parameter from String to ByteString.
In compareTo(), reordered the if statements + extracted method compare().
Comments => javadocs

git-svn-id: https://svn.forgerock.org/opendj/trunk@9710 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 57df8824   OPENDJ-1134 (CR-2355) Introduce a class in replication for encapsulating host+port combinations ... Browse Code » 
    Fixed a regression introduced in r9605:  It was found by Christophe Sovant with the functional test suite.

Partial revert of r9605:
Using DN.toNormalizedString() should have been only done for replication metadata, not for user data because OpenDJ stores and returns data like provided by users.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9709 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

10 Oct, 2013

6 commits

  • 98043fee   Checkpoint commit for OPENDJ-175: Decouple OpenDJ LDAP SDK from Grizzly ... Browse Code » 
    * simplify module names
* minor pom cleanup
* minor file cleanup, e.g. remove unused directories, etc.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9708 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • 1a720e53   ECLServerHandler.java: ... Browse Code » 
    Fixed a regression introduced in r9677. It was found by Christophe Sovant with the functional test suite:
When throwing a DirectoryException with ERR_RESYNC_REQUIRED_UNKNOWN_DOMAIN_IN_PROVIDED_COOKIE, the domainCtxts is read before it is written to.
This code should have been changed to iterate on the Set<DomainContext> rather than the domainCtxts field which has not been assigned at this point.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9707 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 36d4e2bf   Added some checks to avoid python exception ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9706 41b1ffd8-f28e-4786-ab96-9950f0a78031
    csovant
     
  • 00aafaf0   Checkpoint commit for OPENDJ-175: Decouple OpenDJ LDAP SDK from Grizzly ... Browse Code » 
    * Introduce two new maven modules, resulting from splitting functionality of module opendj-ldap-sdk :
    opendj-core : core APIs
    opendj-grizzly : implementation classes for Grizzly transport provider
    
These modules produce a jar with the same name (opendj-core and opendj-grizzly)
  
The opendj-ldap-sdk module is kept for compatibility. It contains no more source code, 
but it provides a opendj-ldap-sdk jar built from the two new maven modules.

* Move classes in opendj-grizzly module to org.forgerock.opendj.grizzly package
   
* Move some classes in opendj-core module to the org.forgerock.opendj.ldap.spi package 
   Modify visibility of  some constructors and methods of these classes to allow use by classes in opendj-grizzly
   Classes :
     - AbstractLDAPFutureResultImpl
     - LDAPFutureResultImpl
     - LDAPSearchFutureResultImpl
     - LDAPBindFutureResultImpl
     - LDAPCompareFutureResultImpl
     - LDAPExtendedFutureResultImpl

* Duplicated methods in opendj-grizzly module 
  - LDAPReader#decodeEntry
  - LDAPWriter#encodeEntry 
  to methods in opendj-core module
  - LDAPUtils#encodeSearchResultEntry
  - LDAPUtils#decodeSearchResultEntry 
to avoid sharing  or exposing too much code from these classes.
 

git-svn-id: https://svn.forgerock.org/opendj/trunk@9705 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     
  • 235bbcff   OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code » 
    DBCursor.java:
Added usage example to the javadocs.

DraftCNDB.java:
Replaced catch (Exception) by catch (DatabaseException), or removed them altogether where unapplicable.
In next(), first wiped the current record + reverted the if condition and clauses.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9704 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 8ac0a10c   OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code » 
    Changes after review from Matthew Swift.

Renamed CNIndexRecord to ChangeNumberIndexRecord to be consistent with ChangeNumberIndexDB name.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9703 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac