org.forgerock / org.forgerock.opendj

16 Dec, 2013

3 commits

13 Dec, 2013

17 commits

  • 182d8e00   Minor fix for OPENDJ-1235: Migrate configuration framework ... Browse Code » 
    * query property option to determine if a property is multi-valued.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9996 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • d17a675c   Fix OPENDJ-1252: ReadSchema example throws NPE ... Browse Code » 
    The bug was caused by a regression introduced when fixing OPENDJ-1200:

* ensure that default syntax and matching rule are validated before using them
* added unit tests which trigger NPEs.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9994 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • dfc928ce   Additional fix OPENDJ-1223: Copy DataProvider PoC from branch to OpenDJ 3 trunk ... Browse Code » 
    * rename opendj-server3 to opendj-server now that adapter dependency range is fixed.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9993 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • bd2c1b6d   Reduce opendj-server dependency range to < 3.0.0. ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9992 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • dab0da42   Checkpoint commit for OPENDJ-1235 : Migrate configuration framework ... Browse Code » 
    Forget TestChildCfgDefn and TestParentCfgDefn propertie files when moving to src/test/resources
 




git-svn-id: https://svn.forgerock.org/opendj/trunk@9991 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     
  • 3c6cbae5   Checkpoint commit for OPENDJ-1235 : Migrate configuration framework ... Browse Code » 
    * Fix bundle issue in unit tests for org.opends.server.admin package 
** Move TestParentCfgDefn and TestChildCfgDefn properties and xml files to src/test/resources
  so they are included in classpath

* Update pom.xml
** Generate core admin messages in src/main/resources directory
** Update generation of profiles messages

* Cleanup and minor refactoring in test classes and ConfigGuideGeneration class



git-svn-id: https://svn.forgerock.org/opendj/trunk@9990 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     
  • c3488168   OPENDJ-1250 Unexpected error when using encode-password tool ... Browse Code » 
    Regression introduced by r9970.
virtualAttributeConfigManager is null by default, but some code expected it to not be null.

DirectoryServer.java:
Made sure the virtualAttributeConfigManager is never null + inlined the remainings of initializeVirtualAttributes().
Applied generics + fixed formatting and typos.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9989 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 57d4f6c0   DirectoryServer.java: ... Browse Code » 
    Code cleanup, thanks AutoRefactor.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9988 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 05cefd17   Fix OPENDJ-1223: Copy DataProvider PoC from branch to OpenDJ 3 trunk ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9987 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • fbc82ead   OPENDJ-1222 Global update of CDDL copyright headers ... Browse Code » 
    
Most of the replace was done by global search replace from Eclipse via regular expressions.
Individual files had incorrect headers or badly formatted ones, so some of them have been done manually by replacing the content between CDDL HEADER START and CDDL HEADER END.
Some headers were quoting "trunk/opends/resource/legal-notices/CDDLv1_0.txt" while it should have been "legal-notices/CDDLv1_0.txt".


git-svn-id: https://svn.forgerock.org/opendj/trunk@9986 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 0f9eaa92   Add capability for debugging tests ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9985 41b1ffd8-f28e-4786-ab96-9950f0a78031
    csovant
     
  • 08290ad6   OPENDJ-1222 Global update of CDDL copyright headers ... Browse Code » 
    
Most of the replace was done by global search replace from Eclipse via regular expressions.
Individual files had incorrect headers or badly formatted ones, so some of them have been done manually by replacing the content between CDDL HEADER START and CDDL HEADER END.
Some headers were quoting "trunk/opends/resource/legal-notices/CDDLv1_0.txt" while it should have been "legal-notices/CDDLv1_0.txt".


Removed:
- resource/legal-notices/OpenDS.LICENSE

The following required manual changes:
- build.xml
- ext/checkstyle/opendj.sourceheader
- resource/admin/java-utilities.xsl
- src/build-tools/org/opends/build/tools/ProcessFilesForPackages.java
- src/build-tools/windows/*
- src/pkg/opends-dsml-gateway_proto.py
- src/pkg/opends_proto.py
- src/server/org/opends/server/util/ServerConstants.java
- tests/staf-tests/functional-tests/shared/data/aci/aci_targattrfilter/add_aci18.ldif
- tests/staf-tests/build.bat

An incorrect header mentionning "exclude" instead of "include" in the copyright header existed for: tests/staf-tests/functional-tests/testcases/backends/backup/**/*

Some files have no copyright headers at all. I did not update them. Here is some of them (more exist):
- tests/staf-tests/functional-tests/shared/data/core/psearch/**/*.ref
- tests/staf-tests/functional-tests/shared/data/core/psearch/**/delete.ldif


git-svn-id: https://svn.forgerock.org/opendj/trunk@9984 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 208c133c   Checkpoint commit for OPENDJ-1235 : Migrate configuration framework ... Browse Code » 
    * Migrate and fix all unit tests in org.opends.server.admin package
** 18 test cases, 409 tests
** Remove server start in setup method of all test cases
** Test case ValidateConfigDefinitionsTest is disabled for now as it needs schema with config object classes 

* Update pom.xml
** Change location of generated messages for managed objects to src/main/resources directory

* Update DirectoryServer class : comments and implementation of some stub methods  

* Reformat some classes in opends.server.admin package

git-svn-id: https://svn.forgerock.org/opendj/trunk@9983 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     
  • 89a576a6   OPENDJ-1222 Global update of CDDL copyright headers ... Browse Code » 
    
Most of the replace was done by global search replace from Eclipse via regular expressions.
Individual files had incorrect headers or badly formatted ones, so some of them have been done manually by replacing the content between CDDL HEADER START and CDDL HEADER END.
Some headers were quoting "trunk/opends/resource/legal-notices/CDDLv1_0.txt" while it should have been "legal-notices/CDDLv1_0.txt".


Removed:
- resource/legal-notices/OpenDS.LICENSE

The following required manual changes:
- build.xml
- ext/checkstyle/opendj.sourceheader
- resource/admin/java-utilities.xsl
- src/build-tools/org/opends/build/tools/ProcessFilesForPackages.java
- src/build-tools/windows/*
- src/pkg/opends-dsml-gateway_proto.py
- src/pkg/opends_proto.py
- src/server/org/opends/server/util/ServerConstants.java
- tests/staf-tests/functional-tests/shared/data/aci/aci_targattrfilter/add_aci18.ldif
- tests/staf-tests/build.bat

An incorrect header mentionning "exclude" instead of "include" in the copyright header existed for: tests/staf-tests/functional-tests/testcases/backends/backup/**/*

Some files have no copyright headers at all. I did not update them. Here is some of them (more exist):
- tests/staf-tests/functional-tests/shared/data/core/psearch/**/*.ref
- tests/staf-tests/functional-tests/shared/data/core/psearch/**/delete.ldif


git-svn-id: https://svn.forgerock.org/opendj/trunk@9982 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • dcd5c78c   CR-2693 OPENDJ-1245 import-ldif changes ds-cfg-enabled attr (for user backend) t… ... Browse Code » 
    …o TRUE which causes an error in post ugrade task (rebuild-index)

git-svn-id: https://svn.forgerock.org/opendj/trunk@9981 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     
  • 629baac4   DsconfigOptionsTestCase.java: ... Browse Code » 
    In testGenerateDoc(), added the @Test annotation + ensured the property set is cleared at the end of the test.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9980 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • f8bb60e7   Workaround for OPENDJ-1198: make-ldif example template shows markup ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9979 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     

12 Dec, 2013

9 commits

  • df9294f8   Fix OPENDJ-1247: Client side timeouts do not cancel bind or startTLS requests properly ... Browse Code » 
    * fail the connection when a bind or startTLS request times out
* ensure that abandon requests are sent for other types of operation
* fix a bug which meant that the timeout checker could fail to enforce timeouts for the first LDAP connection
* minor improvements: only register connections which have a non-zero timeout; remove duplicate requestID field from LDAP future implementation
* added unit tests. These tests are a bit too functional at the moment and will be split up in a subsequent change.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9975 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • d3bbcd42   Fix OPENDJ-1249: ConnectionFactory timeout setting is applied for Active Directo… ... Browse Code » 
    …ry persistent search requests

* don't enforce timeouts for searches that contain the control 1.2.840.113556.1.4.528


git-svn-id: https://svn.forgerock.org/opendj/trunk@9974 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • bc97701b   Update to forgerock-parent 1.2.0. ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9973 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • c135a922   Code cleanup in the virtual attributes. ... Browse Code » 
    
VirtualAttributeProvider.java:
Pulled up the empty implementations of initializeVirtualAttributeProvider().
Fixed typos.

*.java:
Consequence of pulling up empty implementations of initializeVirtualAttributeProvider().
Automatic + manual code cleanups.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9972 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 25bf4fe1   Fixing a test failure in Continuous Integration. ... Browse Code » 
    See the test failure stack trace at the bottom of this commit message.
ECLReplicationServerPreTest(), the very first test of ExternalChangeLogTest, expects external changelog to be disabled.
However, when GroupIdHandshakeTest was run before ExternalChangeLogTest but never removed ECL virtual attributes.
This led to the "lastChangeNumber" virtual attribute having an actual value of "0" while it was expected it would not exist on the returned entry.

Moved the total responsibility of maintaining the virtual attributes to VirtualAttributeConfigManager.
Ensured the ECL virtual attributes are removed on ECL shutdown.




VirtualAttributeConfigManager.java:
Do not call anymore the DirectoryServer.(de)registerVirtualAttribute() methods.
Added getVirtualAttributes(),  register(), deregister(), getDummyDN().
In loadProvider(), removed the use of reflection.

DirectoryServer.java:
Removed virtualAttributes field.
Delegated getVirtualAttributes(), registerVirtualAttribute(), deregisterVirtualAttribute() calls to VirtualAttributeConfigManager.
Removed replaceVirtualAttribute().

ReplicationServer.java:
Renamed externalChangeLogWorkflowID field to eclWorkflowID and externalChangeLogWorkflowImpl field to eclWorkflowImpl.
Changed eclWorkflowImpl to use an AtomicReference.
In enableECL(), used AotmicReference.compareAndSet() to avoid multiple threads initializing at the same time.
Renamed enableECLVirtualAttr() to buildVirtualAttributeRule() + extracted the call to DirectoryServer.registerVirtualAttribute() outside.
In buildVirtualAttributeRule(), used Collections.* methods.
In shutdownECL(), deregister the virtual attributes added by the enableECL().





   [testng]                  T E S T   F A I L U R E ! ! !
   [testng] 
   [testng] Failed Test:  org.opends.server.replication.server.ExternalChangeLogTest#ECLReplicationServerPreTest
   [testng] Failure Cause:  java.lang.AssertionError: expected:<null> but was:<0>
   [testng]     org.testng.Assert.fail(Assert.java:84)
   [testng]     org.testng.Assert.failNotEquals(Assert.java:438)
   [testng]     org.testng.Assert.assertEquals(Assert.java:108)
   [testng]     org.testng.Assert.assertEquals(Assert.java:129)
   [testng]     org.testng.Assert.assertEquals(Assert.java:139)
   [testng]     org.opends.server.replication.server.ExternalChangeLogTest.ECLCompatTestLimits(ExternalChangeLogTest.java:2560)
   [testng]     org.opends.server.replication.server.ExternalChangeLogTest.ECLIsNotASupportedSuffix(ExternalChangeLogTest.java:407)
   [testng]     org.opends.server.replication.server.ExternalChangeLogTest.ECLReplicationServerPreTest(ExternalChangeLogTest.java:167)

git-svn-id: https://svn.forgerock.org/opendj/trunk@9971 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 747ff5e3   Fix build in Jenkins. ... Browse Code » 
    Code review: Matthew Swift

build.xml:
Removed special checks checkstyle for org.opends.server.api, org.opends.server.protocols.internal, org.opends.server.types packages. Matt said they were added to ease embedding code into the docs, but this never happened, so this feature is basically dead.
Extracted property named "buildtools.jar"

opends-doctarget-checkstyle.xml: REMOVED

git-svn-id: https://svn.forgerock.org/opendj/trunk@9970 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 9692811e   Checkpoint commit for OPENDJ-1235 : Migrate configuration framework ... Browse Code » 
    * Add ConfigurationMock class to enable creation of Configuration objects mocks
 with default values automatically enabled
** Add ConfigurationMockTest to test correct behavior of mocking

* Add default implementation of some DirectoryServer class methods to enable tests
** Use default SDK schema 

* Add dependency on opendj-core test jar in pom.xml

git-svn-id: https://svn.forgerock.org/opendj/trunk@9969 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     
  • 6536436f   VirtualAttributeRule.java: ... Browse Code » 
    Code cleanup

git-svn-id: https://svn.forgerock.org/opendj/trunk@9968 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • ecaa051e   VirtualAttributeConfigManager.java: ... Browse Code » 
    Extracted methods createRule(), buildFilters(), areFiltersAcceptable().
In loadProvider(), called StaticUtils.collectionToString().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9967 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

11 Dec, 2013

5 commits

  • 89096143   Fixed compile error due to uncommitted changes in my workspace. ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9962 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • d79bc53a   Ti amo checkstyle! ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9961 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • fff68807   GroupManager.java: ... Browse Code » 
    Extracted method hasGroupMembershipUpdateControl().
In loadGroup(), used StaticUtils.collectionToString().
Automatic code cleanups.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9960 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 34637012   Code cleanups ... Browse Code » 
    
SetPropSubCommandHandler.java:
Extracted methods parseValue() and getPropertyDefinition().

Argument.java:
Improved the toString() + javadocs.
Minor code cleanups.

ArgumentParser.java:
Removed one parseArguments() method - never used.
Extracted method indentAndWrap() to match SubCommandArgumentParser.
Minor code cleanups.

SubCommandArgumentParser.java:
Removed one parseArguments() method - never used.
Minor code cleanups.

DsconfigOptionsTestCase.java:
Added testGenerateDoc().
Minor code cleanups.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9959 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 13ac0537   Minor code simplification. ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9958 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     

10 Dec, 2013

6 commits