org.forgerock / org.forgerock.opendj

05 Sep, 2013

5 commits

4f125b0f Fix last build test failure (another style enforcement: Messages must not end wi… ... Browse Code »
```
…th a dot, unlike Javadoc)

git-svn-id: https://svn.forgerock.org/opendj/trunk@9512 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-09-05 10:59:15 +0000

1789505b OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code »


Fixed a few bugs (introduced in the previous commits?):
- All code must check that the result of calling ChangeNumberIndexDB.getFirstCNIndexData() and ChangeNumberIndexDB.getLastCNIndexData() are not null (if the DB is empty, or closed, etc.).
- In ReplicationServer.clearGenerationId(), the code could have a side effect if the last entry in the DB was cleared by this method: the lastGeneratedChangeNumber would be allowed to go back!


ChangeNumberIndexDB.java:
Removed getLastChangeNumber().

DraftCNDbHandler.java:
Inlined getLastChangeNumber() to the only remaining method caller ReplicationServer.getChangeNumberIndexDB().
Finally changed the implementation of isEmpty() to something less costly.

DraftCNDbHandlerTest.java:
Inlined getFirstChangeNumber() and getLastChangeNumber().


ReplicationServer.java:
In clearGenerationId(), removed the code changing the value of lastGeneratedChangeNumber: lastGeneratedChangeNumber is not allowed to go backward.
In getChangeNumberIndexDB(), inlined here the code of DraftCNDbHandler.getLastChangeNumber() + removed useless use of MessageBuilder.
In getECLChangeNumberLimits(), added a null check for the result of getLastCNIndexData().

replication.properties:
Added a new error message.
Changed MILD_ERR_DRAFT_CHANGENUMBER_DATABASE_173 to MILD_ERR_CHANGENUMBER_DATABASE_173.


ECLServerHandler.java:
In findCookie(), replaced the DB empty checks by null checks on the return of getFirstCNIndexData() and getLastCNIndexData() since this is purely equivalent.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9511 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-09-05 09:32:32 +0000

3738a0cd Checkstyle mon amour! ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9510 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-09-05 08:11:23 +0000

43bc7041 OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code »

Remainder of r9504: changed changeNumber from int to long.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9509 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-09-05 07:54:17 +0000

5a52d8ac OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code »


Added CNIndexData class to replace the conjunct use of the (CSN, baseDN, previousCookie) tuple along with the changeNumber.
It allowed to replace:
- several parameters list with all theses types
- several groups of methods returning instances of these types with duplicate code in the implementation.

Remainder of r9504: changed changeNumber from int to long.


CNIndexData.java: ADDED

*.java:
Consequence of introducing CNIndexData class.


ECLServerHandler.java:
Renamed releaseIterator() into releaseCursor().
In getNextECLUpdate(), aggregated consecutive if statements + added a debugInfo().
Renamed assignNewDraftCNAndStore() to assignNewChangeNumberAndStore().
Changed changeNumber from int to long.

ChangeNumberIndexDB.java:
Replaced getCSN(), getBaseDN() and getPreviousCookie() by getCNIndexData().
Renamed getFirstChangeNumber() to getFirstCNIndexData().
Added getLastCNIndexData().
Changed add() signature.

DraftCNDbHandler.java
Consequence of the change to implemented interface ChangeNumberIndexDB.
Changed changeNumber from int to long.
Added getChangeNumber().


ChangeNumberIndexDBCursor.java:
Replaced getCSN(), getBaseDN() and getPreviousCookie() by getCNIndexData().

DraftCNDbIterator.java
Consequence of the change to implemented interface ChangeNumberIndexDBCursor.


DraftCNData.java:
Added changeNumber field + getter.
Replaced fields value, baseDN and csn by cnIndexData + getters.
Renamed readFirstChangeNumber() and readLastChangeNumber() to readFirstCNIndexData() and readLastCNIndexData().
Added newCNIndexData().
In inner class DraftCNDBCursor, Field key is now a ReplicationDraftCNKey (was DatabaseEntry) + DraftCNData field has been replaced with CNIndexData + entry is initialized on construction.
Replaced currentValue(), currentBaseDN(), currentCSN() and currentKey() by currentData().
Removed getKey().

ReplicationDraftCNKey.java:
Added a default ctor.
In getChangeNumber(), matched the code in DraftCNDB.

DraftCNDbHandlerTest.java:
Added assertEqualTo(), getFirstChangeNumber(), getLastChangeNumber(), getPreviousCookie().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9508 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-09-05 07:51:54 +0000

04 Sep, 2013

11 commits

a070273e CR-2258 Fix for OPENDJ-1113: Provide an example for resetting passwords in AD ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9507 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-09-04 15:53:52 +0000

dbb829ee SearchOperation*.java: ... Browse Code »

Change one field from Long to long.

SearchOperationBasis*.java:
Extracted method getSizeLimit() and getTimeLimit().

ExternalChangeLogTest.java:
Simplified the code.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9506 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-09-04 15:08:23 +0000

e4ea5b80 OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code »


ChangeNumberIndexDB.java:
All methods can now throw ChangelogException.


ReplicationServer.java:
Extracted method shutdownCNIndexDB().
Removed getFirstChangeNumber() and getLastChangeNumber().

DraftCNDbHandler.java:
Removed catch blocks and let the exception propagate.

ECLServerHandler.java:
Let the ChangelogException propagate.


ReplicaDBCursor.java:
Augmented the javadoc to explain the sort order. Follow up of r9504.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9505 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-09-04 12:34:42 +0000

fd4da70c OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code »


After talking Matthew's over the phone review, did a few changes described down below.

*.java:
Changed changeNumber from int to long throughout the replication code base.

ECLUpdateMsg.java:
In getBytes(), did not complete the change to long because it would require a protocol version change.


ReplicaDBCursor.java:
Now extends Comparable.

ReplicaDBCursorComparator.java: REMOVED
Code has been moved to JEReplicaDBCursor.compareTo().


ChangeNumberIndexDB.java:
Does not extend Runnable anymore (mistake from earlier refactorings).

DraftCNDbHandler.java:
Now extends Runnable.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9504 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-09-04 10:57:18 +0000

c1cdba9f Remove TestCaseUtils.clearJEBackend2() and use existing clearJEBackend() method. ... Browse Code »
```
* all impacted tests pass.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9503 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-09-04 09:42:08 +0000
440a1a62 Additional fix for OPENDJ-1119, typos spotted by Jean-Noel (thanks!) ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9502 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-09-04 09:19:13 +0000

cc6d5736 In javadocs, variable names, method names, etc., renamed: ... Browse Code »

- "draft change number" to "change number"
- "draftCN" to "change number"
- "sn" to "cn" in tests.
Fixed wrong usage of seqnum (only defined for CSNs - see the various IETF draft)

Now remains to rename a few classes.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9501 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-09-04 08:43:15 +0000

12458332 FractionalLDIFImportPlugin.java: ... Browse Code »

In flushFractionalConfigIntoEntry(), changed code to fix build break from r9497.
In doLDIFImport(), extracted method getAttribute() + used early exit .
Used javadocs instead of comments.
Removed redundant comments.
Used static imports.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9500 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-09-04 08:20:44 +0000

97cd1d3f LDAPReplicationDomain.java: ... Browse Code »

Fixed a small bug that I introduced in the previous commit by removing ENTRYUUID from the Set of attributes. Also, apparently "*" encodes for user attributes (and not operational).

ExternalChangeLogTest.java:
In ALL_ATTRIBUTES, changed the order of the attributes to match the order mentioned in the javadoc.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9499 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-09-04 07:48:25 +0000

fb827376 Renamed: ... Browse Code »

- ChangelogDB to ChangeNumberIndexDB
- ChangelogDBIterator to ChangeNumberIndexDBCursor

git-svn-id: https://svn.forgerock.org/opendj/trunk@9498 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-09-04 07:16:14 +0000

fdc69ea0 LDAPReplicationDomain.java: ... Browse Code »

In loadGenerationId(), fixed a bug.
Removed allOperationalAttributes() and replaced it with ALL_OPERATIONAL_ATTRS constant. Cannot remove HISTORICAL_ATTRIBUTE_NAME from it otherwise HistoricalTest and ExternalChangeLogTest start to fail.
Used Sets instead of Lists to avoid duplicate entries and the code does not care about ordering.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9497 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-09-04 07:03:19 +0000

03 Sep, 2013

5 commits

75242d70 CR-2254 Fix for OPENDJ-1119: Document service capabilities in .deb, .rpm ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9496 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-09-03 15:33:15 +0000
a90c5f80 OPENDJ-1084: Need Windows-specific instructions for unzipping archive ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9495 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-09-03 13:21:40 +0000

53d44f4f LDAPreplicationDomain.java: ... Browse Code »

Reverted if statement conditions to do early exit in loops or methods.
Reduced variable scopes.
Moved clearJEBackend() to TestCaseUtils and renamed it clearJEBackend2().
Extracted method allOperationalAttributes.
Increased vertical density.

ReplicationServerDomain.java:
Fixed javadocs.

*Test*.java:
Used TestCaseUtils.clearJEBackend2().
Various refactorings.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9494 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-09-03 13:08:51 +0000

1f7785c0 Editorial: add a jumplist given that there are multiple uninstall paths depending on packaging ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9493 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-09-03 10:10:23 +0000
bbdb0ae7 CR-2181 OPENDJ-1030 Upgrade : add a task to rebuild ds-sync-hist index when upgr… ... Browse Code »
```
…ading from 2.5.0-Xpress

git-svn-id: https://svn.forgerock.org/opendj/trunk@9492 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-09-03 09:27:02 +0000

02 Sep, 2013

5 commits

0bdce2e0 OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code »

After renaming ChangeNumber to CSN, fixed more javadocs, variable names, method names, etc.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9491 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-09-02 14:57:25 +0000

27187130 Surprisingly, doing better cleanup after a test ensured the tests are now passing. ... Browse Code »

No idea why it was working then suddenly not working anymore though.

ExternalChangeLogTest.java
Extracted methods remove(), createSearchRequest().
In removeTestBackend(), used variadic arguments.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9490 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-09-02 13:51:46 +0000

f531573d Checkstyle I love you. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9489 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-09-02 12:50:38 +0000
34977c4a Added spaces between error messages and stack traces. ... Browse Code »
```
+ minor code cleanup

git-svn-id: https://svn.forgerock.org/opendj/trunk@9488 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-09-02 12:27:44 +0000

5163a164 Renamed: ... Browse Code »

- ChangeNumber to CSN
- ChangeNumberGenerator to CSNGenerator
- ChangeNumberTest to CSNTest
- ChangeNumberGeneratorTest to CSNGeneratorTest


git-svn-id: https://svn.forgerock.org/opendj/trunk@9487 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-09-02 08:57:43 +0000

30 Aug, 2013

7 commits

890b3576 Final fix for OPENDJ-1112: LoadBalancing connection factories need better diagnostic messages ... Browse Code »

* add support for specifying the LoadBalancerEventListener when constructing load-balancing algorithms.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9483 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-30 14:04:28 +0000

242f29e1 OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code »

Renamed:
- ReplicationDBCursor to ReplicaDBCursor
- ReplicationDBCursorComparator to ReplicaDBCursorComparator
- JEReplicationDBCursor to JEReplicaDBCursor

Fixed javadocs, variable names, method names, etc.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9482 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-30 12:29:54 +0000

5b918c75 Fix typo in comment and avoid possible NPE in debugging mode. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9481 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-08-30 10:24:00 +0000
9139f553 OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code »
```
Fixed checkstyle.
Oh Eclipse, why did you fail me?


git-svn-id: https://svn.forgerock.org/opendj/trunk@9480 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-08-30 10:07:10 +0000
a17bbb38 More code cleanup and use of interfaces in dsreplication and ADS. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9479 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-08-30 10:02:05 +0000

e6384caf OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code »

Renamed:
- ReplicationIterator to ReplicationDBCursor
- ReplicationIteratorComparator to ReplicationDBCursorComparator
- JEReplicationIterator to JEReplicationDBCursor

Fixed javadocs, variable names, method names, etc.

ReplicationServerDomain.java:
Renamed getChangelogIterator() to getCursorFrom().

DbHandler.java:
Renamed generateIterator() to generateCursorFrom().

MessageHandler.java:
Extracted nextOldestUpdateMsg() and findOldestChangeNumberFromReplicationDBs() to increase code expressiveness.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9478 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-30 09:56:47 +0000

e22657c3 ChangeNumberTest.java: ... Browse Code »

Added compareToEquivalentToEquals(), hashCodesEqualWhenChangeNumbersEqual(), hashCodesEqualWhenCompareToEqual() to verify basic properties are covered.
Code cleanup.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9477 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-30 09:43:41 +0000

29 Aug, 2013

7 commits

9fbaca5f Partial fix for OPENDJ-1112: LoadBalancing connection factories need better diagnostic messages ... Browse Code »

* avoid accidentally trapping Errors - only RuntimeExceptions should be caught. Thanks to Peter for pointing this out :-)

git-svn-id: https://svn.forgerock.org/opendj/trunk@9476 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-29 21:56:13 +0000

2403b402 Partial fix for OPENDJ-1112: LoadBalancing connection factories need better diagnostic messages ... Browse Code »

* implement event notification framework
* TODO: need to figure out how to expose it in public API.



git-svn-id: https://svn.forgerock.org/opendj/trunk@9475 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-29 21:48:20 +0000

718b221d Partial fix for OPENDJ-1112: LoadBalancing connection factories need better diagnostic messages ... Browse Code »
```
* save last failure and include it as exception cause when all factories have failed.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9474 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-08-29 21:01:42 +0000
56d3a3c3 Fix OPENDJ-1124: Connection.search() return value not mockable ... Browse Code »
```
* make ConnectionEntryReader non-final.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9472 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-08-29 20:10:15 +0000
6b5889fb Minor error message cleanup. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9471 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-08-29 20:00:25 +0000

821c7470 Code cleanup. ... Browse Code »

ReplicationServerDomain.java:
Renamed getMessage() to debug() + called TRACER.debugInfo() in it.

MessageHandler.java:
Implemented toString().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9470 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-29 14:10:35 +0000

09f6557d ReplicationDbEnv.java: ... Browse Code »

Renamed:
- field stateDb to changelogStateDb.
- start() to initializeFromChangelogStateDB().
- putInStateDBIfNotExist() to putInChangelogStateDBIfNotExist()
- deleteFromStateDB() to deleteFromChangelogStateDB() + changed the signature.
In getOrAddDb(), reduced code clutter and removed useless comments.
Extracted methods kb(), mb(), toBytes(), buildGenIdKey(), buildServerIdKey(), buildGenIdData() for better readability.
Extracted method debug() to reduce code clutter.
Used static imports.

ReplicationServer.java:
Consequence of the rename of ReplicationDbEnv.start().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9469 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-29 10:56:29 +0000