16 Jul, 2013

2 commits


25 Jun, 2013

1 commit

  • In the end, it's simpler long term to include the install instructions in the README, and remove these extra files. With additional review from Ludo by mail, I've also fixed up a few small things in the README.
    
    I'm leaving the SVR4 related changes to Ludo.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9059 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     

21 Jun, 2013

1 commit


18 Jun, 2013

1 commit


11 Jun, 2013

2 commits


07 Jun, 2013

2 commits


05 Jun, 2013

1 commit


30 May, 2013

1 commit

  • - added message when buildinfo is not found.
    - excluded .app / bat files.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8944 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     

28 May, 2013

5 commits


27 May, 2013

4 commits

  • config.ldif:
    Made the "File-Based HTTP Access Logger" disabled by default.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8925 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • Made the "File-Based HTTP Access Logger" disabled by default.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8922 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • There are a number of issues with the Mac Apps, and this commit fixes most of them, but we should also change the icon name and picture once we have a logo for OpenDJ.
     The version and revision numbers are now automatically set when packaging.
     The -client JVM option is deprecated and thus removed. And we properly set the ServerRoot to allow ControlPanel to work when double clicking the icon.
     Note that Mac App are dependant on the JavaApplicationStub that only supports Java6. We fine for now, since OpenDJ is built with target 1.6, but we will need to redo the Apps when/if we switch to 1.7 by default.
     
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8921 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ludo
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@8920 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     

24 May, 2013

1 commit


23 May, 2013

1 commit

  • OPENDJ-842 On Windows, the setup command hangs when the length of the install path is too long
    
    
    Code review and initial idea: violette
    
    
    Now that the application starts with the single bootstrap jar, MacOS X can take advantage of this by referencing it statically in the plist files. In other words, it is no longer necessary to build the plist files dynamically.
    
    
    Info.plist:
    Hardcoded the path to bootstrap.jar
    
    build.xml:
    Removed the code that appended the jars to the **/Info.plist files for MacOS X.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8897 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

22 May, 2013

1 commit


19 May, 2013

1 commit


17 May, 2013

2 commits

  • …install path is too long
    
    
    In order to avoid getting errors like "The input line is too long" on windows, a common way to fix this is to provide a "bootstrap" empty jar which contains only a MANIFEST.MF file listing all the application's jars in the "Class-Path" attribute.
    This URL describes well enough the problem: http://ant.apache.org/manual/Tasks/manifestclasspath.html
    
    
    build.xml:
    In "prepackage" target, build bootstrap.jar.
    
    _script-util.bat, _script-util.sh:
    Replaced appending all the jars under libs with just the bootstrap jar.
    
    Utilities.java, Utils.java, UpgradeUtils.java:
    In getInstallPathFromClasspath(), extracted getInstallPath() and simplified its code a lot.
    
    Installation.java, Installation.java:
    Changed OPEN_DS_JAR_RELATIVE_PATHS into OPEN_DJ_BOOTSTRAP_JAR_RELATIVE_PATH. 
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8878 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@8876 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     

16 May, 2013

1 commit


15 May, 2013

1 commit

  • Code review: csovant
    
    Jars now appear only once in the classpath (they were appearing twice).
    INSTALL_ROOT and INSTANCE_ROOT represented the same absolute paths despite having different relative paths, resulting in the jars appended twice to the classpath.
    After this change, the paths are using the absolute paths instead of the relative paths.
    
    _script-util.bat:
    Fixed jars appearing twice in the classpath
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8872 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

14 May, 2013

2 commits

  • 
    
    Added support for ds-cfg-num-request-handlers in the HTTPConnectionHandler configuration to bring it at par with the LDAPConnectionHandler configuration.
    
    
    
    02-config.ldif, HTTPConnectionHandlerConfiguration.xml, HTTPConnectionHandlerCfgDefn.properties:
    Added ds-cfg-num-request-handlers.
    
    HTTPConnectionHandler.java:
    Set the SelectorRunnersCount in grizzly based on the numRequestHandlers property.
    
    LDAPConnectionHandler.java, ConnectionHandler.java:
    Moved getNumRequestHandlers() from LDAPConnectionHandler to ConnectionHandler.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8868 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 
    
    Now monitoring total etime for each supported HTTP method.
    While implementing this, I noticed that HTTPRequestInfo was duplicating fields in HTTPClientConnection and adding little more. I moved the missing data in HTTPRequestInfo to HTTPClientConnection and transformed the HTTPRequestInfo class into an interface to keep zero coupling between logging and HTTPClientConnection.
    
    
    
    HTTPRequestInfo.java:
    Transformed this class into an interface.
    Renamed getRemoteHost() to getClientHost() and getRemoteAddress() to getClientAddress().
    
    HTTPClientConnection.java
    Now implements HTTPRequestInfo.
    Moved several fields from HTTPRequestInfo here + added missing getters and setters.
    In sendResponse(), calling HTTPStatistics.updateRequestMonitoringData().
    Added log().
    
    TextHTTPAccessLogPublisher.java:
    Consequence of the changes to HTTPRequestInfo.
    Also added support for the "c-port", "s-ip", "s-computername", and "s-port" fields.
    
    CollectClientConnectionsFilter.java, SdkConnectionAdapter.java:
    Consequence of the changes to HTTPRequestInfo.
    
    HTTPStatistics.java:
    Renamed instance members nbRequests to requestMethodsTotalCount and nbRequestsTotalCount to requestsTotalCount.
    Added requestMethodsTotalTime instance member.
    Completed the constructor, clearStatistics(), getMonitorData().
    Fixed clearStatistics().
    Added addAll(), updateRequestMonitoringData().
    
    02-config.ldif:
    Added attributes for monitoring the total etime of HTTP requests.
    Renumbered some previously added attributes to follow what is done for LDAP operations etime.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8862 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

13 May, 2013

2 commits

  • Added support for monitoring statistics of the HTTP connection handler:
    It monitors: total number of requests, and number of delete, get, patch, post and put requests.
    It also monitors the internal LDAP operations to display how the server is performing.
    
    
    HTTPConnectionHandler.java, HTTPClientConnection.java, CollectClientConnectionsFilter.java, SdkConnectionAdapter.java:
    Added support for statistics.
    
    config.ldif, HTTPConnectionHandlerConfiguration.xml, HTTPConnectionHandlerCfgDefn.properties:
    Added "keep-stats" property.
    
    02-config.ldif:
    Added attributes "ds-mon-http-*" for monitoring HTTP statistics.
    
    LDAPStatistics.java:
    Changed getMonitorData() return type to List.
    Made createAttribute protected.
    
    HTTPStatsProbe.java, HTTPStatistics.java: ADDED
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8859 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • HTTPConnectionHandler.java, HTTPClientConnection.java, CollectClientConnectionsFilter.java, SdkConnectionAdapter.java:
    Added support for statistics.
    
    02-config.ldif, config.ldif, HTTPConnectionHandlerConfiguration.xml, HTTPConnectionHandlerCfgDefn.properties:
    Added "keep-stats" property.
    
    02-config.ldif:
    Added attributes "ds-mon-http-*" for monitoring HTTP statistics.
    
    LDAPStatistics.java:
    Changed getMonitorData() return type to List.
    Made createAttribute protected.
    
    HTTPStatsProbe.java, HTTPStatistics.java: ADDED
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8857 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

07 May, 2013

1 commit


03 May, 2013

1 commit

  • 
    
    Implemented the HTTP access logger by taking inspiration from other loggers.
    Configured the new logger everywhere other loggers are configured.
    Logged the HTTP request in several places to cover all cases (happy paths, errors, etc.).
    
    
    
    config.ldif, 02-config.ldif, HTTPAccessLogPublisherConfiguration.xml, FileBasedHTTPAccessLogPublisherConfiguration.xml, HTTPAccessLogPublisherCfgDefn.properties, FileBasedHTTPAccessLogPublisherCfgDefn.properties: ADDED
    Added 2 new objectClasses HTTPAccessLogPublisherConfiguration and FileBasedHTTPAccessLogPublisherConfiguration.
    
    config.properties:
    Added new error messages for the HTTP access logger.
    
    HTTPAccessLogger.java, HTTPAccessLogPublisher.java, TextHTTPAccessLogPublisher.java, HTTPRequestInfo.java: ADDED
    HTTPRequestInfo.log() prevents double logging.
    
    CollectClientConnectionsFilter.java:
    Logged the request info when HttpServletResponse.setStatus(), sendAuthenticationFailure() and onFailure() are called.
    Pushed more data to the HTTPRequestContext + switched to use the more specific HttpServletRequest/HttpServletResponse
    
    SdkConnectionAdapter.java:
    Logged the request info when close() is called.
    
    LoggerConfigManager.java, TestCaseUtils.java:
    Configured the HTTP access logger.
    
    InProcessServerController.java: TO BE REMOVED (by Matt on the native packaging branch)
    
    
    
    Sample log:
    localhost bjensen [03/May/2013:10:14:54 +0200] "GET /users/_queryFilter=true&_prettyPrint=true HTTP/1.1" 500 "curl/7.27.0"
    localhost bjensen [03/May/2013:10:15:05 +0200] "GET /users/_queryFilter=true&_prettyPrint=true HTTP/1.1" 200 "curl/7.27.0"
    localhost  [03/May/2013:10:15:14 +0200] "GET /users/_queryFilter=true&_prettyPrint=true HTTP/1.1" 200 "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:20.0) Gecko/20100101 Firefox/20.0"
    localhost  [03/May/2013:10:16:40 +0200] "GET /users/_queryFilter=true&_prettyPrint=true HTTP/1.1" 401 "curl/7.27.0"
    localhost  [03/May/2013:10:16:50 +0200] "GET /users/_queryFilter=true&_prettyPrint=true HTTP/1.1" 200 "curl/7.27.0"
    localhost  [03/May/2013:10:16:51 +0200] "GET /favicon.ico/null HTTP/1.1" 404 "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:20.0) Gecko/20100101 Firefox/20.0"
    localhost  [03/May/2013:10:17:10 +0200] "GET /users/_queryFilter=true&_prettyPrint=true HTTP/1.1" 200 "curl/7.27.0"
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8832 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

22 Apr, 2013

1 commit

  • 
    
    Limited the number of concurrent operations per client connection.
    
    
    
    SdkConnectionAdapter.java:
    Changed the queueing strategy to BoundedWorkQueueStrategy.
    
    BoundedWorkQueueStrategy.java: ADDED
    
    AbandonOperationWrapper.java, xtendedOperationWrapper.java, UnbindOperationWrapper.java: ADDED
    
    DirectoryServer.java:
    Extracted checkCanEnqueueRequest() from enqueueRequest().
    Added tryEnqueueRequest().
    
    WorkQueue.java:
    Pulled computeNumWorkerThreads() here from sub classes.
    Added abstract method trySubmitOperation().
    Added abstract getter getNumWorkerThreads().
    
    ParallelWorkQueue.java:
    Implemented trySubmitOperation() and getter getNumWorkerThreads().
    Renamed getNumWorkerThreads() to computeNumWorkerThreads() + moved it to WorkQueue.
    
    TraditionalWorkQueue.java:
    Implemented trySubmitOperation() and getter getNumWorkerThreads().
    Renamed getNumWorkerThreads() to computeNumWorkerThreads() + moved it to WorkQueue.
    Extacted overloaded method submitOperation(Operation, boolean) from submitOperation(Operation).
    
    
    
    ClientConnection.java, JmxClientConnection.java, HTTPClientConnection.java, InternalClientConnection.java, MockClientConnection.java, LDAPClientConnection.java:
    Added abstract method isConnectionValid() + implemented it in subclasses.
    
    
    
    02-config.ldif, HTTPConnectionHandlerConfiguration.xml:
    Added property max-concurrent-ops-per-connection
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8775 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

12 Apr, 2013

1 commit

  • Added the possibility for the HTTP Connection Handler to accept unauthenticated requests.
    
    CollectClientConnectionsFilter.java:
    Extracted method getAuthenticationInfo() and added support for unauthenticated requests here.
    
    CollectClientConnectionsFilterTest.java:
    Added tests.
    
    HTTPConnectionHandler.java:
    Added acceptUnauthenticatedRequests().
    
    config.ldif, 02-config.ldif, HTTPConnectionHandlerConfiguration.xml, HTTPConnectionHandlerCfgDefn.properties:
    Added property 'ds-cfg-authentication-required' with default 'true' to HTTP Connection Handler
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8733 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

11 Apr, 2013

3 commits


10 Apr, 2013

1 commit

  • build.xml:
    Added code to automatically append the classpath entries to the **/Info.plist files for MacOS X. This includes the classes directory and all the jars too.
    
    Info.plist:
    Removed hardcoded paths.
    Added classes directory first in the classpath to allow patches to work.
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8717 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac