15 Jul, 2013

2 commits


12 Jul, 2013

1 commit

  • TestCaseUtils.java:
    Added schemaBeforeStartingFakeServer and shutdownFakeServer().
    
    AciBodyTest.java:
    Added tearDown().
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9223 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

11 Jul, 2013

2 commits

  • git-svn-id: https://svn.forgerock.org/opendj/trunk@9220 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • EnumRightTest.java:
    Now implements DirectoryServerTestCase instead of the heavyweight AciTestCase.
    
    AciBodyTest.java, EnumRightTest.java:
    Now implements DirectoryServerTestCase instead of the heavyweight AciTestCase.
    Need to fake the DirectoryServer.
    
    TestCaseUtils.java:
    Added startFakeServer() method to fake the DirectoryServer.
    
    AttributeTypeConstants.java: ADDED
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9219 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

10 Jul, 2013

1 commit

  • Replaced collection concrete classes with interfaces.
    Used javadocs instead of line comments.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9212 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

09 Jul, 2013

4 commits


04 Jul, 2013

2 commits


03 Jul, 2013

3 commits

  • In encodeAndPurge(), made the code more readable by extracting methods needsPurge() and encode().
    
    HistoricalTest.java:
    Cleaned up the test a bit.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9168 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • Modified the code after feedback from Ludo.
    
    EnumRight.java:
    In getEnumRight(), changed the order of the tests to cater for the new info + added comments.
    Removed DELWRITE and ADDWRITE supposedly mirroring the effective rights seflwrite_del and seflwrite_add, but never used in the code.
    javadocs: added @see tags.
    
    EnumRightTest.java: ADDED
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9162 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 
    AciBodyTest.java: ADDED
    
    KeywordBindRule.java:
    Added toString(StringBuilder).
    
    *.java:
    Fixed a lot of javadocs and made a lot of instance members private.
    Added toString() and toString(StringBuilder) to most classes, with AciBody, BindRule, PermBindRulePair, Permission, UserDN having a proper implementation.
    
    EnumBindRuleType.java:
    Added getType().
    
    EnumRight.java:
    Added getRight(), getEnumRight() and hasRights()
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9155 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

01 Jul, 2013

1 commit


29 Jun, 2013

1 commit


28 Jun, 2013

1 commit


27 Jun, 2013

4 commits


26 Jun, 2013

1 commit

  • Removed unused methods getCommonLogElements(), getRequestLogElements() and getResponseLogElements().
    
    *.java:
    Consequence of the change to Operation.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9073 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

25 Jun, 2013

7 commits


24 Jun, 2013

6 commits


20 Jun, 2013

2 commits

  • The issue was triggered by the mix of AssuredReplication and bad network conditions, which resulted in a deadlock between 2 RS, as both were blocked on writing to the TCP socket and not reading (because waiting on the write lock).
    The solution (more of a workaround) is to have another thread for sending data to the socket and have the reader and writer posting data to send to a queue that this new thread is polling.
    There are still potential deadlocks but they will occur much later, if the sendQueue gets full.  The code needs more work post 2.6 to be fully non blocking, but the changes are enough for now to resolve the customer deadlock case.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9015 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ludo
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@9012 41b1ffd8-f28e-4786-ab96-9950f0a78031
    csovant
     

19 Jun, 2013

2 commits

  • git-svn-id: https://svn.forgerock.org/opendj/trunk@9011 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • * make protocol versioning the responsibility of the ProtocolSession object. Previously, it was split between various classes making it very confusing and risk-prone. Now only one class (TLSSocketSession) "owns" the protocol version
    * removed ReplicationMsg.getBytes() and require that all message impls implement ReplicationMsg.getBytes(short protocolVersion). Messages which have never evolved since the first protocol version can simply ignore the passed in protocol version parameter
    * simplified the handshake process, ensuring that we always set the protocol version once the handshake has completed. Part of this change was to remove the protocol version from the start message constructors, since it is implied during encoding (this removes some ambiguity in these classes)
    * many other minor code clean ups and bug fixes.
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9009 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew