15 Jul, 2013
2 commits
-
Automated refactorings. git-svn-id: https://svn.forgerock.org/opendj/trunk@9239 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Code cleanup. git-svn-id: https://svn.forgerock.org/opendj/trunk@9237 41b1ffd8-f28e-4786-ab96-9950f0a78031
12 Jul, 2013
1 commit
-
TestCaseUtils.java: Added schemaBeforeStartingFakeServer and shutdownFakeServer(). AciBodyTest.java: Added tearDown(). git-svn-id: https://svn.forgerock.org/opendj/trunk@9223 41b1ffd8-f28e-4786-ab96-9950f0a78031
11 Jul, 2013
2 commits
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9220 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
EnumRightTest.java: Now implements DirectoryServerTestCase instead of the heavyweight AciTestCase. AciBodyTest.java, EnumRightTest.java: Now implements DirectoryServerTestCase instead of the heavyweight AciTestCase. Need to fake the DirectoryServer. TestCaseUtils.java: Added startFakeServer() method to fake the DirectoryServer. AttributeTypeConstants.java: ADDED git-svn-id: https://svn.forgerock.org/opendj/trunk@9219 41b1ffd8-f28e-4786-ab96-9950f0a78031
10 Jul, 2013
1 commit
-
Replaced collection concrete classes with interfaces. Used javadocs instead of line comments. git-svn-id: https://svn.forgerock.org/opendj/trunk@9212 41b1ffd8-f28e-4786-ab96-9950f0a78031
09 Jul, 2013
4 commits
-
Extracted methods assertIndexContainsID() to remove duplicated code. git-svn-id: https://svn.forgerock.org/opendj/trunk@9208 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
In initMatchedDNs(), fixed the test (variables were inverted). Replaced concrete collections with interfaces. Used Collections.singleton(). git-svn-id: https://svn.forgerock.org/opendj/trunk@9207 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Used StaticUtils.close() git-svn-id: https://svn.forgerock.org/opendj/trunk@9203 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9202 41b1ffd8-f28e-4786-ab96-9950f0a78031
04 Jul, 2013
2 commits
-
Code cleanup. git-svn-id: https://svn.forgerock.org/opendj/trunk@9176 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9175 41b1ffd8-f28e-4786-ab96-9950f0a78031
03 Jul, 2013
3 commits
-
In encodeAndPurge(), made the code more readable by extracting methods needsPurge() and encode(). HistoricalTest.java: Cleaned up the test a bit. git-svn-id: https://svn.forgerock.org/opendj/trunk@9168 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Modified the code after feedback from Ludo. EnumRight.java: In getEnumRight(), changed the order of the tests to cater for the new info + added comments. Removed DELWRITE and ADDWRITE supposedly mirroring the effective rights seflwrite_del and seflwrite_add, but never used in the code. javadocs: added @see tags. EnumRightTest.java: ADDED git-svn-id: https://svn.forgerock.org/opendj/trunk@9162 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
AciBodyTest.java: ADDED KeywordBindRule.java: Added toString(StringBuilder). *.java: Fixed a lot of javadocs and made a lot of instance members private. Added toString() and toString(StringBuilder) to most classes, with AciBody, BindRule, PermBindRulePair, Permission, UserDN having a proper implementation. EnumBindRuleType.java: Added getType(). EnumRight.java: Added getRight(), getEnumRight() and hasRights() git-svn-id: https://svn.forgerock.org/opendj/trunk@9155 41b1ffd8-f28e-4786-ab96-9950f0a78031
01 Jul, 2013
1 commit
-
…problem in split mode git-svn-id: https://svn.forgerock.org/opendj/trunk@9127 41b1ffd8-f28e-4786-ab96-9950f0a78031
29 Jun, 2013
1 commit
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9123 41b1ffd8-f28e-4786-ab96-9950f0a78031
28 Jun, 2013
1 commit
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9117 41b1ffd8-f28e-4786-ab96-9950f0a78031
27 Jun, 2013
4 commits
-
Extracted methods setPathProperty(), setBooleanProperty(), isPropertyTrue(). *Test.java: Made things more explicit. git-svn-id: https://svn.forgerock.org/opendj/trunk@9100 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
More javadoc/code cleanup. Switched (excluded)serviceIDs/excludedDomains from List to Set. git-svn-id: https://svn.forgerock.org/opendj/trunk@9097 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9096 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9091 41b1ffd8-f28e-4786-ab96-9950f0a78031
26 Jun, 2013
1 commit
-
Removed unused methods getCommonLogElements(), getRequestLogElements() and getResponseLogElements(). *.java: Consequence of the change to Operation. git-svn-id: https://svn.forgerock.org/opendj/trunk@9073 41b1ffd8-f28e-4786-ab96-9950f0a78031
25 Jun, 2013
7 commits
-
=> fixed cleanup for operations testsuite => removed traces for sdk tools git-svn-id: https://svn.forgerock.org/opendj/trunk@9056 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Made the test code (hopefully) more readable. git-svn-id: https://svn.forgerock.org/opendj/trunk@9055 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Implemented several methods, removed TODOs, better implemented the offer() methods. git-svn-id: https://svn.forgerock.org/opendj/trunk@9054 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9053 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9051 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9050 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9049 41b1ffd8-f28e-4786-ab96-9950f0a78031
24 Jun, 2013
6 commits
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9048 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9047 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9046 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
The code replaying the replicated operations now handles BUSY and UNAVAILABLE result codes and will retry replaying these operations. Prevented a possible OutOfMemoryError by bounding the queue holding the replicated operations. LDAPReplicationDomain.java, ReplicationDomain.java: In replay(), added the AtomicBoolean shutdown parameter + tested for server shutdown + handled BUSY and UNAVAILABLE result codes + In processUpdate(), added the AtomicBoolean shutdown parameter + tested for server shutdown + ensured the code works with a bounded queue. Extracted logDecodingOperationError() out of replay(). MultimasterReplication.java: Made updateToReplayQueue a bounded queue (it was unbounded before). ReplayThread.java, ListenerThread.java: Converted shutdown boolean instance member into an AtomicBoolean. git-svn-id: https://svn.forgerock.org/opendj/trunk@9044 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Review: Matthew Swift, Ludovic Poitou, Christophe Sovant 1st phase of the changes. LockManager.java: Tripled the wait time for trying to acquire a lock. *.java: Removed the triple attempts at locking anti pattern. PasswordModifyExtendedOperation.java: Extracted method toAttributeValues() from processExtendedOperation(). git-svn-id: https://svn.forgerock.org/opendj/trunk@9043 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Converted comments to javadocs. git-svn-id: https://svn.forgerock.org/opendj/trunk@9042 41b1ffd8-f28e-4786-ab96-9950f0a78031
20 Jun, 2013
2 commits
-
The issue was triggered by the mix of AssuredReplication and bad network conditions, which resulted in a deadlock between 2 RS, as both were blocked on writing to the TCP socket and not reading (because waiting on the write lock). The solution (more of a workaround) is to have another thread for sending data to the socket and have the reader and writer posting data to send to a queue that this new thread is polling. There are still potential deadlocks but they will occur much later, if the sendQueue gets full. The code needs more work post 2.6 to be fully non blocking, but the changes are enough for now to resolve the customer deadlock case. git-svn-id: https://svn.forgerock.org/opendj/trunk@9015 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9012 41b1ffd8-f28e-4786-ab96-9950f0a78031
19 Jun, 2013
2 commits
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9011 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
* make protocol versioning the responsibility of the ProtocolSession object. Previously, it was split between various classes making it very confusing and risk-prone. Now only one class (TLSSocketSession) "owns" the protocol version * removed ReplicationMsg.getBytes() and require that all message impls implement ReplicationMsg.getBytes(short protocolVersion). Messages which have never evolved since the first protocol version can simply ignore the passed in protocol version parameter * simplified the handshake process, ensuring that we always set the protocol version once the handshake has completed. Part of this change was to remove the protocol version from the start message constructors, since it is implied during encoding (this removes some ambiguity in these classes) * many other minor code clean ups and bug fixes. git-svn-id: https://svn.forgerock.org/opendj/trunk@9009 41b1ffd8-f28e-4786-ab96-9950f0a78031