06 Feb, 2015

7 commits


05 Feb, 2015

6 commits


04 Feb, 2015

3 commits


03 Feb, 2015

5 commits

  • SubCommandArgumentParser.java:
    After r11664, getUsage(Argument) should call setUsageOrVersionDisplayed() itself.
    
    ManageAccountTestCase.java:
    Extracted method manageAccountMain(), the change to SubCommandArgumentParser will fix the tests.
    
    DsconfigOptionsTestCase.java:
    For testGenerateDoc() failure, calling DSConfig with "-?" option and "org.forgerock.opendj.gendoc" property set now returns SUCCESS while it was not before. This is due to r11664 which stops dsconfig execution after generating the documentation. This test assertion did not make sense to me.
    
    *.java:
    Code cleanup
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@11672 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • This is a problem since switching to using the opendj-cli argument classes.
    This happens because the opendj-cli tools check the new "com.forgerock.opendj.ldap.tools.scriptName" property instead of the opends property "org.opends.server.scriptName" that is still set by the server tools.
    Fixed by also checking the legacy opends property.
    Factorized the code from ArgumentParser, SubCommandArgumentParser and DSConfig.
    
    
    ArgumentParser.java:
    Added constant PROPERTY_SCRIPT_NAME_LEGACY.
    Extracted methods getScriptNameOrJava(), getLocalizableScriptName() and getScriptName().
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@11668 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • DSConfig.java:
    Used DSCONFIGTOOLNAME constant.
    Extracted method getCommandName() and conflictingArgs().
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@11667 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • …ough subcommand options
    
    Left code generating the reference documentation in opendj-cli SubCommandArgumentParser, so it can be reused with other tools using SubCommandArgumentParser.
    Created SubCommandUsageHandler interface to allow outputing additional documentation + implemented it in opendj-config DSConfig, this way the code can access all the config classes and generate the reference documentation inline with the command usage.
    
    
    SubCommandArgumentParser.java:
    Added subCommandUsageHandler field + setter.
    In toRefSect2(), used subCommandUsageHandler to output additional documentation.
    
    DSConfig.java:
    Created inner class DSConfigSubCommandUsageHandler + copied code from ConfigGuideGeneration to here.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@11666 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@11665 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

30 Jan, 2015

1 commit


29 Jan, 2015

7 commits


28 Jan, 2015

2 commits


27 Jan, 2015

5 commits


26 Jan, 2015

1 commit


23 Jan, 2015

1 commit


22 Jan, 2015

2 commits