20 Mar, 2013
3 commits
-
Fixed the issues identified with r8615. ivy.xml: Use the latest of Grizzly. Use very specifically javax.servlet-api 3.1-b02 to ensure compatibility with java 6. HTTPConnectionHandler.java: Uncommented all the code that I previously commented to allow code to compile on Jenkins. git-svn-id: https://svn.forgerock.org/opendj/trunk@8619 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Made the code compile with java 6 until we can further solve the issue. I'll come back to this code to uncomment the lines I commented here. ivy.xml: Excluded the dependency to activation.jar. Remporarily downgraded grizzly and javax.servlet versions. Replaced tabs with spaces. HTTPConnectionHandler.java: Commented out some code to be reenabled in a subsequent commit. git-svn-id: https://svn.forgerock.org/opendj/trunk@8615 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Added the HTTPConnnectionHandler implemented using Grizzly. Added support for all configuration similar to the LDAPConnectionHandler. Missing support for ds-cfg-keep-stats and ds-cfg-num-request-handlers. config.ldif, 02-config.ldif: Added new entry for HTTP connection handler + defaults. HTTPConnectionHandlerCfgDefn.properties, HTTPConnectionHandlerConfiguration.xml: ADDED LDAPConnectionHandlerConfiguration.xml: Moved properties common to HTTPConnectionHandlerConfiguration.xml to Package.xml . protocol*.properties: Merged protocol messages between LDAP, HTTP and JMX. Made them non LDAP specific. Added 2 new protocol messages for HTTP. CollectClientConnectionsFilter.java, HTTPClientConnection.java, HTTPConnectionHandler.java, package-info.java: ADDED JmxClientConnection.java, JmxConnectionHandler.java, LDAPClientConnection.java: Used common protocol messages. LDAPConnectionHandler.java Used common protocol messages. Extracted method configureSSL() Simplified the code in getEnabledSSLCipherSuites() and getEnabledSSLProtocols() and protected against a multi threaded change ofg the SSL engine by using a local copy. git-svn-id: https://svn.forgerock.org/opendj/trunk@8613 41b1ffd8-f28e-4786-ab96-9950f0a78031
19 Mar, 2013
3 commits
-
This is just a one liner to use the proper error message (looks like a copy/paste mistake). The error reported will now show as below: $ ldapsearch -h localhost -p 1389 -D "uid=user.0,ou=people,dc=example,dc=com" -w password -Y "uid=user.1,ou=people,dc=example,dc=com" -b "dc=example,dc=com" 'uid=user.1' SEARCH operation failed Result Code: 2 (Protocol Error) Additional Information: The authorization ID "uid=user.1,ou=people,dc=example,dc=com" contained in the proxied authorization V2 control is invalid because it does not start with "dn:" to indicate a user DN or "u:" to indicate a username git-svn-id: https://svn.forgerock.org/opendj/trunk@8609 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
TLSCapableConnection.java: Renamed isStartTLSAvailable() to prepareTLS() after a discussion with Ludo and Matt. StartTLSExtendedOperation.java, LDAPClientConnection.java: Consequence of the change to TLSCapableConnection. git-svn-id: https://svn.forgerock.org/opendj/trunk@8608 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
TLSCapableConnection.java: Renamed isTLSAvailable() to isStartTLSAvailable() to better explicit the purpose of this method. StartTLSExtendedOperation.java: Consequence of the change to TLSCapableConnection. LDAPClientConnection.java: Consequence of the change to TLSCapableConnection. Used StaticUtils.close() methods. Removed one useless parameter from ConnectionFinalizerJob constructor. StaticUtils.java: Added close(Selector...). git-svn-id: https://svn.forgerock.org/opendj/trunk@8607 41b1ffd8-f28e-4786-ab96-9950f0a78031
18 Mar, 2013
1 commit
-
Code cleanup. AddressMask.java: In maskListContains(), replaced the AddressMask array argument to a Collection<AddressMask>. *.java: Changed all places calling it. git-svn-id: https://svn.forgerock.org/opendj/trunk@8605 41b1ffd8-f28e-4786-ab96-9950f0a78031
14 Mar, 2013
3 commits
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@8602 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Extracted methods registerChannels() and serveIncomingConnections(). In run(), removed useless try/catch blocks around cleanUpSelector() (because it catches all exception internally). git-svn-id: https://svn.forgerock.org/opendj/trunk@8601 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Extracted method checkAnyListenAddressInUse(). Fixed words spelling, renamed exceptions in catch clauses to better communicate their intent. Added javadocs + @Override annotations. Used foreach + StaticUtils.close(). git-svn-id: https://svn.forgerock.org/opendj/trunk@8600 41b1ffd8-f28e-4786-ab96-9950f0a78031
13 Mar, 2013
2 commits
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@8595 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
The main set of changes have been provided by Elliot Kandall @ UCSF, but I've done additional cleanup of code and refactoring, added support for multiple constants per lines (this was required by the support for escaping [ and ]. Unit tests are provided and have been extended after the code review and suggestions by reviewers (CR-1401). git-svn-id: https://svn.forgerock.org/opendj/trunk@8593 41b1ffd8-f28e-4786-ab96-9950f0a78031
12 Mar, 2013
1 commit
-
… prop is set and server is running with JDK1.7 The issue here is that the TreeSet implementation changed starting from Java 1.7. When adding as a first element a non Comparable object, Java 1.7 will now throw a ClassCastException. SNMPInetAddressAcl.java: Changed hostsList instance member type from TreeSet to Set + HashSet. In checkReadPermission() used Set.contains(). Used foreach. git-svn-id: https://svn.forgerock.org/opendj/trunk@8590 41b1ffd8-f28e-4786-ab96-9950f0a78031
11 Mar, 2013
1 commit
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@8586 41b1ffd8-f28e-4786-ab96-9950f0a78031
08 Mar, 2013
2 commits
-
- Fixed : with degraded state option, the backend is no more disabled/activated. git-svn-id: https://svn.forgerock.org/opendj/trunk@8575 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
LDAPConnection.java: In connectToHost(), protected LDAPConnectionException from the general catch(Exception) which made our error code disappear. LDAPSearchTestCase.java: In getInvalidArgumentLists(), removed very easily 100 lines of code. Properly used assertEquals() instead of assertTrue(). LDAPSearchNoServerTestCase.java: ADDED git-svn-id: https://svn.forgerock.org/opendj/trunk@8573 41b1ffd8-f28e-4786-ab96-9950f0a78031
07 Mar, 2013
5 commits
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@8567 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
…emove unused param from method. git-svn-id: https://svn.forgerock.org/opendj/trunk@8566 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
…f the user for easier analysis. Removed the bindDN from several error messages, covering simple bind and SASL bind. core*.properties: Updated relevant error messages + the places where they are used in the java code. TextAccessLogPublisher.java: In logBindResponse(), log the bindDN and SASL saslAuthUserDN if SASL is used. git-svn-id: https://svn.forgerock.org/opendj/trunk@8565 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@8562 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
…f the user for easier analysis. Fixed other occurences of copy/pasted code. LocalBackendBindOperation.java: In processBind(), fixed the code. Extracted methods generateAccountStatusNotificationForLockedBindAccount() and getIntegerUserAttribute() to remove duplicated code. git-svn-id: https://svn.forgerock.org/opendj/trunk@8561 41b1ffd8-f28e-4786-ab96-9950f0a78031
06 Mar, 2013
8 commits
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@8560 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@8559 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@8558 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
…f the user for easier analysis. Aargh so much code copy/pasted! Found and fixed other occurences. Aargh I also broke the build again. LocalBackendBindOperation.java: In processBind(), fixed the code. Extracted methods generateAccountStatusNotificationForLockedBindAccount() and getIntegerUserAttribute() to remove duplicated code. git-svn-id: https://svn.forgerock.org/opendj/trunk@8557 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
- Fixed message. git-svn-id: https://svn.forgerock.org/opendj/trunk@8556 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
…f the user for easier analysis. What a convoluted code!! It is using a label and a block to implement a goto in Java. yuck! LocalBackendBindOperation.java: In processLocalBind(), extracted method processBind(). In the newly extracted method processBind(), converted the break stmts into return stmts + moved the switch stmt inside the try stmt (instead of the try/catch stmt in the switch stmt) + then removed useless if statements and break statements from the switch stmt. git-svn-id: https://svn.forgerock.org/opendj/trunk@8555 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
…t groups when configured explicitly for one of the groups ReplicationBroker.java: In connectAsDataServer(), removed following useless if statement (root cause for the bug): // Really no other server with our group id ? if ((tmpRsGroupId == groupId) || (!someServersWithSameGroupId)) Extracted method connectToReplicationServer() in connectAsDataServer(). Removed hasSomeServerWithSameGroupId(). git-svn-id: https://svn.forgerock.org/opendj/trunk@8554 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
…hen configured explicitly for one of the groups java.net.Socket implements java.io.Closeable starting from Java 7 only :( git-svn-id: https://svn.forgerock.org/opendj/trunk@8549 41b1ffd8-f28e-4786-ab96-9950f0a78031
05 Mar, 2013
8 commits
-
…t groups when configured explicitly for one of the groups Fixing checkstyle errors. git-svn-id: https://svn.forgerock.org/opendj/trunk@8548 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
…t groups when configured explicitly for one of the groups Fixing checkstyle errors. git-svn-id: https://svn.forgerock.org/opendj/trunk@8547 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
…t groups when configured explicitly for one of the groups Code cleanup. ReplicationBroker.java In computeBestReplicationServer(), fixed the screwed up for (ctr) switch (ctr){}; pattern + added keepBest() method. In computeBestServerForWeight(), used BigDecimal.valueOf() instead of ctor. In changeConfig(), fixed complicated condition. Added javadocs, fixed variable naming, used foreach. StaticUtils.java: Added toIterable(). git-svn-id: https://svn.forgerock.org/opendj/trunk@8546 41b1ffd8-f28e-4786-ab96-9950f0a78031 -
git-svn-id: https://svn.forgerock.org/opendj/trunk@8542 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
If I see another if (c != null) try{ c.close(); }catch (Throwable t){}, I am going to bail out!! git-svn-id: https://svn.forgerock.org/opendj/trunk@8541 41b1ffd8-f28e-4786-ab96-9950f0a78031 -
LDAPConnection.java: Extracted methods createSocket(), createSSLSocket() and createSSLOrBasicSocket(). In createSocket() and createSSLSocket(),call InetAddress.getAllByName() to try all host name entries. SSLConnectionFactory.java: Added method createSocket(InetAddress host, int portNumber). git-svn-id: https://svn.forgerock.org/opendj/trunk@8540 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@8539 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@8537 41b1ffd8-f28e-4786-ab96-9950f0a78031
04 Mar, 2013
2 commits
-
- If in cleardegradedState mode, output just displays the following msg "Degraded state of index(es) [indexe(s) name] has been removed". git-svn-id: https://svn.forgerock.org/opendj/trunk@8535 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
- added support for the clearDegradedState option in online mode. git-svn-id: https://svn.forgerock.org/opendj/trunk@8532 41b1ffd8-f28e-4786-ab96-9950f0a78031
01 Mar, 2013
1 commit
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@8529 41b1ffd8-f28e-4786-ab96-9950f0a78031