org.forgerock / org.forgerock.opendj

21 Aug, 2013

2 commits

70ea1efd Increased encapsulation in ReplicationServerDomain by: ... Browse Code »

- Making private the start*() methods
- Moved some code to here from some other classes
- MAking private the buildAndSendTopoInfoTo*() methods.

ReplicationServerDomain.java:
Extracted method sendTopoInfoToAllExcept().
Renamed buildAndSendTopoInfoToDSs() to sendTopoInfoToAllDSsExcept() + made it private.
Renamed buildAndSendTopoInfoToRSs() to sendTopoInfoToAllRSs() + made it private.
Renamed changeStatusFromStatusAnalyzer() to changeStatus().
Made startStatusAnalyzer() and startMonitoringPublisher() private.
Directly used the fields connectedDSs and connectedRSs instead of through their getters.
Moved 2 register() methods here from DataServerHandler and ReplicationServerHandler.
Renamed all variables and parameters named "handler" to disambiguated names.

DataServerHandler.java:
Renamed changeStatusFromStatusAnalyzer() to changeStatus().
Moved registerIntoDomain() + some other code to ReplicationServerDomain.

ReplicationServerHandler.java:
Moved registerIntoDomain() + some other code to ReplicationServerDomain.

ReplicationServer.java
Renamed all variables and parameters named "handler" to disambiguated names.
Consequence of the change to ReplicationServerDomain.sendTopoInfoToAllExcept().

StatusAnalyzer.java:
Consequence of the change to ReplicationServerDomain.changeStatusFromStatusAnalyzer().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9434 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-21 08:33:59 +0000

65f89b4e Partial fix for OPENDJ-1114 Improve the DEB package ... Browse Code »

- copyright added
- doc section added (to complete)


git-svn-id: https://svn.forgerock.org/opendj/trunk@9433 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-21 07:47:45 +0000

20 Aug, 2013

5 commits

c64558ad LDAPReplicationDomain.java: ... Browse Code »

Fixed off-by-one error.

FractionalReplicationTest.java:
Removed try / catch / fail test anti pattern.
Removed useless comments.
Extracted method waitTillEntryHasSynchroAttribute().
Made attributes private.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9432 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-20 15:19:28 +0000

5f037f31 ReplicationMonitor.java: ... Browse Code »

Used interfaces instead of concrete classes.
Removed useless comments.
Extracted method addMonitorData().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9431 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-20 13:41:49 +0000

4de1199a Entry.java: ... Browse Code »

Extracted methods newMapIfNull(), getUserOrOperationalAttributes(), getAttributes(), putAttributes(), removeAttributes(), addAllIfNotNull(), onlyKeepAttributesWithAllOptions(), getAttribute(), onlyKeepAttributesWithAllOptions(), addObjectClass(), hasObjectClassOrAttribute(), hasObjectClass(), containsObjectClassByName(), hashCode(), equals(), appendAttributes(), newList().
Comments to javadoc.
Used interfaces instead of concrete classes.
Collapsed if statements.
Put code on one line where possible.

LDAPReplicationDomain.java:
Extracted methods isSolveConflict(), needReconnection(), findReplicationSearchResultEntry(), isMandatoryAttribute(), isFractionalProhibited(AttributeType), canRemoveAttribute(), contains(), runAsSynchronizedOperation().
Removed useless else.
Used interfaces instead of concrete classes.
Put code on one line where possible.
Removed useless comments.
Simplified code in several places.
Collapsed if statements.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9430 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-20 13:22:22 +0000

0c48cb0f Fix nightly tests failure within these tests. ... Browse Code »

It was due to a side effect of the last commit as well as several locations where cleanup wasn't properly done after a test.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9429 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-20 13:05:53 +0000

faa9db49 Partial fix for OPENDJ-1031 (DEB part) ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9428 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-08-20 08:58:21 +0000

19 Aug, 2013

5 commits

b9bcd548 Simplify via refactoring the processing within LDAPReplicationDomain's synchroni… ... Browse Code »
```
…ze(PostOperationOperation op) method. 
Reviewed by JN, CR-2193.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9427 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-08-19 16:02:07 +0000

821e6c72 Code cleanup. ... Browse Code »

RSInfo.java, DSInfo.java:
Made them (almost) immutable classes.

LightweightServerHandler.java:
Replaced many instance members with just one DSInfo instance member.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9426 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-19 14:18:10 +0000

bdeecc59 - Fix STAX exception in replication/externalchangelog_consistency tests due to u… ... Browse Code »

…nknown function paramter
- Added README to explain how to start the STAF daemon and run the tests



git-svn-id: https://svn.forgerock.org/opendj/trunk@9425 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-19 14:16:00 +0000

ccbdfce4 Avoided possible costly thread leaks in ReplicationServerDomain. ... Browse Code »



ReplicationServerDomain.java:
Used AtomicReference for statusAnalyzer and monitoringPublisher.
As a consequence:
- Changed update*(), start*() and stop*() methods.
- Removed isRunning*() methods.

MonitoringPublisher.java:
Extracted getMessage() to make error messages more conherent.

ServerReader.java:
In run(), removed redundant code by checking whether the message is a RoutableMsg.
Extracted method logException().
In ServerReader.run(), moved some code to ServerHandler.put().
Code cleanups:
- inlined useless local variables
- removed useless use of "this" before method calls.

DataServerHandler.java, ECLServerHandler.java, ReplicationServerHandler.java:
Extracted method createReplServerStartMsg().

ServerHandler.java:
Renamed process(WindowProbeMsg) to replyToWindowProbe().
Made some instance members private.
Moved createReplServerStartMsg here.
In put(), moved decAndCheckWindow() call here from ServerReader.run().

WindowProbeMsg.java:
Fixed javadocs + simplified code.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9424 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-19 13:27:40 +0000

50d9c0b5 Enforced ReplicationServerDomain responsibilities by increasing encapsulation. ... Browse Code »


ReplicationServer.java:
Added getConnectedRSUrls(), that aggregates code from ReplicationServerDomain.getChangelogs() and from runConnect().
In applyConfigurationChange(), moved code to ReplicationServerDomain for better encapsulation.

ReplicationServerDomain.java:
Renamed checkForDuplicateDS() into isAlreadyConnectedToDS().
Renamed checkForDuplicateRS() into isAlreadyConnectedToRS().
Moved getChangelogs() to ReplicationServer.
Made several methods private to reduce coupling and enforce class responsibilities.
Generalized the use of isRunningStatusAnalyzer() and isRunningMonitoringPublisher() to improved readability.
Inlined updateStatusAnalyzer() and updateMonitoringPublisher().
Moved code from ... to create updateDegradedStatusThreshold() and updateMonitoringPeriod().
In stopReplicationServers(), renamed parameter for increased readability.

DataServerHandler.java:
Inlined createStatusAnalyzer().

ServerHandler.java, ReplicationServerHandler.java:
Inlined createMonitoringPublisher().
In lockDomain(), removed useless else.
Code cleanup.

StatusAnalyzer.java:
Extracted isInterrupted().
Extracted getMessage() to make error messages more conherent.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9423 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-19 10:32:47 +0000

15 Aug, 2013

1 commit

74923ee1 Update additional links to community SSO ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9421 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-08-15 14:51:00 +0000

14 Aug, 2013

5 commits

6947eea3 ReplicationServerDomain.java ... Browse Code »

Renamed directoryServers to connectedDSs.
Renamed replicationServers to connectedRSs.
Removed the useless getConnectedLDAPservers(), replaced with getConnectedDSs().
Renamed a few local variables.

DataServerHandler.java:
Consequence of removing to ReplicationServerDomain.getConnectedLDAPservers()
Extracted method changeStatus() from changeStatusFromStatusAnalyzer() and changeStatusForResetGenId().
Extracted method getStatusMachineEvent() from changeStatusForResetGenId().

InitOnLineTest.java
Consequence of removing to ReplicationServerDomain.getConnectedLDAPservers().
Removed useless try / catch / fail.
Extracted methods getCompletionTime(), assertAttributeValue().
Used Assertions.assertThat().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9418 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-14 14:22:52 +0000

ca7e1746 - Added known issue OPENDJ-1051 in replication/externalchangelog_consistency tests (Upgrade mode) ... Browse Code »
```
- Updated i18n/datacomparison reference file
 


git-svn-id: https://svn.forgerock.org/opendj/trunk@9417 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-08-14 13:08:43 +0000

d53a5808 ChangeNumber.java: ... Browse Code »

In the ctor, renamed parameters.
In other methods, used early exit.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9416 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-14 11:15:32 +0000

dc7c17c6 OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code »

Removed ReplicationServerDomain.getReplicationServer() to follow the Law of Demeter: "Only talk to your immediate friends." to promote loose coupling.
Changed approxFirstMissingDate from Long object to long primitive.


ReplicationServerDomain.java:
Removed getReplicationServer().
Added getLocalRSMonitorInstanceName() and getLocalRSServerId().

*.java:
Used the newly added ReplicationServerDomain.getLocalRSMonitorInstanceName() and ReplicationServerDomain.getLocalRSServerId().

LightweightServerHandler.java:
Removed getLocalRSMonitorInstanceName().


MonitorMsg.java, MonitorData.java:
Changed firstMissingDate from Long object to long primitive.
Used StringBuilder in toString().

SynchronizationMsgTest.java
Changed approxFirstMissingDate from Long object to long primitive.
Extracted methods newList(), newSet(), getEntryAttributes(), assertAttributesEqual().
Used assertEquals() instead of assertTrue().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9415 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-14 11:14:13 +0000

29ad2aa6 OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code »

Removed avoidable references to replicationServerDomain.getReplicationServer().
Code cleanups:
- collapsed if statements
- applied early exits
- Replaced useless use of StringBulders with string concatenations
- Removed useless parentheses


*ServerHandler.java:
Replaced calls to this.replicationServerDomain.getReplicationServer() with directly using this.replicationServer .

DataServerHandler.java:
Inlined local variables.
Removed useless catch.

ECLServerHandler.java:
Extracted method releaseIterator().

LightweightServerHandler.java:
Extracted method getLocalRSMonitorInstanceName().

ReplicationServerHandler.java
In isRemoteLDAPServer(), renamed parameter.


MessageHandler.java:
Extracted methods collectAllIteratorsWithChanges(), addIteratorIfNotEmpty(), releaseAllIterators().

ReplicationServerDomain.java
Renamed replicationServer to localReplicationServer.
In put(), renamed id to serverId + extracted method publishMessage().
In getChangelogIterator(), renamed parameter.
Extracted methods replyWithMonitorMsg(), replyWithUnroutableMsgType(), forwardMsgToAllServers(), replyWithUnreachablePeerMsg() from process().
Renamed stopDbHandlers() to shutdownDbHandlers().
Extracted isServerConnected() from getEligibleCN().



DbHandler.java, JEReplicationIterator.java:
Renamed parameter.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9414 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-14 09:30:53 +0000

13 Aug, 2013

13 commits

b1466a91 Fix checkstyle ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9413 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-08-13 16:28:31 +0000
940d10e3 Major code refactoring - preparing the ground to OPENDJ-1030. ... Browse Code »
```
Thanks to JN for his help :)

git-svn-id: https://svn.forgerock.org/opendj/trunk@9412 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-08-13 15:48:19 +0000

bddf83a6 OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code »

Moved all JE changelog related classes to the new package org.opends.server.replication.server.changelog.je



DbHandler.java, DraftCNData.java, DraftCNDB.java, DraftCNDbHandler.java, DraftCNDbIterator.java, JEReplicationIterator.java, package-info.java, ReplicationData.java, ReplicationDB.java, ReplicationDbEnv.java, ReplicationDraftCNKey.java, DbHandlerTest.java, DraftCNDbHandlerTest.java:
Moved to package org.opends.server.replication.server.changelog.je

ReplicationServer.java:
Updated the imports.
Made getTrimAge() public.
Removed use of "this" from method invocation.
Moved handleUnexpectedChangelogException() to ReplicationDbEnv.

DraftCNDB.java, ReplicationDB.java:
Moved handleUnexpectedDatabaseException() to ReplicationDbEnv.

ReplicationDbEnv.java:
Moved handleUnexpectedChangelogException() here from ReplicationServer, and renamed it to shutdownOnException().
Moved handleUnexpectedDatabaseException() here from DraftCNDB and ReplicationDB, and renamed it to shutdownOnException().

ECLServerHandler.java, ReplicationServerDomain.java, ExternalChangeLogTest.java:
Updated the imports.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9411 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-13 15:15:13 +0000

dccedb39 Update community SSO link ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9410 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-08-13 13:53:22 +0000

49431fe4 OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code »

Extracted interface org.opends.server.replication.server.changelog.api.ReplicationIterator from org.opends.server.replication.server.ReplicationIterator and used it in all the places where the class was used.
Renamed ReplicationIterator class to JEReplicationIterator.
Moved ReplicationIteratorComparator from package org.opends.server.replication.server to org.opends.server.replication.server.changelog.api.

MessageHandler.java:
Minimal code cleanup.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9409 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-13 13:32:13 +0000

5824d62b ReplicationIterator.java: ... Browse Code »

In next(), removed useless local variable.
Renamed instance field from dbh to dbHandler.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9408 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-13 12:59:45 +0000

6422e8de Fix checkstyle ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9407 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-08-13 10:47:25 +0000

5cbc3c56 ExternalChangelogTest.java: ... Browse Code »

Extracted constants SERVER_ID_1 and SERVER_ID_2.
Renamed getAttributeValue() to getAttributeValueOrNull().
Extracted new getAttributeValue() from getAttributeValueOrNull(), checkValue() and checkPossibleValues().
In ECLGetEligibleCountTest(), extracted constants to better explicit the code + removed the count local variable + extracted method now()
Removed useless code blocks.

ReplicationServerDomain.java:
In getEligibleCount(), removed a useless if statement.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9406 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-13 10:07:41 +0000

4b173f5a Fixes for OPENDJ-1111 + SVR4 specific fix related to OPENDJ-1066. ... Browse Code »
```
Reviewed in CR 2142.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9405 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-08-13 09:31:33 +0000

b3cea6d7 TimeThread.java: ... Browse Code »

Converted comments to javadoc.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9404 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-13 09:16:46 +0000

22883610 Another fix for OPENDJ-1069 (removal of instance.loc) ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9403 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-08-13 08:17:19 +0000

86b5361f Fix for OPENDJ-1069, no longer delivering the instance.loc file. Now that the .b… ... Browse Code »

…at files can cope with the absence of the file, we can remove it completely.
 CR-2142


git-svn-id: https://svn.forgerock.org/opendj/trunk@9402 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-13 08:02:29 +0000

82b1c274 ivy.xml: ... Browse Code »

Upgraded to grizzly 2.3.5 which removes grizzly-rcm dependency :)

git-svn-id: https://svn.forgerock.org/opendj/trunk@9401 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-13 07:59:13 +0000

12 Aug, 2013

3 commits

bed8de21 Fix windows batch if instance.loc is missing - OPENDJ-1069 ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9400 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-08-12 15:40:53 +0000

a9d10551 OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Code »

Hid low level JE's DatabaseException and ReplicationDBException from replication higher level code. They have been replaced by the newly created ChangelogException.

Tidied up the exception handling by throwing or catching more specific exceptions.
Moved some code to protect them with try / catch.
Adding a few catch for specific handling of ChangelogException.
Threw ChangelogException instead of Exception.
Added handleUnexpectedDatabaseException() methods.

ReplicationDBException.java: REMOVED (now useless)

replication*.properties:
Removed ERR_COULD_NOT_INITIALIZE_DB, not adding anything to ERR_COULD_NOT_READ_DB.

Removed "this." from member method invocations.
Used Integer.parseInt().
Used StaticUtils.close().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9399 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-12 15:22:03 +0000

86f153af ExternalChangeLogTest.java: ... Browse Code »

Removed another 200 lines.
Extracted several methods: newSet(), generateChangeNumbers(), checkDn(), assertDnEquals(), debugAndWriteEntries(), createDomain(), runDeleteOperation(), assertOnlyDoneMsgReceived.
Removed useless / unused / plain wrong code.
Removed commented out code.
assertTrue() => assertEquals().
Used assertj assertThat().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9398 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-12 10:16:57 +0000

11 Aug, 2013

1 commit

43f2794d CR-2061 Fix for OPENDJ-979: Use JCite rather than copy/paste to cite Java example code ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9397 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-08-11 10:07:18 +0000

09 Aug, 2013

5 commits

bf5264c3 ExternalChangeLogTest.java: ... Browse Code »

In ECLTwoDomains(), inverted 2 parameters to fix another test failure.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9396 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-09 15:32:17 +0000

05ed1ad6 Minor code refactoring. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9395 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-08-09 15:21:27 +0000

5551ef8d ExternalChangeLogTest.java: ... Browse Code »

In ECLAfterChangelogTrim(), inverted 2 parameters to fix a test failure.
Used AutoRefactor plugin.
Extracted method waitForClose().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9394 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-09 14:57:44 +0000

48689015 Fixed a test. ... Browse Code »

Improved javadocs.


ExternalChangeLogTest.java:
In ECLTwoDomains(), fixed the test.
Extracted runModifyOperation() and createMods().



PersistentSearchChangeType.java, ChangeOperationType.java:
Improved javadocs.
Increased vertical density.
Code cleanup.

LDAPReplicationDomain.java:
Added comments / javadocs.

DraftCNDB.java:
Used static import to put if conditions on just one line.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9393 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-09 14:41:10 +0000

fcd7b9f8 ExternalChangeLogTest.java: ... Browse Code »

Knocked off 500 lines of code by extracting various methods.
This makes the code easier to read even though it is still sometimes puzzling.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9392 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-08-09 13:58:32 +0000