org.forgerock / org.forgerock.opendj

14 Aug, 2015

5 commits

  • 796eeff2   AbstractOperation.java: ... Browse Code » 
    Removed setResults(), used the more complete setResponseData() instead

*.java:
Called AbstractOperation.setResponseData().
Removed useless @inheritDoc javadocs.
Ran UCDetector
Grouped relevant fields together.
Cleaned up constructors.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12739 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • d58a8104   Removed code duplication, made code more readable ... Browse Code » 
    I think PasswordModifyExtendedOperation.processExtendedOperation() should call setMatchedDN() ?



AbstractOperation.java:
Extracted methods processOperationResult() and setResults().

PluginResult.java:
Extracted PluginResult.OperationResult interface out of several types.
Removed duplicate javadocs.
Used {@code} in javadocs.
Fixed typos.

SynchronizationProviderResult.java:
Now extends PluginResult.OperationResult + removed duplicate declarations.



*OperationBasis.java:
Called processOperationResult() and setResults().
Used static imports for DirectoryServer.*.
Removed useless comments.

LocalBackend*Operation.java
Called processOperationResult() and setResults().
Used static imports for DirectoryServer.*.
Removed useless comments.
Extracted method getAccessControlHandler().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12738 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • a8dc2293   Code cleanup ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12737 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • fcd0d6ff   Extracted method PasswordPolicyState.isLocked(). ... Browse Code » 
    PasswordPolicyState.java:
Extracted methods isLocked(), computeHighestTime() and newAttribute()

*.java:
Used PasswordPolicyState.isLocked().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12736 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • b032c912   Code cleanup: ... Browse Code » 
    - removed code duplication
- explicited code. this allowed to remove useless comments

LocalBackendModifyOperation.java:
Extracted methods mustCheckSchema(), processInitialSchema(), addIfAttributeValueExistsPreEncodedPassword(), addIfAttributeValueExistsNoPreEncodedPassword(), checkSchema(), isHumanReadable()
Removed unused method getName()

git-svn-id: https://svn.forgerock.org/opendj/trunk@12735 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

13 Aug, 2015

6 commits

12 Aug, 2015

7 commits

11 Aug, 2015

2 commits

10 Aug, 2015

1 commit

07 Aug, 2015

1 commit

05 Aug, 2015

1 commit

31 Jul, 2015

3 commits

30 Jul, 2015

6 commits

29 Jul, 2015

1 commit

  • 360d5d70   CR-7759 OPENDJ-2195 Move hand-written server docs ... Browse Code » 
    Hand-written docs depend on generated doc sources.
In order to move the hand-written docs out of the project,
the sources generated from project code must be in artifacts.

This initial patch creates the artifacts for man pages
and other generated documentation.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12703 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     

27 Jul, 2015

7 commits

  • 2ef4413e   OPENDJ-2159 CR-7527 PDB Storage is read-only when using verify-index tool on Windows. ... Browse Code » 
    The real problem is the server is killed before flushing has a chance to run and the fact operations for tree creation
do not appear in the journal file. Adding a flag to open tree operations so that we can skip errors on missing trees
while the storage is read only.
Moreover, verify-index was trying to verify indexes already known to be in degraded state, and printing weird stats
about them.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12702 41b1ffd8-f28e-4786-ab96-9950f0a78031
    fabiop
     
  • b2fd1d33   OPENDJ-2027 CR-7646 Change tools message on error ... Browse Code » 
    This commit makes all tools consistent in the way that if no arguments are provided on the command line (or only the non prompt argument for interactive tools), tool prints the error and the help reference message on error stream.
Changes details:
* ArgumentParser
** Create method displayMessageAndUsageReference(), this method is used by tools to print both an error message and the help usage reference message
** getHelpUsageReference() has been moved from SubCommandArgumentParser

* DSConfig
** displayErrorMessageAndUsageReference() has been moved to ArgumentParser

* CreateRCScript
** Moves the server root path check after the argument parsing in order to have a consistent error message if arguments are invalid.

* RebuildIndex
* VerifyIndex
** Removed dead code which printed usage if no args were provided (if so, an argument exception is raised before).

* MakeLDIF
** Add a main method for test purpose

* ArgumentParserToolsTestCase
** Test that tools are consistent if an invalid argument is provided or if no args are provided.

Tools modified by this commit are the following:
Server tools
* Does not print usage anymore
** backup
** base64 (only if no args are provided)
** control-panel
** create-rc-script
** dbtest
** dsjavaproperties
** dsreplication
** encode-password
** export-ldif
** import-ldif
** ldapcompare
** ldapdelete
** ldapmodify
** ldappasswordmodify
** ldapsearch
** ldif-diff
** ldifmodify
** ldifsearch
** make-ldif
** manage-account
** manage-tasks
** rebuild-index
** restore
** setup
** start-ds
** status
** stop-ds
** uninstall
** upgrade
** verify-index

* Usage reference message added
** base64 (only if invalid args are provided)

SDK tools
* Does not print usage anymore
** addrate
** makeldif

* Usage reference message added
** authrate
** ldapcompare
** ldapmodify
** ldappasswordmodify
** ldapsearch
** ldifdiff
** ldifmodify
** ldifsearch
** modrate
** searchrate

git-svn-id: https://svn.forgerock.org/opendj/trunk@12701 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • 1027841c   OPENDJ-2027 Refactor MakeLDIF integration test ... Browse Code » 
    * MakeLDIFITCase
** Inherits from ToolITCase
** Uses parent checkOutputStreams() method
** Add a test to check that -H displays help
** Code cleanup

git-svn-id: https://svn.forgerock.org/opendj/trunk@12700 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • a0d3a9ef   OPENDJ-2027 Rename MakeLDIFTestCase ... Browse Code » 
    * MakeLDIFTestCase -> MakeLDIFITCase to improve consistency in the package.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12699 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • f2326b64   Add missing return statement ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12698 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • 017b11aa   CR-7576 OPENDJ-1767 Show an example schema check ... Browse Code » 
    This patch documents an example app that checks an entry
against the directory server schema before attempting an LDAP add.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12697 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     
  • d1c78829   CR-7576 OPENDJ-1767 Show an example schema check ... Browse Code » 
    This patch adds an example app that checks an entry
against the directory server schema before attempting an LDAP add.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12696 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark