org.forgerock / org.forgerock.opendj

16 Jul, 2013

9 commits

7bbc9377 CR-2008 Fix for OPENDJ-1057: dsconfig reference does not accurately explain how … ... Browse Code »

…'components' of the 'OpenDJ configuration refence it refers to have to be used

git-svn-id: https://svn.forgerock.org/opendj/trunk@9249 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-16 14:51:34 +0000

476f24cd Fix build break ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9248 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-07-16 14:41:19 +0000

1615d261 BooleanHolder.java: ... Browse Code »

Forced specifying a default value in the ctor.
Implemented toString().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9247 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-16 14:22:03 +0000

4fc22897 CR-2005 Fix OPENDJ-1036 Cleanup passwords in memory? ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9246 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2013-07-16 14:12:20 +0000
f5f09ce1 CR-2007 Fix for OPENDJ-1047: Create a reference entry for windows-service.bat ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9245 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-07-16 14:00:23 +0000
84761877 Typos ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9244 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-07-16 13:54:58 +0000
a992555b CR-2006 Fix for OPENDJ-1046: Make paths to commands consistent throughout the doc set ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9243 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-07-16 12:55:19 +0000
16875d75 CR-2004 Fix for OPENDJ-1028: There are 3 ways of constructing ModifyRequests ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9242 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-07-16 10:56:34 +0000

d121f14d Respected the Single Responsibility Principle by splitting findAndSetMatchingDN(… ... Browse Code »

…) method into findMatchedDN() and setMatchedDN() methods.

Also fixed the checkstyle error.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9241 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-16 07:57:52 +0000

15 Jul, 2013

10 commits

9cd0b5a1 Extracted several time the method findAndSetMatchingDN(). We should look at movi… ... Browse Code »

…ng this code to a single reusable place.

LocalBackend*Operation.java:
Extracted method findAndSetMatchingDN() from the process*() methods. Tidied up the code to make it the same across all classes.

PasswordModifyExtendedOperation.java:
Extracted method findAndSetMatchingDN() from getEntryByDN().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9240 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-15 15:24:47 +0000

b7c41f16 TaskBackendTestCase.java: ... Browse Code »
```
Automated refactorings.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9239 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-15 15:09:23 +0000
21361e63 Remove unused messages ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9238 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2013-07-15 09:09:19 +0000
0032e7bb AssuredReplicationServerTest.java: ... Browse Code »
```
Code cleanup.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9237 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-15 09:09:09 +0000
0d57e736 Added test-output to svn:ignore property ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9236 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-15 08:47:29 +0000
965d44a2 Removed useless empty statements. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9235 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-15 08:45:56 +0000
de100d34 Created NullOutputStream.wrapOrNullStream() and used it in all tools instead of … ... Browse Code »
```
…duplicating the null checks everywhere.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9234 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-15 08:41:33 +0000
2fd5fcda Created NullOutputStream.wrapOrNullStream() and used it in all tools instead of … ... Browse Code »
```
…duplicating the null checks everywhere.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9233 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-15 08:40:31 +0000

8865c993 Refactoring on the LocalBackend*Operation classes: ... Browse Code »

- Extracted process*() methods from the processLocal*() methods for the LocalBackend*Operation classes.
- Transformed plain comments into javadocs.
- Used interfaces instead of concrete classes.
- Made all protected members be private.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9232 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-15 08:17:58 +0000

18206e98 Refactoring on the LocalBackend*Operation classes: ... Browse Code »

- Moved BooleanHolder out of LocalBackendAddOperation.
- Extracted process*() methods from the processLocal*() methods for the LocalBackend*Operation classes.
- Transformed plain comments into javadocs.
- Used interfaces instead of concrete classes.
- Made all protected members be private.
- Used StatisUtils.collectionToString()

git-svn-id: https://svn.forgerock.org/opendj/trunk@9231 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-15 07:44:51 +0000

12 Jul, 2013

8 commits

d10c2445 Fix checkstyle ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9230 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-07-12 15:59:00 +0000

17a5c707 Big refactoring of LocalBackendAddOperation, removed nearly 300 lines of code. ... Browse Code »

LocalBackendAddOperation.java:
Added helper class BooleanHolder.
Made all protected members be private.
Extracted method processAdd() out of the labeled code block in processLocalAdd() + replaced duplicated catch(DirectoryException) with just one.
Extracted method checkHasReadOnlyAttributes() out of processLocalAdd().
Extracted a second method addRDNAttributesIfNecessary() out of addRDNAttributesIfNecessary().
Extracted method checkAttributes() out of checkSchema().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9229 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-12 14:37:47 +0000

2d320f4f Fixed checkstyle error. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9228 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-12 14:28:32 +0000

2ad595af AciHandler.java: ... Browse Code »

More code simplifications.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9227 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-12 13:02:12 +0000

d5a5e573 AciContainer.java: ... Browse Code »

More code simplifications.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9226 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-12 12:48:45 +0000

2d68ad2d AciEvalContext.java, AciContainer.java: ... Browse Code »

Removed instance member isDenyEval, setDecidingAci() and setEvalReason(), replaced with setEvaluationResult() since both are always set at the same time.
Changed the impl of isDenyEval() to use the evalReason.

AciEffectiveRights.java:
Used AciEvalContext.setEvaluationResult().

AciHandler.java:
In testApplicableLists(), used AciEvalContext.setEvaluationResult().
Pushed negation down in if statements condition, merged common code between if and else clauses, collapsed if statements.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9225 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-12 12:12:39 +0000

a52e45f0 *.java: ... Browse Code »

Switched the use of collections concrete classes to interfaces.

AciHandler.java:
Switched use of collections concrete classes to interfaces.
Used the AutoRefactor plugin on the code to simplify the code.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9224 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-12 10:27:23 +0000

f93ba571 Fixing the build. ... Browse Code »

TestCaseUtils.java:
Added schemaBeforeStartingFakeServer and shutdownFakeServer().

AciBodyTest.java:
Added tearDown().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9223 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-12 07:54:55 +0000

11 Jul, 2013

4 commits

ce0ea010 EntryContainer.java: ... Browse Code »

Committed adding @Override separately from bigger, real changes.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9222 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-11 14:03:36 +0000

65491ed0 AbstractOperation.java: ... Browse Code »

Removed duplicated javadoc.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9221 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-11 13:51:55 +0000

89bf2a33 Fixed typo. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9220 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-11 13:30:04 +0000

a41ed246 Decouple some tests from running the server. ... Browse Code »

EnumRightTest.java:
Now implements DirectoryServerTestCase instead of the heavyweight AciTestCase.

AciBodyTest.java, EnumRightTest.java:
Now implements DirectoryServerTestCase instead of the heavyweight AciTestCase.
Need to fake the DirectoryServer.

TestCaseUtils.java:
Added startFakeServer() method to fake the DirectoryServer.

AttributeTypeConstants.java: ADDED


git-svn-id: https://svn.forgerock.org/opendj/trunk@9219 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-11 13:15:43 +0000

10 Jul, 2013

5 commits

a63f89d9 Fix comments ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9215 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2013-07-10 10:43:45 +0000
ea1421d0 CR-1977 Fix for OPENDJ-1005: Move server doc sources alongside other server code ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9213 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-07-10 09:28:19 +0000

8a3027f4 *.java: ... Browse Code »

Replaced collection concrete classes with interfaces.
Used javadocs instead of line comments.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9212 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-10 08:05:32 +0000

dba1aac8 Fixed checkstyle errors. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9211 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-10 07:41:31 +0000

5f176521 DirectoryServer.java: ... Browse Code »

In bootstrapAttributeSyntaxes(), extracted method initAndRegister() to remove duplicated code.

*.java:
Replaced collection concrete classes with interfaces.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9210 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-10 07:36:32 +0000

09 Jul, 2013

4 commits

5d530646 TestBackendImpl.java: ... Browse Code »

Extracted methods assertIndexContainsID() to remove duplicated code.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9208 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-09 14:38:32 +0000

b9e33fdd TestBackendImpl.java: ... Browse Code »

In initMatchedDNs(), fixed the test (variables were inverted).
Replaced concrete collections with interfaces.
Used Collections.singleton().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9207 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-09 14:09:23 +0000

ee4f67c9 Fix OPENDJ-1067: Tools are not properly picking up OPENDJ_JAVA_HOME variable. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9206 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-07-09 13:20:37 +0000
363453c6 Fixed typo. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9205 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-09 12:04:02 +0000