org.forgerock / org.forgerock.opendj

30 Apr, 2013

2 commits

  • 7c8b653b   AttrHistoricalMultiple.java, AttrHistoricalSingle.java: ... Browse Code » 
    Fixed Checkstyle issue.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8814 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 4866e539   Made code more generic: Used Map instead of HashMap in method signatures. ... Browse Code » 
    AttrHistoricalMultiple.java, AttrHistoricalSingle.java:
Changed comments to javadocs.
Fixed condition checking.
Inlined local variables and used the field instead.
Replaced use of Boolean with boolean.

We were looking at this code with Ludo and thought replacing the List with a Map had to be done in conjunction with breaking up AttrValueHistorical class to reduce memory usage (removing stroing unnecessary references).
The value field should be used as the key of the Map, and the value of the Map should contain an object with a reference to a ChangeNumber and a boolean indicating whether it is an update or a delete (Since they are mutually exclusive).

git-svn-id: https://svn.forgerock.org/opendj/trunk@8813 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

29 Apr, 2013

4 commits

26 Apr, 2013

3 commits

25 Apr, 2013

5 commits

  • 4023f7bd   Use factory methods from JsonValue. ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8805 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • 56254a0b   CR-1582 Remove reference to old known issues (part2) ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8804 41b1ffd8-f28e-4786-ab96-9950f0a78031
    csovant
     
  • 77009611   Use Maven to build OpenDJ server ... Browse Code » 
    
Trying to bring opendj server the most possible under maven.
Here maven-antrun-plugin is only used to generate the java files from our resources.
I am sure there are many glitches that need to be fixed in this file. We'll fix them over time. It is not ready to be used as prime build system yet. For example, no tests are run yet, or several resources are missing (.properties files, other??).
My goal is to bring opendj server under Sonar in order to see code coverage data.
Use "mvn -f pom-maven.xml clean install" to compile.

build.xml:
Renamed compileadmin target to generateadmin.mvn -f pom-maven.xml clean install
Added generatesources target depending on dynamicconstants, generatemessages and generateadmin.
In generateadmin target, pass down admin.src.dir property to generateadminsubtask.

pom-maven.xml: ADDED
Inspired from pom.xml.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8803 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • a1b5e7bf   OPENDJ-879 (CR-1603) Add HTTP access log ... Browse Code » 
    
Consolidated common code for the *Logger classes prior to implementing the HTTP access log.


AbstractLogger.java: ADDED
Pulled up from the *Logger classes.

AccessLogger.java, ErrorLogger.java, DebugLogger.java:
Now inherit from AbstractLogger.
Removed code pulled up into AbstractLogger: initializeErrorLogger(), isConfigurationAddAcceptable(), applyConfigurationAdd(), applyConfigurationChange(), isConfigurationDeleteAcceptable(), applyConfigurationDelete(), isJavaClassAcceptable(), getErrorPublisher().
Added the loggerStorage static variable.
Added a ctor + implemented getJavaClassPropertyDefinition() and getStorage().

LoggerConfigManager.java:
Replaced the calls to the various initialize*Logger() methods with calling initializeLogger().
Extracted method getLoggerInstance() and used it in all the other methods.


LogPublisherConfiguration.xml:
Pulled up the declaration of "java-class" property here from sub configurations.

AccessLogPublisherConfiguration.xml, DebugLogPublisherConfiguration.xml, ErrorLogPublisherConfiguration.xml, LogPublisherConfiguration.xml:
Replaced the declaration of "java-class" property by a property-override.

StaticUtils.java:
Added close(Collection<Closeable>)

git-svn-id: https://svn.forgerock.org/opendj/trunk@8802 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 73a94d25   Added modify functionality. ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8801 41b1ffd8-f28e-4786-ab96-9950f0a78031
    glennvl
     

24 Apr, 2013

9 commits

  • b1733934   Fix Javadoc typo. ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8799 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • 8e5e7f21   Replication Cleanup. ... Browse Code » 
    Tons of simplification of code, fix of typos, transformed comments to block.
In ReplicationDomain, changed synchronization of Map with a concurrentHashMap.
Fixed an error message in LDAPReplicationDomain
Removed mods from error message on Assured replication ack timeout (could be too large).
Added a log message on critical error (when reading change from RS db).
Removed some unused code.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8797 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ludo
     
  • b91866fa   OPENDJ-879 (CR-1600) Add HTTP access log ... Browse Code » 
    
Consolidated common code for the *LogPublisher classes prior to implementing the HTTP access log.


LogPublisher.java: ADDED
Unify all the *LogPublisher classes.
Implements Closeable.

AccessLogPublisher.java, DebugLogPublisher.java, ErrorLogPublisher.java:
Now implementing LogPublisher.
Pulled up isConfigurationAcceptable(), initialize*LogPublisher() renamed to initializeLogPublisher(), close(), getDN().
Removed syntactic/spaces differences between all these classes to better expose their commonalities.
Used Set and MAp interfaces rather than comcrete classes.

AccessLogger.java, ErrorLogger.java, DebugLogger.java:
In isJavaClassAcceptable() and getAccessPublisher(), replaced method invocations via reflection by direct method calls.

TextAccessLogPublisher.java, TextAuditLogPublisher.java, TextErrorLogPublisher.java, ThreadFilterTextErrorLogPublisher.java, TextDebugLogPublisher.java, ConsoleDebugLogPublisher.java:
Consequence of renaming the initialize*LogPublisher() methods, or generecizing the isConfigurationAcceptable() methods in their parent classes.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8792 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 3b5fcf26   Remove source files of the User Interface ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8791 41b1ffd8-f28e-4786-ab96-9950f0a78031
    jochenr
     
  • dfac0066   Tests cleanup ... Browse Code » 
    CryptoManagerTestCase.java:
Replaced use of reflection with use of direct method call.
Removed useless parentheses.


ExtensionTestUtils.java: ADDED
Factorizes common code among Extensions tests cases.

EntryDNVirtualAttributeProviderTestCase.java, EntryUUIDVirtualAttributeProviderTestCase.java, GoverningStructureRuleVirtualAttributeProviderTestCase.java, HasSubordinatesVirtualAttributeProviderTestCase.java, NumSubordinatesVirtualAttributeProviderTestCase.java, StructuralObjectClassVirtualAttributeProviderTestCase.java, SubschemaSubentryVirtualAttributeProviderTestCase.java:
Moved common code from 6 tests methods to ExtensionTestUtils + made tests delegate to the ExtensionTestUtils static methods.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8790 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 3e88ae44   Correction of header copyright. ... Browse Code » 
    Applied correct formatting style.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8789 41b1ffd8-f28e-4786-ab96-9950f0a78031
    glennvl
     
  • 49796789   Correction of header copyright. ... Browse Code » 
    Applied correct formatting style.
Removed hard-coded values: "opendj_db" in fillTablesList() and "dc=example,dc=com" in search requests to work dynamically.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8788 41b1ffd8-f28e-4786-ab96-9950f0a78031
    glennvl
     
  • 59e3181f   Correction of header copyright. ... Browse Code » 
    Applied correct formatting style.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8787 41b1ffd8-f28e-4786-ab96-9950f0a78031
    glennvl
     
  • c59517d9   Correction of header copyright. ... Browse Code » 
    Applied correct formatting style.
Class now extends AbstractSynchronousConnection instead of implementing Connection.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8786 41b1ffd8-f28e-4786-ab96-9950f0a78031
    glennvl
     

23 Apr, 2013

5 commits

  • 9e32281b   Added a comment. ... Browse Code » 
    Reordered the inner classes so they appear in the same order as they are executed.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8785 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 0ae97aec   OPENDJ-830 (CR-1595) Implement authentication and authorization for HTTP connection handler ... Browse Code » 
    
Fixed information leak on unsuccessful authentication: if the username was incorrect, the server was returning 404 (not found) instead of 401 (invalid credentials).
When authentication was unsuccessful, the client was not receiving a response and the connection was not closed leaving it hanging.


CollectClientConnectionFilter.java:
In DoBindResultHandler.handleErrorResult(), send back an authentication failure when a search on the user name does not return a unique result.
In sendAuthenticationFailure(), correctly complete the AsyncContext.
In doFilter(), removed the call to AsyncContext.setTimeout().

git-svn-id: https://svn.forgerock.org/opendj/trunk@8784 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • c5bdc0cd   OPENDJ-830 (CR-1591) Implement authentication and authorization for HTTP connection handler ... Browse Code » 
    Implemented the authentication steps (search username + bind) in an async way.

CollectClientConnectionsFilter.java:
Added inner classes HTTPRequestContext, DoBindResultHandler and CallDoFilterResultHandler to support async processing.
In doFilter(), built the HTTPRequestContext + removed some local parameters.
Extracted the methods doFilter(HTTPRequestContext, AuthenticationInfo), sendAuthenticationFailure() and onFailure() from doFilter(ServletRequest, ServletResponse, FilterChain).
In several methods, replaced several parameters by using just one HTTPRequestContext parameter.
Extracted method buildSearchRequest(String) from searchUniqueEntryDN().
Removed getAuthenticationInfo() and added the code back to doFilter().
Removed authenticate(), searchUniqueEntryDN() and bind(), and moved their corresponding code to the inner classes.
Added getAsyncContext().

CollectClientConnectionsFilter.java:
Removed the test for authenticate()

SdkConnectionAdapter.java:
Fixed two bugs

git-svn-id: https://svn.forgerock.org/opendj/trunk@8783 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • e3b8d09c   Fix typo in comment (Spotted when reviewing changes for OPENDJ-625) ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8782 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ludo
     
  • 7d1f57d8   Fix OPENDJ-625: ModifyDN does not allow the same (normalized) DN ... Browse Code » 
    Many thanks to Manuel Gaupp for the contributed patch and tests.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8781 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     

22 Apr, 2013

5 commits

  • a6dff714   One liner + tests: GeneralizedTime does not account for daylight savings when co… ... Browse Code » 
    …nverting Calendar to String.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8779 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • 703570f3   Fix error in build.xml. ... Browse Code » 
    Ant should be taken from ant.dir (within the workspace)

git-svn-id: https://svn.forgerock.org/opendj/trunk@8778 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ludo
     
  • 9b04ee7b   Minor improvement for OPENDJ-419: exposing SIMPLE and SASL authentication types in BindRequest. ... Browse Code » 
    
git-svn-id: https://svn.forgerock.org/opendj/trunk@8777 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • d89a6613   OPENDJ-832 Leverage the work queue for processing requests received on the HTTP connection handler ... Browse Code » 
    

Limited the number of concurrent operations per client connection.



SdkConnectionAdapter.java:
Changed the queueing strategy to BoundedWorkQueueStrategy.

BoundedWorkQueueStrategy.java: ADDED

AbandonOperationWrapper.java, xtendedOperationWrapper.java, UnbindOperationWrapper.java: ADDED

DirectoryServer.java:
Extracted checkCanEnqueueRequest() from enqueueRequest().
Added tryEnqueueRequest().

WorkQueue.java:
Pulled computeNumWorkerThreads() here from sub classes.
Added abstract method trySubmitOperation().
Added abstract getter getNumWorkerThreads().

ParallelWorkQueue.java:
Implemented trySubmitOperation() and getter getNumWorkerThreads().
Renamed getNumWorkerThreads() to computeNumWorkerThreads() + moved it to WorkQueue.

TraditionalWorkQueue.java:
Implemented trySubmitOperation() and getter getNumWorkerThreads().
Renamed getNumWorkerThreads() to computeNumWorkerThreads() + moved it to WorkQueue.
Extacted overloaded method submitOperation(Operation, boolean) from submitOperation(Operation).



ClientConnection.java, JmxClientConnection.java, InternalClientConnection.java, HTTPClientConnection.java, MockClientConnection.java, LDAPClientConnection.java:
Added abstract method isConnectionValid() + implemented it in subclasses.



02-config.ldif, HTTPConnectionHandlerConfiguration.xml:
Added property max-concurrent-ops-per-connection

git-svn-id: https://svn.forgerock.org/opendj/trunk@8776 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • b3107a80   OPENDJ-832 Leverage the work queue for processing requests received on the HTTP connection handler ... Browse Code » 
    

Limited the number of concurrent operations per client connection.



SdkConnectionAdapter.java:
Changed the queueing strategy to BoundedWorkQueueStrategy.

BoundedWorkQueueStrategy.java: ADDED

AbandonOperationWrapper.java, xtendedOperationWrapper.java, UnbindOperationWrapper.java: ADDED

DirectoryServer.java:
Extracted checkCanEnqueueRequest() from enqueueRequest().
Added tryEnqueueRequest().

WorkQueue.java:
Pulled computeNumWorkerThreads() here from sub classes.
Added abstract method trySubmitOperation().
Added abstract getter getNumWorkerThreads().

ParallelWorkQueue.java:
Implemented trySubmitOperation() and getter getNumWorkerThreads().
Renamed getNumWorkerThreads() to computeNumWorkerThreads() + moved it to WorkQueue.

TraditionalWorkQueue.java:
Implemented trySubmitOperation() and getter getNumWorkerThreads().
Renamed getNumWorkerThreads() to computeNumWorkerThreads() + moved it to WorkQueue.
Extacted overloaded method submitOperation(Operation, boolean) from submitOperation(Operation).



ClientConnection.java, JmxClientConnection.java, HTTPClientConnection.java, InternalClientConnection.java, MockClientConnection.java, LDAPClientConnection.java:
Added abstract method isConnectionValid() + implemented it in subclasses.



02-config.ldif, HTTPConnectionHandlerConfiguration.xml:
Added property max-concurrent-ops-per-connection


git-svn-id: https://svn.forgerock.org/opendj/trunk@8775 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

19 Apr, 2013

2 commits

18 Apr, 2013

4 commits

17 Apr, 2013

1 commit

  • 0134ef3c   Typo ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8766 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark