org.forgerock / org.forgerock.opendj

11 Mar, 2013

4 commits

84d2d8c0 AssuredReplicationServerTest.java: ... Browse Code »
```
Use javadocs everywhere possible.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8585 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-11 09:42:05 +0000
e63664d8 AssuredReplicationServerTest.java: ... Browse Code »
```
Changed method and variable names.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8584 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-11 08:23:55 +0000

4f9e97ed (CR-1392) AssuredReplicationServerTest: removed test anti pattern try/catch/fail… ... Browse Code »

… + added throws exception declarations: let the exception put the tests in error.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8583 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-11 08:19:24 +0000

4dab3fea Attempt to fix Jenkins build failures. The Jenkins task and thus directory contains spaces. ... Browse Code »
```
Added copyright statement to the file that didn't have any.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8582 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-03-11 07:38:45 +0000

08 Mar, 2013

9 commits

897fc122 Additional fix for OPENDJ-699: Implement DN reference mapping ... Browse Code »
```
Forgot to return after fast-path invocation.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8581 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-03-08 19:38:17 +0000
f4f96e05 Updating example for consistency. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8580 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
nessa
2013-03-08 18:57:48 +0000
5da3d0b4 Final fix for OPENDJ-699: Implement DN reference mapping ... Browse Code »
```
Added support for updates.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8579 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-03-08 18:20:41 +0000

1dce333a Partial fix for OPENDJ-699: Implement DN reference mapping ... Browse Code »

Add support for caching the results of read requests. This is required in order to avoid repeatedly performing the same searches when resolving DN references whilst processing query results. In order to minimize the risk of stale data the cache is thrown away after each REST request. At the moment the cache is limited to a maximum of 32 cached results.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8578 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-08 14:53:47 +0000

20dea677 AssuredReplicationServerTest.java: ... Browse Code »
```
Fixed wording and spelling.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8577 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-08 14:41:13 +0000

696b6a96 (CR-1387) Making AssuredReplicationServerTest.java more maintainable ... Browse Code »

AssuredReplicationServerTest.java:
In createReplicationServer(), added parameter int nbRS, removed some complicated code that I replaced with generateReplicationServerUrls() and addIfNotSame(). I think this explicits better what this code is doing.
Extracted method getRsPort(int rsId).

git-svn-id: https://svn.forgerock.org/opendj/trunk@8576 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-08 14:36:11 +0000

6e013d7b OPENDJ-802 rebuild-index online with "--clearDegradedState" should not disable the backend ... Browse Code »
```
- Fixed : with degraded state option, the backend is no more disabled/activated.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8575 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-03-08 09:45:51 +0000
541cca21 (CR-1380) AssuredReplicationServerTest.java Code cleanup ... Browse Code »
```
Removed some try / catch / fail test anti patterns.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8574 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-08 08:26:52 +0000

26f870df OPENDJ-803 (CR-1380) ldapsearch exits with wrong return code when server is down ... Browse Code »

LDAPConnection.java:
In connectToHost(), protected LDAPConnectionException from the general catch(Exception) which made our error code disappear.

LDAPSearchTestCase.java:
In getInvalidArgumentLists(), removed very easily 100 lines of code.
Properly used assertEquals() instead of assertTrue().

LDAPSearchNoServerTestCase.java: ADDED

git-svn-id: https://svn.forgerock.org/opendj/trunk@8573 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-08 08:20:00 +0000

07 Mar, 2013

12 commits

e1b479d7 CR-1382 Fix for fractional-replication testsuite on Windows ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8572 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-03-07 20:46:58 +0000
45710f5f CR-1378 Fix tasks/restore_db testcase on Windows and cleanup known issue in tasks testsuite ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8571 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-03-07 16:46:48 +0000
0c19c180 CR-1378 Fix tasks/restore_db testcase on Windows and cleanup known issue in tasks testsuite ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8570 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-03-07 16:46:28 +0000
cc7c70d7 [Opendj-738] CR-1377 Fix v1 and v2c snmp tests ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8569 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-03-07 16:44:36 +0000
aec544f0 Minor cleanup of sample config. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8568 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-03-07 15:59:29 +0000
d064ff77 Fix typo and code simplification ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8567 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-03-07 13:59:03 +0000
e0c6b182 Fix typos in comment, as well as refactor multi-line comments into blocks, and r… ... Browse Code »
```
…emove unused param from method.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8566 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-03-07 13:18:34 +0000

d1af4e45 OPENDJ-655 Message about authentication failures should contain identification o… ... Browse Code »

…f the user for easier analysis. 

Removed the bindDN from several error messages, covering simple bind and SASL bind.

core*.properties:
Updated relevant error messages + the places where they are used in the java code.

TextAccessLogPublisher.java:
In logBindResponse(), log the bindDN and SASL saslAuthUserDN if SASL is used.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8565 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-07 12:03:26 +0000

5fd1bfeb (CR-1376) Making ReplicationServerTest easier to maintain ... Browse Code »

ReplicationServerTest.java:
Extracted methods assertDeleteMsgBodyEquals() and assertDeleteMsgChangeNumberEquals().
Used the relevant assert*() methods instead of the al too generic assertTrue() in order to get real error messages in Jenkins.
Used foreach loops.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8564 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-07 11:51:27 +0000

c63ac006 Eclipse Workspace Mechanic: Lots of new/updated Eclipse parameters\n\n Eclipse S… ... Browse Code »
```
…ync: removed the non working JavaHL SVN adapter

git-svn-id: https://svn.forgerock.org/opendj/trunk@8563 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-07 10:13:19 +0000
1ddbeef5 Minor fix about style and typos. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8562 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-03-07 09:51:12 +0000

77d18595 OPENDJ-655 Message about authentication failures should contain identification o… ... Browse Code »

…f the user for easier analysis.

Fixed other occurences of copy/pasted code.

LocalBackendBindOperation.java:
In processBind(), fixed the code.
Extracted methods generateAccountStatusNotificationForLockedBindAccount() and getIntegerUserAttribute() to remove duplicated code.



git-svn-id: https://svn.forgerock.org/opendj/trunk@8561 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-07 09:02:37 +0000

06 Mar, 2013

12 commits

14d5bb0e Do the one fix to get a green build. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8560 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-06 16:55:44 +0000
16acfb22 Revert to revision 8555 of this file. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8559 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-06 16:54:27 +0000
374cadec Fix OPENDJ-797 Custom Password policy did not survive upgrade to 2.5.0-Xpress1 ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8558 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2013-03-06 16:49:21 +0000

c711abfe OPENDJ-655 Message about authentication failures should contain identification o… ... Browse Code »

…f the user for easier analysis.

Aargh so much code copy/pasted! Found and fixed other occurences.
Aargh I also broke the build again.

LocalBackendBindOperation.java:
In processBind(), fixed the code.
Extracted methods generateAccountStatusNotificationForLockedBindAccount() and getIntegerUserAttribute() to remove duplicated code.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8557 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-06 16:48:29 +0000

9bb6c8ff OPENDJ-770 Simplify the "rebuild-index --clearDegradedState" command output ... Browse Code »
```
- Fixed message.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8556 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-03-06 15:58:01 +0000

f77e2588 OPENDJ-655 Message about authentication failures should contain identification o… ... Browse Code »

…f the user for easier analysis.

What a convoluted code!! It is using a label and a block to implement a goto in Java. yuck!

LocalBackendBindOperation.java:
In processLocalBind(), extracted method processBind().
In the newly extracted method processBind(), converted the break stmts into return stmts + moved the switch stmt inside the try stmt (instead of the try/catch stmt in the switch stmt) + then removed useless if statements and break statements from the switch stmt.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8555 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-06 15:51:04 +0000

a39a6553 OPENDJ-66 (CR-1368) DS does not failover between replication servers in differen… ... Browse Code »

…t groups when configured explicitly for one of the groups 

ReplicationBroker.java:
In connectAsDataServer(), removed following useless if statement (root cause for the bug):
// Really no other server with our group id ?
if ((tmpRsGroupId == groupId) || (!someServersWithSameGroupId))

Extracted method connectToReplicationServer() in connectAsDataServer().
Removed hasSomeServerWithSameGroupId().

git-svn-id: https://svn.forgerock.org/opendj/trunk@8554 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-06 13:03:44 +0000

95a6d04c Partial fix for OPENDJ-699: Implement DN reference mapping ... Browse Code »

* add filter support: this required some refactoring of the core resource provider in order to ensure that an LDAP connection was available before attempting to resolve LDAP filter.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8553 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-06 11:57:52 +0000

6123a7a6 Cleanup ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8552 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-06 11:55:26 +0000
252286fe CR-1367 Fix dsml/04addmodaddsuite-add999 testcase and cleanup known issue in dsml testsuite ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8551 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-03-06 11:07:13 +0000

b49a3e7a Minor improvements: ... Browse Code »

* use encoder for JSON query filter assertion values
* handle unexpected exceptions when encoding and decoding values between JSON and LDAP
* improve Javadoc for Utils.accumulate and Utils.transform and make both methods more fault tolerant.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8550 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-06 10:01:06 +0000

9d883d41 OPENDJ-66 DS does not failover between replication servers in different groups w… ... Browse Code »

…hen configured explicitly for one of the groups 

java.net.Socket implements java.io.Closeable starting from Java 7 only :(


git-svn-id: https://svn.forgerock.org/opendj/trunk@8549 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-06 08:57:56 +0000

05 Mar, 2013

3 commits

a345dbb7 OPENDJ-66 (CR-1365) DS does not failover between replication servers in differen… ... Browse Code »

…t groups when configured explicitly for one of the groups 

Fixing checkstyle errors.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8548 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-05 17:06:37 +0000

53006813 OPENDJ-66 (CR-1365) DS does not failover between replication servers in differen… ... Browse Code »

…t groups when configured explicitly for one of the groups 

Fixing checkstyle errors.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8547 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-05 17:01:02 +0000

3881ced1 OPENDJ-66 (CR-1365) DS does not failover between replication servers in differen… ... Browse Code »

…t groups when configured explicitly for one of the groups 

Code cleanup.

ReplicationBroker.java
In computeBestReplicationServer(), fixed the screwed up for (ctr) switch (ctr){}; pattern + added keepBest() method.
In computeBestServerForWeight(), used BigDecimal.valueOf() instead of ctor.
In changeConfig(), fixed complicated condition.
Added javadocs, fixed variable naming, used foreach.

StaticUtils.java:
Added toIterable().

git-svn-id: https://svn.forgerock.org/opendj/trunk@8546 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-05 16:50:35 +0000