13 Dec, 2013

2 commits

  • 
    Most of the replace was done by global search replace from Eclipse via regular expressions.
    Individual files had incorrect headers or badly formatted ones, so some of them have been done manually by replacing the content between CDDL HEADER START and CDDL HEADER END.
    Some headers were quoting "trunk/opends/resource/legal-notices/CDDLv1_0.txt" while it should have been "legal-notices/CDDLv1_0.txt".
    
    
    Removed:
    - resource/legal-notices/OpenDS.LICENSE
    
    The following required manual changes:
    - build.xml
    - ext/checkstyle/opendj.sourceheader
    - resource/admin/java-utilities.xsl
    - src/build-tools/org/opends/build/tools/ProcessFilesForPackages.java
    - src/build-tools/windows/*
    - src/pkg/opends-dsml-gateway_proto.py
    - src/pkg/opends_proto.py
    - src/server/org/opends/server/util/ServerConstants.java
    - tests/staf-tests/functional-tests/shared/data/aci/aci_targattrfilter/add_aci18.ldif
    - tests/staf-tests/build.bat
    
    An incorrect header mentionning "exclude" instead of "include" in the copyright header existed for: tests/staf-tests/functional-tests/testcases/backends/backup/**/*
    
    Some files have no copyright headers at all. I did not update them. Here is some of them (more exist):
    - tests/staf-tests/functional-tests/shared/data/core/psearch/**/*.ref
    - tests/staf-tests/functional-tests/shared/data/core/psearch/**/delete.ldif
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9982 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • In testGenerateDoc(), added the @Test annotation + ensured the property set is cleared at the end of the test.
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9980 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

11 Dec, 2013

1 commit

  • 
    SetPropSubCommandHandler.java:
    Extracted methods parseValue() and getPropertyDefinition().
    
    Argument.java:
    Improved the toString() + javadocs.
    Minor code cleanups.
    
    ArgumentParser.java:
    Removed one parseArguments() method - never used.
    Extracted method indentAndWrap() to match SubCommandArgumentParser.
    Minor code cleanups.
    
    SubCommandArgumentParser.java:
    Removed one parseArguments() method - never used.
    Minor code cleanups.
    
    DsconfigOptionsTestCase.java:
    Added testGenerateDoc().
    Minor code cleanups.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9959 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

10 Dec, 2013

1 commit


09 Dec, 2013

7 commits


06 Dec, 2013

4 commits


05 Dec, 2013

4 commits


02 Dec, 2013

3 commits

  • 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9882 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 
    Hooked the ChangeNumberIndexer thread into our code base.
    Managed thread lifecycle.
    Added configuration to turn it on / off.
    Removed code that builds the ChangeNumberIndexDB from ECLServerHandler.
    
    
    ChangeNumberIndexer.java:
    Added clear() + doClear field for unit tests
    Used thread safe versions of MultiDomainServerState.
    In run(), merged all the try blocks to factorize the catch blocks + supported doClear + fixed a bug with the mediumConsistencyRUV.
    In removeCursor(), closed the cursors.
    Added removeAllCursors(), getPrecedingCSN().
    Renamed crossDomainDBCursor to nextChangeForInsertDBCursor and newCompositeDBCursor() to resetNextChangeForInsertDBCursor().
    Changed newCursors from ConcurrentMap<CSN, DN> to ConcurrentMap<Pair<DN, Integer>, CSN> to ensure minimum memory consumption.
    
    JEChangelogDB.java:
    Removed dbDirectoryName field.
    Added config, cnIndexer fields.
    Changed ctor to accept ReplicationServerCfg.
    In initializeDB(), shutdownDB(), clearDB(), publishUpdateMsg() took appropriate actions with the cnIndexer thread.
    Added setComputeChangeNumber().
    In getCursorFrom(), accept null parameter.
    In setPurgeDelay(), also call it on the cnIndexDB.
    
    
    MultiDomainServerState.java:
    Made implementation to be fully thread safe.
    Changed list from Map to ConcurrentMap + removed synchrnoized blocks.
    Renamed update(DN, ServerState) to replace(DN, ServerState).
    Added new version of update(DN, ServerState).
    
    ECLServerHandler.java:
    Removed assignNewChangeNumberAndStore() that builds the ChangeNumberIndexDB + adapted the code that was using this method.
    Used MultiDomainServerState.replace().
    
    
    ReplicationServerConfiguration.xml, ReplicationServerCfgDefn.properties:
    Added ds-cfg-compute-changenumber.
    
    ExternalChangelogDomainConfiguration.xml, ExternalChangelogDomainCfgDefn.properties:
    Updated description
    
    ReplicationServer.java:
    In applyConfigurationChange(), handled computeChangenumber config.
    Used MultiDomainServerState.replace().
    
    ChangelogDB.java:
    Added setComputeChangeNumber().
    
    ReplServerFakeConfiguration.java:
    Added isComputeChangenumber() and setComputeChangenumber().
    
    
    ExternalChangeLogTest.java:
    Adapted the code to the use of the ChangeNumberIndexer thread.
    
    JEChangeNumberIndexDB.java:
    Extracted runPurge() from run().
    
    
    ReplicationDbEnv.java
    Code cleanup.
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9881 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@9877 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     

28 Nov, 2013

2 commits

  • ExternalChangeLogTest.java:
    In searchOnChangelog(), added the parameters expectedNbEntries and testName + added a loop that tries during 1s to get the expected number of entries + moved assert on nb of returned entries here + moved calls to debugAndWriteEntries() here.
    Removed now unnecessary calls to Thread.sleep().
    Added assertSuccessful(LDAPMessage).
    Reduced scope for variables of type SearchResultDoneProtocolOp or SearchResultEntryProtocolOp + removed now useless statements making use of them.
    In ECLCompatWriteReadAllOps(), removed useless calls to toLowercase().
    Used Assertions.assertThat().
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9857 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • Added toString() for debuggging.
    Added or completed javadocs.
    Fixed a little bug in test code.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9852 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

23 Nov, 2013

3 commits


22 Nov, 2013

3 commits

  • ExternalChangeLogTest.java:
    In getAttributeValue(), added null check.
    Removed getAttributeValueOrNull() replaced by getAttributeValue().
    Removed checkPossibleValues(), replaced by checkValue().
    In readLastCookie(), called getAttributeValue() and removed useless catch.
    Extracted method checkAttributeValue().Used Assertions.as() - thanks Nicolas for the trick.
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9831 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • …ngeNumberIndexDB to ChangelogDB
    
    
    Properly implemented the medium consistency point algorithm with heartbeats and replicas going offline.
    
    
    ChangeNumberIndexer.java:
    Added replicasOffline instance field.
    Added methods replicaOffline() and removeCursor().
    In moveForwardMediumConsistencyPoint(), updated the code to cater for offline replica.
    
    ChangeNumberIndexerTest.java:
    Added new tests for heartbeat and replica going offline.
    
    
    MultiDomainServerState.java, ServerState.java:
    Added removeCSN().
    
    MultiDomainServerStateTest.java, ServerStateTest.java:
    Added more tests.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9828 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • …ngeNumberIndexDB to ChangelogDB
    
    
    Properly implemented the medium consistency point algorithm.
    
    
    ChangeNumberIndexer.java:
    Renamed instance field previousCookie to mediumConsistencyRUV and mediumConsistencyPoint to lastSeenUpdates.
    Added mediumConsistencyCSN instance field.
    Changed newCursors from ConcurrentMap<Integer, DN> to ConcurrentMap<CSN, DN>.
    In tryNotify(), removed CSN parameter.
    Added methods canMoveForwardMediumConsistencyPoint() and moveForwardMediumConsistencyPoint().
    
    
    ChangeNumberIndexerTest.java:
    Updated to reflect how the medium consistency point algorithm should work.
    
    MultiDomainServerState.java:
    Renamed get() to getCSN().
    
    ServerState.java
    In update(), updated javadocs + renamed local variables.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9827 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

21 Nov, 2013

3 commits

  • git-svn-id: https://svn.forgerock.org/opendj/trunk@9824 41b1ffd8-f28e-4786-ab96-9950f0a78031
    csovant
     
  • …ngeNumberIndexDB to ChangelogDB 
    
    Fixed imports for Pair class which has been moved recently.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9821 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • …ngeNumberIndexDB to ChangelogDB 
    
    
    
    ChangeNumberIndexer.java, ChangeNumberIndexerTest.java: ADDED
    
    CompositeDBCursor.java:
    Converted this class from holding a Collection of DBCursor to holding a Map of DBCursor with their associated data + generecized it.
    Added getData().
    
    CompositeDBCursorTest.java:
    Consequence of the change to CompositeDBCursor.
    Moved MyDBCursor inner class to its own file.
    
    SequentialDBCursor.java: ADDED
    Extracted from CompositeDBCursorTest.MyDBCursor.
    
    ReplicationDomainDB.java:
    Pulled up getCursorFrom(DN, int, CSN) in order to be able to mock it.
    
    MultiDomainServerState.java:
    In update(DN, CSN), simplified the code.
    In update(DN, serverState), made the code better.
    Added update(MultiDomainServerState), get(DN) and cover(DN, CSN).
    
    AttributeTypeConstants.java:
    Added support for 'o', 'ou' and 'dc'.
    
    JEReplicaDBCursor.java:
    In toString(), fixed display.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9820 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

19 Nov, 2013

1 commit

  • Added @Test annotation to testCover() - follow up of r9800
    
    ServerState.java:
    Little code cleanup.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9811 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

15 Nov, 2013

1 commit


14 Nov, 2013

4 commits


13 Nov, 2013

1 commit

  • ExternalChangeLogTest.java:
    Put the actual expected message.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9793 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac