20 Apr, 2015

5 commits

  • - Used java 7 diamond operator
    - Compressed javadocs to a single line
    - Added toString()
    - Extracted methods
    
    Argument.java:
    In getDoubleValues(), fixed copied/pasted error message.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12121 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@12120 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@12119 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • Extracted methods, used ternary operator.
    
    
    RebuildIndexPanel.java:
    Fixed a display bug in the newly extracted method allDisabled().
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12118 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@12117 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

18 Apr, 2015

1 commit


17 Apr, 2015

14 commits

  • * org.opends.guitools.controlpanel.ui.DBEnvironmentMonitoringPanel.java
    * org.opends.guitools.controlpanel.ui.RebuildIndexPanel.java
    * org.opends.guitools.controlpanel.ui.StatusGenericPanel.java
    * org.opends.guitools.controlpanel.ui.VerifyIndexPanel.java
    ** Add pluggable support
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12115 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • * org.opends.guitools.controlpanel.ui.VerifyIndexPanel.java
    ** Autorefactor'ed file
    ** Reformat
    ** Add final keyword
    ** Remove unecessary javadoc
    ** Use List instead of ArrayList as declarative type
    ** Reduce visibility when it was possible
    ** Extracted method:
    *** addNewElements(List<AbstractIndexDescriptor>, String label, List<CategorizedComboBoxElement>)
    
    * org.opends.guitools.controlpanel.ui.RebuildIndexPanel.java
    * org.opends.guitools.controlpanel.ui.StatusGenericPanel.java
    ** Autorefactor'ed file
    ** Reformat
    ** Add final keyword
    ** Remove unecessary javadoc
    ** Use Set instead of LinkedHashSet as declarative type
    ** Use Map instead of HashMap as declarative type
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12114 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@12113 41b1ffd8-f28e-4786-ab96-9950f0a78031
    austingene
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@12112 41b1ffd8-f28e-4786-ab96-9950f0a78031
    austingene
     
  • …looking at java stack gives only vague indications about the shutdown process.
    The new disk space monitor register itself as a listener for shutdown, and right after deregistering all disk monitors deregister itself.
    This is done before the MonitorProvider service itself has been shutdown, so there may be a lingering thread still scheduling the run() method.
    Do not deregister itself so that the shutdown process can cleanly stop everything.
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12111 41b1ffd8-f28e-4786-ab96-9950f0a78031
    fabiop
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@12110 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@12109 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ylecaillez
     
  • CR-6632: Apply  Jean-Noel suggestion
    Creates compile-time annotation to mark code that should be removed once the JE backend will be pluggable.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12108 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • CR-6632
    * org.opends.guitools.controlpanel.datamodel.BackendDescriptor.java
    ** Add PLUGGABLE as backend type
    * org.opends.guitools.controlpanel.util.ConfigFromDirContext.java
    ** Add the logic to read index definitions from a pluggable backend
    * org.opends.guitools.controlpanel.util.ConfigFromFile.java
    ** Add the logic to read index definitions from a pluggable backend
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12107 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • CR-6632
    As pluggable backend VLV indexes has no max block size property, we decided to remove this property in control panel VLV indexes management view.
    That means that all new VLV indexes created from the control panel will have the max-block-size default value assigned (4000)
    All files listed below are impacted by this update:
    
    * org.opends.guitools.controlpanel.datamodel.VLVIndexDescriptor.java
    * org.opends.guitools.controlpanel.ui.AbstractVLVIndexPanel.java
    * org.opends.guitools.controlpanel.ui.NewVLVIndexPanel.java
    * org.opends.guitools.controlpanel.ui.VLVIndexPanel.java
    * org.opends.guitools.controlpanel.util.ConfigFromDirContext.java
    * org.opends.guitools.controlpanel.util.ConfigFromFile.java
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12106 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • CR-6632
    To avoid LocalDBVLVIndexDefn.Scope dependency in UI, we need to use a general API for VLV index scopes.
    * org.opends.guitools.controlpanel.datamodel.VLVIndexDescriptor.java
    ** Replace LocalDBLocalDBVLVIndexCfgDefn.Scope by SearchScope as the scope class
    
    * org.opends.guitools.controlpanel.datamodel.VLVIndexTableModel.java
    ** Use IllegalArgumentException instead of RuntimeException to be more consistent.
    
    * org.opends.guitools.controlpanel.ui.VLVIndexPanel.java
    ** Use this change to take the opportunity to change the selectScopeRadioButton parameter type (use straight SearchScope instead of VLVIndexDescriptor)
    
    * org.opends.guitools.controlpanel.ui.AbstractVLVIndexPanel.java
    ** Use SearchScope in getScope() method
    ** Use straight return
    ** throw a IllegalStateException instead of fall back on WHOLE_SUBTREE.
    
    * Others modified files are consequences of modifications described above.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12105 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • CR-6632
    * org.opends.guitools.controlpanel,datamodel,IndexTypeDescriptor.java
    ** Create a new class to describe an index type
    ** Add some static helper function to convert from/to equivalent configuration classes.
    
    * org.opends.guitools.controlpanel.datamodel.IndexDescriptor.java
    ** Use IndexTypeDescriptor instead of JE IndexType
    
    * org.opends.guitools.controlpanel.datamodel.IndexTableModel.java
    * org.opends.guitools.controlpanel.ui.AbstractIndexPanel.java
    * org.opends.guitools.controlpanel.ui.AbstractVLVIndexPanel.java
    * org.opends.guitools.controlpanel.ui.IndexPanel.java
    * org.opends.guitools.controlpanel.ui.NewIndexPanel.java
    * org.opends.guitools.controlpanel.util.ConfigFromDirContext.java
    * org.opends.guitools.controlpanel.util.ConfigFromFile.java
    ** Consequences of the changes in IndexDescriptor
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12104 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • This commit fixes checktyle issues introduced in r12102
    * src/main/java/org/opends/server/extensions/FileBasedKeyManagerProvider.java
    ** Remove unused import (and reorganizes imports)
    * src/main/java/org/opends/server/util/SelectableCertificateKeyManager.java
    ** Add missing javadoc comment
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12103 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@12102 41b1ffd8-f28e-4786-ab96-9950f0a78031
    patrickdiligent
     

16 Apr, 2015

7 commits

  • Method for changes in backend configuration was incorrectly behaving as an add regardless of backend's current status.
    revise it to let changes go through to the backend and only act when backend is going from disabled to enabled.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12101 41b1ffd8-f28e-4786-ab96-9950f0a78031
    fabiop
     
  • Fix copyright and code cleanup on r12098 (Thanks to Matt and Jean-Noël for the review)
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12100 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@12099 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • In order to allow config.ldif edition without harcoded ldif lines, we need to have a may to use configuration framework classes in an offline mode.
    * org.forgerock.opendj.config.client.ldap.LDAPManagementContext.java
    ** Add newLDIFManagementContext(...) methods
    
    * org.opends.server.tools.ConfigureDS.java
    ** Update impacted client code
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12098 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • IndexInputBuffer.java:
    Simplified API:
    - removed getKeyLen(), ensureRecordFetched() and currentRecord()
    - renamed getIndexID() to currentRecord() + removed fetchKey()
    - made public methods package protected
    
    Importer.java:
    Changed call0() return type to void.
    Removed useless javadocs.
    In IndexDBWriteTask:
    - in call(), removed the ByteStringBuilder key
    - consequence of the changes to IndexInputBuffer
    - changed newImportIDSet(ByteStringBuilder key, Integer indexID) to newImportIDSet(ImportRecord).
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12097 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@12096 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ylecaillez
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@12095 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

15 Apr, 2015

2 commits


14 Apr, 2015

7 commits

  • As suggested by Ludo, in general it's better to do delete before add.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12092 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • git-svn-id: https://svn.forgerock.org/opendj/trunk@12091 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • * src/main/java/org/opends/guitools/controlpanel/util/ConfigFromFile.java
    ** Apply r12079 refqctoring
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12090 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • * org.opends.guitools.controlpanel.ui.VLVIndexPanel.java
    * org.opends.guitools.controlpanel.ui.AbstractVLVIndexPanel.java
    * org.opends.guitools.controlpanel.ui.NewVLVIndexPanel.java
    * org.opends.guitools.controlpanel.task.DeleteIndexTask.java
    ** Use List instead of ArrayList as declarative type
    ** Reformat
    ** Add final keyword
    ** Add @Override annotations
    ** Remove unecessary javadoc
    
    * org.opends.guitools.controlpanel.task.Task.java
    ** In method getConfigCommandLineArguments():
    *** Returns a List instead of ArrayList
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12089 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • * VLVIndexDescriptor.java
    ** Add final keyword
    ** Reformat
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12088 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • * indexDescriptor.java
    ** Add final keyword
    ** Add override annotations
    ** Extract local constants for database indexes
    ** Reformat and improve a bit javadoc
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12087 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • This change is a backport to opendj-server-legacy of the bug fixing done in opendj-config at revision r11503.
    * org.opends.server.client.spi.Driver
    ** Fix bug in config framework that prevented management of Persistit backend indexes using dsconfig.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12086 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     

13 Apr, 2015

1 commit


10 Apr, 2015

3 commits