org.forgerock / org.forgerock.opendj

16 Jul, 2015

6 commits

15 Jul, 2015

9 commits

  • e288284d   Fix checkstyle error ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12676 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 38677e98   Code cleanup ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12675 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 06f210d5   AutoRefactor'ed use StringBuilder ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12674 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • c0733cc6   length <= 0 -> length == 0 ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12673 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 44ff2e74   Autorefactor'ed Map usage ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12672 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 83086d0b   OPENDJ-2027 Print usage on stderr after error ... Browse Code » 
    * src/main/java/org/opends/server/tools/RebuildIndex.java
** Remove an unreachable use case
** Print usage on error stream after an error instead of output stream
* src/main/java/org/opends/server/tools/VerifyIndex.java
** Print usage on error stream after an error instead of output stream

git-svn-id: https://svn.forgerock.org/opendj/trunk@12671 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • eb741427   OPENDJ-2027 Code cleanup ... Browse Code » 
    Preparatory work for OPENDJ-2027:
* src/main/java/org/opends/server/backends/jeb/DBTest.java
** Reduce visibilty of printMessage and rename it to printErrorMessage to improve code consistency
* src/main/java/org/opends/server/tools/ConfigureWindowsService.java
* src/main/java/org/opends/server/tools/StartWindowsService.java
* src/main/java/org/opends/server/tools/StopWindowsService.java
** Autorefactor'ed file + format
** Use straigt return
** Remove unecessary comment
** Additionnal minor cleanup
** Extract method serviceState() to avoid multiple nullchecks on output streams.
* Changes in other files are related to the serviceState() extracted method

git-svn-id: https://svn.forgerock.org/opendj/trunk@12670 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • f195d1f5   OPENDJ-1353 Fix setup in quiet mode mode ... Browse Code » 
    * org/opends/server/tools/InstallDS.java
** migrate old print command to println which includes isQuiet() check.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12669 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • dcfc38b5   Code cleanup ... Browse Code » 
    * src/main/java/org/opends/quicksetup/QuickSetupLog.java
** Autorefactor'd file + reformat
** Rename static elements to uppercase
** Factorize code a bit

* src/main/java/org/opends/guitools/controlpanel/ui/BrowseSchemaPanel.java
** Autorefactor'ed file + Reformat
** Minor code cleanup
** Add final keyword
** Reduce visibility when it was possible
** Use straight return
** Use interface instead of concrete class for local variable which are collections
** Use ternary operator
** Format javadoc
** Add some generic statement to prevent warnings

* src/main/java/org/opends/guitools/controlpanel/task/DeleteSchemaElementsTask.java
** Consequences of cleanup done in BrowseSchemaPanel.java

git-svn-id: https://svn.forgerock.org/opendj/trunk@12668 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     

14 Jul, 2015

1 commit

13 Jul, 2015

7 commits

10 Jul, 2015

11 commits

  • 2ab5dec8   OPENDJ-2211 Searches using debugsearchindex return NOT-INDEXED when index cursor limits are exceeded ... Browse Code » 
    In cases where we give on the index because of index cursor limits being hit, reported at least a LIMIT-EXCEEDED in debugsearchindex.

Over the shoulder review by Jean-Noel and Yannick.



git-svn-id: https://svn.forgerock.org/opendj/trunk@12657 41b1ffd8-f28e-4786-ab96-9950f0a78031
    fabiop
     
  • 9797a7ce   Code cleanup ... Browse Code » 
    
DirectoryServer.java:
Changed getAttributeType(String lowerName, boolean returnDefault) to getAttributeTypeOrDefault(String lowerName).
Renamed getAttributeType(String lowerName, String upperName) to getAttributeTypeOrDefault(String lowerName, String upperName).

DirectoryConfig.java:
Removed getAttributeType(String lowerName, boolean returnDefault), used DirectoryServer methods instead.

*.java:
Changed all code that was calling DirectoryServer.getAttributeType(lowerName, false) to directly call the more explicit DirectoryServer.getAttributeType(lowerName).

SubjectAttributeToUserAttributeCertificateMapper.java:
In initializeCertificateMapper(), isConfigurationChangeAcceptable() and applyConfigurationChange(), extracted methods buildAttributeMap() and getUserBaseDNs() to remove code duplication

git-svn-id: https://svn.forgerock.org/opendj/trunk@12656 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 4d9dec6b   Fix checkstyle error ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12655 41b1ffd8-f28e-4786-ab96-9950f0a78031
    fabiop
     
  • f5f557f0   IndexBuffer.java: ... Browse Code » 
    Augmented javadoc with a comment from CR-7560

git-svn-id: https://svn.forgerock.org/opendj/trunk@12654 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 5698722a   Fix checkstyle error ... Browse Code » 
    
git-svn-id: https://svn.forgerock.org/opendj/trunk@12653 41b1ffd8-f28e-4786-ab96-9950f0a78031
    fabiop
     
  • e5c3737b   More code cleanup ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12652 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 77a85143   ID2entry.java: ... Browse Code » 
    Removed code duplication and dead code

git-svn-id: https://svn.forgerock.org/opendj/trunk@12651 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • cd059c04   Code cleanup ... Browse Code » 
    DirectoryServer.java:
Added getAttributeType(String lowerName, String upperName).

*.java:
Used the newly added DirectoryServer.getAttributeType(String lowerName, String upperName).
Used more DirectoryServer.getAttributeType(String, boolean).

git-svn-id: https://svn.forgerock.org/opendj/trunk@12650 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 65b74d3a   Upgrade PersistIt to 4.1.0-SNAPSHOT ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12649 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ylecaillez
     
  • f240df21   PDB: Reduce probability of transaction conflict (CR-7560) ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12648 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ylecaillez
     
  • 48e04737   Code cleanup ... Browse Code » 
    
AttributeBuilder.java:
Removed setInitialCapacity(), (no op)
Added addAllStrings() and made use of it.

Attributes.java:
Changed create(String attributeName, String firstValueString, String... otherValueStrings) to create(String attributeName, String... valueStrings) + made use of it.

*.java:
Removed javadocs duplicating javadocs from overridden methods.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12647 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

09 Jul, 2015

6 commits

  • 4d3bda98   OPENDJ-2171 CR-7414 import-ldif in append mode should not reset index state ... Browse Code » 
    Regardless of options specified to import-ldif, all indexes are systematically set as not trusted before importing and reset to trusted once it's finished. 
On the other hand if the suffix is simply appended to, indexes not up to date with the data should not be set to trusted, since they may end up with partial data. 

Before import we should set all trusted indexes as candidates for updates, but leave not trusted indexes alone.
In order to do that, use index lists from Suffix, building the list of indexes to update taking into account the append flag: if it is specified only consider trusted indexes. 
Import code should only get index information from the Suffix. 

Rebuild index should still be based on the EntryContainer though, since we are managing indexes directly.


git-svn-id: https://svn.forgerock.org/opendj/trunk@12646 41b1ffd8-f28e-4786-ab96-9950f0a78031
    fabiop
     
  • e6dd34ee   Apply code simplifications related to DN2ID and DN2URI from r12247, see CR-7414 ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12645 41b1ffd8-f28e-4786-ab96-9950f0a78031
    fabiop
     
  • 608ca70b   Code cleanup ... Browse Code » 
    
*.java:
Used CollectionUtils.newArrayList() as much as possible.
Made use of LDAPAttribute constructors which accepts Strings. This avoids String to ByteString conversion in client code since the constructors handle it.

AttributeBuilder.java:
Added toAttributeList() to avoid the need for client code to create a List itself.

Attributes.java:
Added several createAsList() to avoid the need for client code to create a List itself.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12642 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 37e0e591   OPENDJ-2187 Add missing server Javadoc to OpenDJ site ... Browse Code » 
    Revert r12639

git-svn-id: https://svn.forgerock.org/opendj/trunk@12640 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     
  • 4a9e79b6   OPENDJ-2187 Add missing server Javadoc to OpenDJ site ... Browse Code » 
    This patch aims to fix the connection to upload the site.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12639 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     
  • 21cd3fa5   AutoRefactor'ed Collections ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12637 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac