org.forgerock / org.forgerock.opendj

21 Aug, 2015

2 commits

  • a1a9d57a   AttrHistoricalMultiple.java, AttrValueHistorical.java: ... Browse Code » 
    Improved toString()

git-svn-id: https://svn.forgerock.org/opendj/trunk@12765 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • edd83f36   Fix random test failure. ... Browse Code » 
    Tests methods were not properly isolated. The sequence testUpdateDeletedIDs() followed by testUpdateAddedIDs() caused the following failure:
17:42:32                  T E S T   F A I L U R E ! ! !
17:42:32 
17:42:32 Failed Test:  org.opends.server.backends.pluggable.DefaultIndexTest#testUpdateAddedIDs
17:42:32 Failure Cause:  java.lang.AssertionError: 
17:42:32 Expecting:
17:42:32  <[]>
17:42:32 to contain:
17:42:32  <[1, 2, 3, 4]>
17:42:32 but could not find:
17:42:32  <[1, 2, 3, 4]>
17:42:32 
17:42:32     org.opends.server.backends.pluggable.Utils.assertIdsEquals(Utils.java:39)
17:42:32     org.opends.server.backends.pluggable.Utils.assertIdsEquals(Utils.java:51)
17:42:32     org.opends.server.backends.pluggable.DefaultIndexTest.testUpdateAddedIDs(DefaultIndexTest.java:76)



DefaultIndexTest.java:
In setUp(), use @BeforeMethod annotation (rather than @BeforeTest)


git-svn-id: https://svn.forgerock.org/opendj/trunk@12764 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

20 Aug, 2015

4 commits

19 Aug, 2015

3 commits

18 Aug, 2015

3 commits

  • 16d24293   AttrHistoricalSingle.java: ... Browse Code » 
    In processLocalOrNonConflictModification(), made the code more explicit + prevented double assignment

*.java:
Added toString().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12755 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • fbd5487a   Changed AttrHistorical.getValuesHistorical() return type to match usage ... Browse Code » 
    
AttrHistorical.java:
In getValuesHistorical(), changed return type from Map<AttrValueHistorical, AttrValueHistorical> to Set<AttrValueHistorical> - to match the usage.

AttrHistoricalMultiple.java:
Consequence of the change to AttrHistorical.getValuesHistorical().
In delete(Attribute, CSN), now call delete(ByteString, CSN).
In add(Attribute, CSN), now call add(ByteString, CSN).
Extracted method update(CSN, AttrValueHistorical).
In conflictAdd(), changed return type to void since it was never used.
Removed javadoc copied from supertype + useless @inheritDoc.
Reduced method's visibilities.

AttrHistoricalSingle.java
Consequence of the change to AttrHistorical.getValuesHistorical().
Removed javadoc copied from supertype + useless @inheritDoc.
Used static import for HistAttrModificationKey.*.
Extracted method getSingleValue().

EntryHistorical.java:
Consequence of the change to AttrHistorical.getValuesHistorical().
Extracted method toOptionsString().
In newInstanceFromEntry(), reduced scope of variables.

AttrInfoTest.java:
Consequence of the change to AttrHistorical.getValuesHistorical().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12754 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 3a418f54   Replaced uses of StringBuilder.append(Utils.joinAsString(String, Collection)) wi… ... Browse Code » 
    …th the more efficient Utils.joinAsString(StringBuilder, String, Collection).

git-svn-id: https://svn.forgerock.org/opendj/trunk@12753 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

17 Aug, 2015

9 commits

  • e52f59c4   DirectoryServer.java: ... Browse Code » 
    Removed fields duplicating the ones from CoreSchema + replaced them with the getters directly delegating to CoreSchema methods.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12752 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • e6a7de5a   DatabaseEnvironmentMonitor.java: ... Browse Code » 
    Remove class which has been moved to org.opends.server.backends.jeb

git-svn-id: https://svn.forgerock.org/opendj/trunk@12751 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 2bfac168   ChangelogBackendTestCase.java: ... Browse Code » 
    In assertChangelogAttributesInRootDSE(), removed always true parameter "isECLEnabled".

ReplicationTestCase.java:
Code cleanup

git-svn-id: https://svn.forgerock.org/opendj/trunk@12750 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • b5491f8a   CR-7933 OPENDJ-2240 Handle lack of spaces at end of attributeType values ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12747 41b1ffd8-f28e-4786-ab96-9950f0a78031
    cjr
     
  • 0c9bc6fc   opendj-server-legacy module: replace fest by assertj ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12746 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 7c871b0b   Code cleanup ... Browse Code » 
    Fix a bug in RootDSEBackend.getRootDSE().

RootDSEBackend.java:
In getRootDSE(), fix a bug with supportedAuthPWSchemes which wrongly referred to supportedSASLMechanism attribute.
In addAttribute(), renamed publicNamingContextAttr parameter to attribute
Used interfaces for collections rather than concrete classes.
Removed useless @inheritDoc javadoc.

Task.java:
Extracted methods getTime(), compareTimes(), 
In execute(), simplified code.

LDAPReplicationDomain.java, ReplicationDomainMonitorData.java:
Code cleanups

git-svn-id: https://svn.forgerock.org/opendj/trunk@12745 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 0e49b07f   Fix incorrect error message in replication ... Browse Code » 
    replication*.properties:
ERR_RSQUEUE_DIFFERENT_MSGS_WITH_SAME_CN => ERR_RSQUEUE_DIFFERENT_MSGS_WITH_SAME_CSN

git-svn-id: https://svn.forgerock.org/opendj/trunk@12744 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 5649077e   OPENDJ-2233 CR-7906 Changelog cursoring seems to rely on exception handling too much. ... Browse Code » 
    Avoid try to reading past EOF, as it generates too many exceptions unnecessarily.


git-svn-id: https://svn.forgerock.org/opendj/trunk@12743 41b1ffd8-f28e-4786-ab96-9950f0a78031
    fabiop
     
  • 695b1a7f   Code improvements ... Browse Code » 
    
DN2URI.java:
Do not decode DN when only the list of URIs is needed:
- extracted methods decodeUrisOnly(), decode0(), decodeDN(), decodeUris()
- used Map.Entry instead of Pair because it maps exactly to the role of DN2URI index (where DN is the key and List of URIs is the value).


EntryContainer.java:
Extracted method getNumberOfEntriesInBaseDN0() to avoid creating a sub transaction (used by RootContainer).

VerifyJob.java:
Used SuffixContainer constants.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12742 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

14 Aug, 2015

7 commits

  • 97c9b5de   Code cleanup ... Browse Code » 
    

HistoricalAttributeValue.java:
Added toString() for easier debugging.

HistoricalAttributeValueTestCase.java: CREATED

HistAttrModificationKey.java:
In DELATTR, fixed a bug.
In decodeKey(), simplified the code.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12741 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 0ae95159   Fix randomness in JmxPrivilegeTestCase. ... Browse Code » 
    Many thanks Fabio for finding the problem!!



JmxTestCase.java:
In getJmxConnectionHandler(), also wait for the rmiConnector to be available before proceeding.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12740 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 796eeff2   AbstractOperation.java: ... Browse Code » 
    Removed setResults(), used the more complete setResponseData() instead

*.java:
Called AbstractOperation.setResponseData().
Removed useless @inheritDoc javadocs.
Ran UCDetector
Grouped relevant fields together.
Cleaned up constructors.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12739 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • d58a8104   Removed code duplication, made code more readable ... Browse Code » 
    I think PasswordModifyExtendedOperation.processExtendedOperation() should call setMatchedDN() ?



AbstractOperation.java:
Extracted methods processOperationResult() and setResults().

PluginResult.java:
Extracted PluginResult.OperationResult interface out of several types.
Removed duplicate javadocs.
Used {@code} in javadocs.
Fixed typos.

SynchronizationProviderResult.java:
Now extends PluginResult.OperationResult + removed duplicate declarations.



*OperationBasis.java:
Called processOperationResult() and setResults().
Used static imports for DirectoryServer.*.
Removed useless comments.

LocalBackend*Operation.java
Called processOperationResult() and setResults().
Used static imports for DirectoryServer.*.
Removed useless comments.
Extracted method getAccessControlHandler().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12738 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • a8dc2293   Code cleanup ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12737 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • fcd0d6ff   Extracted method PasswordPolicyState.isLocked(). ... Browse Code » 
    PasswordPolicyState.java:
Extracted methods isLocked(), computeHighestTime() and newAttribute()

*.java:
Used PasswordPolicyState.isLocked().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12736 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • b032c912   Code cleanup: ... Browse Code » 
    - removed code duplication
- explicited code. this allowed to remove useless comments

LocalBackendModifyOperation.java:
Extracted methods mustCheckSchema(), processInitialSchema(), addIfAttributeValueExistsPreEncodedPassword(), addIfAttributeValueExistsNoPreEncodedPassword(), checkSchema(), isHumanReadable()
Removed unused method getName()

git-svn-id: https://svn.forgerock.org/opendj/trunk@12735 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

13 Aug, 2015

6 commits

12 Aug, 2015

6 commits