org.forgerock / org.forgerock.opendj

06 Dec, 2013

13 commits

05 Dec, 2013

13 commits

  • 9f761222   If the server hangs, dump stack trace of the server process before kill it ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9921 41b1ffd8-f28e-4786-ab96-9950f0a78031
    csovant
     
  • cf70042c   Added testcase for issue OPENDJ-1192 ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9920 41b1ffd8-f28e-4786-ab96-9950f0a78031
    csovant
     
  • ef97f122   Eliminate duplicate code by creating SchemaValidationPolicy#adaptSchemaForValidation. ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@9919 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • 54fd8d4a   OPENDJ-1174 Transfer responsibility for populating the ChangeNumberIndexDB to ChangelogDB ... Browse Code » 
    Code review: Matthew Swift



Fixing failing unit tests, removed the following stack trace which makes test and code fail.

   [testng] Failed Test:  org.opends.server.replication.plugin.HistoricalCsnOrderingTest#buildAndPublishMissingChangesSeveralEntriesTest
   [testng] Failure Cause:  com.sleepycat.je.ThreadInterruptedException: (JE 5.0.97) Environment must be closed, caused by: com.sleepycat.je.ThreadInterruptedException: Environment invalid because of previous exception: (JE 5.0.97) <https://builds.forgerock.org/job/OpenDJ%20-%20trunk%20-%20postcommit/ws/build/unit-tests/package-instance/HistoricalCsnOrdering> Thread interrupted prior to logging the commit THREAD_INTERRUPTED: InterruptedException may cause incorrect internal state, unable to continue. Environment is invalid and must be closed.
   [testng]     com.sleepycat.je.ThreadInterruptedException.wrapSelf(ThreadInterruptedException.java:99)
   [testng]     com.sleepycat.je.dbi.EnvironmentImpl.checkIfInvalid(EnvironmentImpl.java:1594)
   [testng]     com.sleepycat.je.Database.checkEnv(Database.java:2154)
   [testng]     com.sleepycat.je.Database.getDatabaseName(Database.java:1939)
   [testng]     org.opends.server.replication.server.changelog.je.ReplicationDbEnv.closeDB(ReplicationDbEnv.java:457)
   [testng]     org.opends.server.replication.server.changelog.je.ReplicationDbEnv.shutdown(ReplicationDbEnv.java:435)
   [testng]     org.opends.server.replication.server.changelog.je.JEChangelogDB.shutdownDB(JEChangelogDB.java:409)
   [testng]     org.opends.server.replication.server.ReplicationServer.shutdown(ReplicationServer.java:702)
   [testng]     org.opends.server.replication.server.ReplicationServer.remove(ReplicationServer.java:1028)
   [testng]     org.opends.server.replication.plugin.HistoricalCsnOrderingTest.buildAndPublishMissingChangesSeveralEntriesTest(HistoricalCsnOrderingTest.java:308)



DirectoryThread.java:
In initiateShutdown(), removed the call to Thread.interrupt() added in r9911.

ChangeNumberIndexer.java:
Overrode initiateShutdown() to stop this thread on shutdown: used notify() to wake up the thread if it was waiting.
In run(), checked whether shutdown has been initiated for this thread before calling wait(): this protects against missed notifications.

JEReplicaDB.java:
In run(), removed call to Thread.currentThread().interrupt().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9918 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 7b86ee1d   Editorial fix ... Browse Code » 
    Thanks, Chris Ridd!

git-svn-id: https://svn.forgerock.org/opendj/trunk@9917 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     
  • b126c73d   OPENDJ-1174 Transfer responsibility for populating the ChangeNumberIndexDB to ChangelogDB ... Browse Code » 
    Fixed ValidateConfigDefinitionsTest failure.

02-config.ldif:
Added ds-cfg-compute-change-number to ds-cfg-replication-server object class.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9916 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 8191c896   Updated test to match r9887. ... Browse Code » 
    JEReplicaDBTest.java:
In JEReplicaDB.generateCursorFrom(), changed the asserts: no exception is thrown anymore, but the cursor appears empty now.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9915 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • cf212891   Fixing NullPointerException in tests. ... Browse Code » 
    ReplServerFakeConfiguration.java:
In ctor, if no dirName is provided use "changelogDb" as the path where to store the changelogDB. This is restoring behaviour lost with r9881.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9914 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • f08e2e23   OpenDJ 3 : config framework ... Browse Code » 
    Reducing compilation errors in org.opends.server.admin packages
 
* Remove AdministrationConnector and AdministrationDataSync classes
** These classes does not belong to the config framework

* Remove methods that are no more needed in DirectoryServer stub 

git-svn-id: https://svn.forgerock.org/opendj/trunk@9913 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     
  • 685bc523   OpenDJ 3 : config framework ... Browse Code » 
    Reducing compilation errors in org.opends.server.admin packages
 
* Add org.opends.server.config.ConfigEntry class from the server
** Keep only code related to registering/deregistering listeners
** Intent is to manage entries relationships in a memory backend / LDIF backend 
     instead of reproducing the hierarchical structure into ConfigEntry class as
     done currently in the server

* Add config.properties file from the server to get config messages

* Other minor changes

git-svn-id: https://svn.forgerock.org/opendj/trunk@9912 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     
  • bc12002c   #2 Fixed a readWriteLock deadlock happening in tests on calling ChangelogDB.remo… ... Browse Code » 
    …veDB() which then calls ReplicationDB.shutdown().
Code is blocked acquiring a writeLock on the dbCloseLock, but a readLock is never unlocked.
Debugging showed that the ChangeNumberIndexDB is holding a cursor on a ReplicationDB, said cursor holds the readLock.
Despite the ChangeNumberIndexer thread being asked to initiateShutdown(), the thread is waiting indefinitely for new changes which will never come.

DirectoryThread.java:
In initiateShutdown(), call interrupt() to ensure the thread will be interrupted if it calls Object.wait() before checking whether it needs to shutdown, or if it is already waiting.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9911 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 74056426   ReplicationServerDomain.java: ... Browse Code » 
    Removed change which was not intended for commit, at least not for now.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9910 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 08fe888b   Fixed a readWriteLock deadlock happening on calling ChangelogDB.removeDB() which… ... Browse Code » 
    … then calls ReplicationDB.shutdown().
Code is blocked acquiring a writeLock on the dbCloseLock, but a readLock is never unlocked.
Debugging showed that the ChangeNumberIndexDB is holding a cursor on a ReplicationDB, said cursor holds the readLock.
The solution is to not try to call ReplicationDB.shutdown() in ReplicationServerDomain.shutdownDomain() because it will be closed by JEChangelogDB.shutdownDB().


ReplicationServerDomain.java:
Removed the call to ReplicationDB.shutdownDomain(DN).

ReplicationDomainDB.java, JEChangelogDB.java:
Removed shutdownDomain(DN) which was never used outside of a complete shutdown of the ReplicationServer.
Inlined innerShutdownDomain().

JEReplicaDBCursor.java:
In next(), extracted a local variable to protect against a concurrent update to the cursor field.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9909 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

04 Dec, 2013

11 commits

03 Dec, 2013

3 commits