org.forgerock / org.forgerock.opendj

10 Apr, 2015

8 commits

acd443cf OPENDJ-1929 Code cleanup ... Browse Code »

* IndexPanel.java
** Reformat
** Add final keyword
** Use list as declarative type

git-svn-id: https://svn.forgerock.org/opendj/trunk@12078 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 10:42:58 +0000

5fff3286 OPENDJ-1932 Code cleanup ... Browse Code »

* NewBaseDNPanel.java
** validateAutomaticallyGenerated(final Set<LocalizableMessage> errors)
*** Extract local constants
*** Add final keyword

* StatusGenericPanel.java
** checkIntValue(Collection<LocalizableMessage> errors, String stringValue,int minValue, int maxValue, LocalizableMessage errMsg)
*** Now return a boolean to allow client code to use conditionnal code after call
*** Don't throw runtime exception anymore (Thanks Jean-Noël for refactoring advices!)

* ExportLDIFPanel.java
** okClicked()
** Consequences of checkIntValue changes

git-svn-id: https://svn.forgerock.org/opendj/trunk@12077 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 10:30:37 +0000

0c67de10 OPENDJ-1932 Code cleanup ... Browse Code »

* NewBaseDNPanel.java
** refactor okClicked()
*** Reformat
*** Add final keyword
*** Extract local NEW_BACKEND_TEXT constant
*** Extracted methods
**** resetLabelAsValid()
**** validateBackendName(final Set<BackendDescriptor> existingBackends, final Set<LocalizableMessage> errors)
**** validateBaseDN(final String backendName, final Set<BackendDescriptor> existingBackends, final Set<LocalizableMessage> errors)
**** validateImportLDIFFilePath(final Set<LocalizableMessage> errors)
**** validateAutomaticallyGenerated(final Set<LocalizableMessage> errors)

git-svn-id: https://svn.forgerock.org/opendj/trunk@12076 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 10:30:32 +0000

b7842b3b OPENDJ-1932 Code cleanup ... Browse Code »

* opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/NewBaseDNPanel.java
** Reformat
** Removes unecessary javadocs
** Use interface List declarative type instead of ArrayList

git-svn-id: https://svn.forgerock.org/opendj/trunk@12075 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 10:30:29 +0000

85a2312c OPENDJ-1932 Code cleanup ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12074 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
gaetan
2015-04-10 10:30:25 +0000
8b9d4ac7 OPENDJ-1605 CR-6610 update syntax for ds-base-dn-entry-count to reflect actual usage ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12073 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ian.packer
2015-04-10 09:39:31 +0000

251b3640 OPENDJ-1893 (CR-6600) Do not hardcode Importer threadCount to 1 ... Browse Code »

Problem was due to multiple threads sharing the same Persistit exchanges. Generally speaking DBs do not like mixing transactions and threads.
By using transactions for each DB access, the problem disappears.
Are we losing any performance by using full fledged transactions? Could we somehow do these operations in a thread safe manner without the need to use transactions?

Importer.java:
Use transactions for read/write operations on DN cache.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12072 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 09:07:55 +0000

e89c578c More code cleanup: ... Browse Code »

Added generics
Ignored javadocs warnings
etc.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12071 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-10 08:16:10 +0000

09 Apr, 2015

7 commits

c87ea6ca Minor code cleanup: reduce visibility and remove redundant method parameter. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12070 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2015-04-09 22:59:43 +0000

25114903 Minor code cleanup: ... Browse Code »

* removed listDatabases(), getConfiguration(), and substringKeys() in AttributeIndex
* added AttributeIndex.isIndexed() and modified BackendImpl.isIndexed() to delegate to AttributeIndex.


git-svn-id: https://svn.forgerock.org/opendj/trunk@12069 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-09 22:45:43 +0000

c8f1b0bf Minor code cleanup: use matching rule's index ID for verifying indexes. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12068 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2015-04-09 22:16:52 +0000
f21a4627 Minor code cleanup: use matching rule's index ID for identifying indexes. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12067 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2015-04-09 21:25:21 +0000

6fed2f34 IndexOutputBuffer.java: ... Browse Code »

Prevent too many allocations

git-svn-id: https://svn.forgerock.org/opendj/trunk@12066 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-09 16:57:19 +0000

ea6acd4a Introduced ImportRecord to get rid of IndexOutputBuffer.IndexComparator and its … ... Browse Code »

…myriad of compare() methods.
ImportRecord is composed of a key as a ByteSequence and an indexID being an int.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12065 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-09 16:34:24 +0000

fdd07f33 OPENDJ-1714 (CR-6595) UI setup backend type choice ... Browse Code »

* Installer.java
** Remove temparary OPENDJ-1927 fix

* DataOptionsPanel.java
** Add a combo box to allow user to select a backend type (default value is JE)

* Utils.java
** Update UI installation review and equivalent setup command

* FieldName.java
** Add the backend type field name

git-svn-id: https://svn.forgerock.org/opendj/trunk@12064 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-09 12:41:47 +0000

08 Apr, 2015

8 commits

f86728a6 DatabaseContainer.java: ... Browse Code »

Removed unnecessary declaration of toString() in an interface.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12063 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-08 16:18:32 +0000

cbe25d4d OPENDJ-1714 Code cleanup ... Browse Code »

* Installer.java
** Minor refactorings in method updateUserDataForNewSuffixOptionsPanel(QuickSetup)
*** Fix minor UI bug with invalid/valid fields
*** Reformat
*** Add final keyword
*** Replace hardcoded line separator by constant
*** Extracted methods:
**** checkProvidedBaseDn(QuickSetup, List<String>, List<LocalizableMessage>)
**** checkImportLDIFFile(QuickSetup, List, boolean, List)
**** checkImportGeneratedData(QuickSetup, List, boolean, List)
**** checkImportData(QuickSetup, List, boolean, List)

git-svn-id: https://svn.forgerock.org/opendj/trunk@12062 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-08 14:42:49 +0000

4ed4c538 AttributeIndex.java: ... Browse Code »

Protect against accidental changes.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12061 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-08 11:56:40 +0000

bea3b609 AttributeIndex.java: ... Browse Code »

Removed more duplicated code.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12060 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-08 11:55:25 +0000

b34fb23d Code cleanup ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12059 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-04-08 11:35:19 +0000

34e0c4cb (CR-6590) Remove code specific to extensible indexes in Importer and VerifyJob ... Browse Code »

AttributeIndex.java:
Removed extensibleIndexesMapping field + getter getExtensibleIndexes() + computeExtensibleIndexesMapping() and isDefaultIndex().
Removed getDefaultNameToIndexes(), superseded by getNameToIndexes()

Importer.java:
Removed extensibleIndexMap, superseded by indexMap.
Removed one fillIndexMap(), superseded by the other fillIndexMap()
Removed processExtensibleIndexes().

VerifyJob.java:
Consequence of removing AttributeIndex.getDefaultNameToIndexes().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12058 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-08 11:29:49 +0000

ff7abfb3 Minor code simplification and fix for incorrect trace logging. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12057 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2015-04-08 07:59:47 +0000

598b5221 CR-6580 OPENDJ-1796 Use static hostname in reference docs ... Browse Code »

This patch prevents generated man pages
from using the default host name of the build system.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12056 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-08 07:08:08 +0000

07 Apr, 2015

17 commits

1a6d588d SearchOperationBasis.java: ... Browse Code »

Partial revert of r11027 for entriesSent and referencesSent fields going from AtomicInteger to int (as pointed out by Ludo).




git-svn-id: https://svn.forgerock.org/opendj/trunk@12055 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-07 20:19:59 +0000

a577243a CR-6574 OPENDJ-1923 Move doc out of properties files ... Browse Code »

This patch moves long document strings out of properties files,
replacing them with XIncluded files.

Tested with a manual doc build and visual check.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12054 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-07 17:31:06 +0000

d7f3f025 OPENDJ-1714 Code cleanup ... Browse Code »

* Utils.java
** Refactor getSetupEquivalentCommandLine(UserData) method:
*** Reformat
*** Add final keyword
*** Change return type to List<?> instead of ArrayList<?>
*** Extract addSecurityOptionSetupEquivalentCmdLine(List<String>, UserData) to make the code more readable

* InstallDS.java
** Consequences of changes in Utils.java

git-svn-id: https://svn.forgerock.org/opendj/trunk@12053 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-07 16:37:15 +0000

092f8637 AttributeIndex.java: ... Browse Code »

Progressively getting rid of getExtensibleIndexes(), replaced by getNameToIndexes() wherever possible.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12052 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-07 16:12:01 +0000

462ab6f4 AttributeIndex.java: ... Browse Code »

In buildIndexes(), "fix" the code even though it always works today (because MatchingRule.getIndexers() only ever return singleton lists).

git-svn-id: https://svn.forgerock.org/opendj/trunk@12051 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-07 16:02:10 +0000

730cf17e Code cleanup ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12050 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-04-07 15:56:59 +0000

15402fc8 Code simplification in AttributeIndex ... Browse Code »

AttributeIndex.java:
Inlined getAllIndexes().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12049 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-07 15:48:07 +0000

8e1d0970 Code simplification in AttributeIndex ... Browse Code »

Code review: Matthew Swift


AttributeIndex.java:
Removed getEqualityIndex(), getApproximateIndex(), getOrderingIndex(), getSubstringIndex(), getPresenceIndex() and getIndexById() methods, all replaced with the new getNameToIndexes() and getDefaultNameToIndexes() methods.

Importer.java, IndexQueryFactoryImpl.java, Suffix.java, VerifyJob.java:
Consequence of the change to AttributeIndex + added toImportIndexType(String IndexID)

git-svn-id: https://svn.forgerock.org/opendj/trunk@12048 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-07 15:43:34 +0000

6d71570f PENDJ-1714 Code cleanup ... Browse Code »

* InstallReviewPanel
** Use Constants.LINE_SEPARATOR instead of redefined it

* Utils.java
** Refactor getDataDisplayString() method:
*** Reformat
*** Add final keyword
*** ** Use Constants.LINE_SEPARATOR instead of hardcoded "\n"

git-svn-id: https://svn.forgerock.org/opendj/trunk@12047 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-07 15:33:34 +0000

fca4544b CR-6577 OPENDJ-1862 Doc patching multiple JSON fields ... Browse Code »

This patch demonstrates how to change
more than one JSON field in a REST resource.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12046 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-07 15:30:07 +0000

a93c703c OPENDJ-1714 Code cleanup ... Browse Code »

* InstallReviewPanel
** Remove unecessary String.valueOf()
** Update formatting
** Add final keyword
** Remove unecessary javadocs
** Fix imports
** imports static from Utils class
** replace ArrayList<?> declarative types by List<?>

* Utils.java
** Replace declarative ArrayList<?> variable by List<?>

git-svn-id: https://svn.forgerock.org/opendj/trunk@12045 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-07 15:21:18 +0000

ee996f94 CR-6575 OPENDJ-1912 Move doc source generation to a profile ... Browse Code »

This patch speeds up a basic clean install
by moving doc generation out of the common path into a profile.

This patch requires that both native package builds and also doc builds
now use -Pman-pages to build the man pages.

Otherwise the build breaks with a message:
Man pages not found. You must build with -P man-pages.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12044 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-07 15:03:42 +0000

113ea6e8 OPENDJ-1927 (OPENDJ-1714) Temporary fix setup UI ... Browse Code »

* Installer.java
** Enforce default backend type if UI is used to setup the server

git-svn-id: https://svn.forgerock.org/opendj/trunk@12042 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-07 11:06:48 +0000

7729b86a OPENDJ-1714: Creates class to manage backend type ... Browse Code »

* BackendTypeHelper.java
** Create class to manage backend type utilities.

* ConfigureDS, InstallDS
** Consequences of the change

git-svn-id: https://svn.forgerock.org/opendj/trunk@12041 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-07 11:06:44 +0000

e307b08c OPENDJ-1714 Code cleanup ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12040 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
gaetan
2015-04-07 11:06:40 +0000

1445af50 CR-6576 OPENDJ-1903 Update setup --cli doc, default baseDN ... Browse Code »

This patch updates the documentation to account for
the default base DN provided during interactive command-line setup.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12039 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-07 11:00:46 +0000

e79beaaf OPENDJ-1628 - Simplify Index hierarchy and remove Indexer classes ... Browse Code »

* DatabaseContainer / Index
    - now interfaces providing minimal set of methods
* NullIndex
    - implements Index interface and forces us to override new interface methods when they are added
* AbstractDatabaseContainer
    - common base class for all indexes (was DatabaseContainer)
* DefaultIndex
    - implementation of id2children, id2subtree, and base implementation for attribute indexes
* AttributeIndex
    - includes MatchingRuleIndex inner class which is used for all matching rule based indexes and presence indexing (presence is now implemented using a specialized Indexer)
    - pushed down all attribute index specific logic from Index API to AttributeIndex/MatchingRuleIndex
* IndexBuffer
    - remove feature envy between this class and Index
    - used consistent method/field/paramet names throughout.



git-svn-id: https://svn.forgerock.org/opendj/trunk@12038 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-04-07 10:45:33 +0000