org.forgerock / org.forgerock.opendj

06 Mar, 2013

9 commits

c711abfe OPENDJ-655 Message about authentication failures should contain identification o… ... Browse Code »

…f the user for easier analysis.

Aargh so much code copy/pasted! Found and fixed other occurences.
Aargh I also broke the build again.

LocalBackendBindOperation.java:
In processBind(), fixed the code.
Extracted methods generateAccountStatusNotificationForLockedBindAccount() and getIntegerUserAttribute() to remove duplicated code.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8557 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-06 16:48:29 +0000

9bb6c8ff OPENDJ-770 Simplify the "rebuild-index --clearDegradedState" command output ... Browse Code »
```
- Fixed message.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8556 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-03-06 15:58:01 +0000

f77e2588 OPENDJ-655 Message about authentication failures should contain identification o… ... Browse Code »

…f the user for easier analysis.

What a convoluted code!! It is using a label and a block to implement a goto in Java. yuck!

LocalBackendBindOperation.java:
In processLocalBind(), extracted method processBind().
In the newly extracted method processBind(), converted the break stmts into return stmts + moved the switch stmt inside the try stmt (instead of the try/catch stmt in the switch stmt) + then removed useless if statements and break statements from the switch stmt.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8555 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-06 15:51:04 +0000

a39a6553 OPENDJ-66 (CR-1368) DS does not failover between replication servers in differen… ... Browse Code »

…t groups when configured explicitly for one of the groups 

ReplicationBroker.java:
In connectAsDataServer(), removed following useless if statement (root cause for the bug):
// Really no other server with our group id ?
if ((tmpRsGroupId == groupId) || (!someServersWithSameGroupId))

Extracted method connectToReplicationServer() in connectAsDataServer().
Removed hasSomeServerWithSameGroupId().

git-svn-id: https://svn.forgerock.org/opendj/trunk@8554 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-06 13:03:44 +0000

95a6d04c Partial fix for OPENDJ-699: Implement DN reference mapping ... Browse Code »

* add filter support: this required some refactoring of the core resource provider in order to ensure that an LDAP connection was available before attempting to resolve LDAP filter.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8553 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-06 11:57:52 +0000

6123a7a6 Cleanup ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8552 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-06 11:55:26 +0000
252286fe CR-1367 Fix dsml/04addmodaddsuite-add999 testcase and cleanup known issue in dsml testsuite ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8551 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-03-06 11:07:13 +0000

b49a3e7a Minor improvements: ... Browse Code »

* use encoder for JSON query filter assertion values
* handle unexpected exceptions when encoding and decoding values between JSON and LDAP
* improve Javadoc for Utils.accumulate and Utils.transform and make both methods more fault tolerant.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8550 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-06 10:01:06 +0000

9d883d41 OPENDJ-66 DS does not failover between replication servers in different groups w… ... Browse Code »

…hen configured explicitly for one of the groups 

java.net.Socket implements java.io.Closeable starting from Java 7 only :(


git-svn-id: https://svn.forgerock.org/opendj/trunk@8549 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-06 08:57:56 +0000

05 Mar, 2013

12 commits

a345dbb7 OPENDJ-66 (CR-1365) DS does not failover between replication servers in differen… ... Browse Code »

…t groups when configured explicitly for one of the groups 

Fixing checkstyle errors.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8548 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-05 17:06:37 +0000

53006813 OPENDJ-66 (CR-1365) DS does not failover between replication servers in differen… ... Browse Code »

…t groups when configured explicitly for one of the groups 

Fixing checkstyle errors.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8547 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-05 17:01:02 +0000

3881ced1 OPENDJ-66 (CR-1365) DS does not failover between replication servers in differen… ... Browse Code »

…t groups when configured explicitly for one of the groups 

Code cleanup.

ReplicationBroker.java
In computeBestReplicationServer(), fixed the screwed up for (ctr) switch (ctr){}; pattern + added keepBest() method.
In computeBestServerForWeight(), used BigDecimal.valueOf() instead of ctor.
In changeConfig(), fixed complicated condition.
Added javadocs, fixed variable naming, used foreach.

StaticUtils.java:
Added toIterable().

git-svn-id: https://svn.forgerock.org/opendj/trunk@8546 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-05 16:50:35 +0000

67d587a3 Partial fix for OPENDJ-699: Implement DN reference mapping ... Browse Code »
```
* fix typo in Javadoc.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8545 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-03-05 16:15:55 +0000

0962b48a Partial fix for OPENDJ-699: Implement DN reference mapping ... Browse Code »

* update default configuration to support new DN reference mappings.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8544 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-05 16:10:25 +0000

cb9b4a0f Partial fix for OPENDJ-699: Implement DN reference mapping ... Browse Code »

* add ReferenceAttributeMapper class which includes read support and no filtering.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8543 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-05 16:05:52 +0000

9574d5c1 Fix OPENDJ-765 Modify with replace attr=value and delete attr gets misrecorded in ds-sync-hist ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8542 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2013-03-05 13:13:07 +0000

e4c9e5a4 Code cleanup. ... Browse Code »

If I see another if (c != null) try{ c.close(); }catch (Throwable t){}, I am going to bail out!!

git-svn-id: https://svn.forgerock.org/opendj/trunk@8541 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-05 12:04:09 +0000

352663cf OPENDJ-764 ldapsearch etc does not try all dns entries ... Browse Code »

LDAPConnection.java:
Extracted methods createSocket(), createSSLSocket() and createSSLOrBasicSocket().
In createSocket() and createSSLSocket(),call InetAddress.getAllByName() to try all host name entries.

SSLConnectionFactory.java:
Added method createSocket(InetAddress host, int portNumber).

git-svn-id: https://svn.forgerock.org/opendj/trunk@8540 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-05 12:00:24 +0000

70390f94 Cleanup: use Java 5 foreach ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8539 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-05 11:34:10 +0000

f49aec89 Initial work for OPENDJ-699: Implement DN reference mapping ... Browse Code »

Add group/manager support to sample Servlet configuration.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8538 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-05 10:38:34 +0000

a1d1a570 Minor code and typos cleanup. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8537 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-03-05 10:27:55 +0000

04 Mar, 2013

5 commits

48241dcb CR-1363 Fix ldif-diff testcases and cleanup known issue in clu testsuite ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8536 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-03-04 16:35:21 +0000

1f8f3624 OPENDJ-770 Simplify the "rebuild-index --clearDegradedState" command output ... Browse Code »

- If in cleardegradedState mode, output just displays the following msg "Degraded state of index(es) [indexe(s) name] has been removed".

git-svn-id: https://svn.forgerock.org/opendj/trunk@8535 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-04 12:25:31 +0000

6aadc841 Fixed wording in the dev guide. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8534 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-04 10:34:37 +0000
4ad11022 After comments from Gary, try to break lines in a less unfortunate place ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8533 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-03-04 10:02:30 +0000
4b64fb63 OPENDJ-769 rebuild-index --clearDegradedState in online mode should not rebuild the index ... Browse Code »
```
- added support for the clearDegradedState option in online mode.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8532 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-03-04 08:37:07 +0000

03 Mar, 2013

1 commit

17d3f24a [Opendj-777] CR-1353 Update ldapcompare testscases following fix for issue OPENDJ-777 ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8531 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-03-03 20:52:23 +0000

01 Mar, 2013

13 commits

b920b342 CR-1327 Fix for OPENDJ-772: Document how to set up the REST to LDAP Servlet ... Browse Code »

Note: This is the first step, documenting what is currently available. More is on the way as identified by the TODOs and issue IDs in the documentation (and visible in JIRA).

git-svn-id: https://svn.forgerock.org/opendj/trunk@8530 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-01 17:09:07 +0000

c4ed891a Fix OPENDJ-750 SNMP: impossible to get the operation counters for a LDAP connection handler ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8529 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2013-03-01 16:21:49 +0000
38ca258c OPENDJ-796 Document new ldif-diff and ldapcompare arguments ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8528 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-01 15:57:23 +0000
0cd0271c OPENDJ-777 (CR-1343) ldapcompare should exit with different values w.r.t compari… ... Browse Code »
```
…son is successful or not

Fixing the build.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8527 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-03-01 11:25:21 +0000

c208ef26 OPENDJ-777 (CR-1343) ldapcompare should exit with different values w.r.t compari… ... Browse Code »

…son is successful or not

LDAPCompare.java:
In mainCompare(), added useCompareResultCode option and changed the code to return the aggregated resultCode when this option is used from command line, else return SUCCESS. Used LDAPResultCode everywhere possible.
In readAndExecute() and executeCompare(), changed result code to int.
Added aggregateResultCode() method.

LDAPCompareTestCase.java:
Replaced exit code 0 with LDAPResultCode.SUCCESS.
In many tests, added checks for --useCompareResultCode option.
Added testMultipleCompareAllTrue(), testMultipleCompareOneCompareIsFalse(), testMultipleCompareOneNoSuchObject(), addEntriesUpToParentDN(), getAggregateResultCodeParamsAndResults() and testAggregateResultCode().

git-svn-id: https://svn.forgerock.org/opendj/trunk@8526 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-01 10:41:48 +0000

0c139549 CR-1344 Update ldif-diff testcases following fix for issue OPENDJ-778 (part2) ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8525 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-03-01 10:26:36 +0000

47087a85 OPENDJ-778 ldif-diff should exit with different values w.r.t files are identical or not ... Browse Code »

EncodePassword.java:
Fixed a little bug introduced in previous commit (missing one output message)


git-svn-id: https://svn.forgerock.org/opendj/trunk@8524 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-01 10:07:20 +0000

72ac2b76 CR-1344 Update ldif-diff testcases following fix for issue OPENDJ-778 ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8523 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-03-01 10:06:09 +0000
f2087a4a Update core/filters testscases following fix for issue OPENDJ-735 ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8522 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-03-01 10:03:31 +0000

49a3cd22 OPENDJ-777 ldapcompare should exit with different values w.r.t comparison is successful or not ... Browse Code »

Cleaned up the SDK.

ConsoleApplication.java:
Used variable arguments for closeIfNotNull()

LDIFDiff.java, LDIFModify.java, LDIFSearch.java:
Made use of the variable arguments for closeIfNotNull().
Returned ResultCode.SUCCESS instead of 0.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8521 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-03-01 09:52:32 +0000

b5c79058 Additional improvement suggested by Chris Ridd to make the X-ENUM example easier to understand ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8520 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-03-01 09:43:37 +0000
83e24c47 Additional fix for OPENDJ-643: Show how to configure identity mapping in the admin guide ... Browse Code »
```
Typo and two improvements (Thanks, Chris Ridd)

git-svn-id: https://svn.forgerock.org/opendj/trunk@8519 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-03-01 09:21:00 +0000
1eeb599d CR-1346 Fix for OPENDJ-641: Describe attribute syntaxes & matching rules ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@8518 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-03-01 08:45:23 +0000