org.forgerock / org.forgerock.opendj

11 Dec, 2013

4 commits

d79bc53a Ti amo checkstyle! ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9961 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-12-11 15:10:52 +0000

fff68807 GroupManager.java: ... Browse Code »

Extracted method hasGroupMembershipUpdateControl().
In loadGroup(), used StaticUtils.collectionToString().
Automatic code cleanups.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9960 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-11 15:08:55 +0000

34637012 Code cleanups ... Browse Code »


SetPropSubCommandHandler.java:
Extracted methods parseValue() and getPropertyDefinition().

Argument.java:
Improved the toString() + javadocs.
Minor code cleanups.

ArgumentParser.java:
Removed one parseArguments() method - never used.
Extracted method indentAndWrap() to match SubCommandArgumentParser.
Minor code cleanups.

SubCommandArgumentParser.java:
Removed one parseArguments() method - never used.
Minor code cleanups.

DsconfigOptionsTestCase.java:
Added testGenerateDoc().
Minor code cleanups.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9959 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-11 15:03:48 +0000

13ac0537 Minor code simplification. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9958 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-12-11 12:30:17 +0000

10 Dec, 2013

6 commits

b5741e22 Fix OPENDJ-1248: Unexpected rejected entries during import-ldif ... Browse Code »
```
* ensure that temporary enviroment is always closed.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9955 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-12-10 17:42:39 +0000
d37859e5 CR-2688 OPENDJ-1230 SDK Builder for Matching rules ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9954 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-12-10 16:26:21 +0000
69a684ea Fix typo in help. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9953 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-12-10 16:02:36 +0000

91fb8995 OpenDJ 3 : config framework ... Browse Code »

Remove all remaining compilation errors in org.opends.server.admin packages

* Replace client.AuthorizationException and client.CommunicateException classes
 by ErrorResultException from SDK
** Update stylesheets clientMO.xsl and metaMO.xsl to use ErrorResultException 
 in generated code

* Replace all javax.naming classes by SDK classes
** Remove JNDIDirContextAdaptor class

* Replace all remaining occurences of RDN, DN and Attribute classes from server
 by SDK classes

* Other minor changes

git-svn-id: https://svn.forgerock.org/opendj/trunk@9952 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-10 12:43:16 +0000

0acd4003 Argument.java: ... Browse Code »

Implemented toString().
Code cleanup.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9951 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-10 10:01:47 +0000

6c008f8f Removed known issue tag for OPENDJ-1088 ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9950 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-12-10 09:21:44 +0000

09 Dec, 2013

12 commits

dc5f0fa7 Attempt to fix nightly unit test failures: forcefully clean the backend during e… ... Browse Code »

…ach import. This shouldn't be necessary since there is only one suffix per backend.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9949 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-09 21:36:47 +0000

d689b034 Reset the configuration after the server is stopped, not before. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9948 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-12-09 17:46:34 +0000
dada01a5 Add more debugging to import test which outputs the configured base DNs upon failure. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9947 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-12-09 17:45:29 +0000
5f103f80 Minor code cleanup ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9946 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-12-09 17:12:39 +0000
7a386c51 Update development version to 3.0.0-SNAPSHOT. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9945 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-12-09 16:54:26 +0000
34fd0d06 Minor updates to pom so that it builds using Eclipse. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9944 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-12-09 16:24:54 +0000

0170ca45 OPENDJ-1106 fractional-replication: adding entry on a replica as DM should not exit with RC 50 ... Browse Code »

Code review: Matthew Swift


Regression caused by the fix for OPENDJ-948 unauthorized disclosure of directory contents.
The code was looking for the entry matching the DN we are adding which obviously was null here.
Since it was null, the code went on to wrongly check the following conditions: op.isInternalOperation() || op.isSynchronizationOperation() || op.isInnerOperation().
The correct fix was to avoid calling AccessControlHandler.canDiscloseInformation() where it did not make sense at all, when there was no info to protect yet.


LocalBackend*Operation.java:
Do not call the setResultCodeAndMessageNoInfoDisclosure() when we fail to grab a lock, because this is not disclosing any sensitive information at that point.

LocalBackendAddOperation.java:
Do not call the setResultCodeAndMessageNoInfoDisclosure() when we fail to grab a lock, because this is not disclosing any sensitive information at that point.
In lockParent(), reversed the exception to make the code easier to read.

LocalBackendModifyDNOperation.java:
Do not call the setResultCodeAndMessageNoInfoDisclosure() when we fail to grab a lock, because this is not disclosing any sensitive information at that point.
In newDirectoryException(), removed the entryDN parameter since now this method is always called with a non null entry.


AciHandler.java:
Code cleanup


git-svn-id: https://svn.forgerock.org/opendj/trunk@9943 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-09 16:10:36 +0000

f0738ccc Add i18n-sl4f dependency in opendj parent pom ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9942 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
nicolas.capponi@forgerock.com
2013-12-09 12:04:48 +0000

58b89515 Fixing thread leaks in Continuous Integration. ... Browse Code »

ReplicationServerDomain.java:
Fixed NPEs in stopStatusAnalyzer() and stopMonitoringPublisher().
In getEligibleCSN(), removed useless null checks.

ServerWriter.java:
Code cleanup.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9941 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-09 11:43:18 +0000

af43b515 Investigate unit test failures: dump unexpected content of reject file. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9940 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-12-09 10:53:55 +0000
7a78834e Updated privileges tests after fix for issue OPENDJ-1107 and fixed problem with jstack on Windows ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9939 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-12-09 10:26:46 +0000

ffc716ec ChangeNumberIndexerTest.java: ... Browse Code »

Test cleanup: stop the indexer thread after each test method has finished running.

TestListener.java:
Automatic code cleanup.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9938 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-09 10:08:04 +0000

06 Dec, 2013

16 commits

018aebf9 Don't stop the server at the end of the test. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9937 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-12-06 17:45:22 +0000
e7e3cec4 Improve accuracy of timestamps and thread count changes. ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9936 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-12-06 17:44:53 +0000

f2882770 OpenDJ 3 : config framework ... Browse Code »

Reducing compilation errors in org.opends.server.admin packages

* Convert AttributeValue class from server to SDK compliant code

* Add new interface ConfigurationRepository to simplify ConfigEntry

* Add AciException class from server 

* Add extension.properties file from server

* Add validation of XML core definitions 
**  Add catalog.xml file to handle references to other schema files

* Other minor changes

git-svn-id: https://svn.forgerock.org/opendj/trunk@9935 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-06 16:52:01 +0000

a3bc45ea OPENDJ-1088 (CR-2677) Wrong error message and result code when deleting branch a… ... Browse Code »

…s a user with insufficient access rights


Fixed ConcurrentModificationException introduced in r7972 for OPENDJ-475: Incorrect behaviour/result code regarding non-critical controls.
The ConcurrentModificationExcepotion was hidden via several method calls, but generally it takes such form:
1. for (Control c : Operation.getRequestControls()) - directly or via indirect calls
2. AccessControlHandler.isAllowed()
2.1. Operation.removeRequestControl()
3. ConcurrentModificationException on next loop iteration at 1.



LocalBackendWorkflowElement.java:
Replaced isControlAllowed() by removeAllDisallowedControls() that uses Iterator.remove() instead of Operation.removeRequestControl().


LocalBackend*Operation.java:
In handleRequestControls(), processControls() and processRequestControls(), called LocalBackendWorkflowElement.removeAllDisallowedControls() before the for loop + removed call to LocalBackendWorkflowElement.isControlAllowed() in the loop body.
Tiny code cleanups.

ExtendedOperationBasis.java, ECLSearchOperation.java:
Used Iterator.remove() instead of Operation.removeRequestControl().

MultimasterReplication.java:
In findDomain(), used Iterator.remove() instead of Operation.removeRequestControl() + simplified the while loop code.


Operation.java, OperationWrapper.java, PreParseOperation.java:
Removed now unused removeRequestControl().

AbstractOperation.java:
Consequence of the change to Operation.
little code tidy up.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9934 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-06 16:13:01 +0000

ef7b85b5 ArgumentParser.java: ... Browse Code »

Extracted method normalizeArguments().
Made printVersion() protected.

SubCommandArgumentParser.java:
Removed normalizeArguments() and printVersion().
Extracted method indentAndWrap2().
In isUsageArgumentPresent() and isVersionArgumentPresent(), code cleanup.
In toRefSect2(), used a StringBuilder.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9933 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-06 15:44:45 +0000

7054a1b1 CR-2675 OPENDJ-1241 Server does not start after upgrade - Part II ... Browse Code »

- fixed upgrade (removed white spaces in upgrade tasks, added Filter instead of LDAPFilter, added matcher and setting schema default matching rule/syntax.)

git-svn-id: https://svn.forgerock.org/opendj/trunk@9932 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-06 15:15:39 +0000

c2bd7532 ArgumentParser.java, SubCommandArgumentParser.java: ... Browse Code »

Moved try / catch / ignore inside getUsage() methods.
Extracted method printVersion(), dashVAccepted() and normalizeArguments().
Code cleanups.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9931 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-06 15:09:06 +0000

001af2bc Additional Fix for OPENDJ-1229: Update doc for make-ldif interface changes ... Browse Code »
```
Keep checkstyle happy

git-svn-id: https://svn.forgerock.org/opendj/trunk@9930 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-12-06 14:57:22 +0000
a43c2b5a CR-2676 Fix for OPENDJ-1229: Update doc for make-ldif interface changes ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9929 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-12-06 14:43:55 +0000
27078ea4 CR-2675 OPENDJ-1241 Server does not start after upgrade - Part I ... Browse Code »
```
- fixed Rebuild Index

git-svn-id: https://svn.forgerock.org/opendj/trunk@9928 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-12-06 14:23:02 +0000
1630a1a8 * print time stamps for each unit test status in order to help correlate tests against logs ... Browse Code »
```
* improve code for tracking thread count changes.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9927 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
matthew
2013-12-06 13:29:54 +0000

1c405d09 Temporary workaround for OPENDJ-1243: ClassCastException while accessing Environ… ... Browse Code »

…mentStats appearing frequently in debug logs

* avoiding collecting buggy stats.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9926 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-06 13:28:11 +0000

ed8dea05 Javadoc cleanup. ... Browse Code »

AbstractOperation.java:
Replaced javadocs duplicated from Operation interface by {@inheritDoc}.
Put {@inheritDoc} on one line only.
Removed empty lines.
Little code formatting.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9925 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-06 10:30:08 +0000

f9d1cf76 Fixed once and for all: privilige => privilege ... Browse Code »

WhoAmIExtendedOperation.java:
Initialized supportedControlOIDs once and for all.
Applied automatic refactorings

ECLSearchOperation.java:
Applied automatic refactorings

git-svn-id: https://svn.forgerock.org/opendj/trunk@9924 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-06 09:22:15 +0000

27159c06 - Fixed unit tests, removing all 'if (resultReader.hasNext())' - which made the tests useless. ... Browse Code »
```
- Added unit tests about CaseExactMatchingRule && CaseIgnoreMatchingRule use.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9923 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-12-06 08:56:24 +0000

cb4f0414 Removed a couple of broken unit test cases which were dependent upon the task ba… ... Browse Code »

…ckend being empty, which is not necessarily the case if previous unit tests have performed any tasks.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9922 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-12-06 08:02:26 +0000

05 Dec, 2013

2 commits

9f761222 If the server hangs, dump stack trace of the server process before kill it ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9921 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-12-05 22:48:08 +0000
cf70042c Added testcase for issue OPENDJ-1192 ... Browse Code »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9920 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-12-05 22:44:37 +0000