09 Dec, 2013
12 commits
-
…ach import. This shouldn't be necessary since there is only one suffix per backend. git-svn-id: https://svn.forgerock.org/opendj/trunk@9949 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9948 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9947 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9946 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9945 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9944 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Code review: Matthew Swift Regression caused by the fix for OPENDJ-948 unauthorized disclosure of directory contents. The code was looking for the entry matching the DN we are adding which obviously was null here. Since it was null, the code went on to wrongly check the following conditions: op.isInternalOperation() || op.isSynchronizationOperation() || op.isInnerOperation(). The correct fix was to avoid calling AccessControlHandler.canDiscloseInformation() where it did not make sense at all, when there was no info to protect yet. LocalBackend*Operation.java: Do not call the setResultCodeAndMessageNoInfoDisclosure() when we fail to grab a lock, because this is not disclosing any sensitive information at that point. LocalBackendAddOperation.java: Do not call the setResultCodeAndMessageNoInfoDisclosure() when we fail to grab a lock, because this is not disclosing any sensitive information at that point. In lockParent(), reversed the exception to make the code easier to read. LocalBackendModifyDNOperation.java: Do not call the setResultCodeAndMessageNoInfoDisclosure() when we fail to grab a lock, because this is not disclosing any sensitive information at that point. In newDirectoryException(), removed the entryDN parameter since now this method is always called with a non null entry. AciHandler.java: Code cleanup git-svn-id: https://svn.forgerock.org/opendj/trunk@9943 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9942 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
ReplicationServerDomain.java: Fixed NPEs in stopStatusAnalyzer() and stopMonitoringPublisher(). In getEligibleCSN(), removed useless null checks. ServerWriter.java: Code cleanup. git-svn-id: https://svn.forgerock.org/opendj/trunk@9941 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9940 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9939 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Test cleanup: stop the indexer thread after each test method has finished running. TestListener.java: Automatic code cleanup. git-svn-id: https://svn.forgerock.org/opendj/trunk@9938 41b1ffd8-f28e-4786-ab96-9950f0a78031
06 Dec, 2013
16 commits
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9937 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9936 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Reducing compilation errors in org.opends.server.admin packages * Convert AttributeValue class from server to SDK compliant code * Add new interface ConfigurationRepository to simplify ConfigEntry * Add AciException class from server * Add extension.properties file from server * Add validation of XML core definitions ** Add catalog.xml file to handle references to other schema files * Other minor changes git-svn-id: https://svn.forgerock.org/opendj/trunk@9935 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
…s a user with insufficient access rights Fixed ConcurrentModificationException introduced in r7972 for OPENDJ-475: Incorrect behaviour/result code regarding non-critical controls. The ConcurrentModificationExcepotion was hidden via several method calls, but generally it takes such form: 1. for (Control c : Operation.getRequestControls()) - directly or via indirect calls 2. AccessControlHandler.isAllowed() 2.1. Operation.removeRequestControl() 3. ConcurrentModificationException on next loop iteration at 1. LocalBackendWorkflowElement.java: Replaced isControlAllowed() by removeAllDisallowedControls() that uses Iterator.remove() instead of Operation.removeRequestControl(). LocalBackend*Operation.java: In handleRequestControls(), processControls() and processRequestControls(), called LocalBackendWorkflowElement.removeAllDisallowedControls() before the for loop + removed call to LocalBackendWorkflowElement.isControlAllowed() in the loop body. Tiny code cleanups. ExtendedOperationBasis.java, ECLSearchOperation.java: Used Iterator.remove() instead of Operation.removeRequestControl(). MultimasterReplication.java: In findDomain(), used Iterator.remove() instead of Operation.removeRequestControl() + simplified the while loop code. Operation.java, OperationWrapper.java, PreParseOperation.java: Removed now unused removeRequestControl(). AbstractOperation.java: Consequence of the change to Operation. little code tidy up. git-svn-id: https://svn.forgerock.org/opendj/trunk@9934 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Extracted method normalizeArguments(). Made printVersion() protected. SubCommandArgumentParser.java: Removed normalizeArguments() and printVersion(). Extracted method indentAndWrap2(). In isUsageArgumentPresent() and isVersionArgumentPresent(), code cleanup. In toRefSect2(), used a StringBuilder. git-svn-id: https://svn.forgerock.org/opendj/trunk@9933 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
- fixed upgrade (removed white spaces in upgrade tasks, added Filter instead of LDAPFilter, added matcher and setting schema default matching rule/syntax.) git-svn-id: https://svn.forgerock.org/opendj/trunk@9932 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Moved try / catch / ignore inside getUsage() methods. Extracted method printVersion(), dashVAccepted() and normalizeArguments(). Code cleanups. git-svn-id: https://svn.forgerock.org/opendj/trunk@9931 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Keep checkstyle happy git-svn-id: https://svn.forgerock.org/opendj/trunk@9930 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9929 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
- fixed Rebuild Index git-svn-id: https://svn.forgerock.org/opendj/trunk@9928 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
* improve code for tracking thread count changes. git-svn-id: https://svn.forgerock.org/opendj/trunk@9927 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
…mentStats appearing frequently in debug logs * avoiding collecting buggy stats. git-svn-id: https://svn.forgerock.org/opendj/trunk@9926 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
AbstractOperation.java: Replaced javadocs duplicated from Operation interface by {@inheritDoc}. Put {@inheritDoc} on one line only. Removed empty lines. Little code formatting. git-svn-id: https://svn.forgerock.org/opendj/trunk@9925 41b1ffd8-f28e-4786-ab96-9950f0a78031 -
WhoAmIExtendedOperation.java: Initialized supportedControlOIDs once and for all. Applied automatic refactorings ECLSearchOperation.java: Applied automatic refactorings git-svn-id: https://svn.forgerock.org/opendj/trunk@9924 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
- Added unit tests about CaseExactMatchingRule && CaseIgnoreMatchingRule use. git-svn-id: https://svn.forgerock.org/opendj/trunk@9923 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
…ckend being empty, which is not necessarily the case if previous unit tests have performed any tasks. git-svn-id: https://svn.forgerock.org/opendj/trunk@9922 41b1ffd8-f28e-4786-ab96-9950f0a78031
05 Dec, 2013
12 commits
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9921 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9920 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9919 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Code review: Matthew Swift Fixing failing unit tests, removed the following stack trace which makes test and code fail. [testng] Failed Test: org.opends.server.replication.plugin.HistoricalCsnOrderingTest#buildAndPublishMissingChangesSeveralEntriesTest [testng] Failure Cause: com.sleepycat.je.ThreadInterruptedException: (JE 5.0.97) Environment must be closed, caused by: com.sleepycat.je.ThreadInterruptedException: Environment invalid because of previous exception: (JE 5.0.97) <https://builds.forgerock.org/job/OpenDJ%20-%20trunk%20-%20postcommit/ws/build/unit-tests/package-instance/HistoricalCsnOrdering> Thread interrupted prior to logging the commit THREAD_INTERRUPTED: InterruptedException may cause incorrect internal state, unable to continue. Environment is invalid and must be closed. [testng] com.sleepycat.je.ThreadInterruptedException.wrapSelf(ThreadInterruptedException.java:99) [testng] com.sleepycat.je.dbi.EnvironmentImpl.checkIfInvalid(EnvironmentImpl.java:1594) [testng] com.sleepycat.je.Database.checkEnv(Database.java:2154) [testng] com.sleepycat.je.Database.getDatabaseName(Database.java:1939) [testng] org.opends.server.replication.server.changelog.je.ReplicationDbEnv.closeDB(ReplicationDbEnv.java:457) [testng] org.opends.server.replication.server.changelog.je.ReplicationDbEnv.shutdown(ReplicationDbEnv.java:435) [testng] org.opends.server.replication.server.changelog.je.JEChangelogDB.shutdownDB(JEChangelogDB.java:409) [testng] org.opends.server.replication.server.ReplicationServer.shutdown(ReplicationServer.java:702) [testng] org.opends.server.replication.server.ReplicationServer.remove(ReplicationServer.java:1028) [testng] org.opends.server.replication.plugin.HistoricalCsnOrderingTest.buildAndPublishMissingChangesSeveralEntriesTest(HistoricalCsnOrderingTest.java:308) DirectoryThread.java: In initiateShutdown(), removed the call to Thread.interrupt() added in r9911. ChangeNumberIndexer.java: Overrode initiateShutdown() to stop this thread on shutdown: used notify() to wake up the thread if it was waiting. In run(), checked whether shutdown has been initiated for this thread before calling wait(): this protects against missed notifications. JEReplicaDB.java: In run(), removed call to Thread.currentThread().interrupt(). git-svn-id: https://svn.forgerock.org/opendj/trunk@9918 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Thanks, Chris Ridd! git-svn-id: https://svn.forgerock.org/opendj/trunk@9917 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Fixed ValidateConfigDefinitionsTest failure. 02-config.ldif: Added ds-cfg-compute-change-number to ds-cfg-replication-server object class. git-svn-id: https://svn.forgerock.org/opendj/trunk@9916 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
JEReplicaDBTest.java: In JEReplicaDB.generateCursorFrom(), changed the asserts: no exception is thrown anymore, but the cursor appears empty now. git-svn-id: https://svn.forgerock.org/opendj/trunk@9915 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
ReplServerFakeConfiguration.java: In ctor, if no dirName is provided use "changelogDb" as the path where to store the changelogDB. This is restoring behaviour lost with r9881. git-svn-id: https://svn.forgerock.org/opendj/trunk@9914 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Reducing compilation errors in org.opends.server.admin packages * Remove AdministrationConnector and AdministrationDataSync classes ** These classes does not belong to the config framework * Remove methods that are no more needed in DirectoryServer stub git-svn-id: https://svn.forgerock.org/opendj/trunk@9913 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Reducing compilation errors in org.opends.server.admin packages * Add org.opends.server.config.ConfigEntry class from the server ** Keep only code related to registering/deregistering listeners ** Intent is to manage entries relationships in a memory backend / LDIF backend instead of reproducing the hierarchical structure into ConfigEntry class as done currently in the server * Add config.properties file from the server to get config messages * Other minor changes git-svn-id: https://svn.forgerock.org/opendj/trunk@9912 41b1ffd8-f28e-4786-ab96-9950f0a78031 -
…veDB() which then calls ReplicationDB.shutdown(). Code is blocked acquiring a writeLock on the dbCloseLock, but a readLock is never unlocked. Debugging showed that the ChangeNumberIndexDB is holding a cursor on a ReplicationDB, said cursor holds the readLock. Despite the ChangeNumberIndexer thread being asked to initiateShutdown(), the thread is waiting indefinitely for new changes which will never come. DirectoryThread.java: In initiateShutdown(), call interrupt() to ensure the thread will be interrupted if it calls Object.wait() before checking whether it needs to shutdown, or if it is already waiting. git-svn-id: https://svn.forgerock.org/opendj/trunk@9911 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Removed change which was not intended for commit, at least not for now. git-svn-id: https://svn.forgerock.org/opendj/trunk@9910 41b1ffd8-f28e-4786-ab96-9950f0a78031