23 Oct, 2013
2 commits
-
Thanks to Chris Ridd for reviewing the patch I posted to the issue and letting me know by IM. git-svn-id: https://svn.forgerock.org/opendj/trunk@9747 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Replaced instance fields with directly storing and using the ReplicationDomainCfg object. ReplicationBroker.java: Replaced instance fields with directly storing and using the ReplicationDomainCfg object. Removed start(Set<String>), setChangeTimeHeartbeatInterval() (now useless), and setGroupId() (never used). Added getBaseDN(), getReplicationServerUrls(), getGroupId(). In several methods, used Map.entrySet() instead of Map.keySet() with Map.get(Object) + renamed replicationServerInfo to rsInfo. replication.properties: Removed now unused message. ReplicationDomain.java: Replaced instance fields with directly storing and using the ReplicationDomainCfg object. Code cleanups: - Removed useless use of "this." for method calls. - In processErrorMsg() and processUpdateDone(), collapsed if statements - Increased vertical density - Extracted method getGenId() - In waitForAckIfAssuredEnabled(), used early exit. DomainFakeCfg.java: Comments => javadocs baseDn => baseDN Removed several unused methods. Added setWindowSize() + instance member. *Test*.java Used the DomainFakeCfg everywhere + SortedSet instead of Set. git-svn-id: https://svn.forgerock.org/opendj/trunk@9746 41b1ffd8-f28e-4786-ab96-9950f0a78031
21 Oct, 2013
1 commit
-
Use a root connection to do the initial user search, and then avoid explicitly setting authentication info, since it's done by the bind operation itself. git-svn-id: https://svn.forgerock.org/opendj/trunk@9741 41b1ffd8-f28e-4786-ab96-9950f0a78031
18 Oct, 2013
2 commits
-
This a a part of OPENDJ-175 - Decouple OpenDJ LDAP SDK from Grizzly CR2491 * In GrizzlyLDAPListener and GrizzlyLDAPConnectionFactory classes : - Default filter chain used for processing is built from transport instead of building it from scratch. - Additional Grizzly filters can be provided by using transport argument passed to constructors (no change implied) - Additional Grizzly filters are added between Transport filter and LDAP filter * Add a new utility class GrizzlyUtils that provides buildFilterChain and addFilterToConnection methods Use the utility class to factorize code to add a filter to the filter chain in LDAPServerFilter and GrizzlyLDAPConnection classes * Add test case for the new GrizzlyUtils class git-svn-id: https://svn.forgerock.org/opendj/trunk@9740 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
* revert back to previous "(objectClass=*)" search filter to avoid interop issues. git-svn-id: https://svn.forgerock.org/opendj/trunk@9738 41b1ffd8-f28e-4786-ab96-9950f0a78031
17 Oct, 2013
7 commits
-
ReplicationDbEnv.java, replication.properties: In openDatabase(), fixed TODOs for i18n. In newErrorMessage(), improved error logging by including the DB name. JEChangelogDB.java: Simplified the code by calling domainToReplicaDBs.remove() from inside shutdownReplicaDBs(). In shutdownReplicaDBs(), do not bother cleaning up the domainMap since it will be removed from domainToReplicaDBs. git-svn-id: https://svn.forgerock.org/opendj/trunk@9737 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
…e directory server's broker was not connected to a replication domain, hence it was impossible to add the changes to the changelogDB and then find them when querying the changelogDB. GenerationIdTest.java: Renamed assertConnectedToReplicationDomain() to waitConnectionToReplicationDomain(). LDAPReplicationDomain.java: Removed uses of StringBuilder, relied on *Operation.toString() to do it for us. ReplicationBroker.java: Improved toString(). ReplicationTestCase.java: Removed a wrong comment. Used Assertions.assertThat(). ReplicationServerTest.java: Removed a useless call to DirectoryServer.getSynchronizationProviders(). git-svn-id: https://svn.forgerock.org/opendj/trunk@9736 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
… that it is failing because the server is not connected to a replication domain, hence it is impossible to add the changes to the changelog. GenerationIdTest.java: Added assertConnectedToReplicationDomain() + called it. Fixed a few logged strings. git-svn-id: https://svn.forgerock.org/opendj/trunk@9735 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
* added support for paged results in rest2ldap. git-svn-id: https://svn.forgerock.org/opendj/trunk@9734 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
* added support for page results in memory backend. * unit test accidentally committed in previous commit. git-svn-id: https://svn.forgerock.org/opendj/trunk@9733 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
* added ByteSequence.isEmpty(). git-svn-id: https://svn.forgerock.org/opendj/trunk@9732 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
In toString(), improved the returned String. Changed rsServerId field from Integer to int. git-svn-id: https://svn.forgerock.org/opendj/trunk@9731 41b1ffd8-f28e-4786-ab96-9950f0a78031
16 Oct, 2013
2 commits
-
* Renamed LDAPConnectionFactoryTestCase and LDAPListenerTestCase to GrizzlyXXXTestCase to match src classes git-svn-id: https://svn.forgerock.org/opendj/trunk@9730 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Used StaticUtils.stackTraceToSingleLineString(e)) for logging on one line only. ReplicationBackend.java: Renamed all *containers to *domains. Reworked findExportContainers() and findSearchContainers() into only one method: selectReplicationDomains(). ListenerThread.java: Fixed formatting. ReplicationServerLoadBalancingTest.java: Code cleanup. git-svn-id: https://svn.forgerock.org/opendj/trunk@9729 41b1ffd8-f28e-4786-ab96-9950f0a78031
15 Oct, 2013
4 commits
-
More code cleanup. git-svn-id: https://svn.forgerock.org/opendj/trunk@9728 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Code cleanup. git-svn-id: https://svn.forgerock.org/opendj/trunk@9727 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
The adapter only requires opendj-core, not opendj-ldap-sdk. This was causing the server to pull in the core twice, once as opendj-core and once as part of opendj-ldap-sdk. git-svn-id: https://svn.forgerock.org/opendj/trunk@9726 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
UpdateOperationTest.java: Added consumeAllMessages(ReplicationBroker). In csnGeneratorAdjust(), called consumeAllMessages(). Extracted local variables serverId. Fixed formatting. Increased vertical density. Removed a useless call to Thread.sleep(). Removed useless comments. ReplicationBroker.java: Used local variables "localSession" to avoid concurrency issues when setSession(null) is called by another thread. *.java: Implemented toString(). git-svn-id: https://svn.forgerock.org/opendj/trunk@9725 41b1ffd8-f28e-4786-ab96-9950f0a78031
14 Oct, 2013
3 commits
-
Tried to simplify the code + separated similar looking test data between the different tests to help debug the (not so) random test failure. git-svn-id: https://svn.forgerock.org/opendj/trunk@9724 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
* Minor cleanup on test files git-svn-id: https://svn.forgerock.org/opendj/trunk@9723 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
* Adjust opendj-rest2ldap-servlet dependency on grizzly module : need to include transitive dependencies in war - Add dependency on opendj-grizzly in pom as optional - Copy the dependency and its transitive dependencies for inclusion in the war git-svn-id: https://svn.forgerock.org/opendj/trunk@9722 41b1ffd8-f28e-4786-ab96-9950f0a78031
12 Oct, 2013
1 commit
-
* I think that these were left over from previous versions of import. git-svn-id: https://svn.forgerock.org/opendj/trunk@9721 41b1ffd8-f28e-4786-ab96-9950f0a78031
11 Oct, 2013
9 commits
-
* Adjust opendj-rest2ldap-servlet dependencies - Add dependency on opendj-grizzly jar in generated war - No dependency on opendj-grizzly for use by another component git-svn-id: https://svn.forgerock.org/opendj/trunk@9720 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
ReplicationTestCase.java: In executeTask() and waitTaskState() added maxWaitTimeInMillis parameter. HistoricalTest.java: In testRecurringPurgeIn1Run(), added a sleep before configuring conflicts purge delay + waited purge for a maximum of 120 seconds (was approximatively 20 seconds before): as long as task max duration. InitOnLineTest.java, ReplicationServerTest.java: Consequence of the change to ReplicationTestCase. GenerationIdTest.java: Consequence of the change to ReplicationTestCase. Extracted method createSetGenerationIdTask(). git-svn-id: https://svn.forgerock.org/opendj/trunk@9719 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
* Added dependency-reduced-pom.xml to svn:ignore property git-svn-id: https://svn.forgerock.org/opendj/trunk@9715 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
* Removed dependency-reduced-pom.xml as it is a file generated by the build git-svn-id: https://svn.forgerock.org/opendj/trunk@9714 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
* Fix issue with dependencies when using opendj-ldap-sdk Now we ensure that : - maven-based clients don't get dependencies on opendj-core and opendj-grizzly - non-maven-based clients can use jar with all dependencies included opendj-ldap-sdk module uses: - maven-shade-plugin to build a jar from opendj-core and opendj-grizzly, to hide opendj-core and opendj-grizzly and to provide a corresponding (reduced) pom - copy-maven-plugin to extract content of jar into target/classes directory (needed by bundle) - maven-bundle-plugin to generate a custom META-INF/MANIFEST file * Remove duplicated javadoc/overview.html file git-svn-id: https://svn.forgerock.org/opendj/trunk@9713 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
In computeInitialServerStatus(), used early exits. In computeBestServerForWeight(), extracted methods computeBestServerWhenNotConnected() and computeBestServerWhenConnected(). Changed replicationServerUrls from Collection<String> to Set<String>. Removed useless field initialization to null. Renamed _publish() to publish() + reduced local variables scope. In receive(), renamed local variable replicationServerID to previousRsServerID and used this one more rather than the field. In changeConfig(), used Set.equals(). Changed getReplicationMonitor() to getReplicationMonitorInstanceName(). ReplicationDomain.java: Consequence of the change to ReplicationBroker.getReplicationMonitor(), inlined getReplicationMonitorInstanceName(). Consequence of the change to ReplicationBroker.replicationServerUrls. TestCaseUtils.java: Moved newSet(), newSortedSet(), newList() here from test classes. *Test.java: Consequence of the changes to ReplicationBroker.replicationServerUrls. git-svn-id: https://svn.forgerock.org/opendj/trunk@9712 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
package org.opends.server.types requires javadoc even for private methods. git-svn-id: https://svn.forgerock.org/opendj/trunk@9711 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
RDN.java: In getDNValue(), changed parameter from String to ByteString. In compareTo(), reordered the if statements + extracted method compare(). Comments => javadocs git-svn-id: https://svn.forgerock.org/opendj/trunk@9710 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Fixed a regression introduced in r9605: It was found by Christophe Sovant with the functional test suite. Partial revert of r9605: Using DN.toNormalizedString() should have been only done for replication metadata, not for user data because OpenDJ stores and returns data like provided by users. git-svn-id: https://svn.forgerock.org/opendj/trunk@9709 41b1ffd8-f28e-4786-ab96-9950f0a78031
10 Oct, 2013
9 commits
-
* simplify module names * minor pom cleanup * minor file cleanup, e.g. remove unused directories, etc. git-svn-id: https://svn.forgerock.org/opendj/trunk@9708 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Fixed a regression introduced in r9677. It was found by Christophe Sovant with the functional test suite: When throwing a DirectoryException with ERR_RESYNC_REQUIRED_UNKNOWN_DOMAIN_IN_PROVIDED_COOKIE, the domainCtxts is read before it is written to. This code should have been changed to iterate on the Set<DomainContext> rather than the domainCtxts field which has not been assigned at this point. git-svn-id: https://svn.forgerock.org/opendj/trunk@9707 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9706 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
* Introduce two new maven modules, resulting from splitting functionality of module opendj-ldap-sdk : opendj-core : core APIs opendj-grizzly : implementation classes for Grizzly transport provider These modules produce a jar with the same name (opendj-core and opendj-grizzly) The opendj-ldap-sdk module is kept for compatibility. It contains no more source code, but it provides a opendj-ldap-sdk jar built from the two new maven modules. * Move classes in opendj-grizzly module to org.forgerock.opendj.grizzly package * Move some classes in opendj-core module to the org.forgerock.opendj.ldap.spi package Modify visibility of some constructors and methods of these classes to allow use by classes in opendj-grizzly Classes : - AbstractLDAPFutureResultImpl - LDAPFutureResultImpl - LDAPSearchFutureResultImpl - LDAPBindFutureResultImpl - LDAPCompareFutureResultImpl - LDAPExtendedFutureResultImpl * Duplicated methods in opendj-grizzly module - LDAPReader#decodeEntry - LDAPWriter#encodeEntry to methods in opendj-core module - LDAPUtils#encodeSearchResultEntry - LDAPUtils#decodeSearchResultEntry to avoid sharing or exposing too much code from these classes. git-svn-id: https://svn.forgerock.org/opendj/trunk@9705 41b1ffd8-f28e-4786-ab96-9950f0a78031 -
DBCursor.java: Added usage example to the javadocs. DraftCNDB.java: Replaced catch (Exception) by catch (DatabaseException), or removed them altogether where unapplicable. In next(), first wiped the current record + reverted the if condition and clauses. git-svn-id: https://svn.forgerock.org/opendj/trunk@9704 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Changes after review from Matthew Swift. Renamed CNIndexRecord to ChangeNumberIndexRecord to be consistent with ChangeNumberIndexDB name. git-svn-id: https://svn.forgerock.org/opendj/trunk@9703 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Removed ChangeNumberIndexDB.getRecord(long). ECLServerHandler.java: Replaced calls to ChangeNumberIndexDB.getRecord() by calls to ChangeNumberIndexDB.getCursorFrom(). Inlined all the crossDomainStartState local variables. Added getCursorFrom() to preserve old behaviour from JEChangeNumberIndexDBCursor ctor. ChangeNumberIndexDB.java: Removed getRecord(). JEChangeNumberIndexDB.java: Removed getReadCursor(), getRecord() + some surprising and never used code like lock field, hasLock(), lock() and release(). JEChangeNumberIndexDBCursor.java: In ctor, do not throw ChangelogException if the changeNumber cannot be found. JEChangeNumberIndexDBTest.java: Used JEChangeNumberIndexDB.getCursorFrom() instead of JEChangeNumberIndexDB.getReadCursor(). Renamed a few variables. git-svn-id: https://svn.forgerock.org/opendj/trunk@9702 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
Added tests on the CSNs returned by changelog and on their order too. Removed stupid for loops. Extracted methods readCookie() and commonAssert(). Renamed: - getCookie() to assertContainsAndReadCookie() - assertEntries() to assertFourEntries() - assertDnEquals() to assertDNEquals() Added getCSNs(). git-svn-id: https://svn.forgerock.org/opendj/trunk@9701 41b1ffd8-f28e-4786-ab96-9950f0a78031
-
git-svn-id: https://svn.forgerock.org/opendj/trunk@9700 41b1ffd8-f28e-4786-ab96-9950f0a78031
