org.forgerock / org.forgerock.opendj

17 Aug, 2007

6 commits

  • ee29c2ce   Fixed some minor issues that were pointed out in review of the messages commit. … ... Browse Dir » 
    … This biggest issues here is the reversion of the Validator class to use String based messages instead of the message framework as the class is only used internally.


git-svn-id: https://svn.forgerock.org/opendj/trunk@2669 41b1ffd8-f28e-4786-ab96-9950f0a78031
    kenneth_suter
     
  • 203a1dc7   Fix for issues 2099 and 2101 (add package-info.java file for the packages of the… ... Browse Dir » 
    … ADS and of guitools).


git-svn-id: https://svn.forgerock.org/opendj/trunk@2668 41b1ffd8-f28e-4786-ab96-9950f0a78031
    jvergara
     
  • 8ac181a1   Fix for issue 2114. ... Browse Dir » 
    The DatabasesTableModel now returns for several values Message objects.  Update the DatabaseTableCellRenderer to take this into account.


git-svn-id: https://svn.forgerock.org/opendj/trunk@2667 41b1ffd8-f28e-4786-ab96-9950f0a78031
    jvergara
     
  • 5a6f4f02   Fix for issue 2113. The Listeners Model must return a String as a value for the… ... Browse Dir » 
    … listener state as it does for the other columns.


git-svn-id: https://svn.forgerock.org/opendj/trunk@2666 41b1ffd8-f28e-4786-ab96-9950f0a78031
    jvergara
     
  • ceb3ab47   The following modifications have the following goals: ... Browse Dir » 
    1. Provide a fix for the CLI part of issue 1894 (consider replication in uninstall).  The command line now proposes to remove references in remote servers of the server that is being uninstalled.

2. Add options to specify to uninstall only some parts of the server as appears in http://bde.central.sun.com/projects/opendsw/cmdline/commandmatrix.html.

3. Fix some bugs in the messages.

4. The fix of 1894 includes some code to display certificates to the user so that they can be viewed and accepted interactively.

5. Separate the uninstall command-line into two different command lines (uninstall-gui and uninstall)  as appears in http://bde.central.sun.com/projects/opendsw/cmdline/commandmatrix.html.


git-svn-id: https://svn.forgerock.org/opendj/trunk@2665 41b1ffd8-f28e-4786-ab96-9950f0a78031
    jvergara
     
  • 50eac72d   Provide a new EmbeddedUtils.initializeForClientUse() method that can be used to ... Browse Dir » 
    initialize the proper internal structures so that OpenDS code can be more
easily used for client-side applications that could benefit from the code but
don't want or need to be running in the same JVM as the server.

Also, update the DirectoryServer.bootstrapClient() method (which is what
EmbeddedUtils.initializeForClientUse() uses behind the scenes) can be called
multiple times on the same server instance without interfering with any
previous initialization that might have been done.  In short, it will ensure
that this initialization occurs no more than once during the life of the
DirectoryServer object instance.


git-svn-id: https://svn.forgerock.org/opendj/trunk@2664 41b1ffd8-f28e-4786-ab96-9950f0a78031
    neil_a_wilson
     

16 Aug, 2007

10 commits

  • 98e7e7a6   fixes broken launch status panel button ... Browse Dir » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@2662 41b1ffd8-f28e-4786-ab96-9950f0a78031
    kenneth_suter
     
  • 18f8edbc   Add a new convenience constructor for the InternalClientConnection class that ... Browse Dir » 
    allows you to create a new internal client connection authenticated as a given
user by providing only that user's DN (as opposed to having to create an
AuthenticationInfo object for the user in order to use the other constructor).


git-svn-id: https://svn.forgerock.org/opendj/trunk@2660 41b1ffd8-f28e-4786-ab96-9950f0a78031
    neil_a_wilson
     
  • 4d4b145b   Fix a problem in the network group design that prevented the server from ... Browse Dir » 
    restarting correctly when performing an in-core restart.  Also, eliminate a
potential null pointer exception if an admin alert was generated early in the
server startup process.

OpenDS Issue Number:  1518


git-svn-id: https://svn.forgerock.org/opendj/trunk@2659 41b1ffd8-f28e-4786-ab96-9950f0a78031
    neil_a_wilson
     
  • 0cdbaa86   This commit gets the QuickSetup installer working again by specifying the server… ... Browse Dir » 
    … root during the directory configuration.  This is addressed by adding a hidden arg to ConfigureDS for the server root that the installer uses for the specification of the directory.

This also fixes SchemaConfigManager so that it doesn' throw an NPE if the server root happens to not be specified and the schema directory cannot be determined. 


git-svn-id: https://svn.forgerock.org/opendj/trunk@2658 41b1ffd8-f28e-4786-ab96-9950f0a78031
    kenneth_suter
     
  • c137d4e1   fixed another stream almost identical to the previously problematic one ... Browse Dir » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@2657 41b1ffd8-f28e-4786-ab96-9950f0a78031
    kenneth_suter
     
  • 50781017   This addresses a few errors related to the messaging framework: ... Browse Dir » 
    - Fixes an error introduced in with Application.ErrorPrintStream no longer overrode println(String) as was causing a stack overflow. 
- Fixes a problem with Message in which raw format strings were run through the formatter with illegal argument specifiers which would throw an exception. 



git-svn-id: https://svn.forgerock.org/opendj/trunk@2656 41b1ffd8-f28e-4786-ab96-9950f0a78031
    kenneth_suter
     
  • 45dc50b6   changed method of finding workspace base dir ... Browse Dir » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@2652 41b1ffd8-f28e-4786-ab96-9950f0a78031
    kenneth_suter
     
  • b75cc1f7   Fix for broken message generation on Windows ... Browse Dir » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@2651 41b1ffd8-f28e-4786-ab96-9950f0a78031
    kenneth_suter
     
  • 92b39dd6   Update package-info.java files to include the @PublicAPI annotation to indicate ... Browse Dir » 
    whether any or all of the classes in that package are intended to be part of
the public API.  Further, mark all classes that we intend to be part of the
public API with the @PublicAPI annotation to indicate the ways in which they
may be used.  Note that the use of these annotations and the ultimate
determination as to what is in our public API and the ways in which those
elements may be used still needs to be carefully reviewed before the 1.0
release.

Also, perform minor cleanup in various places througout the code.  This
includes:

- Eliminate the use of protected fields in classes that are in the
org.opends.server.api package (and the classes that extend them).  The use of
protected fields can be troublesome, and there are generally better ways to
accomplish the same thing.

- Eliminate the use of the {@inheritDoc} Javadoc tag in classes that are
intended to be part of the public API.  Some IDEs don't resolve {@inheritDoc}
to show the actual documentation.  Further, there were problems in the way
that some instances of {@inheritDoc} were used, namely having a method sourced
from multiple parents, and in some cases {@inheritDoc} was used to refer to
code defined outside of the OpenDS codebase, which will not be properly handled
by the javadoc utility.

- Update a number of public API classes to mark them as final if we do not
intend for them to be overridden.  Further, for some classes that cannot be
marked final, mark some methods final if we do not intend for those methods to
be overridden.


git-svn-id: https://svn.forgerock.org/opendj/trunk@2650 41b1ffd8-f28e-4786-ab96-9950f0a78031
    neil_a_wilson
     
  • 942ec6f2   Make a change to remove additional ambiguity among Messages.raw methods. The ... Browse Dir » 
    version with arguments (Object, Object...) has been renamed to fromObject, as
it may have been seen as a conflict with one or more other raw methods.  There
was only a single existing use of the renamed method, and it has been updated.


git-svn-id: https://svn.forgerock.org/opendj/trunk@2649 41b1ffd8-f28e-4786-ab96-9950f0a78031
    neil_a_wilson
     

15 Aug, 2007

6 commits

  • b66d97e7   Correct a number of spelling errors identified in the message files. ... Browse Dir » 
    
git-svn-id: https://svn.forgerock.org/opendj/trunk@2648 41b1ffd8-f28e-4786-ab96-9950f0a78031
    neil_a_wilson
     
  • 85cf85e3   Update the javadoc for the ADSContextException.getReason() method because it ... Browse Dir » 
    had previously used {@inheritDoc} but after recent message changes now no
longer inherits from any parent class and was therefore generating a javadoc
warning.


git-svn-id: https://svn.forgerock.org/opendj/trunk@2647 41b1ffd8-f28e-4786-ab96-9950f0a78031
    neil_a_wilson
     
  • abf18f78   Launch the method backgroundTaskCompleted in the event thread. This way we avoi… ... Browse Dir » 
    …d having locking problems and the reactivity of the Graphical interfaces using this classes improves a lot.


git-svn-id: https://svn.forgerock.org/opendj/trunk@2645 41b1ffd8-f28e-4786-ab96-9950f0a78031
    jvergara
     
  • d22d0b7d   Removed ambiguity between two Messages.raw methods to make certain IDEs happy by… ... Browse Dir » 
    … reodering the parameters of one of the methods

git-svn-id: https://svn.forgerock.org/opendj/trunk@2644 41b1ffd8-f28e-4786-ab96-9950f0a78031
    davidely
     
  • 8055a387   Small fixes to have the message generation stuff work on Windows ... Browse Dir » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@2643 41b1ffd8-f28e-4786-ab96-9950f0a78031
    davidely
     
  • 7b183900   This commit is a step toward getting OpenDS internationalized. There are still i… ... Browse Dir » 
    …ssues to be resolved before we can declare that we are internationalized but this commit covers the bulk of changes needed at this time.

In general this commit converts any string values that might potentially be shown to an end user (client or administrator) to a new class called Message.  This includes exception messages, error log messages, alert and email text, labels, and CLI output.  Message's main interface includes methods for rendering itself as a string in the default locale using toString() or a specified locale toString(Locale).  In addition to addressing localization, this would allow us to potentially support controls allowing clients to set a preferred locale for server communication or output log messages in different languages.  Message extends CharSequence so it can be used in some places where strings are currently used with not code change (e.g. writing to a buffer) as well as allowing messages to be composed of one another.

In order to create localized messages, instead of adding them to the *Messages.java class, you define them in the corresponding properties files.  In general the property file keys are used to derive the new messages severity, category, and ordinal.  There are directives that can be used in the properties file in order to avoid doing this however.  For instance all the properties files used internally include the 'global.category' directive at the top of the file that instructs the generator to make all the following message belong to a single category.  So for internal messages the property value key will be as follows:

   [SEVERITY]_[DESCRIPTION]_[ORDINAL]

See the properties files themselves for more information.

Once your messages are in the properties file you can use the ant target 'generatemessages' to create create MessageDescriptor objects that are referred to in the Java code.  In the code you might think of these objects as replacing the int-valued message IDs.  To create messages you call MessageDescriptor.get() which replaces MessageHandler.getMessage().  It might be helpful then to try to define your messages before referring to them in your code since until you run 'generatemessages' you won't have any Java-code with with to create your message objects.

In order to support non-localizable text in messages (host names, DN's, etc.) Message's can be created from String values by calling Message.raw(String).  In this way it is also possible to circumvent the intention of changing the APIs to use Message objects instead of Strings which is to support writing of localizable messages.  This method is currently used in the code as a crutch for areas of the code that need internationalization (tagged with a 'TODO: i18n' comment).  It might also be used by 3rd party developers that don't intend to localize their products.  However for internal use we should not be using this method to create Messages for text that is locale sensitive.

Additionally this code includes a MessageBuilder that can be used in much the same way that a StringBuilder can be used.  It has a method toMessage() that can be used to generate a message object when needed.  At this time this method just converts the buffer contents to a raw, unlocalizable message so this will need to addressed in the future.

Some other issues:

- While all of the unit tests pass after this commit, there may be issues in the code where we have no or minimal test coverage.  This includes much of the setup and GUI tools packages for which I have not done any testing but will begin after this commit.

- The new message related Java sources are contained in package org.opends.messages and organized in a new module src/module modeled somewhat after the admin module:

    src/messages/src (non-generated Java source files)
    src/messages/generated (generated source files)
    src/messages/messages (properties files for messages)

If you run the code from within your IDE you will have to mark all messages/src, messages/generated and messages as source directories.

- To generated the MessageDescriptor files you invoke the 'generatemessages' target.

- If you run the code from within your IDE you will probably ne

- This commit would change the plugin API.  Here are the changes caught by DirectoryServerPluginTestCase:

    doShutdown(String)->doShutdown(Message)

    doPostDisconnect(PostDisconnectPluginResult,ClientConnection,DisconnectReason,int,String) ->         doPostDisconnect(PostDisconnectPluginResult,ClientConnection,DisconnectReason,Message);

- This commit aligns the entire code-base behind the new Formatter class (printf style formattings like %s) as opposed to the older MessageFormat style (using curly braces for message arguments).  This allows us to provide more type safety for message arguments.  So for instance you can include a %c argument specifier in your format string and the MessageDescriptor will enforce specification of a Character as message creation time.

- Not all of the config framework has not been converted to use Messages.  Perhaps as some point we might have a 'message' syntax for locale-sensitive textural data.  I'm sure Matt will have ideas about this.

- In addition to Message, MessageDescriptor and MessageBuilder, the org.opends.server.message package includes enums for Category and Severity that replace the definitions formerly found in MessageHandler.

- The interface for the ErrorLogger has been simplified to allow logging of messages using a single Message parameter.  The severity and category of the message will be derived from the Message itself instead of specified as arguments when a message is logged.

- I will provide more documentation about this plumbing on the Wiki shortly.

- I will expand on the included tests soon.


git-svn-id: https://svn.forgerock.org/opendj/trunk@2641 41b1ffd8-f28e-4786-ab96-9950f0a78031
    kenneth_suter
     

14 Aug, 2007

1 commit

13 Aug, 2007

5 commits

  • a84a56d9   Implement support for the "list" tag for use with MakeLDIF. This was the last ... Browse Dir » 
    major tag type that was supported by the SLAMD variant of MakeLDIF that was not
available with the OpenDS version.  Unfortunately, the OpenDS version is not
able to use exactly the same syntax as the SLAMD version, but the OpenDS
version has all of the same functionality and its syntax is actually more
consistent with that used by other tags than the SLAMD version.

OpenDS Issue Number:  588


git-svn-id: https://svn.forgerock.org/opendj/trunk@2619 41b1ffd8-f28e-4786-ab96-9950f0a78031
    neil_a_wilson
     
  • d0568dd0   Update the DIGEST-MD5 processing code to properly degrade to an initial ... Browse Dir » 
    authentication whenever a client requests subsequent authentication.  The
current implementation does not support subsequent authentication (which is an
optional part of the spec), but we were previously incorrectly rejecting
attempts to use it when instead we should have treated it as a completely new
DIGEST-MD5 session.

OpenDS Issue Number:  2098


git-svn-id: https://svn.forgerock.org/opendj/trunk@2614 41b1ffd8-f28e-4786-ab96-9950f0a78031
    neil_a_wilson
     
  • aa17b4ed   Add a new @PublicAPI annotation type that can be used later to mark OpenDS ... Browse Dir » 
    packages, classes, and methods to indicate what part (if any) they play in the
OpenDS public API.  This annotation type can be useful for documentation
purposes, for helping to verify whether third-party code is using appropriate
interfaces, and ensuring that what we declare as our public API does not change
in an inappropriate way between releases.

This commit also introduces a new StabilityLevel enumeration that can be used
to indicate the likelihood that the associated code will change in an
incompatible manner in the future.

Comments in the @PublicAPI annotation type and the StabilityLevel enum should
adequately describe their purpose and intended use.  At the present time, none
of the OpenDS code uses them, but we will add the @PublicAPI annotation to
OpenDS code where appropriate before the 1.0 release in order to help define
what is included in our public API.

Note that checkstyle analysis is currently disabled for this annotation type
because of an apparent checkstyle limitation that does not support the use of
Javadoc comments in methods used to define annotation type properties.


git-svn-id: https://svn.forgerock.org/opendj/trunk@2613 41b1ffd8-f28e-4786-ab96-9950f0a78031
    neil_a_wilson
     
  • 47ff5520   Provide a new org.opends.server.util.EmbeddedUtils class that can be used to ... Browse Dir » 
    simplify the process of running the server as an embedded application.  There
are methods to start, stop, and restart the server, as well as to determine
whether the server is running.  Also, provide a new
org.opends.server.types.DirectoryEnvironmentConfig class that can be used to
define a number of "environment" properties that provide information about the
way in which the server should run.

The TestCaseUtils.startServer method has been updated to make use of the new
EmbeddedUtils functionality.


git-svn-id: https://svn.forgerock.org/opendj/trunk@2612 41b1ffd8-f28e-4786-ab96-9950f0a78031
    neil_a_wilson
     
  • ecb29084   Add support for nested static groups and nesting of a dynamic groups ... Browse Dir » 
    in a static group. This implementation does not use a different
attribute to define a nested group. Issue 423

git-svn-id: https://svn.forgerock.org/opendj/trunk@2611 41b1ffd8-f28e-4786-ab96-9950f0a78031
    dugan
     

11 Aug, 2007

1 commit

  • 9c1f8df5   Fix issues 1996 and 1998. ... Browse Dir » 
    The previous fix in revision 2434 only catered for managed objects being created, not existing managed objects.

Also modify the ManagedObjectPath class to reject empty path names with an IllegalArgumentException. This will cause errors like this to be trapped earlier and fail predictably.

git-svn-id: https://svn.forgerock.org/opendj/trunk@2609 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew_swift
     

09 Aug, 2007

4 commits

08 Aug, 2007

3 commits

  • 7b465353   Make a change to the Group API that will allow for better nesting support. ... Browse Dir » 
    There are now variants of the isMember methods that include an additional
Set<DN> argument to which the current group's DN should be added whenever a
check is made to determine whether a user is a member.  This will help provide
a mechanism for avoiding infinite recursion loops if two groups both reference
each other as nested groups.


git-svn-id: https://svn.forgerock.org/opendj/trunk@2594 41b1ffd8-f28e-4786-ab96-9950f0a78031
    neil_a_wilson
     
  • 313cddf8   corrected duplicate ordinal values and argument replacement types ... Browse Dir » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@2592 41b1ffd8-f28e-4786-ab96-9950f0a78031
    kenneth_suter
     
  • cffd4a18   This set of changes add ID to identify network groups, workflows and workflow el… ... Browse Dir » 
    …ements. These identifiers pave the way for the network group and workflow configuration.

A workflow that is registered with a network group must have an identifier that is not already registered with the network group. To deregister a workflow one has to provide either a workflow base DN or a workflow identifier. The former method is used when a backend is deregistered with the server while the later may be used when applying workflow configuration changes.

The unit-tests are updated accordingly.



git-svn-id: https://svn.forgerock.org/opendj/trunk@2590 41b1ffd8-f28e-4786-ab96-9950f0a78031
    jdemendi
     

07 Aug, 2007

4 commits

  • 4dbf5f0b   Fix a number of copy-and-paste errors in the javadoc for the virtual static ... Browse Dir » 
    group implementation.


git-svn-id: https://svn.forgerock.org/opendj/trunk@2589 41b1ffd8-f28e-4786-ab96-9950f0a78031
    neil_a_wilson
     
  • b4f3d504   Add some more missing files. ... Browse Dir » 
    
git-svn-id: https://svn.forgerock.org/opendj/trunk@2588 41b1ffd8-f28e-4786-ab96-9950f0a78031
    jvergara
     
  • 3fdfc2aa   Add missing files to my previous commit: ... Browse Dir » 
    The following modifications have the following goals:

1. Provide a fix for the GUI part of issue 1894 (consider replication in uninstall).  Basically the graphical uninstall checks whether there is an ADS defined and if the server is configured for replication and asks the users whether (s)he wants to remove the references to the server that is being uninstalled.

2. Fix some minor issues that appear in the merged version of the installer and upgrader.

3. Update the build so that statuspanel.jar disappears.  The idea is to minimize the number of jars that we have.  This is a requirement coming from customers and approved by Neil in a conversation we had a while ago.

4. Minimize the number of classes that go to quicksetup.jar so that its size is the minimal possible and we reduce the download time when launching the WebStart based tools.  This has been done by moving the uninstaller tool to OpenDS.jar (with the status tools). 





git-svn-id: https://svn.forgerock.org/opendj/trunk@2587 41b1ffd8-f28e-4786-ab96-9950f0a78031
    jvergara
     
  • 2f1a0654   The following modifications have the following goals: ... Browse Dir » 
    1. Provide a fix for the GUI part of issue 1894 (consider replication in uninstall).  Basically the graphical uninstall checks whether there is an ADS defined and if the server is configured for replication and asks the users whether (s)he wants to remove the references to the server that is being uninstalled.

2. Fix some minor issues that appear in the merged version of the installer and upgrader.

3. Update the build so that statuspanel.jar disappears.  The idea is to minimize the number of jars that we have.  This is a requirement coming from customers and approved by Neil in a conversation we had a while ago.

4. Minimize the number of classes that go to quicksetup.jar so that its size is the minimal possible and we reduce the download time when launching the WebStart based tools.  This has been done by moving the uninstaller tool to OpenDS.jar (with the status tools). 


git-svn-id: https://svn.forgerock.org/opendj/trunk@2586 41b1ffd8-f28e-4786-ab96-9950f0a78031
    jvergara