org.forgerock / org.forgerock.opendj

06 May, 2013

5 commits

03 May, 2013

2 commits

  • be163680   OPENDJ-879 Add HTTP access log ... Browse Code » 
    
Warn about non existing HTTP access logger when the HTTP connection handler is starting (was when loggers are initialized).


LoggerConfigManager.java, HTTPConnectionHandler.java:
Moved the warning about non existing HTTP access logger from LoggerConfigManager.initializeLoggerConfig() to HTTPConnectionHandler.startServer().

HTTPAccessLogger.java:
Made getHTTPAccessLogPublishers() public.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8839 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 90314ebf   OPENDJ-879 (CR-1642) Add HTTP access log ... Browse Code » 
    

Implemented the HTTP access logger by taking inspiration from other loggers.
Configured the new logger everywhere other loggers are configured.
Logged the HTTP request in several places to cover all cases (happy paths, errors, etc.).



config.ldif, 02-config.ldif, HTTPAccessLogPublisherConfiguration.xml, FileBasedHTTPAccessLogPublisherConfiguration.xml, HTTPAccessLogPublisherCfgDefn.properties, FileBasedHTTPAccessLogPublisherCfgDefn.properties: ADDED
Added 2 new objectClasses HTTPAccessLogPublisherConfiguration and FileBasedHTTPAccessLogPublisherConfiguration.

config.properties:
Added new error messages for the HTTP access logger.

HTTPAccessLogger.java, HTTPAccessLogPublisher.java, TextHTTPAccessLogPublisher.java, HTTPRequestInfo.java: ADDED
HTTPRequestInfo.log() prevents double logging.

CollectClientConnectionsFilter.java:
Logged the request info when HttpServletResponse.setStatus(), sendAuthenticationFailure() and onFailure() are called.
Pushed more data to the HTTPRequestContext + switched to use the more specific HttpServletRequest/HttpServletResponse

SdkConnectionAdapter.java:
Logged the request info when close() is called.

LoggerConfigManager.java, TestCaseUtils.java:
Configured the HTTP access logger.

InProcessServerController.java: TO BE REMOVED (by Matt on the native packaging branch)



Sample log:
localhost bjensen [03/May/2013:10:14:54 +0200] "GET /users/_queryFilter=true&_prettyPrint=true HTTP/1.1" 500 "curl/7.27.0"
localhost bjensen [03/May/2013:10:15:05 +0200] "GET /users/_queryFilter=true&_prettyPrint=true HTTP/1.1" 200 "curl/7.27.0"
localhost  [03/May/2013:10:15:14 +0200] "GET /users/_queryFilter=true&_prettyPrint=true HTTP/1.1" 200 "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:20.0) Gecko/20100101 Firefox/20.0"
localhost  [03/May/2013:10:16:40 +0200] "GET /users/_queryFilter=true&_prettyPrint=true HTTP/1.1" 401 "curl/7.27.0"
localhost  [03/May/2013:10:16:50 +0200] "GET /users/_queryFilter=true&_prettyPrint=true HTTP/1.1" 200 "curl/7.27.0"
localhost  [03/May/2013:10:16:51 +0200] "GET /favicon.ico/null HTTP/1.1" 404 "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:20.0) Gecko/20100101 Firefox/20.0"
localhost  [03/May/2013:10:17:10 +0200] "GET /users/_queryFilter=true&_prettyPrint=true HTTP/1.1" 200 "curl/7.27.0"

git-svn-id: https://svn.forgerock.org/opendj/trunk@8832 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

02 May, 2013

3 commits

01 May, 2013

7 commits

30 Apr, 2013

6 commits

29 Apr, 2013

4 commits

26 Apr, 2013

3 commits

25 Apr, 2013

5 commits

  • 4023f7bd   Use factory methods from JsonValue. ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8805 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • 56254a0b   CR-1582 Remove reference to old known issues (part2) ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8804 41b1ffd8-f28e-4786-ab96-9950f0a78031
    csovant
     
  • 77009611   Use Maven to build OpenDJ server ... Browse Code » 
    
Trying to bring opendj server the most possible under maven.
Here maven-antrun-plugin is only used to generate the java files from our resources.
I am sure there are many glitches that need to be fixed in this file. We'll fix them over time. It is not ready to be used as prime build system yet. For example, no tests are run yet, or several resources are missing (.properties files, other??).
My goal is to bring opendj server under Sonar in order to see code coverage data.
Use "mvn -f pom-maven.xml clean install" to compile.

build.xml:
Renamed compileadmin target to generateadmin.mvn -f pom-maven.xml clean install
Added generatesources target depending on dynamicconstants, generatemessages and generateadmin.
In generateadmin target, pass down admin.src.dir property to generateadminsubtask.

pom-maven.xml: ADDED
Inspired from pom.xml.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8803 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • a1b5e7bf   OPENDJ-879 (CR-1603) Add HTTP access log ... Browse Code » 
    
Consolidated common code for the *Logger classes prior to implementing the HTTP access log.


AbstractLogger.java: ADDED
Pulled up from the *Logger classes.

AccessLogger.java, ErrorLogger.java, DebugLogger.java:
Now inherit from AbstractLogger.
Removed code pulled up into AbstractLogger: initializeErrorLogger(), isConfigurationAddAcceptable(), applyConfigurationAdd(), applyConfigurationChange(), isConfigurationDeleteAcceptable(), applyConfigurationDelete(), isJavaClassAcceptable(), getErrorPublisher().
Added the loggerStorage static variable.
Added a ctor + implemented getJavaClassPropertyDefinition() and getStorage().

LoggerConfigManager.java:
Replaced the calls to the various initialize*Logger() methods with calling initializeLogger().
Extracted method getLoggerInstance() and used it in all the other methods.


LogPublisherConfiguration.xml:
Pulled up the declaration of "java-class" property here from sub configurations.

AccessLogPublisherConfiguration.xml, DebugLogPublisherConfiguration.xml, ErrorLogPublisherConfiguration.xml, LogPublisherConfiguration.xml:
Replaced the declaration of "java-class" property by a property-override.

StaticUtils.java:
Added close(Collection<Closeable>)

git-svn-id: https://svn.forgerock.org/opendj/trunk@8802 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 73a94d25   Added modify functionality. ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8801 41b1ffd8-f28e-4786-ab96-9950f0a78031
    glennvl
     

24 Apr, 2013

5 commits

  • b1733934   Fix Javadoc typo. ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8799 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • 8e5e7f21   Replication Cleanup. ... Browse Code » 
    Tons of simplification of code, fix of typos, transformed comments to block.
In ReplicationDomain, changed synchronization of Map with a concurrentHashMap.
Fixed an error message in LDAPReplicationDomain
Removed mods from error message on Assured replication ack timeout (could be too large).
Added a log message on critical error (when reading change from RS db).
Removed some unused code.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8797 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ludo
     
  • b91866fa   OPENDJ-879 (CR-1600) Add HTTP access log ... Browse Code » 
    
Consolidated common code for the *LogPublisher classes prior to implementing the HTTP access log.


LogPublisher.java: ADDED
Unify all the *LogPublisher classes.
Implements Closeable.

AccessLogPublisher.java, DebugLogPublisher.java, ErrorLogPublisher.java:
Now implementing LogPublisher.
Pulled up isConfigurationAcceptable(), initialize*LogPublisher() renamed to initializeLogPublisher(), close(), getDN().
Removed syntactic/spaces differences between all these classes to better expose their commonalities.
Used Set and MAp interfaces rather than comcrete classes.

AccessLogger.java, ErrorLogger.java, DebugLogger.java:
In isJavaClassAcceptable() and getAccessPublisher(), replaced method invocations via reflection by direct method calls.

TextAccessLogPublisher.java, TextAuditLogPublisher.java, TextErrorLogPublisher.java, ThreadFilterTextErrorLogPublisher.java, TextDebugLogPublisher.java, ConsoleDebugLogPublisher.java:
Consequence of renaming the initialize*LogPublisher() methods, or generecizing the isConfigurationAcceptable() methods in their parent classes.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8792 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • 3b5fcf26   Remove source files of the User Interface ... Browse Code » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@8791 41b1ffd8-f28e-4786-ab96-9950f0a78031
    jochenr
     
  • dfac0066   Tests cleanup ... Browse Code » 
    CryptoManagerTestCase.java:
Replaced use of reflection with use of direct method call.
Removed useless parentheses.


ExtensionTestUtils.java: ADDED
Factorizes common code among Extensions tests cases.

EntryDNVirtualAttributeProviderTestCase.java, EntryUUIDVirtualAttributeProviderTestCase.java, GoverningStructureRuleVirtualAttributeProviderTestCase.java, HasSubordinatesVirtualAttributeProviderTestCase.java, NumSubordinatesVirtualAttributeProviderTestCase.java, StructuralObjectClassVirtualAttributeProviderTestCase.java, SubschemaSubentryVirtualAttributeProviderTestCase.java:
Moved common code from 6 tests methods to ExtensionTestUtils + made tests delegate to the ExtensionTestUtils static methods.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8790 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac