org.forgerock / org.forgerock.opendj

20 Aug, 2015

1 commit

27 Jul, 2015

4 commits

  • b2fd1d33   OPENDJ-2027 CR-7646 Change tools message on error ... Browse Dir » 
    This commit makes all tools consistent in the way that if no arguments are provided on the command line (or only the non prompt argument for interactive tools), tool prints the error and the help reference message on error stream.
Changes details:
* ArgumentParser
** Create method displayMessageAndUsageReference(), this method is used by tools to print both an error message and the help usage reference message
** getHelpUsageReference() has been moved from SubCommandArgumentParser

* DSConfig
** displayErrorMessageAndUsageReference() has been moved to ArgumentParser

* CreateRCScript
** Moves the server root path check after the argument parsing in order to have a consistent error message if arguments are invalid.

* RebuildIndex
* VerifyIndex
** Removed dead code which printed usage if no args were provided (if so, an argument exception is raised before).

* MakeLDIF
** Add a main method for test purpose

* ArgumentParserToolsTestCase
** Test that tools are consistent if an invalid argument is provided or if no args are provided.

Tools modified by this commit are the following:
Server tools
* Does not print usage anymore
** backup
** base64 (only if no args are provided)
** control-panel
** create-rc-script
** dbtest
** dsjavaproperties
** dsreplication
** encode-password
** export-ldif
** import-ldif
** ldapcompare
** ldapdelete
** ldapmodify
** ldappasswordmodify
** ldapsearch
** ldif-diff
** ldifmodify
** ldifsearch
** make-ldif
** manage-account
** manage-tasks
** rebuild-index
** restore
** setup
** start-ds
** status
** stop-ds
** uninstall
** upgrade
** verify-index

* Usage reference message added
** base64 (only if invalid args are provided)

SDK tools
* Does not print usage anymore
** addrate
** makeldif

* Usage reference message added
** authrate
** ldapcompare
** ldapmodify
** ldappasswordmodify
** ldapsearch
** ldifdiff
** ldifmodify
** ldifsearch
** modrate
** searchrate

git-svn-id: https://svn.forgerock.org/opendj/trunk@12701 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • 1027841c   OPENDJ-2027 Refactor MakeLDIF integration test ... Browse Dir » 
    * MakeLDIFITCase
** Inherits from ToolITCase
** Uses parent checkOutputStreams() method
** Add a test to check that -H displays help
** Code cleanup

git-svn-id: https://svn.forgerock.org/opendj/trunk@12700 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • a0d3a9ef   OPENDJ-2027 Rename MakeLDIFTestCase ... Browse Dir » 
    * MakeLDIFTestCase -> MakeLDIFITCase to improve consistency in the package.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12699 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • f2326b64   Add missing return statement ... Browse Dir » 
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12698 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     

20 Jul, 2015

1 commit

  • b7bdd646   OPENDJ-1666 CR-7647 forgerock-util 2.0.0 migration ... Browse Dir » 
    * Note that this migration just solved compilation issues, it does not try to take benefits from the apis enhancements.
* The major change is that org.forgerock.opendj.ldap.ResultHandler has been renamed to org.forgerock.opendj.ldap.LdapResultHandler.java to prevent conflicts with the org.forgerock.util.promise.ResultHandler

git-svn-id: https://svn.forgerock.org/opendj/trunk@12687 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     

01 Jun, 2015

2 commits

28 May, 2015

2 commits

18 May, 2015

1 commit

12 May, 2015

1 commit

06 May, 2015

1 commit

  • 6f62aba1   OPENDJ-1993 Replace outdated Java 6 references ... Browse Dir » 
    Review: Matt (uppon the shoulder)
This commit replaces Java 6 occurences by Java 7 in messages.
It also performs the Java version check against Java 7.

* org.opends.quicksetup.util.Utils.java
** Use opendj-cli check java version, this allow us to remove old check process based on CompatibleJava

* Other changes are just messages or text update.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12208 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     

28 Apr, 2015

1 commit

07 Apr, 2015

2 commits

  • a577243a   CR-6574 OPENDJ-1923 Move doc out of properties files ... Browse Dir » 
    This patch moves long document strings out of properties files,
replacing them with XIncluded files.

Tested with a manual doc build and visual check.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12054 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     
  • ee996f94   CR-6575 OPENDJ-1912 Move doc source generation to a profile ... Browse Dir » 
    This patch speeds up a basic clean install
by moving doc generation out of the common path into a profile.

This patch requires that both native package builds and also doc builds
now use -Pman-pages to build the man pages.

Otherwise the build breaks with a message:
Man pages not found. You must build with -P man-pages.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12044 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     

03 Apr, 2015

1 commit

  • c8ad3759   CR-6570 OPENDJ-1898 Move to single doc gen plugin ... Browse Dir » 
    This patch brings the doc generation plugins together
in a single module, and adapts the implementation
of the log ref generation plugin to use a FreeMarker template
as is already in use in other plugins.

This patch also uses sections in the log ref.
Sections, rather than naked variablelists,
make the log ref easier to navigate.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12027 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     

27 Mar, 2015

1 commit

  • 3e18d45c   CR-6483 OPENDJ-1786 Automate integration of generated content ... Browse Dir » 
    This patch replaces nearly all the server & SDK tools reference pages
with generated pages.

As explained in the comments for OPENDJ-1786,
there's still a problem with <xref> linkends inside the dsconfig page.
I've logged OPENDJ-1895 to address that.

The rest of the content seems to correspond to what we had before,
with minor formatting problems that are flagged in related JIRA issues.

Thanks to Jean-Noël R. for reviews.

git-svn-id: https://svn.forgerock.org/opendj/trunk@11994 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     

25 Mar, 2015

1 commit

  • e97a9ee5   Work around broken link ... Browse Dir » 
    This patch replaces a broken link with a reference.
It removes the . at the end of the link to avoid confusing some apps.

Thanks to Lee Trujillo for spotting the problem.

git-svn-id: https://svn.forgerock.org/opendj/trunk@11975 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     

24 Mar, 2015

1 commit

  • c0d65c3b   OPENDJ-1886: Remove short option for testonly arg ... Browse Dir » 
    *****  opendj-cli *****
* ArgumentConstants.java
** Add constant for testonly long option

* CommonArguments.java
** Removes getTestOnly(...) static method as it is only used in InstallDS.

* cli.properties
** Removes INFO_ARGUMENT_DESCRIPTION_TESTONLY message and migrate it to server tool.properties to have consistant import in InstallDS.java

***** opendj-ldap-toolkit *****
* resources/.../_script_util.bat
** Replace short option call by long option call

***** opendj-server-legacy *****
* resources/.../bin/_script-util.sh _script-util.bat
** Replace short option call by long option call

* InstallDSArgumentParser.java
** Inline static call to CommonArguments

* tools.properties
** Add testonly argument information message

git-svn-id: https://svn.forgerock.org/opendj/trunk@11968 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     

20 Feb, 2015

1 commit

13 Feb, 2015

1 commit

  • 348eb949   CR-6068 OPENDJ-1785 Add "extra" doc into code for generated content ... Browse Dir » 
    This patch is like r11722, but for the LDAP SDK tools.

This patch does not resolve the fact that duplicate tools exist.
I have, however, logged OPENDJ-1810 regarding that point.
Duplication should disappear in the move to a single set of tools.

This is a subtask of the following issue:
OPENDJ-386 Move to single reference document

git-svn-id: https://svn.forgerock.org/opendj/trunk@11735 41b1ffd8-f28e-4786-ab96-9950f0a78031
    mark
     

12 Feb, 2015

1 commit

29 Jan, 2015

2 commits

15 Jan, 2015

1 commit

28 Nov, 2014

1 commit

27 Nov, 2014

1 commit

  • 89e7c9a3   OPENDJ-1607 (CR-5295) Merge HeartBeatConnectionFactory, AuthenticatedConnectionF… ... Browse Dir » 
    …actory and GrizzlyLDAPConnectionFactory

To avoid code duplication and makes API more fluent, we have merged HBCF, ACF and GCF by creating an AbstractLdapConnectionFactoryImpl.
The new connection skeletal associated is AbstractLdapConnectionImpl.
This is a sub-optimal solution, there is still some concurrency issues to address in AbstractLdapConnecitonImpl.

git-svn-id: https://svn.forgerock.org/opendj/trunk@11348 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     

03 Nov, 2014

1 commit

  • 550a9b87   AutoRefactored: ... Browse Dir » 
    - work with null checked expressions first
- revert conditions
- collapse if statements
- push negations down
- invert equals()

Manually used ternary operators

git-svn-id: https://svn.forgerock.org/opendj/trunk@11233 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

20 Oct, 2014

2 commits

17 Oct, 2014

1 commit

  • 4e9e9fcf   OPENDJ-1549: xxxrate tools warmup duration does not clear etimes ... Browse Dir » 
    * com.forgerock.opendj.ldap.tools.PerformanceRunner
** Makes the ResponseTimeBuckets inner class package private to allow unit tests.
* com.forgerock.opendj.ldap.tools.PerformanceRunnerStatsTestCase
** Adds a simple black box unit test to control PerformanceRunner eTimes calculation.

git-svn-id: https://svn.forgerock.org/opendj/trunk@11156 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     

15 Oct, 2014

1 commit

07 Oct, 2014

1 commit

  • 603d74cf   PerformanceRunner.java: ... Browse Dir » 
    Extracted local PrintStream variable rather than always calling app.getOutputStream().

git-svn-id: https://svn.forgerock.org/opendj/trunk@11085 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

03 Oct, 2014

1 commit

29 Sep, 2014

1 commit

  • a30c1c4f   OPENDJ-1536 OPENDJ-1285 Rename FutureResult classes hierarchy in the SDK to enhance code consistency ... Browse Dir » 
    * org.forgerock.opendj.ldap package:
** Rename FutureResult to LdapPromise
** Rename FutureResultImpl to LdapPromiseImpl and move it to org.forgerock.opendj.ldap.spi
** Rename the util class FutureResultWrapper to LdapPromises and move it to org.forgerock.opendj.ldap.spi package 
** Solve some bugs in HeartBeatConnectionFactory class

org.forgerock.opendj.ldap.spi
** Merge old LDAPFutureResultImpl and AbstractLDAPFutureResultImpl and rename it as ResultLdapPromiseImpl
** Remove AbstractLDAPFutureResultImpl, LDAPFutureResultImpl and LDAPCompareFutureResultImpl
** Rename LDAP[Bind | Extended | Search]FutureResultImpl to [Bind | Extended | Search]ResultLdapPromiseImpl
** Add static methods in LdapPromises to return *LdapPromiseImpl instances

git-svn-id: https://svn.forgerock.org/opendj/trunk@11065 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     

19 Sep, 2014

1 commit

15 Sep, 2014

1 commit

  • b0f324ed   OPENDJ-1285 CR-4409 Migrate SDK from Futures to Promises ... Browse Dir » 
    Connection, ConnectionFactory, ResultHandler and SearchResultHandler public APIs have been changed.
* Connection.java
  In all xxxAsync method, the final handler parameter will be removed and the client is expected to register the handler with the returned promise. For search request, a SearchResultHandler is still required because it needs to handle search result entries/references.

* ConnectionFactory.java
  In the method getConnectionAsync(), the final handler parameter will be removed.

* ResultHandler.java
  Now extends SuccessHandler and FailureHandler in order to allow usage of then() method call.

* SearchResultHandler.java
  Remove the inheritance link with ResultHandler. So client needs to register a ResultHandler instance when he calls searchAsync in addition to register a SearchResultHandler.

git-svn-id: https://svn.forgerock.org/opendj/trunk@11001 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     

22 Aug, 2014

1 commit

19 Aug, 2014

1 commit