org.forgerock / org.forgerock.opendj

25 Aug, 2015

12 commits

6a2e6899 Fix checkstyle ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12788 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
fabiop
2015-08-25 16:43:25 +0000

b473a235 SearchFilter.java: ... Browse Dir »

Used Collection.contains().

LDAPURL.java:
Simplified equals().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12787 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-25 16:03:49 +0000

89f2c442 Use Collection.contains() ... Browse Dir »

Used early exits
Removed duplicated code

git-svn-id: https://svn.forgerock.org/opendj/trunk@12786 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-25 16:02:28 +0000

297ff520 CommonSchemaElements.java: ... Browse Dir »

Changed getNormalizedNames() to return a Set instead of Iterable.

*.java:
Consequence of the change to CommonSchemaElements.getNormalizedNames().
Used early exits.
Extracted method SchemaElementPanel.getAliases().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12785 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-25 15:59:10 +0000

caed5af9 VerifyIndex.java: ... Browse Dir »

In mainVerifyIndex():
- use Collection.contains()
- release the shared lock in a finally clause

git-svn-id: https://svn.forgerock.org/opendj/trunk@12784 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-25 15:49:47 +0000

0c5d3200 Remove duplicated code ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12783 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-25 15:47:47 +0000
fb7c7ddb Fix build (Eclipse did not give me any errors :( ) ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12782 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-25 14:48:55 +0000
a00b8260 Use Collection.contains() ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12781 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-25 13:11:18 +0000
e1fafc6b Use Collection.contains() ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12780 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-25 13:00:27 +0000

80cfedf5 Code cleanup ... Browse Dir »


Entry.java:
In applyModification(), extracted methods applyModificationToObjectclass() and applyModificationToNonObjectclass().
In hasUserAttribute() and hasOperationalAttribute(), extracted method hasAttribute()
Used Attribute.isReal() to explicit code + merged if statements.


Attribute.java:
Added isReal() -> !isVirtual().

AbstractAttribute.java:
Implemented isReal().
In equals() extracted method valuesEqual().
In hasAllOptions() and optionsEqual(), extracted method hasAllOptions0().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12779 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-25 12:51:06 +0000

75c5ce2f OPENDJ-1666 Code cleanup ... Browse Dir »

* org.opends.server.protocols.http.HttpConnectionHandler
** Fix copyright section
** Make code more readable
*** Reformat
*** Inline some local variables

* org.opends.server.protocols.http.HTTPClientConnection
** Fix copyright section
** Reformat

* org.opends.server.protocols.http.CollectClientConnectionsFilter
** Fix copyright

* org.opends.server.protocols.http.CollectClientConnectionsFilterTest
** Reformat

git-svn-id: https://svn.forgerock.org/opendj/trunk@12778 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-25 08:12:30 +0000

1ff1552e AutoRefactor'ed Modification.java ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12777 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-25 07:52:56 +0000

24 Aug, 2015

2 commits

4dd4823c EntryHistorical.java: ... Browse Dir »

Use HistAttrModificationKey instead of raw string.
Code cleanup

git-svn-id: https://svn.forgerock.org/opendj/trunk@12775 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-24 09:13:47 +0000

52c76278 HistAttrModificationKey.java: ... Browse Dir »

Renamed DELATTR to ATTRDEL to match string representation.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12772 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-24 07:59:10 +0000

21 Aug, 2015

2 commits

6a724f71 AttrHistoricalSingle.java: ... Browse Dir »

Extracted methods replaceOrDelete(), add(), replace(), delete() and deleteWithoutDeleteTime() to increase code expressiveness.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12769 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-21 14:48:58 +0000

a1a9d57a AttrHistoricalMultiple.java, AttrValueHistorical.java: ... Browse Dir »
```
Improved toString()

git-svn-id: https://svn.forgerock.org/opendj/trunk@12765 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-21 10:51:46 +0000

20 Aug, 2015

2 commits

cfa395e7 CR-8001 OPENDJ-2216 Add upgrade task which reruns dsjavaproperties ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12763 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2015-08-20 17:19:24 +0000

592f2972 RebuildIndexTask.java: ... Browse Dir »

Removed indexExists, used Collection.contains() instead

git-svn-id: https://svn.forgerock.org/opendj/trunk@12761 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-20 10:14:55 +0000

19 Aug, 2015

1 commit

f6eafc85 CR-7872 OPENDJ-2238 Add support for FreeBSD to init script ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12756 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2015-08-19 09:43:33 +0000

18 Aug, 2015

3 commits

16d24293 AttrHistoricalSingle.java: ... Browse Dir »

In processLocalOrNonConflictModification(), made the code more explicit + prevented double assignment

*.java:
Added toString().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12755 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-18 14:51:20 +0000

fbd5487a Changed AttrHistorical.getValuesHistorical() return type to match usage ... Browse Dir »


AttrHistorical.java:
In getValuesHistorical(), changed return type from Map<AttrValueHistorical, AttrValueHistorical> to Set<AttrValueHistorical> - to match the usage.

AttrHistoricalMultiple.java:
Consequence of the change to AttrHistorical.getValuesHistorical().
In delete(Attribute, CSN), now call delete(ByteString, CSN).
In add(Attribute, CSN), now call add(ByteString, CSN).
Extracted method update(CSN, AttrValueHistorical).
In conflictAdd(), changed return type to void since it was never used.
Removed javadoc copied from supertype + useless @inheritDoc.
Reduced method's visibilities.

AttrHistoricalSingle.java
Consequence of the change to AttrHistorical.getValuesHistorical().
Removed javadoc copied from supertype + useless @inheritDoc.
Used static import for HistAttrModificationKey.*.
Extracted method getSingleValue().

EntryHistorical.java:
Consequence of the change to AttrHistorical.getValuesHistorical().
Extracted method toOptionsString().
In newInstanceFromEntry(), reduced scope of variables.

AttrInfoTest.java:
Consequence of the change to AttrHistorical.getValuesHistorical().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12754 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-18 12:56:09 +0000

3a418f54 Replaced uses of StringBuilder.append(Utils.joinAsString(String, Collection)) wi… ... Browse Dir »
```
…th the more efficient Utils.joinAsString(StringBuilder, String, Collection).

git-svn-id: https://svn.forgerock.org/opendj/trunk@12753 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-18 09:39:52 +0000

17 Aug, 2015

6 commits

e52f59c4 DirectoryServer.java: ... Browse Dir »

Removed fields duplicating the ones from CoreSchema + replaced them with the getters directly delegating to CoreSchema methods.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12752 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-17 15:01:57 +0000

e6a7de5a DatabaseEnvironmentMonitor.java: ... Browse Dir »

Remove class which has been moved to org.opends.server.backends.jeb

git-svn-id: https://svn.forgerock.org/opendj/trunk@12751 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-17 14:35:58 +0000

7c871b0b Code cleanup ... Browse Dir »

Fix a bug in RootDSEBackend.getRootDSE().

RootDSEBackend.java:
In getRootDSE(), fix a bug with supportedAuthPWSchemes which wrongly referred to supportedSASLMechanism attribute.
In addAttribute(), renamed publicNamingContextAttr parameter to attribute
Used interfaces for collections rather than concrete classes.
Removed useless @inheritDoc javadoc.

Task.java:
Extracted methods getTime(), compareTimes(), 
In execute(), simplified code.

LDAPReplicationDomain.java, ReplicationDomainMonitorData.java:
Code cleanups

git-svn-id: https://svn.forgerock.org/opendj/trunk@12745 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-17 08:56:29 +0000

0e49b07f Fix incorrect error message in replication ... Browse Dir »

replication*.properties:
ERR_RSQUEUE_DIFFERENT_MSGS_WITH_SAME_CN => ERR_RSQUEUE_DIFFERENT_MSGS_WITH_SAME_CSN

git-svn-id: https://svn.forgerock.org/opendj/trunk@12744 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-17 08:38:24 +0000

5649077e OPENDJ-2233 CR-7906 Changelog cursoring seems to rely on exception handling too much. ... Browse Dir »

Avoid try to reading past EOF, as it generates too many exceptions unnecessarily.


git-svn-id: https://svn.forgerock.org/opendj/trunk@12743 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-17 08:36:09 +0000

695b1a7f Code improvements ... Browse Dir »


DN2URI.java:
Do not decode DN when only the list of URIs is needed:
- extracted methods decodeUrisOnly(), decode0(), decodeDN(), decodeUris()
- used Map.Entry instead of Pair because it maps exactly to the role of DN2URI index (where DN is the key and List of URIs is the value).


EntryContainer.java:
Extracted method getNumberOfEntriesInBaseDN0() to avoid creating a sub transaction (used by RootContainer).

VerifyJob.java:
Used SuffixContainer constants.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12742 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-17 08:21:47 +0000

14 Aug, 2015

6 commits

97c9b5de Code cleanup ... Browse Dir »



HistoricalAttributeValue.java:
Added toString() for easier debugging.

HistoricalAttributeValueTestCase.java: CREATED

HistAttrModificationKey.java:
In DELATTR, fixed a bug.
In decodeKey(), simplified the code.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12741 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-14 16:46:14 +0000

796eeff2 AbstractOperation.java: ... Browse Dir »

Removed setResults(), used the more complete setResponseData() instead

*.java:
Called AbstractOperation.setResponseData().
Removed useless @inheritDoc javadocs.
Ran UCDetector
Grouped relevant fields together.
Cleaned up constructors.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12739 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-14 13:25:31 +0000

d58a8104 Removed code duplication, made code more readable ... Browse Dir »

I think PasswordModifyExtendedOperation.processExtendedOperation() should call setMatchedDN() ?



AbstractOperation.java:
Extracted methods processOperationResult() and setResults().

PluginResult.java:
Extracted PluginResult.OperationResult interface out of several types.
Removed duplicate javadocs.
Used {@code} in javadocs.
Fixed typos.

SynchronizationProviderResult.java:
Now extends PluginResult.OperationResult + removed duplicate declarations.



*OperationBasis.java:
Called processOperationResult() and setResults().
Used static imports for DirectoryServer.*.
Removed useless comments.

LocalBackend*Operation.java
Called processOperationResult() and setResults().
Used static imports for DirectoryServer.*.
Removed useless comments.
Extracted method getAccessControlHandler().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12738 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-14 11:57:52 +0000

a8dc2293 Code cleanup ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12737 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-14 09:18:15 +0000

fcd0d6ff Extracted method PasswordPolicyState.isLocked(). ... Browse Dir »

PasswordPolicyState.java:
Extracted methods isLocked(), computeHighestTime() and newAttribute()

*.java:
Used PasswordPolicyState.isLocked().

git-svn-id: https://svn.forgerock.org/opendj/trunk@12736 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-14 08:56:25 +0000

b032c912 Code cleanup: ... Browse Dir »

- removed code duplication
- explicited code. this allowed to remove useless comments

LocalBackendModifyOperation.java:
Extracted methods mustCheckSchema(), processInitialSchema(), addIfAttributeValueExistsPreEncodedPassword(), addIfAttributeValueExistsNoPreEncodedPassword(), checkSchema(), isHumanReadable()
Removed unused method getName()

git-svn-id: https://svn.forgerock.org/opendj/trunk@12735 41b1ffd8-f28e-4786-ab96-9950f0a78031

2015-08-14 08:21:46 +0000

13 Aug, 2015

1 commit

41175322 Following Jean-Noel suggestion (thank you, btw), replace an expensive operation with a simpler one. ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12731 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
fabiop
2015-08-13 08:31:01 +0000

12 Aug, 2015

3 commits

bdf23c6c Extracted methods to remove duplicated code ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12725 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-12 10:47:38 +0000
cf968c4a Code cleanup ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12723 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-12 09:54:04 +0000
70c5dc07 Remove unused import ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12721 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2015-08-12 07:32:56 +0000

07 Aug, 2015

1 commit

932e6b94 OPENDJ-1359 CR-7818 Control panel requires incremental backups specify the parent ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@12717 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ian.packer
2015-08-07 11:12:02 +0000

05 Aug, 2015

1 commit

42066654 OPENDJ-2237 Searching with SASL trace option generates an error in error log. ... Browse Dir »
```
Removed an "error" message that should only be in access log.

git-svn-id: https://svn.forgerock.org/opendj/trunk@12716 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
fabiop
2015-08-05 17:17:13 +0000