org.forgerock / org.forgerock.opendj

16 Jul, 2013

7 commits

7bbc9377 CR-2008 Fix for OPENDJ-1057: dsconfig reference does not accurately explain how … ... Browse Dir »

…'components' of the 'OpenDJ configuration refence it refers to have to be used

git-svn-id: https://svn.forgerock.org/opendj/trunk@9249 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-16 14:51:34 +0000

476f24cd Fix build break ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9248 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-07-16 14:41:19 +0000

1615d261 BooleanHolder.java: ... Browse Dir »

Forced specifying a default value in the ctor.
Implemented toString().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9247 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-16 14:22:03 +0000

4fc22897 CR-2005 Fix OPENDJ-1036 Cleanup passwords in memory? ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9246 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2013-07-16 14:12:20 +0000
f5f09ce1 CR-2007 Fix for OPENDJ-1047: Create a reference entry for windows-service.bat ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9245 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-07-16 14:00:23 +0000
a992555b CR-2006 Fix for OPENDJ-1046: Make paths to commands consistent throughout the doc set ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9243 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-07-16 12:55:19 +0000

d121f14d Respected the Single Responsibility Principle by splitting findAndSetMatchingDN(… ... Browse Dir »

…) method into findMatchedDN() and setMatchedDN() methods.

Also fixed the checkstyle error.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9241 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-16 07:57:52 +0000

15 Jul, 2013

6 commits

9cd0b5a1 Extracted several time the method findAndSetMatchingDN(). We should look at movi… ... Browse Dir »

…ng this code to a single reusable place.

LocalBackend*Operation.java:
Extracted method findAndSetMatchingDN() from the process*() methods. Tidied up the code to make it the same across all classes.

PasswordModifyExtendedOperation.java:
Extracted method findAndSetMatchingDN() from getEntryByDN().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9240 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-15 15:24:47 +0000

21361e63 Remove unused messages ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9238 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2013-07-15 09:09:19 +0000
de100d34 Created NullOutputStream.wrapOrNullStream() and used it in all tools instead of … ... Browse Dir »
```
…duplicating the null checks everywhere.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9234 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-15 08:41:33 +0000
2fd5fcda Created NullOutputStream.wrapOrNullStream() and used it in all tools instead of … ... Browse Dir »
```
…duplicating the null checks everywhere.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9233 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-15 08:40:31 +0000

8865c993 Refactoring on the LocalBackend*Operation classes: ... Browse Dir »

- Extracted process*() methods from the processLocal*() methods for the LocalBackend*Operation classes.
- Transformed plain comments into javadocs.
- Used interfaces instead of concrete classes.
- Made all protected members be private.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9232 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-15 08:17:58 +0000

18206e98 Refactoring on the LocalBackend*Operation classes: ... Browse Dir »

- Moved BooleanHolder out of LocalBackendAddOperation.
- Extracted process*() methods from the processLocal*() methods for the LocalBackend*Operation classes.
- Transformed plain comments into javadocs.
- Used interfaces instead of concrete classes.
- Made all protected members be private.
- Used StatisUtils.collectionToString()

git-svn-id: https://svn.forgerock.org/opendj/trunk@9231 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-15 07:44:51 +0000

12 Jul, 2013

7 commits

d10c2445 Fix checkstyle ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9230 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-07-12 15:59:00 +0000

17a5c707 Big refactoring of LocalBackendAddOperation, removed nearly 300 lines of code. ... Browse Dir »

LocalBackendAddOperation.java:
Added helper class BooleanHolder.
Made all protected members be private.
Extracted method processAdd() out of the labeled code block in processLocalAdd() + replaced duplicated catch(DirectoryException) with just one.
Extracted method checkHasReadOnlyAttributes() out of processLocalAdd().
Extracted a second method addRDNAttributesIfNecessary() out of addRDNAttributesIfNecessary().
Extracted method checkAttributes() out of checkSchema().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9229 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-12 14:37:47 +0000

2d320f4f Fixed checkstyle error. ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9228 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-12 14:28:32 +0000

2ad595af AciHandler.java: ... Browse Dir »

More code simplifications.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9227 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-12 13:02:12 +0000

d5a5e573 AciContainer.java: ... Browse Dir »

More code simplifications.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9226 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-12 12:48:45 +0000

2d68ad2d AciEvalContext.java, AciContainer.java: ... Browse Dir »

Removed instance member isDenyEval, setDecidingAci() and setEvalReason(), replaced with setEvaluationResult() since both are always set at the same time.
Changed the impl of isDenyEval() to use the evalReason.

AciEffectiveRights.java:
Used AciEvalContext.setEvaluationResult().

AciHandler.java:
In testApplicableLists(), used AciEvalContext.setEvaluationResult().
Pushed negation down in if statements condition, merged common code between if and else clauses, collapsed if statements.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9225 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-12 12:12:39 +0000

a52e45f0 *.java: ... Browse Dir »

Switched the use of collections concrete classes to interfaces.

AciHandler.java:
Switched use of collections concrete classes to interfaces.
Used the AutoRefactor plugin on the code to simplify the code.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9224 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-12 10:27:23 +0000

11 Jul, 2013

2 commits

ce0ea010 EntryContainer.java: ... Browse Dir »

Committed adding @Override separately from bigger, real changes.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9222 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-11 14:03:36 +0000

65491ed0 AbstractOperation.java: ... Browse Dir »

Removed duplicated javadoc.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9221 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-11 13:51:55 +0000

10 Jul, 2013

5 commits

a63f89d9 Fix comments ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9215 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
cjr
2013-07-10 10:43:45 +0000
ea1421d0 CR-1977 Fix for OPENDJ-1005: Move server doc sources alongside other server code ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9213 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
mark
2013-07-10 09:28:19 +0000

8a3027f4 *.java: ... Browse Dir »

Replaced collection concrete classes with interfaces.
Used javadocs instead of line comments.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9212 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-10 08:05:32 +0000

dba1aac8 Fixed checkstyle errors. ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9211 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-10 07:41:31 +0000

5f176521 DirectoryServer.java: ... Browse Dir »

In bootstrapAttributeSyntaxes(), extracted method initAndRegister() to remove duplicated code.

*.java:
Replaced collection concrete classes with interfaces.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9210 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-10 07:36:32 +0000

09 Jul, 2013

7 commits

ee4f67c9 Fix OPENDJ-1067: Tools are not properly picking up OPENDJ_JAVA_HOME variable. ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9206 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-07-09 13:20:37 +0000
363453c6 Fixed typo. ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9205 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-09 12:04:02 +0000
6ff122bb Fix typo in comment ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9204 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-07-09 10:51:56 +0000
13c95e41 Remove try / catch / throw anti-pattern ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9202 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-09 10:28:15 +0000

fb9f048d PluginConfigManager.java: ... Browse Dir »

Updated copyright because of commit r9200 .

git-svn-id: https://svn.forgerock.org/opendj/trunk@9201 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-09 10:04:43 +0000

1989de4b PluginConfigManager.java: ... Browse Dir »

Extracted methods handlePreParseException(), handlePreParseResult(), handlePreOperationException(), handlePreOperationResult() to remove duplication.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9200 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-09 09:45:53 +0000

f9fec13c LDIFReader.java: ... Browse Dir »

Code cleanup: removed useless try / catch.
Used interfaces instead of concrete collection classes.
Extracted methods toAttributesMap(), toAttributesList() and addRDNAttributesIfNecessary() to remove duplicated code.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9199 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-09 08:12:05 +0000

08 Jul, 2013

1 commit

ab1597ea [OPENDJ-1063] CR-1971 Fix "build.sh package-RPM" target which fails when the bui… ... Browse Dir »
```
…ld path contains spaces

git-svn-id: https://svn.forgerock.org/opendj/trunk@9196 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
csovant
2013-07-08 13:08:10 +0000

05 Jul, 2013

3 commits

2845b30a Fix typo and unreachable code. ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9190 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-07-05 14:22:55 +0000
375fda4a CR-1962 OPENDJ-1048 OpenDJ QuickSetup creates the "licenseAccepted" file in the wrong place ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9189 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
violette
2013-07-05 14:07:51 +0000
e490e5de Cleanup typos in comments, and useless variables. ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9187 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
ludo
2013-07-05 13:53:52 +0000

04 Jul, 2013

2 commits

094048a4 AbstractTextAccessLogPublisher.java: ... Browse Dir »

Extracted methods decodePatterns() and filterDN() to remove code duplication.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9179 41b1ffd8-f28e-4786-ab96-9950f0a78031

2013-07-04 09:02:30 +0000

3534b9be Changes made by AutoRefactor plugin and reviewed by me ... Browse Dir »
```
git-svn-id: https://svn.forgerock.org/opendj/trunk@9178 41b1ffd8-f28e-4786-ab96-9950f0a78031
```
JnRouvignac
2013-07-04 08:41:06 +0000