org.forgerock / org.forgerock.opendj

04 Dec, 2013

1 commit

02 Dec, 2013

1 commit

27 Nov, 2013

1 commit

13 Nov, 2013

1 commit

  • de389c70   replication*.properties: ... Browse Dir » 
    Added more info for ERR_INVALID_COOKIE_SYNTAX.

MultiDomainServerState.java:
Consequence of the change to ERR_INVALID_COOKIE_SYNTAX.
In splitGenStateToServerStates(), code clean up.

ExternalChangeLogTest.java:
Consequence of the change to ERR_INVALID_COOKIE_SYNTAX.
Used Assertions.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9789 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

12 Nov, 2013

1 commit

  • 12bc1e79   CR-2563 JEChangelogDB removing a synchronized block in a heavily hit path ... Browse Dir » 
    JEChangelogDB.java:
Used ConcurrentMap for domainToReplicaDBs.
Added shutdown field to better protect various code paths against shutdown.
In getOrCreateReplicaDB(), removed global synchronization block with fined grained synchronization code that is only used on JEReplicaDB creation.
Added getExistingOrNewDomainMap(), getExistingOrNewReplicaDB().
Extracted innerShutdownDomain() from shutdownDomain().
In shutdownDB(), ensured shutdown of all the replicaDBs.
In shutdownDB(), shutdownDomain() and getOrCreateReplicaDB() check whether the DB is shutting down.
In removeDomain() and innerShutdownDomain() ensured the domainMap is removed before shutting down the replicaDBs.

replication.properties:
Added an error message to be used when the DB is shutting down.
Extracted and separated method init() from JEReplicaDB ctor.

JEReplicaDB.java:
In ctor, renamed id parameter to serverId + removed queueSize parameter.

JEReplicaDBTest.java:
Consequence of the change to JEReplicaDB.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9786 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

07 Nov, 2013

1 commit

05 Nov, 2013

1 commit

  • c8040cfd   ECLServerHandler.java, ReplicationServerDomain.java: ... Browse Dir » 
    Renamed variables and changed comments to match the new terminology.
Added more comments to explain what the code is doing.

ReplicationBroker.java
Renamed replicationServerInfo => rsInfo.

replication.properties
Removed space characters at the end of each lines.

RSInfo.java:
In toString(), removed newline + improved formatting.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9775 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

30 Oct, 2013

1 commit

  • 1ea19f36   InitializeTargetTask.java: ... Browse Dir » 
    In runTask(), improved error logging in case of exceptions.
Little code cleanup.

TaskThread.java
Logged the task state after the task finished.
Comments => javadocs.

backend*.properties:
Updated NOTICE_TASK_FINISHED_414 message. Updated the translations where I could, otherwise removed them (alas).

replication.properties, LDAPReplicationDomain.java:
Removed useless spaces in error logging

DSInfo.java:
In toString(), removed newline + improved formatting.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9762 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

28 Oct, 2013

2 commits

  • b43a205b   Fixing the build. ... Browse Dir » 
    replication.properties
Removed the forbidden final dot from i18n message.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9755 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     
  • ec480c97   OPENDJ-1053 (CR-2520) Improve logging of replication load balancing and fail-ove… ... Browse Dir » 
    …r in order to diagnose the causes of these events


This change records how each replication server is evaluated by computeBestReplicationServer().
It also logs why a DS switches from one RS to another RS.


ReplicationBroker.java:
Added static classes RSEvaluations and LocalEvaluation.
Moved keepBest() method to RSEvaluations.
In filterServersWithAllLocalDSChanges(), reworked the code to be more understandable + Added method getCSN() and rejectAllWithRSIsLaterThanBestRS(), rejectAllWithRSOnDifferentVMThanDS().
In computeBestServerWhenConnected(), extracted method isServerOverloadingRS().

replication.properties:
Added tons of messages.

ComputeBestServerTest.java:
Moved this class to package org.opends.server.replication.service to match the package of the tested code.
Consequence of the changes to ReplicationBroker.
Added methods containsOnly(), getDescription(), getEval1() and getEval2().
Reformatted the code a bit.
Removed @throws from javadocs.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9753 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

23 Oct, 2013

1 commit

  • ac9a8c6f   LDAPReplicationDomain.java: ... Browse Dir » 
    Replaced instance fields with directly storing and using the ReplicationDomainCfg object.

ReplicationBroker.java:
Replaced instance fields with directly storing and using the ReplicationDomainCfg object.
Removed start(Set<String>), setChangeTimeHeartbeatInterval() (now useless), and setGroupId() (never used).
Added getBaseDN(), getReplicationServerUrls(), getGroupId().
In several methods, used Map.entrySet() instead of Map.keySet() with Map.get(Object)  + renamed replicationServerInfo to rsInfo.

replication.properties:
Removed now unused message.


ReplicationDomain.java:
Replaced instance fields with directly storing and using the ReplicationDomainCfg object.
Code cleanups:
- Removed useless use of "this." for method calls.
- In processErrorMsg() and processUpdateDone(), collapsed if statements
- Increased vertical density
- Extracted method getGenId()
- In waitForAckIfAssuredEnabled(), used early exit.


DomainFakeCfg.java:
Comments => javadocs
baseDn => baseDN
Removed several unused methods.
Added setWindowSize() + instance member.

*Test*.java
Used the DomainFakeCfg everywhere + SortedSet instead of Set.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9746 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

17 Oct, 2013

1 commit

  • 135ae13b   OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Dir » 
    
ReplicationDbEnv.java, replication.properties:
In openDatabase(), fixed TODOs for i18n.
In newErrorMessage(), improved error logging by including the DB name.

JEChangelogDB.java:
Simplified the code by calling domainToReplicaDBs.remove() from inside shutdownReplicaDBs().
In shutdownReplicaDBs(), do not bother cleaning up the domainMap since it will be removed from domainToReplicaDBs.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9737 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

09 Oct, 2013

1 commit

  • 57640b0a   OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Dir » 
    
JEChangeNumberIndexDBTest.java:
Fixed the build.

ChangeNumberIndexDB.java, JEChangeNumberIndexDB.java:
Improved the javadocs.
Made instance variables volatile.

*.java:
First => Oldest
Last => Newest

git-svn-id: https://svn.forgerock.org/opendj/trunk@9690 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

25 Sep, 2013

1 commit

  • f83d8df3   Fix OPENDJ-18 - keystore import failes due to empty PIN ... Browse Dir » 
    Review CR-2353

* Removed constraints on the mandatory presence of a PIN, to allow use of empty PIN. 
   These contraints were implemented in several places :
  - configuration files : FileBasedKeyManagerProviderConfiguration.xml, PKCS11KeyManagerProviderConfiguration.xml
  - corresponding provider classes : FileBasedKeyManagerProvider.java, PKCS11KeyManagerProvider.java
  - setup tool : CertificateManager.java, InstallDS.java (for CLI), SecurityOptionsDialog.java (for GUI) 

* Removed corresponding admin messages that are no more used in FileBasedKeyManagerProviderCfgDefn.properties and PKCS11KeyManagerProviderCfgDefn.properties
* Removed corresponding messages that are no more used in extension.properties and quicksetup.properties
* Added management of issue JDK-6879539 that prevents usage of empty PIN. This issue occurs on JDK older than JDK7.
* Modified unit tests according to new behavior : FileBasedKeyManagerProviderTestCase.java, CertificateManagerTestCase.java

* Added a new utility method StaticUtils#stackTraceContainsCause to check if an exception contains a given cause.



git-svn-id: https://svn.forgerock.org/opendj/trunk@9598 41b1ffd8-f28e-4786-ab96-9950f0a78031
    nicolas.capponi@forgerock.com
     

06 Sep, 2013

1 commit

  • bd347ba9   CR-2260 Implement Rebuild all indexes Upgrade task ... Browse Dir » 
    - removed start task action (unused)
- removed verifyTaskType function (unused)
- used LDIF.search to retrieve backends (rebuild index works only on 'enabled' backend).
- added rebuild all index task.
 - In case of an upgrade where a rebuild all task is present :
    . All the other single rebuild indexes are bypass.
    . Rebuild-all is launched only if the the user wants to.


git-svn-id: https://svn.forgerock.org/opendj/trunk@9513 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     

05 Sep, 2013

2 commits

  • 4f125b0f   Fix last build test failure (another style enforcement: Messages must not end wi… ... Browse Dir » 
    …th a dot, unlike Javadoc)

git-svn-id: https://svn.forgerock.org/opendj/trunk@9512 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ludo
     
  • 1789505b   OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Dir » 
    
Fixed a few bugs (introduced in the previous commits?):
- All code must check that the result of calling ChangeNumberIndexDB.getFirstCNIndexData() and ChangeNumberIndexDB.getLastCNIndexData() are not null (if the DB is empty, or closed, etc.).
- In ReplicationServer.clearGenerationId(), the code could have a side effect if the last entry in the DB was cleared by this method: the lastGeneratedChangeNumber would be allowed to go back!


ChangeNumberIndexDB.java:
Removed getLastChangeNumber().

DraftCNDbHandler.java:
Inlined getLastChangeNumber() to the only remaining method caller ReplicationServer.getChangeNumberIndexDB().
Finally changed the implementation of isEmpty() to something less costly.

DraftCNDbHandlerTest.java:
Inlined getFirstChangeNumber() and getLastChangeNumber().


ReplicationServer.java:
In clearGenerationId(), removed the code changing the value of lastGeneratedChangeNumber: lastGeneratedChangeNumber is not allowed to go backward.
In getChangeNumberIndexDB(), inlined here the code of DraftCNDbHandler.getLastChangeNumber() + removed useless use of MessageBuilder.
In getECLChangeNumberLimits(), added a null check for the result of getLastCNIndexData().

replication.properties:
Added a new error message.
Changed MILD_ERR_DRAFT_CHANGENUMBER_DATABASE_173 to MILD_ERR_CHANGENUMBER_DATABASE_173.


ECLServerHandler.java:
In findCookie(), replaced the DB empty checks by null checks on the return of getFirstCNIndexData() and getLastCNIndexData() since this is purely equivalent.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9511 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

03 Sep, 2013

1 commit

12 Aug, 2013

1 commit

  • a9d10551   OPENDJ-1116 Introduce abstraction for the changelog DB ... Browse Dir » 
    Hid low level JE's DatabaseException and ReplicationDBException from replication higher level code. They have been replaced by the newly created ChangelogException.

Tidied up the exception handling by throwing or catching more specific exceptions.
Moved some code to protect them with try / catch.
Adding a few catch for specific handling of ChangelogException.
Threw ChangelogException instead of Exception.
Added handleUnexpectedDatabaseException() methods.

ReplicationDBException.java: REMOVED (now useless)

replication*.properties:
Removed ERR_COULD_NOT_INITIALIZE_DB, not adding anything to ERR_COULD_NOT_READ_DB.

Removed "this." from member method invocations.
Used Integer.parseInt().
Used StaticUtils.close().

git-svn-id: https://svn.forgerock.org/opendj/trunk@9399 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

06 Aug, 2013

1 commit

25 Jul, 2013

1 commit

15 Jul, 2013

1 commit

27 Jun, 2013

1 commit

26 Jun, 2013

1 commit

25 Jun, 2013

1 commit

20 Jun, 2013

2 commits

  • 3a73603b   Fix OPENDJ-992: JE environment failure (LOG_FILE_NOT_FOUND) after upgrading from… ... Browse Dir » 
    … OpenDJ 2.4.6 to OpenDJ 2.6.0

* add upgrade task which notifies the user that they must rebuild the ds-sync-hist ordering index when upgrading from 2.5.0-Xpress1.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9016 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     
  • 80796aa3   Fix for OPENDJ-846, Intermittent Replication failure. ... Browse Dir » 
    The issue was triggered by the mix of AssuredReplication and bad network conditions, which resulted in a deadlock between 2 RS, as both were blocked on writing to the TCP socket and not reading (because waiting on the write lock).
The solution (more of a workaround) is to have another thread for sending data to the socket and have the reader and writer posting data to send to a queue that this new thread is polling.
There are still potential deadlocks but they will occur much later, if the sendQueue gets full.  The code needs more work post 2.6 to be fully non blocking, but the changes are enough for now to resolve the customer deadlock case.

git-svn-id: https://svn.forgerock.org/opendj/trunk@9015 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ludo
     

17 Jun, 2013

1 commit

13 Jun, 2013

1 commit

11 Jun, 2013

1 commit

  • 1ad7eb8e   CR-1829 OPENDJ-982 Upgrade: SNMP Connection Handler does not start after the upgrade ... Browse Dir » 
    As suggested in CR, a new upgrade task has been created 'Rename SNMP security config file'. This task is launched if the old SNMP config file
actually exists in the config/snmp/security.
The task renames the file with the new opendj name.

NOTA : The config/snmp/security/opends-snmp.security has been changed in 2.5.0.7466 and the community name as well. ( Cf. Matt's comment in CR). 

git-svn-id: https://svn.forgerock.org/opendj/trunk@8988 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     

10 Jun, 2013

1 commit

07 Jun, 2013

1 commit

  • 8dba2078   Fix for OPENDJ-925, OPENDJ-926, and overall schema management. Review CR-1806. ... Browse Dir » 
    Back a few years ago, when we did the SVR4 package, we split the schema into read-only (Install) and writable (Instance).
With the template model in 2.6, the whole schema is under config, and we should never edit/change the one in the template.
So, I've removed all code related to the 2 locations for schema, reverted some I10N messages to their previous versions, and tidy up code and tests.
All unit-tests are passing.
And it's also possible to change the instance.loc and run setup and have a fully functioning server :-)

git-svn-id: https://svn.forgerock.org/opendj/trunk@8978 41b1ffd8-f28e-4786-ab96-9950f0a78031
    ludo
     

05 Jun, 2013

1 commit

03 Jun, 2013

1 commit

  • 55980394   CR-1777-OPENDJ - Upgrade code cleanup ... Browse Dir » 
    - The upgrade context is now set in the CLI.
- The upgrade context contains now the callback handler
which simplify all the function (removed all calls to callbackhandler, functions just need the context at this point).
- The context contains the CLI user selected options
which simplify the code, removed the CheckCLIUserOption, the task have just to check the context for those parameters.
- Removed the useless VerificationCallback.java
- Added a TaskType in UpgradeTask.java.
- Added function verifyTaskType in UpgradeTasks.java which verify user selected options are correct.
- Modified tools.properties message numbers

git-svn-id: https://svn.forgerock.org/opendj/trunk@8951 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     

27 May, 2013

1 commit

23 May, 2013

1 commit

  • 9ec54a49   CR-1720 OPENDJ-835 Upgrade should add HTTP Connection Handler to config.ldif ... Browse Dir » 
    OPENDJ-914 Upgrade should add Based HTTP Access Logger to config.ldif
- HTTP connection handler and the based HTTP access logger are now added to upgrade.
- The http-config.json is added to the config file during upgrade.
- Simplified UpgradeTasks.java
- Added new messages.
- Fixed javadoc for unit test.

git-svn-id: https://svn.forgerock.org/opendj/trunk@8895 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     

22 May, 2013

1 commit

  • 50f6c043   OPENDJ-918 (CR-1723) - HTTP Connection Handler - Server cannot start with horked http-config.json ... Browse Dir » 
    
Protected the HTTP Connection Handler against a failing initialization: after two consecutive startup failures, the HTTP connection handler will be disabled, errors will be logged and alerts will be output.


HTTPConnectionHandler.java:
Added instance member enabled to decouple the enable/disable state from the config.
Implemented getAlerts() method.
In startHttpServer(), moved the try / catch block and the call to notify() to the run() method.
In run(), handle failing initialization.
In stopHttpServer(), added a null check in case of failed intitialization.
Extracted method cleanUpHttpServer().

ServerConstants.java:
Added alerts for HTTP connection handler.

protocol*.properties:
Modified the name of the LDAP specific properties to be more generic.

LDAPConnectionHandler.java
Consequence of the change to protocol.properties.


git-svn-id: https://svn.forgerock.org/opendj/trunk@8891 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

21 May, 2013

1 commit

  • 837c0e6a   OPENDJ-902 (CR-1702) Add connectionID to the HTTP access log + move to extended log format ... Browse Dir » 
    OPENDJ-858 (CR-1702) Add stats tracking to HTTP client connections



In HTTP access log, changed the name of the non standard "datetime" field to "x-datetime".
Added the "x-etime" field that outputs as a number.
Added validation for the log format that outputs error messages.


FileBasedHTTPAccessLogPublisherConfiguration.xml, FileBasedHTTPAccessLogPublisherConfiguration.properties:
Renamed the "datetime" field to "x-datetime" + added the "x-etime" field.
Improved the description of the ds-cfg-log-format.

TextHTTPAccessLogPublisher.java, config.properties:
Extracted constants for all supported field names.
Added ALL_SUPPORTED_FIELDS constant.
Changed logFormatFields instance member from String[] to List<String>.
Added validateLogFormat() which can output new error messages and called it from applyConfigurationChange() and initializeLogPublisher().
Added subtract().

HTTPClientConnection.java, HTTPRequestInfo.java:
Added instance member totalProcessingTime.
In sendResponse(), added to the totalProcessingTime + extracted method getProcessingTime().
Added getTotalProcessingTime().

git-svn-id: https://svn.forgerock.org/opendj/trunk@8885 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

15 May, 2013

1 commit

14 May, 2013

1 commit