27 Jul, 2015

3 commits

  • This commit makes all tools consistent in the way that if no arguments are provided on the command line (or only the non prompt argument for interactive tools), tool prints the error and the help reference message on error stream.
    Changes details:
    * ArgumentParser
    ** Create method displayMessageAndUsageReference(), this method is used by tools to print both an error message and the help usage reference message
    ** getHelpUsageReference() has been moved from SubCommandArgumentParser
    
    * DSConfig
    ** displayErrorMessageAndUsageReference() has been moved to ArgumentParser
    
    * CreateRCScript
    ** Moves the server root path check after the argument parsing in order to have a consistent error message if arguments are invalid.
    
    * RebuildIndex
    * VerifyIndex
    ** Removed dead code which printed usage if no args were provided (if so, an argument exception is raised before).
    
    * MakeLDIF
    ** Add a main method for test purpose
    
    * ArgumentParserToolsTestCase
    ** Test that tools are consistent if an invalid argument is provided or if no args are provided.
    
    Tools modified by this commit are the following:
    Server tools
    * Does not print usage anymore
    ** backup
    ** base64 (only if no args are provided)
    ** control-panel
    ** create-rc-script
    ** dbtest
    ** dsjavaproperties
    ** dsreplication
    ** encode-password
    ** export-ldif
    ** import-ldif
    ** ldapcompare
    ** ldapdelete
    ** ldapmodify
    ** ldappasswordmodify
    ** ldapsearch
    ** ldif-diff
    ** ldifmodify
    ** ldifsearch
    ** make-ldif
    ** manage-account
    ** manage-tasks
    ** rebuild-index
    ** restore
    ** setup
    ** start-ds
    ** status
    ** stop-ds
    ** uninstall
    ** upgrade
    ** verify-index
    
    * Usage reference message added
    ** base64 (only if invalid args are provided)
    
    SDK tools
    * Does not print usage anymore
    ** addrate
    ** makeldif
    
    * Usage reference message added
    ** authrate
    ** ldapcompare
    ** ldapmodify
    ** ldappasswordmodify
    ** ldapsearch
    ** ldifdiff
    ** ldifmodify
    ** ldifsearch
    ** modrate
    ** searchrate
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12701 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • * MakeLDIFITCase
    ** Inherits from ToolITCase
    ** Uses parent checkOutputStreams() method
    ** Add a test to check that -H displays help
    ** Code cleanup
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12700 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     
  • * MakeLDIFTestCase -> MakeLDIFITCase to improve consistency in the package.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@12699 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     

15 Jan, 2015

1 commit


20 Oct, 2014

1 commit


17 Oct, 2014

1 commit

  • * com.forgerock.opendj.ldap.tools.PerformanceRunner
    ** Makes the ResponseTimeBuckets inner class package private to allow unit tests.
    * com.forgerock.opendj.ldap.tools.PerformanceRunnerStatsTestCase
    ** Adds a simple black box unit test to control PerformanceRunner eTimes calculation.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@11156 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     

15 Oct, 2014

1 commit


25 Jul, 2014

1 commit

  • Adding two new parameters to the xxxrate tools, maximum duration time and warm-up duration time.
    
    ** PerformanceRunner.java
    * Adding a timer thread for the max duration feature and add warm-up implementation.
    ** AddRate.java SearchRate.java
    * Adding resetStats method to reset local statistics (i.e extra columns)
    ** tools.properties
    * Adding warm-up message
    ** AuthRateITCase.java
    ** Adding a test with warm-up phase
     
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@10932 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     

23 Jul, 2014

1 commit

  • Adding an add/del rate tool named addrate.
    -opendj-core
        ** EntryGenerator.java:
        * Changing the subtemplate parsing behavior, add the "generated branches" options
        ** TemplateFile.java
        * Adding the "generated branches" options
        ** addrate.template
        * New template used to generate entries
    
    -opendj-ldap-toolkit
        ** addrate (bat and bin)
        * Adding new tool scripts for unix and windows
        ** AddRate.java
        * addrate tool new class
        ** PerformanceRunner.java
        * Using parameter object in constructor, adding some messages localization
        ** PerformanceRunnerOptions.java
        * Helps to simplify the way to initialize a PerformanceRunner instance
        ** MakeLDIF.java
        * Little refactoring in order to allow the addrate tool to use some make-ldif parameters
        ** tools.properties
        * Adding addrate tool message and also some new generic messages
        ** Minor changes (constructor) in other tools and tests files
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@10927 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     

04 Jul, 2014

1 commit

  • * ConnectionFactoryProvider.java DSConfig.java
    ** Refactoring code by removing unused constructor and fields
    ** Perform anonymous connection by default
    * src/main[..]/ldap/tools/*.java
    ** Making tools not interactive
    * src/test[..]/ldap/tools/*.java
    ** Adding some basic integration tests cases to ensure that general tools behavior is ok
    * pom.xml
    ** Update and clean dependencies
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@10862 41b1ffd8-f28e-4786-ab96-9950f0a78031
    gaetan
     

10 Mar, 2014

1 commit

  • - Moved ApplicationKeyManager.java, ConnectionFactoryProvider.java / PromptingTrustManager.java from opendj-ldap-tools to opendj-cli.
      - Created AbstractAuthenticatedConnectionFactory.class
      - Overriding makeAuthenticatedConnectionFactory(...) in some tools.
    - Replaced argument declarations by CommonArguments.
    - CommonArguments : added property value to getControl() && modified getReportAuthzId().
    - Minor code cleanup.
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@10509 41b1ffd8-f28e-4786-ab96-9950f0a78031
    violette
     

14 Feb, 2014

2 commits


13 Feb, 2014

1 commit

  • - Factorized code
    - Fixed Sonar violations
    - Removed duplicated lines reported by Sonar
    - Applied refactorings suggested by AutoRefactor plugin 
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@10359 41b1ffd8-f28e-4786-ab96-9950f0a78031
    JnRouvignac
     

11 Feb, 2014

1 commit


07 Feb, 2014

1 commit


29 Jan, 2014

1 commit


25 Jan, 2014

1 commit

  • * moved closeSilently() methods and a couple of others from StaticUtils to forgerock-utils
    * bumped dependency on forgerock-utils to 1.3.0-SNAPSHOT
    * all remaining Findbugs warnings are just noise. It's a shame that it's not possible to use @SuppressWarnings("findbugs").
    
    
    
    git-svn-id: https://svn.forgerock.org/opendj/trunk@10187 41b1ffd8-f28e-4786-ab96-9950f0a78031
    matthew
     

26 Nov, 2013

1 commit